Integrated: 8256821: TreeViewSkin/Behavior: misbehavior on switching skin

Jeanette Winzenburg fastegal at openjdk.java.net
Mon Dec 7 13:10:14 UTC 2020


On Tue, 24 Nov 2020 14:17:21 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> issues with behavior:
> - memory leak due to an key eventHandler that's not removed
> - after dispose, still modifying treeView (anchor) state due to listeners selection that are not removed
> 
> issues with skin:
> - memory leak due to behavior leaking
> - memory leak due to cellFactory in flow not removed
> - throws NPE after switching (on modifying root children, refresh) due to listeners not removed
> 
> Fixed by cleaning up as needed. Added tests that are failing before and passing after the fix.

This pull request has now been integrated.

Changeset: ca0d3d0f
Author:    Jeanette Winzenburg <fastegal at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/ca0d3d0f
Stats:     158 lines in 6 files changed: 142 ins; 13 del; 3 mod

8256821: TreeViewSkin/Behavior: misbehavior on switching skin

Reviewed-by: arapte

-------------

PR: https://git.openjdk.java.net/jfx/pull/358


More information about the openjfx-dev mailing list