RFR: 8253356: JavaFX Terminology Refresh

Kevin Rushforth kcr at openjdk.java.net
Wed Dec 16 13:26:59 UTC 2020


On Wed, 16 Dec 2020 13:17:01 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> `modules\javafx.graphics\src\main\native-glass\ios\GlassWindow.h`  has declaration of variables named `masterWindow` and `masterWindowHost`.
>> Please check if we should change these too.
>
> Yes, I agree that these should be changed as well. Given the following in `GlassWindow.h`:
> 
> +(GlassMainWindow *)  getMasterWindow;
> 
> changing `masterWindow` to `mainWindow` is a better fit anyway.

@johanvos since this now touches iOS files, can you take a look at them (just a sanity check unless you also want to review the rest)?

-------------

PR: https://git.openjdk.java.net/jfx/pull/368


More information about the openjfx-dev mailing list