[Rev 02] RFR: 8236839: System menubar removed when other menubars are created or modified

Kevin Rushforth kcr at openjdk.java.net
Thu Feb 6 16:05:59 UTC 2020


On Thu, 6 Feb 2020 16:05:59 GMT, Johan Kaving <github.com+725090+jkaving at openjdk.org> wrote:

>> This pull request fixes the sceneProperty listener in `MenuBarSkin` so that we leave the
>> current system menubar alone when other menubars are changed.
>> 
>> It also adds a test case that reproduces the problem before the fix.
> 
> Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR.

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/86


More information about the openjfx-dev mailing list