[Rev 02] RFR: 8212034: Potential memory leaks in jpegLoader.c in error case
Ambarish Rapte
arapte at openjdk.java.net
Mon Feb 10 13:27:28 UTC 2020
On Wed, 27 Nov 2019 21:19:08 GMT, Johan Vos <jvos at openjdk.org> wrote:
>> The pull request has been updated with a new target base due to a merge or a rebase.
>
> In general, this makes sense. I need to look into more detail that the additional calls for freeing resources (in case of errors) don't cause e.g. segmentation violations and lead to a crash -- which would be worse than throwing an Exception.
> I expect memory consumption to be similar before and after this patch if you don't run into errors, but did you check memory consumption before/after this patch in case of errors?
The PR was outdated. It is now merged with latest master.
Please take a look.
-------------
PR: https://git.openjdk.java.net/jfx/pull/54
More information about the openjfx-dev
mailing list