TableView with many columns poor ui performance

[Danny Gonzalez]

Hi Jeanette,


True, I hadn't read that spec in ObservableValueBase.
Although that does seem odd behaviour to me. Obviously as the original implementation was using an array I can see how the implementation drove that specification.

Non of the JavaFx unit tests test for that specific case as the unit tests all passed. It would be nice if there was a specific test case for this behaviour.

I would need to store a registration count for each listener to satisfy this requirement.



On 12 Feb 2020, at 11:34, Jeanette Winzenburg <fastegal at swingempire.de<mailto:fastegal at swingempire.de>> wrote:


Zitat von Danny Gonzalez <danny.gonzalez at screamingfrog.co.uk<mailto:danny.gonzalez at screamingfrog.co.uk>>:

Hi Ed,

I have submitted a pull request and the branch is here:
https://github.com/screamingfrog/jfx/tree/listeners_optimisation



hmm .. the change seems to be breaking spec of add/remove listeners

"If the same listener is added more than once, then it will be notified more than once".

or what am I missing?