RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

Ajit Ghaisas aghaisas at openjdk.java.net
Fri Feb 14 09:18:33 UTC 2020


Bug : https://bugs.openjdk.java.net/browse/JDK-8235480

Fix : Added the missed out RTL checks to the key mappings in TableViewBehaviorBase class.

Testing : Modified unit tests in TableViewKeyInputTest to take orientation as a parameter. The Left/Right key press tests have been modified to address LTR and RTL orientations.

Note : If this test modification is acceptable, I would like to address other similar tests separately. (I will create a test JBS issue and address later)

-------------

Commits:
 - 5f8a925b: Fix for JDK-8235480

Changes: https://git.openjdk.java.net/jfx/pull/114/files
 Webrev: https://webrevs.openjdk.java.net/jfx/114/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8235480
  Stats: 675 lines in 2 files changed: 410 ins; 10 del; 255 mod
  Patch: https://git.openjdk.java.net/jfx/pull/114.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/114/head:pull/114

PR: https://git.openjdk.java.net/jfx/pull/114


More information about the openjfx-dev mailing list