RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

dannygonzalez github.com+6702882+dannygonzalez at openjdk.java.net
Mon Feb 24 11:11:39 UTC 2020


On Mon, 24 Feb 2020 08:11:40 GMT, dannygonzalez <github.com+6702882+dannygonzalez at openjdk.org> wrote:

>> modules/javafx.base/src/main/java/com/sun/javafx/binding/ExpressionHelperBase.java line 64:
>> 
>>> 63: 
>>> 64:         listeners.entrySet().removeIf(e -> p.test(e.getKey()));
>>> 65:     }
>> 
>> This can be `listeners.keySet().removeIf(p::test);`.
> 
> Agreed, will change.

Nope, actually:
`listeners.keySet().removeIf(p::test) `

is not the same as:
`listeners.entrySet().removeIf(e -> p.test(e.getKey()));`

We need to test against the entrySet.key not the entrySet itself.

-------------

PR: https://git.openjdk.java.net/jfx/pull/108


More information about the openjfx-dev mailing list