[Rev 02] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation
Ajit Ghaisas
aghaisas at openjdk.java.net
Mon Feb 24 17:15:21 UTC 2020
On Sat, 15 Feb 2020 14:59:30 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java line 102:
>
>> 101:
>> 102: private NodeOrientation orientation;
>> 103:
>
> I might recommend also adding a `private boolean ltr` instance variable to make the check less verbose, but that's up to you.
In such a test with large number of lines, I prefer the checks to be verbose.
-------------
PR: https://git.openjdk.java.net/jfx/pull/114
More information about the openjfx-dev
mailing list