[Rev 01] RFR: 8208761: Update constant collections to use the new immutable collections
Nir Lisker
nlisker at openjdk.java.net
Fri Feb 28 08:06:01 UTC 2020
On Fri, 28 Feb 2020 01:19:23 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit.
>
> I finished my review and tested this on all platforms. It looks good to me.
>
> The only comment I have is the one inline comment I left in `KeyCodeMap.java` about renaming the "put" method to something with "entry" in the name to reflect what it now does.
> The only comment I have is the one inline comment I left in KeyCodeMap.java about renaming the "put" method to something with "entry" in the name to reflect what it now does.
Will fix it after Ambarish reviews.
-------------
PR: https://git.openjdk.java.net/jfx/pull/104
More information about the openjfx-dev
mailing list