From jvos at openjdk.java.net Wed Jan 1 19:16:45 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Wed, 1 Jan 2020 19:16:45 GMT Subject: RFR: 8232589: Remove CoreAudio Utility Classes In-Reply-To: References: Message-ID: On Fri, 20 Dec 2019 22:19:27 GMT, Kevin Rushforth wrote: >> https://bugs.openjdk.java.net/browse/JDK-8232589 >> >> - Removed CoreAudio Utility classes. >> - Spectrum which was depended on CoreAudio Utility classes for doing computations will now run GStreamer spectrum element to do spectrum. Element will be run without pipeline and will be used as utility library to do spectrum calculation. I added extra APIs to bypass proper element initialization. >> - Equalizer and audio unit (volume and balance) where modified, so we can run then directly without CoreAudio pipeline. > > modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-good/gst/spectrum/gstspectrum.c line 915: > >> 914: bpf = GST_AUDIO_FILTER_BPF (spectrum); >> 915: #ifdef OSX >> 916: if (spectrum->bps_user != 0 && spectrum->bpf_user != 0) { > > Should this also be qualified with `GSTREAMER_LITE` since it represents changes specific to our port? It doesn't look required to me, but it would make more sense and bring it at the same level as line 738 ------------- PR: https://git.openjdk.java.net/jfx/pull/69 From nlisker at gmail.com Wed Jan 1 21:04:54 2020 From: nlisker at gmail.com (Nir Lisker) Date: Wed, 1 Jan 2020 23:04:54 +0200 Subject: Rate of embedded animations Message-ID: Hi, As part of my work in the animations package I've come across an undefined spec. Is the rate of an animation that is embedded in a Parallel/Sequential transition inherited and overridden by its parent? If I have an animations with a rate of 1 and a parent with a rate of 2, and I add the animation to the parent, does the rate property change from 1 to 2 (generating a change/invalidation event etc.)? Then, should any subsequent changes to the parent's rate trigger a change in the child's rate? The implementation is a bit messy in this regard. The rate and currentRate values exist in both Animation and its ClipEnvelope, which is the source for a couple of bugs. For example, changing the rate of a ParallelTransition changes the child's ClipEnvelope's rate and currentRate, but only the animation's currentRate (and not rate). Is it supposed to be this way? What is clear is that it's not possible to change the rate of the embedded animation directly. The docs do not talk about the rate of an embedded animation (they do talk about the node property though). - Nir From github.com+6153953+pankaj-bansal at openjdk.java.net Thu Jan 2 06:08:25 2020 From: github.com+6153953+pankaj-bansal at openjdk.java.net (Pankaj Bansal) Date: Thu, 2 Jan 2020 06:08:25 GMT Subject: [Rev 04] RFR: 8225571: Port DND source to use GTK instead of GDK In-Reply-To: References: Message-ID: On Thu, 2 Jan 2020 06:08:25 GMT, Thiago Milczarek Sayao wrote: >> https://bugs.openjdk.java.net/browse/JDK-8225571 >> >> To run tests (on the root of the source tree): >> ./gradlew apps >> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls >> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor >> >> java -Djdk.gtk.version=2 @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls >> java -Djdk.gtk.version=2 @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor > > The pull request has been updated with 1 additional commit. Sorry for late review. I have reviewed the code and have run few tests for DND on Ubuntu 18.04, Ubuntu 19.04 and OL 7.5. All works fine for me. Approved. ------------- Marked as reviewed by pankaj-bansal at github.com (no known OpenJDK username). PR: https://git.openjdk.java.net/jfx/pull/4 From thiago.sayao at clamed.com.br Thu Jan 2 11:18:49 2020 From: thiago.sayao at clamed.com.br (Thiago Milczarek Sayao) Date: Thu, 2 Jan 2020 11:18:49 +0000 Subject: Linux Glass - WindowContextChild and WindowContextPlug In-Reply-To: References: Message-ID: Ran all the robot test suite and those two classes are not touched. I suspect they are used for web-start. Are there any guides for running Ensemble on web-start? I guess I must use an old linux distro, that has old browser tech. Happy new year. ________________________________ De: openjfx-dev em nome de Thiago Milczarek Sayao Enviado: ter?a-feira, 31 de dezembro de 2019 16:50 Para: openjfx-dev at openjdk.java.net Assunto: Linux Glass - WindowContextChild and WindowContextPlug Does anyone knows the context of use of WindowContextChild and WindowContextPlug on the linux glass implementation? File: glass_window.cpp They seem to be never called. Thanks. From kcr at openjdk.java.net Thu Jan 2 16:35:56 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 2 Jan 2020 16:35:56 GMT Subject: [Rev 03] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings In-Reply-To: <6A7EJnUHKCuLh4m2zY5YoOTHsAfNpJfTss1K8_JBELE=.34aca62b-f58f-49c4-ba11-14dbec1e1b86@github.com> References: <6A7EJnUHKCuLh4m2zY5YoOTHsAfNpJfTss1K8_JBELE=.34aca62b-f58f-49c4-ba11-14dbec1e1b86@github.com> Message-ID: <2unCYsYHhSg68GSBHU5ZF5C5095MGm5KYS2sfl5Eve8=.e4deb6a8-ccbc-4f10-9b74-b7822c9d7104@github.com> On Fri, 20 Dec 2019 13:53:43 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 2 additional commits. > > Looks good. > > I can sponsor this fix. @tsayao this is ready for you to integrate. ------------- PR: https://git.openjdk.java.net/jfx/pull/63 From kcr at openjdk.java.net Thu Jan 2 16:39:36 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 2 Jan 2020 16:39:36 GMT Subject: [Rev 04] RFR: 8225571: Port DND source to use GTK instead of GDK In-Reply-To: References: Message-ID: <1BMcfFHcS0Iw_Os4vn3ZbNpycbrsNpECPv_e8FuU-L0=.567d5aaa-e494-4519-92a1-f2e1bf3629bc@github.com> On Thu, 2 Jan 2020 06:08:09 GMT, Pankaj Bansal wrote: >> The pull request has been updated with 1 additional commit. > > Sorry for late review. I have reviewed the code and have run few tests for DND on Ubuntu 18.04, Ubuntu 19.04 and OL 7.5. All works fine for me. Approved. @tsayao this is ready for you to integrate. I note that it will only show one reviewer in the commit message; Pankaj did review it, but still needs to associate his GitHub ID with his OpenJDK ID before it will show up (so it will miss being recorded in the commit for this fix). ------------- PR: https://git.openjdk.java.net/jfx/pull/4 From kevin.rushforth at oracle.com Thu Jan 2 17:12:39 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Thu, 2 Jan 2020 09:12:39 -0800 Subject: Pending Skara notifications, JBS updates for recent fixes Message-ID: <118d678c-14eb-f35c-87f4-7f04539857e7@oracle.com> The Skara commit notifications and JBS issue updates for the following recently-integrated bugs are still pending: https://bugs.openjdk.java.net/browse/JDK-8130738 https://bugs.openjdk.java.net/browse/JDK-8236484 https://bugs.openjdk.java.net/browse/JDK-8232811 https://bugs.openjdk.java.net/browse/JDK-8225571 The reason for the delay is a problem accessing JBS from the Skara bot. It should be sorted out soon. In the mean time, I've added a label and a comment to each bug so we can track them, but I left them open to see whether the Skara bot will catch back up once access is restored (it should do). I'll do the same to any other bugs that are resolved prior to fixing the issue. -- Kevin From kcr at openjdk.java.net Thu Jan 2 17:18:26 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 2 Jan 2020 17:18:26 GMT Subject: [Rev 01] RFR: 8087980: Add property to disable Monocle cursor In-Reply-To: <0IRAm4s9xg7Mt5cJ8kOtx-zyHJsvGW01Y5Qxi2WgdAo=.2cd54920-d581-470b-a4c7-1df5fd2a9c18@github.com> References: <6oGs5VTOw0fh_hel0b-jkSNGwwnXY8RCyYbLQfacX0Y=.42838ee2-f3cf-47f7-a048-4a6404d1b3d4@github.com> <0IRAm4s9xg7Mt5cJ8kOtx-zyHJsvGW01Y5Qxi2WgdAo=.2cd54920-d581-470b-a4c7-1df5fd2a9c18@github.com> Message-ID: On Wed, 18 Dec 2019 12:52:04 GMT, Johan Vos wrote: >> The pull request has been updated with 1 additional commit. > > LGTM @dellgreen this is ready for you to integrate. It will need a sponsor, so perhaps @johanvos would be willing? ------------- PR: https://git.openjdk.java.net/jfx/pull/5 From nlisker at openjdk.java.net Thu Jan 2 18:18:35 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Thu, 2 Jan 2020 18:18:35 GMT Subject: RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: <8rYgugRQG-zrAZsJc8I2KCABvRgf6yJ7F-AOMgUvKV8=.267cc5a7-c8b5-4b6e-87ed-3cbdab895020@github.com> Message-ID: <_3FajXoBUGI2oS7eCJLrCiNCeUBhUpPvNzi6hbS6LXY=.92f12e93-1885-4d09-916a-90daa1fe1cbd@github.com> On Fri, 20 Dec 2019 21:56:32 GMT, Kevin Rushforth wrote: >> The bug I mentioned above is not a bug actually. There are large changes over a small distance that make it looks like a jump in the lighting values, but when working with a finer scale the lighting dynamics seem correct. > > I think this is on the right track. The API looks like it is in good shape. > > This will need a fair bit of testing to ensure that there are no regressions either in functionality or (especially) performance, in addition to tests for the new functionality. On the performance aspect, the inner loop of the lighting calculation now has an additional if test for the max range and additional arithmetic calculations for the attenuation. What we will need is a test program that we can run on Mac and Windows to measure the performance of rendering in a fill-rate-limited case. Ideally, we would not pay much of a performance hit in the default case where `ca == 1, la == 0, qa == 0`, but we first need to be able to measure the drop in performance before we can say whether it is acceptable. > > Speaking of testing, I took the current patch for a test drive on Mac and Windows. I get the following system test failures on Mac, and also the same failure using fx83dfeatures/LightMotion in toys. > > > Shader compile log: ERROR: 0:308: Use of undeclared identifier 'range' > ERROR: 0:316: Regular non-array variable 'dist' may not be redeclared > > test.robot.test3d.MeshCompareTest > testSnapshot3D[3] STANDARD_ERROR > java.lang.RuntimeException: Error creating fragment shader > at javafx.graphics/com.sun.prism.es2.ES2Shader.createFromSource(ES2Shader.java:141) > at javafx.graphics/com.sun.prism.es2.ES2PhongShader.getShader(ES2PhongShader.java:177) > ... > test.robot.test3d.MeshCompareTest > testSnapshot3D[3] FAILED > java.lang.IllegalArgumentException: Unrecognized image loader: null > at javafx.graphics/javafx.scene.image.WritableImage.loadTkImage(WritableImage.java:278) > at javafx.graphics/javafx.scene.image.WritableImage$1.loadTkImage(WritableImage.java:53) > at javafx.graphics/javafx.scene.Scene.doSnapshot(Scene.java:1340) > at javafx.graphics/javafx.scene.Scene.doSnapshot(Scene.java:1372) > at javafx.graphics/javafx.scene.Scene.snapshot(Scene.java:1462) > at test.robot.test3d.MeshCompareTest.lambda$testSnapshot3D$0(MeshCompareTest.java:315) > > > test.robot.test3d.Snapshot3DTest > testSnapshot3D[3] FAILED > (same failure as above) > > > test.robot.test3d.Snapshot3DTest > testSnapshot3D[7] FAILED > (same failure as above) > I get the following system test failures on Mac > ``` > Shader compile log: ERROR: 0:308: Use of undeclared identifier 'range' > ERROR: 0:316: Regular non-array variable 'dist' may not be redeclared > ``` I don't have a Mac to test on, but on Ubuntu system tests pass (I ran the `test` command for systemTests). Does the sample app I attached also fail on Mac? They both use the same shaders, so I wonder where the issue could be. Moreover, the error messages are strange. `dist` is not redeclared and `range` is not undeclared in the shader. The error message seems to originate from the native function `Java_com_sun_prism_es2_GLContext_nCompileShader` in `GLContext.c`, not managing to compile the shader, but I can't tell why. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From kcr at openjdk.java.net Fri Jan 3 00:31:38 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 3 Jan 2020 00:31:38 GMT Subject: RFR: 8236626: Update copyright header for files modified in 2019 Message-ID: Simple fix to update the copyright year in the one file that was changed in 2019 after the last update of the year. @arapte can you please review? ------------- Commits: - c1d9b8ef: 8236626: Update copyright header for files modified in 2019 Changes: https://git.openjdk.java.net/jfx/pull/76/files Webrev: https://webrevs.openjdk.java.net/jfx/76/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236626 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/76.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/76/head:pull/76 PR: https://git.openjdk.java.net/jfx/pull/76 From kcr at openjdk.java.net Fri Jan 3 00:49:05 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 3 Jan 2020 00:49:05 GMT Subject: RFR: 8217472: Add attenuation for PointLight In-Reply-To: <_3FajXoBUGI2oS7eCJLrCiNCeUBhUpPvNzi6hbS6LXY=.92f12e93-1885-4d09-916a-90daa1fe1cbd@github.com> References: <8rYgugRQG-zrAZsJc8I2KCABvRgf6yJ7F-AOMgUvKV8=.267cc5a7-c8b5-4b6e-87ed-3cbdab895020@github.com> <_3FajXoBUGI2oS7eCJLrCiNCeUBhUpPvNzi6hbS6LXY=.92f12e93-1885-4d09-916a-90daa1fe1cbd@github.com> Message-ID: <2LXTsp6kQNFIuGEKjzqp8W8O5-VkFKHFPbpaWHddPlA=.4a6f9043-875e-4914-918a-b9365abf9e24@github.com> On Thu, 2 Jan 2020 18:18:21 GMT, Nir Lisker wrote: >> I think this is on the right track. The API looks like it is in good shape. >> >> This will need a fair bit of testing to ensure that there are no regressions either in functionality or (especially) performance, in addition to tests for the new functionality. On the performance aspect, the inner loop of the lighting calculation now has an additional if test for the max range and additional arithmetic calculations for the attenuation. What we will need is a test program that we can run on Mac and Windows to measure the performance of rendering in a fill-rate-limited case. Ideally, we would not pay much of a performance hit in the default case where `ca == 1, la == 0, qa == 0`, but we first need to be able to measure the drop in performance before we can say whether it is acceptable. >> >> Speaking of testing, I took the current patch for a test drive on Mac and Windows. I get the following system test failures on Mac, and also the same failure using fx83dfeatures/LightMotion in toys. >> >> >> Shader compile log: ERROR: 0:308: Use of undeclared identifier 'range' >> ERROR: 0:316: Regular non-array variable 'dist' may not be redeclared >> >> test.robot.test3d.MeshCompareTest > testSnapshot3D[3] STANDARD_ERROR >> java.lang.RuntimeException: Error creating fragment shader >> at javafx.graphics/com.sun.prism.es2.ES2Shader.createFromSource(ES2Shader.java:141) >> at javafx.graphics/com.sun.prism.es2.ES2PhongShader.getShader(ES2PhongShader.java:177) >> ... >> test.robot.test3d.MeshCompareTest > testSnapshot3D[3] FAILED >> java.lang.IllegalArgumentException: Unrecognized image loader: null >> at javafx.graphics/javafx.scene.image.WritableImage.loadTkImage(WritableImage.java:278) >> at javafx.graphics/javafx.scene.image.WritableImage$1.loadTkImage(WritableImage.java:53) >> at javafx.graphics/javafx.scene.Scene.doSnapshot(Scene.java:1340) >> at javafx.graphics/javafx.scene.Scene.doSnapshot(Scene.java:1372) >> at javafx.graphics/javafx.scene.Scene.snapshot(Scene.java:1462) >> at test.robot.test3d.MeshCompareTest.lambda$testSnapshot3D$0(MeshCompareTest.java:315) >> >> >> test.robot.test3d.Snapshot3DTest > testSnapshot3D[3] FAILED >> (same failure as above) >> >> >> test.robot.test3d.Snapshot3DTest > testSnapshot3D[7] FAILED >> (same failure as above) > >> I get the following system test failures on Mac >> ``` >> Shader compile log: ERROR: 0:308: Use of undeclared identifier 'range' >> ERROR: 0:316: Regular non-array variable 'dist' may not be redeclared >> ``` > > I don't have a Mac to test on, but on Ubuntu system tests pass (I ran the `test` command for systemTests). Does the sample app I attached also fail on Mac? They both use the same shaders, so I wonder where the issue could be. > Moreover, the error messages are strange. `dist` is not redeclared and `range` is not undeclared in the shader. The error message seems to originate from the native function `Java_com_sun_prism_es2_GLContext_nCompileShader` in `GLContext.c`, not managing to compile the shader, but I can't tell why. I get the same error on Ubuntu 16.04 as on Mac. Did you run the system tests with `-PFULL_TEST=true -PUSE_ROBOT=true`? Also, you can try running the `fx83dfeatures/LightMotion` toy and you should see the same error. I still need to test your sample app on Mac. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From arapte at openjdk.java.net Fri Jan 3 04:41:55 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Fri, 3 Jan 2020 04:41:55 GMT Subject: RFR: 8236626: Update copyright header for files modified in 2019 In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 00:29:48 GMT, Kevin Rushforth wrote: > Simple fix to update the copyright year in the one file that was changed in 2019 after the last update of the year. > > @arapte can you please review? looks good to me. ------------- Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/76 From arapte at openjdk.java.net Fri Jan 3 09:26:58 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Fri, 3 Jan 2020 09:26:58 GMT Subject: RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Sun, 17 Nov 2019 04:15:34 GMT, Nir Lisker wrote: > CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 I have added few comments, but have not run tests and sample yet. modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java line 71: > 70: public void setCa(double ca) { > 71: this.ca = ca; > 72: visualsChanged(); `if (this.ca != ca)` check can be added here. Similar for `la`, `qa` and `maxRange` modules/javafx.graphics/src/main/java/com/sun/prism/d3d/D3DContext.java line 556: > 555: void setPointLight(long nativeMeshView, int index, float x, float y, float z, > 556: float r, float g, float b, float w, float ca, float la, float qa, float maxRange) { > 557: nSetPointLight(pContext, nativeMeshView, index, x, y, z, r, g, b, w, ca, la, qa, maxRange); There is an extra space before `float maxRange` modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 97: > 96: * The maximum range of this {@code PointLight}. For a pixel to be affected by this light, its distance to > 97: * the light source must be less than or equal to the light's maximum range. Any negative value will treated > 98: * as 0. => will `be` treated as 0. modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java line 43: > 42: private static final double DEFAULT_MAX_RANGE = Double.POSITIVE_INFINITY; > 43: > 44: public NGPointLight() { Will it be a good idea to move these constants to `PointLight` class? However they look good here too. modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 41: > 40: * unless it belongs to a {@code Shape3D} outside of its {@code scope}. > 41: *

> 42: * The light's intensity can be set to decrease over distance by attenuating it. The attenuation formula Can the behavior be explained in terms of `Shape `or `Node `instead of `Pixel`. May be something like this, `Any node within the range of the light will be illuminated by this light, except the nodes that are added to the exclusion scope of this light.` modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 103: > 102: * {@code maxRange} value by finding the where the attenuation is close enough to 0. > 103: *

> 104: * Nodes that are inside the light's range can still be excluded from the light's effect {@code maxRange} value by finding the `distance` where the attenuation is close enough to 0. modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java line 64: > 63: > 64: private double ca = DEFAULT_CA; > 65: The coefficients are not directly used in any arithmetic on java side. They are converted to `float` and passed to GL or D3D pipeline. Should these be `float `instead of `double` ? modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.cc line 175: > 174: lightsAttenuation[a++] = lights[i].attenuation[2]; > 175: lightsAttenuation[a++] = 0; > 176: In the initial commit this filed was used for `maxRange`. I think that was good idea. Was there any issue with that approach ? ------------- Changes requested by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/43 From kcr at openjdk.java.net Fri Jan 3 15:55:47 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 3 Jan 2020 15:55:47 GMT Subject: [Rev 01] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: References: Message-ID: > This PR is a fix for [JDK-8234474](https://bugs.openjdk.java.net/browse/JDK-8234474), a crash in the code that shows a file open or save dialog. > > In order to provide additional support for Copy (CMD-C), Cut (CMD-X), and Paste (CMD-V), the Glass implementation for displaying a file open or save dialog subclasses NSSavePanel or NSOpenPanel to add this support. When the application is running in sandboxed mode, the dialogs are shown out-of-process by the "powerbox". In this mode, attempting to use our subclass results in a security exception. Previously, we added code to detect whether we were running in a sandbox as a fix for [JDK-8092977](https://bugs.openjdk.java.net/browse/JDK-8092977); we now use NSSavePanel or NSOpenPanel directly when in sandboxed mode. > > Starting with macOS 10.15 (Catalina) Apple always displays file dialogs out-of-process via powerbox, so our use of a subclass is ineffective. Further, we have reports of some cases where we crash even though our sandbox detection code doesn't indicate that we are running in a sandbox. > > Since there is no point in trying to use our subclasses on macOS 10.15 or later, I propose to fix this bug by changing the logic so that we use NSSavePanel or NSOpenPanel directly in either of the following conditions: > > 1) the app is running in sandbox mode > OR > 2) The platform is macOS 10.15 or later The pull request has been updated with 1 additional commit. ------------- Added commits: - b13da6f7: Update copyright year to 2020 Changes: - all: https://git.openjdk.java.net/jfx/pull/70/files - new: https://git.openjdk.java.net/jfx/pull/70/files/dca394e6..b13da6f7 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/70/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/70/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/70.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/70/head:pull/70 PR: https://git.openjdk.java.net/jfx/pull/70 From nlisker at openjdk.java.net Fri Jan 3 19:19:06 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Fri, 3 Jan 2020 19:19:06 GMT Subject: [Rev 01] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: > CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 The pull request has been updated with 1 additional commit. ------------- Added commits: - f66e8cf4: Addressing review comments Changes: - all: https://git.openjdk.java.net/jfx/pull/43/files - new: https://git.openjdk.java.net/jfx/pull/43/files/a388fb92..f66e8cf4 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/43/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/43/webrev.00-01 Stats: 25 lines in 3 files changed: 8 ins; 2 del; 15 mod Patch: https://git.openjdk.java.net/jfx/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/43/head:pull/43 PR: https://git.openjdk.java.net/jfx/pull/43 From nlisker at openjdk.java.net Fri Jan 3 19:22:55 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Fri, 3 Jan 2020 19:22:55 GMT Subject: [Rev 01] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 05:08:33 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java line 43: > >> 42: private static final double DEFAULT_MAX_RANGE = Double.POSITIVE_INFINITY; >> 43: >> 44: public NGPointLight() { > > Will it be a good idea to move these constants to `PointLight` class? > However they look good here too. If they are in `PointLight` it will be difficult for the peer to access them (will need to do through the accessor). Also, the parent `NGLightBase` holds the defaults for `color` and `lightOn`. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From nlisker at openjdk.java.net Fri Jan 3 19:32:35 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Fri, 3 Jan 2020 19:32:35 GMT Subject: [Rev 01] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 05:17:26 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 41: > >> 40: * unless it belongs to a {@code Shape3D} outside of its {@code scope}. >> 41: *

>> 42: * The light's intensity can be set to decrease over distance by attenuating it. The attenuation formula > > Can the behavior be explained in terms of `Shape `or `Node `instead of `Pixel`. > May be something like this, > > `Any node within the range of the light will be illuminated by this light, except the nodes that are added to the exclusion scope of this light.` The issue is that range and attenuation work on the pixel scale, not on the node/shape scale. A node can be partially illuminated if only part of it is within the range of the light. See the image in the comment above. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From nlisker at openjdk.java.net Fri Jan 3 19:36:45 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Fri, 3 Jan 2020 19:36:45 GMT Subject: [Rev 01] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 09:21:32 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java line 64: > >> 63: >> 64: private double ca = DEFAULT_CA; >> 65: > > The coefficients are not directly used in any arithmetic on java side. They are converted to `float` and passed to GL or D3D pipeline. Should these be `float `instead of `double` ? I was wondering about it myself, but all the other values are `double`s that are cast to `float`s. Wouldn't it also be odd to have the API properties `DoubleProperty` and the peer to use `float`s? Isn't it just a matter of where the cast happens? ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From nlisker at openjdk.java.net Fri Jan 3 19:41:15 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Fri, 3 Jan 2020 19:41:15 GMT Subject: [Rev 01] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 09:25:21 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.cc line 175: > >> 174: lightsAttenuation[a++] = lights[i].attenuation[2]; >> 175: lightsAttenuation[a++] = 0; >> 176: > > In the initial commit this filed was used for `maxRange`. I think that was good idea. Was there any issue with that approach ? `maxRange` has its own array to reserve space for `minRange` if we ever do that (see [this discussion](https://github.com/javafxports/openjdk-jfx/issues/256#issuecomment-469970201)), so I future-proofed it. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From kcr at openjdk.java.net Fri Jan 3 22:21:16 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 3 Jan 2020 22:21:16 GMT Subject: [Rev 01] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: <5wmco96mDV2o6049nG257Ac_7cUWQzkRXClNSDHdTYY=.c046919f-25fb-4437-894a-2c5ed5ebc936@github.com> On Fri, 3 Jan 2020 19:32:23 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 41: >> >>> 40: * unless it belongs to a {@code Shape3D} outside of its {@code scope}. >>> 41: *

>>> 42: * The light's intensity can be set to decrease over distance by attenuating it. The attenuation formula >> >> Can the behavior be explained in terms of `Shape `or `Node `instead of `Pixel`. >> May be something like this, >> >> `Any node within the range of the light will be illuminated by this light, except the nodes that are added to the exclusion scope of this light.` > > The issue is that range and attenuation work on the pixel scale, not on the node/shape scale. A node can be partially illuminated if only part of it is within the range of the light. See the image in the comment above. Right. This needs to talk about pixels. Perhaps there is a way to make it more clear that we are talking about pixels that are part of a rendered Shape3D, but I don't have a good suggestion right now. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From kcr at openjdk.java.net Fri Jan 3 22:23:46 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 3 Jan 2020 22:23:46 GMT Subject: [Rev 01] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 19:36:35 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java line 64: >> >>> 63: >>> 64: private double ca = DEFAULT_CA; >>> 65: >> >> The coefficients are not directly used in any arithmetic on java side. They are converted to `float` and passed to GL or D3D pipeline. Should these be `float `instead of `double` ? > > I was wondering about it myself, but all the other values are `double`s that are cast to `float`s. Wouldn't it also be odd to have the API properties `DoubleProperty` and the peer to use `float`s? Isn't it just a matter of where the cast happens? Yes, it's just a matter of where the cast happens. While we aren't entirely consistent, I think you'll find more places where the peers hold floats rather than double (one notable exception is transforms where we need the extra precision). In particular, Color and position values for shapes are stored in the peer as floats. Also, PhongMaterial stores the power as a float even though the API is double. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From kcr at openjdk.java.net Fri Jan 3 22:37:15 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 3 Jan 2020 22:37:15 GMT Subject: [Rev 01] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 09:26:43 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > I have added few comments, but have not run tests and sample yet. > I still need to test your sample app on Mac. I get the error with your sample app. It fails on Mac or Linux (Ubuntu 16.04) with the same error as I reported above. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From nlisker at openjdk.java.net Fri Jan 3 23:00:55 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Fri, 3 Jan 2020 23:00:55 GMT Subject: [Rev 02] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: > CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 The pull request has been updated with 1 additional commit. ------------- Added commits: - 464e8b5d: Fixed shader compilation errors for 2 and 3 lights in es2 Changes: - all: https://git.openjdk.java.net/jfx/pull/43/files - new: https://git.openjdk.java.net/jfx/pull/43/files/f66e8cf4..464e8b5d Webrevs: - full: https://webrevs.openjdk.java.net/jfx/43/webrev.02 - incr: https://webrevs.openjdk.java.net/jfx/43/webrev.01-02 Stats: 11 lines in 2 files changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jfx/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/43/head:pull/43 PR: https://git.openjdk.java.net/jfx/pull/43 From nlisker at openjdk.java.net Fri Jan 3 23:03:05 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Fri, 3 Jan 2020 23:03:05 GMT Subject: [Rev 02] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 22:37:06 GMT, Kevin Rushforth wrote: >> I have added few comments, but have not run tests and sample yet. > >> I still need to test your sample app on Mac. > > I get the error with your sample app. It fails on Mac or Linux (Ubuntu 16.04) with the same error as I reported above. The error was for the cases of 2 and 3 lights (I was testing 1) and should be fixed now. My fault with copy-paste... that's why we use loops, but I guess this is some optimization for the pipeline. I wonder if it's really woth it over a single shader looping over the number of lights like d3d does. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From kcr at openjdk.java.net Fri Jan 3 23:19:16 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 3 Jan 2020 23:19:16 GMT Subject: RFR: 8236448: Remove unused and repair broken Android/Dalvik code In-Reply-To: References: Message-ID: On Mon, 30 Dec 2019 11:05:55 GMT, Johan Vos wrote: > This allows to build the JavaFX jars and native libraries for Android devices I did a test build on Linux since there were changes to the shared Monocle classes. I didn't really look at the `android.gradle` changes or the new `android/nativeBridge.c` file, but I don't have any concerns. I did leave a couple minor formatting comments and one copyright year issue. modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidInputDeviceRegistry.java line 62: > 61: } > 62: Platform.runLater( () -> instance.gotTouchEvent(touchState)); > 63: } Minor: normally we wouldn't put a space between the initial `(` and the `()` modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleApplication.java line 229: > 228: ns.getWidth(), ns.getHeight(), > 229: 1.f,1.f, ns.getScale(), ns.getScale()); > 230: // Move the cursor to the middle of the screen Minor: add a space after the first `,` modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleWindowManager.java line 175: > 174: Platform.runLater(new Runnable () { > 175: @Override > 176: public void run() { Other than removing the one blank line above, this file is unchanged. Perhaps it could be reverted? modules/javafx.graphics/src/main/native-glass/monocle/android/nativeBridge.h line 2: > 1: /* > 2: * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved. > 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. That should be `2012, 2019, Oracle...` so as not to lose the initial year (well actually `2012, 2020, Oracle...` as of Jan 1, but that will get updated the next time I run my copyright script, which I plan to do right before RDP2, so either 2019 or 2020 for the last-modified year is fine). ------------- PR: https://git.openjdk.java.net/jfx/pull/75 From nlisker at openjdk.java.net Fri Jan 3 23:22:56 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Fri, 3 Jan 2020 23:22:56 GMT Subject: [Rev 02] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 22:23:29 GMT, Kevin Rushforth wrote: >> I was wondering about it myself, but all the other values are `double`s that are cast to `float`s. Wouldn't it also be odd to have the API properties `DoubleProperty` and the peer to use `float`s? Isn't it just a matter of where the cast happens? > > Yes, it's just a matter of where the cast happens. While we aren't entirely consistent, I think you'll find more places where the peers hold floats rather than double (one notable exception is transforms where we need the extra precision). In particular, Color and position values for shapes are stored in the peer as floats. Also, PhongMaterial stores the power as a float even though the API is double. Alright, I don't mind it, I'll cast in the peer level. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From nlisker at openjdk.java.net Fri Jan 3 23:42:10 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Fri, 3 Jan 2020 23:42:10 GMT Subject: [Rev 03] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: > CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 The pull request has been updated with 1 additional commit. ------------- Added commits: - 66cdab32: Attenuation and range changed internally to floats from doubles Changes: - all: https://git.openjdk.java.net/jfx/pull/43/files - new: https://git.openjdk.java.net/jfx/pull/43/files/464e8b5d..66cdab32 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/43/webrev.03 - incr: https://webrevs.openjdk.java.net/jfx/43/webrev.02-03 Stats: 32 lines in 3 files changed: 0 ins; 0 del; 32 mod Patch: https://git.openjdk.java.net/jfx/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/43/head:pull/43 PR: https://git.openjdk.java.net/jfx/pull/43 From kcr at openjdk.java.net Fri Jan 3 23:50:44 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 3 Jan 2020 23:50:44 GMT Subject: RFR: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface In-Reply-To: References: Message-ID: On Tue, 24 Dec 2019 06:37:05 GMT, Ambarish Rapte wrote: >> The dispose methods indeed won't set the `mem_Error_Flag` but this flag might have been set by other methods. Isn't there a probability that the flag has been set, and that `readAndClearMemErrorFlag()` is not yet called since the flag has been set? > > Hi Johan, I did miss to verify this angle. > But have checked the code now and can confirm that, in a given function for all possible calls to `setMemErrorFlag()` there exists a call to `readAndClearMemErrorFlag()` in the same function. So it looks safe to remove the memory checks from `dispose()` I also looked at the code and don't see any mismatches (including those called from the `ACQUIRE_SURFACE` macro). I suppose you could restore the call, but since we are in a disposer thread throwing an exception doesn't seem like the right thing to do. You could log the error, but if we are sure there can be no pending errors, it might not be worth the effort. ------------- PR: https://git.openjdk.java.net/jfx/pull/66 From nlisker at openjdk.java.net Sat Jan 4 18:22:45 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Sat, 4 Jan 2020 18:22:45 GMT Subject: [Rev 03] RFR: 8217472: Add attenuation for PointLight In-Reply-To: <5wmco96mDV2o6049nG257Ac_7cUWQzkRXClNSDHdTYY=.c046919f-25fb-4437-894a-2c5ed5ebc936@github.com> References: <5wmco96mDV2o6049nG257Ac_7cUWQzkRXClNSDHdTYY=.c046919f-25fb-4437-894a-2c5ed5ebc936@github.com> Message-ID: On Fri, 3 Jan 2020 22:21:01 GMT, Kevin Rushforth wrote: >> The issue is that range and attenuation work on the pixel scale, not on the node/shape scale. A node can be partially illuminated if only part of it is within the range of the light. See the image in the comment above. > > Right. This needs to talk about pixels. Perhaps there is a way to make it more clear that we are talking about pixels that are part of a rendered Shape3D, but I don't have a good suggestion right now. Maybe A light source that radiates light equally in all directions away from itself. The location of the light source is a single point in space. The light affects {@code Shape3D}s in its {@code scope}. Any pixels in the light's {@code range} that belong to a {@code Shape3D} will be illuminated by it according to the computation specified in {@link PhongMaterial}. The docs of `PhongMaterial` will need need to be updated too. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From tsayao at openjdk.java.net Mon Jan 6 00:29:45 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Mon, 6 Jan 2020 00:29:45 GMT Subject: RFR: 8236651: Simplify and update glass gtk backend Message-ID: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> This proposed change does the following: - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); - Use gtk signals instead of gdk events (also to reduce code size); - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; - Replaces (pointer and focus) grabbing with a gtk approach; - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; - Simplified cursor changing; In general it reduces code size and complexity and hands more work to gtk. Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. Please, mark it as WIP. ![image](https://user-images.githubusercontent.com/30704286/71788555-442ba400-3002-11ea-9d8c-e4265909fe6b.png) ------------- Commits: - 039daa4a: Cleaning - 9f209f1e: JDK-8236651 Simplify and update glass gtk backend Changes: https://git.openjdk.java.net/jfx/pull/77/files Webrev: https://webrevs.openjdk.java.net/jfx/77/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236651 Stats: 2497 lines in 11 files changed: 600 ins; 1543 del; 354 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From tsayao at openjdk.java.net Mon Jan 6 00:39:31 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Mon, 6 Jan 2020 00:39:31 GMT Subject: [Rev 01] RFR: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > Please, mark it as WIP. > > ![image](https://user-images.githubusercontent.com/30704286/71788555-442ba400-3002-11ea-9d8c-e4265909fe6b.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - 7b48e484: Cleaning + change year to 2020 Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/039daa4a..7b48e484 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.00-01 Stats: 45 lines in 5 files changed: 0 ins; 42 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From tsayao at openjdk.java.net Mon Jan 6 02:08:14 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Mon, 6 Jan 2020 02:08:14 GMT Subject: [Rev 02] RFR: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > Please, mark it as WIP. > > ![image](https://user-images.githubusercontent.com/30704286/71788555-442ba400-3002-11ea-9d8c-e4265909fe6b.png) The pull request has been updated with 4 additional commits. ------------- Added commits: - 628d5528: Revert idea files - 8b0cadfc: Fix crash - 1c3df122: Fix crash - 4691800a: Fix crash Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/7b48e484..628d5528 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.02 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.01-02 Stats: 118 lines in 4 files changed: 25 ins; 47 del; 46 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From ghb at openjdk.java.net Mon Jan 6 04:32:35 2020 From: ghb at openjdk.java.net (Guru Hb) Date: Mon, 6 Jan 2020 04:32:35 GMT Subject: [Rev 03] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute In-Reply-To: References: <425XkDr6IJiSBJbZzahPMfYluP8YMHgn52xXKrVl2T4=.65dcf6dd-dbf9-4307-8e53-6082e94ccb50@github.com> Message-ID: On Mon, 6 Jan 2020 04:32:34 GMT, Arun Joseph wrote: >> Issue: Native part of WebView throws a DOMException and then, continues executing the rest of the function assuming that value is present. This causes the JVM to crash when retrieving the value. >> >> Fix: Return from the function if exception was raised (code is similar to exception handling in [WebKitLegacy/java/DOM/JavaTreeWalker.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM/JavaTreeWalker.cpp)) >> >> This fix also needs to be applied to all function calls in [WebKitLegacy/java/DOM](https://github.com/openjdk/jfx/tree/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM) functions which raises DOMError similar to createAttributeImpl(). > > The pull request has been updated with 1 additional commit. +1, Looks good to me. ------------- Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/47 From ghb at openjdk.java.net Mon Jan 6 04:43:04 2020 From: ghb at openjdk.java.net (Guru Hb) Date: Mon, 6 Jan 2020 04:43:04 GMT Subject: RFR: 8234471: Canvas in webview displayed with wrong scale on Windows In-Reply-To: References: Message-ID: On Mon, 9 Dec 2019 13:09:04 GMT, Arun Joseph wrote: > This bug can be reproduced when the screen resolution is at 125%, 150% and 175% for Windows, which correpsonds to `pixelScale` values of 1.25, 1.5 and 1.75, respectively. > > Issue: The rectangle inside canvas is rendered on `pixelScale` while the borders are rendered on `Math.ceil(pixelScale)` > > Fix: Use `Math.ceil(pixelScale)` for calculating `pixelScaleTransform` have you tested this on Linux and Mac by changing JVM option -Dglass.win.uiScale=. ------------- PR: https://git.openjdk.java.net/jfx/pull/62 From abhinay_agarwal at live.com Mon Jan 6 09:43:22 2020 From: abhinay_agarwal at live.com (Abhinay Agarwal) Date: Mon, 6 Jan 2020 09:43:22 +0000 Subject: Maximized undecorated stage Message-ID: Hi, If maximize property is set to true for an undecorated Stage, the following behaviour is observed on different platforms: * Windows: Undecorated stage is maximized * MacOS: Undecorated stage is not maximized * Linux(Ubuntu): Undecorated stage is not maximized The following piece of code can be used to reproduce the behaviour: import javafx.application.Application; import javafx.scene.Scene; import javafx.scene.control.Label; import javafx.scene.layout.StackPane; import javafx.stage.Stage; import javafx.stage.StageStyle; public class MaximizedStage extends Application { public void start (Stage stage) { StackPane sp = new StackPane(new Label("Hello")); stage.setScene(new Scene (sp, 500, 500)); stage.initStyle(StageStyle.UNDECORATED); stage.show(); stage.setMaximized(true); } } Is there a reason why the stage gets maximized on Windows but fails on other platforms? Regards, Abhinay From kevin.rushforth at oracle.com Mon Jan 6 14:05:52 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 6 Jan 2020 06:05:52 -0800 Subject: Linux Glass - WindowContextChild and WindowContextPlug In-Reply-To: References: Message-ID: <03d329fa-0764-a45a-f30e-e36157ee71c4@oracle.com> This code was used for running Applets. Support for applets was removed in JDK 11, so the code is no longer relevant. -- Kevin On 1/2/2020 3:18 AM, Thiago Milczarek Sayao wrote: > Ran all the robot test suite and those two classes are not touched. > > I suspect they are used for web-start. > > Are there any guides for running Ensemble on web-start? I guess I must use an old linux distro, that has old browser tech. > > Happy new year. > ________________________________ > De: openjfx-dev em nome de Thiago Milczarek Sayao > Enviado: ter?a-feira, 31 de dezembro de 2019 16:50 > Para: openjfx-dev at openjdk.java.net > Assunto: Linux Glass - WindowContextChild and WindowContextPlug > > > Does anyone knows the context of use of WindowContextChild and WindowContextPlug on the linux glass implementation? > > File: glass_window.cpp > > They seem to be never called. > > Thanks. > > From tsayao at openjdk.java.net Mon Jan 6 14:06:48 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Mon, 6 Jan 2020 14:06:48 GMT Subject: [Rev 03] RFR: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > Please, mark it as WIP. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - 49426b66: Fix flickering and sizing issues Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/628d5528..49426b66 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.03 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.02-03 Stats: 68 lines in 3 files changed: 4 ins; 54 del; 10 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From tsayao at openjdk.java.net Mon Jan 6 14:11:04 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Mon, 6 Jan 2020 14:11:04 GMT Subject: RFR: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: <31X4pHGnuhexI5Rz9Y8afMrdFl0pfNPKp9nMYMNcG50=.1f068b3f-0901-43f3-a2d1-8a12aa18b040@github.com> On Mon, 6 Jan 2020 00:28:14 GMT, Thiago Milczarek Sayao wrote: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > Please, mark it as **WIP**. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) There are still some sizing issues that I am aware of. ------------- PR: https://git.openjdk.java.net/jfx/pull/77 From kevin.rushforth at oracle.com Mon Jan 6 14:23:21 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 6 Jan 2020 06:23:21 -0800 Subject: Linux Glass - WindowContextChild and WindowContextPlug In-Reply-To: <03d329fa-0764-a45a-f30e-e36157ee71c4@oracle.com> References: <03d329fa-0764-a45a-f30e-e36157ee71c4@oracle.com> Message-ID: Btw, there is already a cleanup issue filed to target the removal of the implementation code for applets: https://bugs.openjdk.java.net/browse/JDK-8201538 -- Kevin On 1/6/2020 6:05 AM, Kevin Rushforth wrote: > This code was used for running Applets. Support for applets was > removed in JDK 11, so the code is no longer relevant. > > -- Kevin > > > On 1/2/2020 3:18 AM, Thiago Milczarek Sayao wrote: >> Ran all the robot test suite and those two classes are not touched. >> >> I suspect they are used for web-start. >> >> Are there any guides for running Ensemble on web-start? I guess I >> must use an old linux distro, that has old browser tech. >> >> Happy new year. >> ________________________________ >> De: openjfx-dev em nome de >> Thiago Milczarek Sayao >> Enviado: ter?a-feira, 31 de dezembro de 2019 16:50 >> Para: openjfx-dev at openjdk.java.net >> Assunto: Linux Glass - WindowContextChild and WindowContextPlug >> >> >> Does anyone knows the context of use of WindowContextChild and >> WindowContextPlug on the linux glass implementation? >> >> File: glass_window.cpp >> >> They seem to be never called. >> >> Thanks. >> >> > From kcr at openjdk.java.net Mon Jan 6 14:25:35 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 14:25:35 GMT Subject: RFR: 8236651: Simplify and update glass gtk backend In-Reply-To: <31X4pHGnuhexI5Rz9Y8afMrdFl0pfNPKp9nMYMNcG50=.1f068b3f-0901-43f3-a2d1-8a12aa18b040@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> <31X4pHGnuhexI5Rz9Y8afMrdFl0pfNPKp9nMYMNcG50=.1f068b3f-0901-43f3-a2d1-8a12aa18b040@github.com> Message-ID: On Mon, 6 Jan 2020 14:10:52 GMT, Thiago Milczarek Sayao wrote: >> This proposed change does the following: >> >> - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); >> - Use gtk signals instead of gdk events (also to reduce code size); >> - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; >> - Replaces (pointer and focus) grabbing with a gtk approach; >> - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; >> - Simplified cursor changing; >> - Reduced the use of gtk/gdk deprecated functions; >> >> >> In general it reduces code size and complexity and hands more work to gtk. >> >> Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. >> >> Please, mark it as **WIP**. >> >> ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) > > There are still some sizing issues that I am aware of. > Please, mark it as WIP. You can do this by editing the title and adding `WIP: ` as a prefix. ------------- PR: https://git.openjdk.java.net/jfx/pull/77 From arapte at openjdk.java.net Mon Jan 6 16:24:43 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Mon, 6 Jan 2020 16:24:43 GMT Subject: [Rev 01] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: References: Message-ID: On Mon, 6 Jan 2020 16:24:43 GMT, Kevin Rushforth wrote: >> This PR is a fix for [JDK-8234474](https://bugs.openjdk.java.net/browse/JDK-8234474), a crash in the code that shows a file open or save dialog. >> >> In order to provide additional support for Copy (CMD-C), Cut (CMD-X), and Paste (CMD-V), the Glass implementation for displaying a file open or save dialog subclasses NSSavePanel or NSOpenPanel to add this support. When the application is running in sandboxed mode, the dialogs are shown out-of-process by the "powerbox". In this mode, attempting to use our subclass results in a security exception. Previously, we added code to detect whether we were running in a sandbox as a fix for [JDK-8092977](https://bugs.openjdk.java.net/browse/JDK-8092977); we now use NSSavePanel or NSOpenPanel directly when in sandboxed mode. >> >> Starting with macOS 10.15 (Catalina) Apple always displays file dialogs out-of-process via powerbox, so our use of a subclass is ineffective. Further, we have reports of some cases where we crash even though our sandbox detection code doesn't indicate that we are running in a sandbox. >> >> Since there is no point in trying to use our subclasses on macOS 10.15 or later, I propose to fix this bug by changing the logic so that we use NSSavePanel or NSOpenPanel directly in either of the following conditions: >> >> 1) the app is running in sandbox mode >> OR >> 2) The platform is macOS 10.15 or later > > The pull request has been updated with 1 additional commit. Looks good to me, Verified that all tests pass on Mojave 10.14.6 ------------- Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/70 From prr at openjdk.java.net Mon Jan 6 17:12:55 2020 From: prr at openjdk.java.net (Phil Race) Date: Mon, 6 Jan 2020 17:12:55 GMT Subject: [Rev 01] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: References: Message-ID: On Mon, 6 Jan 2020 16:24:33 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > Looks good to me, Verified that all tests pass on Mojave 10.14.6 Based on my reading of https://bugs.openjdk.java.net/browse/JDK-8092977, this means the support for edit operations in these dialogs is on its way out ... now supportable only in non-sandboxed apps on the older macOS releases. Is there a serious practical consequence of this, or was the editing just a convenience ? There must have been some resason we went to the trouble. However based on this being "on its way out" why try to prolong it ? Just drop the subclasses now. ------------- PR: https://git.openjdk.java.net/jfx/pull/70 From kcr at openjdk.java.net Mon Jan 6 17:35:25 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 17:35:25 GMT Subject: [Rev 01] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: References: Message-ID: On Mon, 6 Jan 2020 17:12:45 GMT, Phil Race wrote: >> Looks good to me, Verified that all tests pass on Mojave 10.14.6 > > Based on my reading of https://bugs.openjdk.java.net/browse/JDK-8092977, this means the support for edit operations in these dialogs is on its way out ... now supportable only in non-sandboxed apps on the older macOS releases. Is there a serious practical consequence of this, or was the editing just a convenience ? There must have been some resason we went to the trouble. However based on this being "on its way out" why try to prolong it ? Just drop the subclasses now. This was just added as a convenience, so it isn't critical functionality. Having said that, while we could just drop the subclasses now, it would cause a perceived regression in behavior for users running on macOS 10.14 Mojave. So my preference would be to not remove the subclass at this time, but to just not use them when running on 10.15 or later. ------------- PR: https://git.openjdk.java.net/jfx/pull/70 From prr at openjdk.java.net Mon Jan 6 17:44:55 2020 From: prr at openjdk.java.net (Phil Race) Date: Mon, 6 Jan 2020 17:44:55 GMT Subject: [Rev 01] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: References: Message-ID: <2HBoid-2b30X-C8V3MJSNswzRa2fKH0APIFjoxOqWtQ=.59936c8b-920a-4838-aed0-f1d04c5aadf3@github.com> On Mon, 6 Jan 2020 17:35:11 GMT, Kevin Rushforth wrote: >> Based on my reading of https://bugs.openjdk.java.net/browse/JDK-8092977, this means the support for edit operations in these dialogs is on its way out ... now supportable only in non-sandboxed apps on the older macOS releases. Is there a serious practical consequence of this, or was the editing just a convenience ? There must have been some resason we went to the trouble. However based on this being "on its way out" why try to prolong it ? Just drop the subclasses now. > > This was just added as a convenience, so it isn't critical functionality. > > Having said that, while we could just drop the subclasses now, it would cause a perceived regression in behavior for users running on macOS 10.14 Mojave. So my preference would be to not remove the subclass at this time, but to just not use them when running on 10.15 or later. Well then you'll just have to come back to it. If its not critical I'd remove it now so that FX 15 (or is this for 14 ?) behaves consistently ------------- PR: https://git.openjdk.java.net/jfx/pull/70 From kcr at openjdk.java.net Mon Jan 6 18:11:46 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 18:11:46 GMT Subject: [Rev 01] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: <2HBoid-2b30X-C8V3MJSNswzRa2fKH0APIFjoxOqWtQ=.59936c8b-920a-4838-aed0-f1d04c5aadf3@github.com> References: <2HBoid-2b30X-C8V3MJSNswzRa2fKH0APIFjoxOqWtQ=.59936c8b-920a-4838-aed0-f1d04c5aadf3@github.com> Message-ID: On Mon, 6 Jan 2020 17:44:39 GMT, Phil Race wrote: >> This was just added as a convenience, so it isn't critical functionality. >> >> Having said that, while we could just drop the subclasses now, it would cause a perceived regression in behavior for users running on macOS 10.14 Mojave. So my preference would be to not remove the subclass at this time, but to just not use them when running on 10.15 or later. > > Well then you'll just have to come back to it. If its not critical I'd remove it now so that FX 15 (or is this for 14 ?) behaves consistently This is targeted for JavaFX 14, which is another reason to go with a more targeted (safer) fix, since we are almost at RDP1. For JavaFX 15 it does seem best to just remove the functionality entirely. ------------- PR: https://git.openjdk.java.net/jfx/pull/70 From prr at openjdk.java.net Mon Jan 6 18:20:05 2020 From: prr at openjdk.java.net (Phil Race) Date: Mon, 6 Jan 2020 18:20:05 GMT Subject: [Rev 01] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: References: <2HBoid-2b30X-C8V3MJSNswzRa2fKH0APIFjoxOqWtQ=.59936c8b-920a-4838-aed0-f1d04c5aadf3@github.com> Message-ID: On Mon, 6 Jan 2020 18:11:29 GMT, Kevin Rushforth wrote: >> Well then you'll just have to come back to it. If its not critical I'd remove it now so that FX 15 (or is this for 14 ?) behaves consistently > > This is targeted for JavaFX 14, which is another reason to go with a more targeted (safer) fix, since we are almost at RDP1. For JavaFX 15 it does seem best to just remove the functionality entirely. Ok, fair enough for 14 ... ------------- PR: https://git.openjdk.java.net/jfx/pull/70 From kcr at openjdk.java.net Mon Jan 6 18:21:25 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 18:21:25 GMT Subject: [Rev 01] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: References: <2HBoid-2b30X-C8V3MJSNswzRa2fKH0APIFjoxOqWtQ=.59936c8b-920a-4838-aed0-f1d04c5aadf3@github.com> Message-ID: On Mon, 6 Jan 2020 18:19:54 GMT, Phil Race wrote: >> This is targeted for JavaFX 14, which is another reason to go with a more targeted (safer) fix, since we are almost at RDP1. For JavaFX 15 it does seem best to just remove the functionality entirely. > > Ok, fair enough for 14 ... I'll file a follow-up bug for 15 shortly. @prrace would you be willing to be the second reviewer on this fix? ------------- PR: https://git.openjdk.java.net/jfx/pull/70 From kcr at openjdk.java.net Mon Jan 6 18:31:35 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 18:31:35 GMT Subject: [Rev 01] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: References: <2HBoid-2b30X-C8V3MJSNswzRa2fKH0APIFjoxOqWtQ=.59936c8b-920a-4838-aed0-f1d04c5aadf3@github.com> Message-ID: On Mon, 6 Jan 2020 18:21:17 GMT, Kevin Rushforth wrote: >> Ok, fair enough for 14 ... > > I'll file a follow-up bug for 15 shortly. > > @prrace would you be willing to be the second reviewer on this fix? I filed [JDK-8236685](https://bugs.openjdk.java.net/browse/JDK-8236685) to remove the custom dialogs in JavaFX 15. ------------- PR: https://git.openjdk.java.net/jfx/pull/70 From projects at saring.de Mon Jan 6 19:28:32 2020 From: projects at saring.de (projects at saring.de) Date: Mon, 6 Jan 2020 20:28:32 +0100 Subject: Broken text rendering in macOS Catalina Message-ID: Hi, I've tried to report this JavaFX problem to the OpenJDK project ( https://bugreport.java.com/bugreport/ ), unfortunately I don?t have an account there. And the report of me as a guest wasn?t accepted. That?s why I?m trying to use this mailing list. Bug description: Since updating to macOS Catalina the text rendering is broken in all JavaFX contrals which render text (labels, text areas, buttons, menu items etc.). This behavior is new since macOS 10.15 Catalina, it worked perfectly in macOS 10.14.x and before. The rendered text is still readable, but looks very blurred. And it looks like vertical pixel lines are completely missing in the displayed text. This error occurs when using a non-Retina (HiDPI) display, e.g. a MacBook Air with the 1440x900 resolution or an external typical FullHD display (e.g. 24" 1920x1080). Only when using a HiDPI / Retina display, then the rendered text looks fine. Unfortunately many / most people are still using non-Retina external displays. Test environment: * OS: macOS 10.15.2 * Java: OpenJDK 11.0.5 (AdaptOpenJDK), OpenJDK 13.0.1 (AdoptOpenJDK), OpenJDK 14 EA Build 28 (2019/12/18) * JavaFX: OpenJFX 11.0.2, OpenJFX 13.0.1, OpenJFX 14-ea+6 * Display: Dell 24" 1920x1200, MacBook Air (2013) 1440x900 The same problem exists in all combinations. How to reproduce (example): * Install and launch SceneBuilder (tested with 11.0.0 from https://gluonhq.com/products/scene-builder/ ) * Open an FXML file or create a new one * Display Info dialog (Help > About Scene Builder) Screenshots of the About Dialog: * NonRetina (broken): https://www.saring.de/openjfx-bugreport/SceneBuilder_About-NonRetina.png (e.g. in line ?The default configuration") * Retina (OK): https://www.saring.de/openjfx-bugreport/SceneBuilder_About-Retina.png Best regards, Stefan From kcr at openjdk.java.net Mon Jan 6 19:39:16 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 19:39:16 GMT Subject: [Integrated] RFR: 8130738: TextFlow's tab width is static In-Reply-To: References: Message-ID: <4cc9c958-cec6-4add-8aeb-4fb733837366@openjdk.org> Changeset: 8367e1a6 Author: Scott Palmer Committer: Kevin Rushforth Date: 2019-12-31 18:34:33 +0000 URL: https://git.openjdk.java.net/jfx/commit/8367e1a6 8130738: Add tabSize property to Text and TextFlow Reviewed-by: prr, kcr ! modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html ! modules/javafx.graphics/src/main/java/com/sun/javafx/scene/text/TextLayout.java ! modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java ! modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java ! modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java ! modules/javafx.graphics/src/test/java/test/com/sun/javafx/pgstub/StubTextLayout.java + modules/javafx.graphics/src/test/java/test/javafx/scene/text/TextFlowTest.java ! modules/javafx.graphics/src/test/java/test/javafx/scene/text/TextTest.java ! modules/javafx.graphics/src/test/java/test/javafx/scene/text/Text_cssMethods_Test.java From jvos at openjdk.java.net Mon Jan 6 19:39:18 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Mon, 6 Jan 2020 19:39:18 GMT Subject: [Integrated] RFR: 8236484: Compile error in monocle dispman In-Reply-To: References: Message-ID: Changeset: 4c6ebfb4 Author: Johan Vos Date: 2020-01-01 19:15:09 +0000 URL: https://git.openjdk.java.net/jfx/commit/4c6ebfb4 8236484: Compile error in monocle dispman Reviewed-by: kcr ! modules/javafx.graphics/src/main/native-glass/monocle/dispman/DispmanScreen.c From kcr at openjdk.java.net Mon Jan 6 19:39:24 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 19:39:24 GMT Subject: [Integrated] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings In-Reply-To: References: Message-ID: <513d4f3e-7101-45f1-b30b-144c11d0f5c1@openjdk.org> Changeset: 1952606a Author: Thiago Milczarek Sayao Committer: Kevin Rushforth Date: 2020-01-02 17:01:13 +0000 URL: https://git.openjdk.java.net/jfx/commit/1952606a 8232811: Dialog's preferred size no longer accommodates multi-line strings Reviewed-by: kcr, arapte ! modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp + tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java From kcr at openjdk.java.net Mon Jan 6 19:39:29 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 19:39:29 GMT Subject: [Integrated] RFR: 8236626: Update copyright header for files modified in 2019 In-Reply-To: References: Message-ID: <590eb433-5c16-4896-ae34-a0c2c9975b27@openjdk.org> Changeset: 3c4d68dc Author: Kevin Rushforth Date: 2020-01-03 13:04:04 +0000 URL: https://git.openjdk.java.net/jfx/commit/3c4d68dc 8236626: Update copyright header for files modified in 2019 Reviewed-by: arapte ! modules/javafx.graphics/src/test/java/test/javafx/scene/text/Text_cssMethods_Test.java From swpalmer at openjdk.java.net Mon Jan 6 19:42:55 2020 From: swpalmer at openjdk.java.net (Scott Palmer) Date: Mon, 6 Jan 2020 19:42:55 GMT Subject: RFR: 8236648: javadoc warning on Text::tabSizeProperty method Message-ID: <8vO-u43ZDM6ru_aowjZntkXsVafe6BijW2fufIdidqU=.23a4a27f-589e-42fe-8e5e-51e630d9f468@github.com> Implemented suggested fix to address javadoc warning. ------------- Commits: - bd81a902: 8236648: javadoc warning on Text::tabSizeProperty method Changes: https://git.openjdk.java.net/jfx/pull/78/files Webrev: https://webrevs.openjdk.java.net/jfx/78/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236648 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/78.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/78/head:pull/78 PR: https://git.openjdk.java.net/jfx/pull/78 From kevin.rushforth at oracle.com Mon Jan 6 20:05:41 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 6 Jan 2020 12:05:41 -0800 Subject: Broken text rendering in macOS Catalina In-Reply-To: References: Message-ID: <96bfa4fe-ba71-e458-0aaa-56dede72b04f@oracle.com> Your bug report was successfully logged into our system for triaging by our incident team. Normally, the bugs are processed quickly and transferred into the JDK project within a couple of days. The delay is due to the holidays. I have transferred that one manually to the JDK project as: https://bugs.openjdk.java.net/browse/JDK-8236689 I can add the additional pointers to the screenshots you provided below to the bug report. -- Kevin On 1/6/2020 11:28 AM, projects at saring.de wrote: > Hi, > > I've tried to report this JavaFX problem to the OpenJDK project ( https://bugreport.java.com/bugreport/ ), unfortunately I don?t have an account there. And the report of me as a guest wasn?t accepted. That?s why I?m trying to use this mailing list. > > Bug description: > > Since updating to macOS Catalina the text rendering is broken in all JavaFX contrals which render text (labels, text areas, buttons, menu items etc.). This behavior is new since macOS 10.15 Catalina, it worked perfectly in macOS 10.14.x and before. > The rendered text is still readable, but looks very blurred. And it looks like vertical pixel lines are completely missing in the displayed text. > > This error occurs when using a non-Retina (HiDPI) display, e.g. a MacBook Air with the 1440x900 resolution or an external typical FullHD display (e.g. 24" 1920x1080). Only when using a HiDPI / Retina display, then the rendered text looks fine. Unfortunately many / most people are still using non-Retina external displays. > > Test environment: > > * OS: macOS 10.15.2 > * Java: OpenJDK 11.0.5 (AdaptOpenJDK), OpenJDK 13.0.1 (AdoptOpenJDK), OpenJDK 14 EA Build 28 (2019/12/18) > * JavaFX: OpenJFX 11.0.2, OpenJFX 13.0.1, OpenJFX 14-ea+6 > * Display: Dell 24" 1920x1200, MacBook Air (2013) 1440x900 > > The same problem exists in all combinations. > > How to reproduce (example): > > * Install and launch SceneBuilder (tested with 11.0.0 from https://gluonhq.com/products/scene-builder/ ) > * Open an FXML file or create a new one > * Display Info dialog (Help > About Scene Builder) > > Screenshots of the About Dialog: > > * NonRetina (broken): https://www.saring.de/openjfx-bugreport/SceneBuilder_About-NonRetina.png > (e.g. in line ?The default configuration") > * Retina (OK): https://www.saring.de/openjfx-bugreport/SceneBuilder_About-Retina.png > > Best regards, > Stefan From kcr at openjdk.java.net Mon Jan 6 20:59:31 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 20:59:31 GMT Subject: [Integrated] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute In-Reply-To: <425XkDr6IJiSBJbZzahPMfYluP8YMHgn52xXKrVl2T4=.65dcf6dd-dbf9-4307-8e53-6082e94ccb50@github.com> References: <425XkDr6IJiSBJbZzahPMfYluP8YMHgn52xXKrVl2T4=.65dcf6dd-dbf9-4307-8e53-6082e94ccb50@github.com> Message-ID: Changeset: f1108b0a Author: Arun Joseph Committer: Kevin Rushforth Date: 2020-01-06 20:58:28 +0000 URL: https://git.openjdk.java.net/jfx/commit/f1108b0a 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute Reviewed-by: kcr, ghb ! modules/javafx.web/src/main/native/Source/WebCore/bindings/java/JavaDOMUtils.h ! modules/javafx.web/src/test/java/test/javafx/scene/web/DOMTest.java From prr at openjdk.java.net Mon Jan 6 21:01:26 2020 From: prr at openjdk.java.net (Phil Race) Date: Mon, 6 Jan 2020 21:01:26 GMT Subject: [Rev 01] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: References: Message-ID: On Mon, 6 Jan 2020 21:01:25 GMT, Kevin Rushforth wrote: >> This PR is a fix for [JDK-8234474](https://bugs.openjdk.java.net/browse/JDK-8234474), a crash in the code that shows a file open or save dialog. >> >> In order to provide additional support for Copy (CMD-C), Cut (CMD-X), and Paste (CMD-V), the Glass implementation for displaying a file open or save dialog subclasses NSSavePanel or NSOpenPanel to add this support. When the application is running in sandboxed mode, the dialogs are shown out-of-process by the "powerbox". In this mode, attempting to use our subclass results in a security exception. Previously, we added code to detect whether we were running in a sandbox as a fix for [JDK-8092977](https://bugs.openjdk.java.net/browse/JDK-8092977); we now use NSSavePanel or NSOpenPanel directly when in sandboxed mode. >> >> Starting with macOS 10.15 (Catalina) Apple always displays file dialogs out-of-process via powerbox, so our use of a subclass is ineffective. Further, we have reports of some cases where we crash even though our sandbox detection code doesn't indicate that we are running in a sandbox. >> >> Since there is no point in trying to use our subclasses on macOS 10.15 or later, I propose to fix this bug by changing the logic so that we use NSSavePanel or NSOpenPanel directly in either of the following conditions: >> >> 1) the app is running in sandbox mode >> OR >> 2) The platform is macOS 10.15 or later > > The pull request has been updated with 1 additional commit. ------------- Marked as reviewed by prr (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/70 From kcr at openjdk.java.net Mon Jan 6 21:12:29 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 21:12:29 GMT Subject: [Integrated] RFR: 8234474: [macos 10.15] Crash in file dialog in sandbox mode In-Reply-To: References: Message-ID: Changeset: 587f195c Author: Kevin Rushforth Date: 2020-01-06 21:11:20 +0000 URL: https://git.openjdk.java.net/jfx/commit/587f195c 8234474: [macos 10.15] Crash in file dialog in sandbox mode Reviewed-by: arapte, prr ! modules/javafx.graphics/src/main/native-glass/mac/GlassDialogs.m From kevin.rushforth at oracle.com Mon Jan 6 21:17:37 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 6 Jan 2020 13:17:37 -0800 Subject: Pending Skara notifications, JBS updates for recent fixes In-Reply-To: <118d678c-14eb-f35c-87f4-7f04539857e7@oracle.com> References: <118d678c-14eb-f35c-87f4-7f04539857e7@oracle.com> Message-ID: This is now fixed. The Skara bot successfully processed the backlog and resolved all of the issues in question. -- Kevin On 1/2/2020 9:12 AM, Kevin Rushforth wrote: > The Skara commit notifications and JBS issue updates for the following > recently-integrated bugs are still pending: > > https://bugs.openjdk.java.net/browse/JDK-8130738 > https://bugs.openjdk.java.net/browse/JDK-8236484 > https://bugs.openjdk.java.net/browse/JDK-8232811 > https://bugs.openjdk.java.net/browse/JDK-8225571 > > The reason for the delay is a problem accessing JBS from the Skara > bot. It should be sorted out soon. In the mean time, I've added a > label and a comment to each bug so we can track them, but I left them > open to see whether the Skara bot will catch back up once access is > restored (it should do). I'll do the same to any other bugs that are > resolved prior to fixing the issue. > > -- Kevin > From kcr at openjdk.java.net Mon Jan 6 21:57:15 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 21:57:15 GMT Subject: RFR: 8236648: javadoc warning on Text::tabSizeProperty method In-Reply-To: <8vO-u43ZDM6ru_aowjZntkXsVafe6BijW2fufIdidqU=.23a4a27f-589e-42fe-8e5e-51e630d9f468@github.com> References: <8vO-u43ZDM6ru_aowjZntkXsVafe6BijW2fufIdidqU=.23a4a27f-589e-42fe-8e5e-51e630d9f468@github.com> Message-ID: On Mon, 6 Jan 2020 19:27:01 GMT, Scott Palmer wrote: > Implemented suggested fix to address javadoc warning. Looks good. This is a low-impact change so one reviewer will suffice. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/78 From kcr at openjdk.java.net Mon Jan 6 22:41:15 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 22:41:15 GMT Subject: RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> <31X4pHGnuhexI5Rz9Y8afMrdFl0pfNPKp9nMYMNcG50=.1f068b3f-0901-43f3-a2d1-8a12aa18b040@github.com> Message-ID: On Mon, 6 Jan 2020 14:25:18 GMT, Kevin Rushforth wrote: >> There are still some sizing issues that I am aware of. > >> Please, mark it as WIP. > > You can do this by editing the title and adding `WIP: ` as a prefix. This sort of enhancement needs to be discussed on the openjfx-dev mailing list first. While the WIP PR might be used to illustrate what you have in mind to propose, it is premature to actually review the implementation without first discussing whether and it makes sense to do it, what the high-level goals are, etc. ------------- PR: https://git.openjdk.java.net/jfx/pull/77 From tsayao at openjdk.java.net Mon Jan 6 22:57:46 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Mon, 6 Jan 2020 22:57:46 GMT Subject: RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> <31X4pHGnuhexI5Rz9Y8afMrdFl0pfNPKp9nMYMNcG50=.1f068b3f-0901-43f3-a2d1-8a12aa18b040@github.com> Message-ID: On Mon, 6 Jan 2020 22:41:07 GMT, Kevin Rushforth wrote: >>> Please, mark it as WIP. >> >> You can do this by editing the title and adding `WIP: ` as a prefix. > > This sort of enhancement needs to be discussed on the openjfx-dev mailing list first. While the WIP PR might be used to illustrate what you have in mind to propose, it is premature to actually review the implementation without first discussing whether and it makes sense to do it, what the high-level goals are, etc. I understand. Will do that when everything is 100%. ------------- PR: https://git.openjdk.java.net/jfx/pull/77 From kcr at openjdk.java.net Mon Jan 6 23:05:26 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 23:05:26 GMT Subject: [Rev 01] RFR: 8236259: MemoryLeak in ProgressIndicator In-Reply-To: References: <4AOkSv1WjFvlW91fwfyuscb_BJpaAmzCZrYwAFMg_w8=.cb41dacd-8f6a-4ce3-bf6e-c9f3ed389232@github.com> <4ZgDMHtyYvvEyjNbrSqYtImrVggXwYRjOWtYm4giLVk=.ca2a5e57-5d0f-4508-ad03-41598f1f1be8@github.com> <46MzoLjJGQldWFkSMjgZLc4d9pCkAeI8gjQWAzqiSO0=.9424ff3f-e054-4842-a56b-7edfc1eb6761@github.com> Message-ID: On Fri, 20 Dec 2019 13:26:05 GMT, Kevin Rushforth wrote: >> I highly doubt that a code analysis tool will find such memoryleaks. > > I agree. Static analysis tools are quite limited in this regard, and are in now way a substitute for regression testing. > > So the question is how best to test fixes for memory leaks at runtime. Our current approach can be best characterized as "ad hoc", and is not all that robust (although works well enough in most cases and is still much better than doing no testing at all). I would welcome discussion of a more robust approach for testing, but it should be decoupled from this bug fix, and discussed as a separate JBS Enhancement request. The use of static analysis tools to catch certain types of problems is orthogonal to a regression test to validate a bug fix of a specific memory leak. @FlorianKirmaier as mentioned previously, please file a new JBS Enhancement to propose adding a test utility for memory leak test. You can then start a discussion on the openjfx-dev mailing list. As for fixing this memory leak, I recommend one of the following two approaches: 1. Modify the PR without relying on any new utilities (meaning you would create yet-another adhoc test for memory leaks). 2. Close this PR, wait for memory leak test utility to be integrated, and then resubmit the PR for this leak using that utility. Obviously, approach 1 would get the fix in faster. You could then modify the test to use the new utility as part of implementing the utility. ------------- PR: https://git.openjdk.java.net/jfx/pull/71 From almatvee at openjdk.java.net Mon Jan 6 23:21:45 2020 From: almatvee at openjdk.java.net (Alexander Matveev) Date: Mon, 6 Jan 2020 23:21:45 GMT Subject: RFR: 8232589: Remove CoreAudio Utility Classes In-Reply-To: References: Message-ID: On Wed, 1 Jan 2020 19:16:33 GMT, Johan Vos wrote: >> modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-good/gst/spectrum/gstspectrum.c line 915: >> >>> 914: bpf = GST_AUDIO_FILTER_BPF (spectrum); >>> 915: #ifdef OSX >>> 916: if (spectrum->bps_user != 0 && spectrum->bpf_user != 0) { >> >> Should this also be qualified with `GSTREAMER_LITE` since it represents changes specific to our port? > > true, as spectrum->bps_user has #if defined (GSTREAMER_LITE) && defined (OSX) around its definition. > > Even apart from that, it would make more sense and bring it at the same level as line 738 No need for GSTREAMER_LITE, since this code already inside #ifdef GSTREAMER_LITE. See line 885 and 925. ------------- PR: https://git.openjdk.java.net/jfx/pull/69 From kevin.rushforth at oracle.com Mon Jan 6 23:26:03 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 6 Jan 2020 15:26:03 -0800 Subject: Proposed schedule for JavaFX 14 In-Reply-To: <27fe44eb-610e-5204-8cb4-a3d98b3d6e8b@oracle.com> References: <536d8828-eb99-2aad-8e3b-d314f86c6b4a@oracle.com> <27fe44eb-610e-5204-8cb4-a3d98b3d6e8b@oracle.com> Message-ID: This is a final reminder that JavaFX 14 enters rampdown phase one (RDP1) on January 9, 2020 at 23:59 Pacific time. Any change integrated to the default 'master' branch after that will be for JavaFX 15. I will fork a new 'jfx14' stabilization branch early Friday morning (Pacific time). As with previous releases, P1-P3 bug fixes, and test or documentation fixes of any priority can still get into JavaFX 14 during RDP1. I'll send out more details Friday morning. -- Kevin On 12/16/2019 11:34 AM, Kevin Rushforth wrote: > The announced RDP1 date is the first Monday of the new year. In taking > a closer look at the upcoming holiday schedule and accounting for > additional days off some will be taking before or after, this doesn't > allow enough time for the final stages of the review process to > complete, including CSR approval. It is quite possible that an > enhancement with a mostly-completed review and a CSR that is Finalized > this Thursday or Friday (Dec 19 or 20), won't be approved in time for > integration. > > To address this, we are delaying RDP1 by three days. The new RDP1 date > is: > > Thursday, Jan 9, 23:59 PST > > The dates for RDP2, code freeze, and GA are unchanged. > > Please be aware that this three-day extension isn't an invitation to > try to get additional features into 14 at the last minute, but rather > an adjustment to better align with the holiday schedule in order to > give the already-in-flight features that are nearing completion a > little more time to make it. It is still the case that if an > enhancement isn't ready (meaning API discussed & approved, code review > mostly done, and CSR finalized) by this Friday, it should be > retargeted to JavaFX 15. > > -- Kevin > > > On 12/10/2019 1:45 PM, Kevin Rushforth wrote: >> As a reminder, RDP1 for JavaFX 14 starts on January 6, 2020 (at 23:59 >> Pacific time). >> >> With the holidays approaching, please allow sufficient time for any >> feature that needs a CSR. New features should be far enough along in >> the review process so you can finalize the CSR before next Friday, >> Dec 20, or it is likely to miss the window for this release, in which >> case it can be targeted for JavaFX 15. >> >> During rampdown of JavaFX 14, the "master" branch of the jfx repo >> will be open for JavaFX 15 fixes. >> >> We will follow the same process as previous releases for getting >> fixes into JavaFX 14 during rampdown. I'll send a message with >> detailed information later, but generally candidates for fixing after >> RDP1 are P1-P3 bugs (as long as they are not risky) and test or doc >> bugs of any priority. >> >> -- Kevin >> >> >> On 9/20/2019 8:00 AM, Kevin Rushforth wrote: >>> Here is the proposed schedule for JavaFX 14. >>> >>> RDP1: Jan 6, 2020 (aka ?feature freeze?) >>> RDP2: Feb 3, 2020 >>> Freeze: Feb 24, 2020 >>> GA: March 10, 2020 >>> >>> We plan to fork a jfx14 stabilization branch at RDP1. The GA date is >>> expected to be one week ahead of JDK 14, matching what we did for 13. >>> >>> Please let Johan or me know if you have any questions. >>> >>> -- Kevin >>> >> > From kcr at openjdk.java.net Mon Jan 6 23:28:30 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 23:28:30 GMT Subject: [Integrated] RFR: 8236648: javadoc warning on Text::tabSizeProperty method In-Reply-To: <8vO-u43ZDM6ru_aowjZntkXsVafe6BijW2fufIdidqU=.23a4a27f-589e-42fe-8e5e-51e630d9f468@github.com> References: <8vO-u43ZDM6ru_aowjZntkXsVafe6BijW2fufIdidqU=.23a4a27f-589e-42fe-8e5e-51e630d9f468@github.com> Message-ID: <584444c7-7e54-48ba-8a87-0a37972aad80@openjdk.org> Changeset: e0b45f8d Author: Scott Palmer Committer: Kevin Rushforth Date: 2020-01-06 23:27:43 +0000 URL: https://git.openjdk.java.net/jfx/commit/e0b45f8d 8236648: javadoc warning on Text::tabSizeProperty method Reviewed-by: kcr ! modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java From almatvee at openjdk.java.net Mon Jan 6 23:37:06 2020 From: almatvee at openjdk.java.net (Alexander Matveev) Date: Mon, 6 Jan 2020 23:37:06 GMT Subject: RFR: 8232589: Remove CoreAudio Utility Classes In-Reply-To: References: Message-ID: On Fri, 20 Dec 2019 22:24:36 GMT, Kevin Rushforth wrote: >> https://bugs.openjdk.java.net/browse/JDK-8232589 >> >> - Removed CoreAudio Utility classes. >> - Spectrum which was depended on CoreAudio Utility classes for doing computations will now run GStreamer spectrum element to do spectrum. Element will be run without pipeline and will be used as utility library to do spectrum calculation. I added extra APIs to bypass proper element initialization. >> - Equalizer and audio unit (volume and balance) where modified, so we can run then directly without CoreAudio pipeline. > > modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp line 422: > >> 421: mEQBufferA = (double*)calloc(mEQBufferSize, sizeof(double)); >> 422: mEQBufferB = (double*)calloc(mEQBufferSize, sizeof(double)); >> 423: } > > This is allocating 8 times (i.e., `sizeof(double)`) as much memory as before. I presume this is intentional? No, it is allocating same amount of memory as before, unless I am missing something. We used to have CAAutoFree mEQBufferA and CAAutoFree.alloc(size_t numItems) method allocates (numItems * sizeof(T)) bytes. See deleted CAAutoDisposer.h for CAAutoFree class implementation. ------------- PR: https://git.openjdk.java.net/jfx/pull/69 From kcr at openjdk.java.net Mon Jan 6 23:50:45 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 23:50:45 GMT Subject: RFR: 8232589: Remove CoreAudio Utility Classes In-Reply-To: References: Message-ID: On Mon, 6 Jan 2020 23:21:32 GMT, Alexander Matveev wrote: >> true, as spectrum->bps_user has #if defined (GSTREAMER_LITE) && defined (OSX) around its definition. >> >> Even apart from that, it would make more sense and bring it at the same level as line 738 > > No need for GSTREAMER_LITE, since this code already inside #ifdef GSTREAMER_LITE. See line 885 and 925. Yes, I see. ------------- PR: https://git.openjdk.java.net/jfx/pull/69 From kcr at openjdk.java.net Mon Jan 6 23:50:46 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 23:50:46 GMT Subject: RFR: 8232589: Remove CoreAudio Utility Classes In-Reply-To: References: Message-ID: On Mon, 6 Jan 2020 23:36:50 GMT, Alexander Matveev wrote: >> modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp line 422: >> >>> 421: mEQBufferA = (double*)calloc(mEQBufferSize, sizeof(double)); >>> 422: mEQBufferB = (double*)calloc(mEQBufferSize, sizeof(double)); >>> 423: } >> >> This is allocating 8 times (i.e., `sizeof(double)`) as much memory as before. I presume this is intentional? > > No, it is allocating same amount of memory as before, unless I am missing something. > We used to have CAAutoFree mEQBufferA and > CAAutoFree.alloc(size_t numItems) method allocates (numItems * sizeof(T)) bytes. See deleted CAAutoDisposer.h for CAAutoFree class implementation. Yes, you're right. I missed that the previous `alloc` call was a method call on a CAAutoFree object, which does exactly what you said above. The new code is equivalent. ------------- PR: https://git.openjdk.java.net/jfx/pull/69 From kcr at openjdk.java.net Mon Jan 6 23:53:55 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 6 Jan 2020 23:53:55 GMT Subject: RFR: 8232589: Remove CoreAudio Utility Classes In-Reply-To: References: Message-ID: On Wed, 18 Dec 2019 01:04:42 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8232589 > > - Removed CoreAudio Utility classes. > - Spectrum which was depended on CoreAudio Utility classes for doing computations will now run GStreamer spectrum element to do spectrum. Element will be run without pipeline and will be used as utility library to do spectrum calculation. I added extra APIs to bypass proper element initialization. > - Equalizer and audio unit (volume and balance) where modified, so we can run then directly without CoreAudio pipeline. This looks good to me. As a reminder, it will need a second review from @johanvos . ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/69 From tsayao at openjdk.java.net Tue Jan 7 00:50:24 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Tue, 7 Jan 2020 00:50:24 GMT Subject: [Rev 04] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - cc7745b4: Pass more tests Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/49426b66..cc7745b4 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.04 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.03-04 Stats: 57 lines in 2 files changed: 11 ins; 30 del; 16 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From tsayao at openjdk.java.net Tue Jan 7 02:01:48 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Tue, 7 Jan 2020 02:01:48 GMT Subject: [Rev 05] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: <7t1I8SSqM4GhwdVIzECjTm6SUyG26PtqUeO7S5HaRQE=.21b3a6de-34b7-45e3-9775-f69dca60d2ae@github.com> > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - e4d2a1d2: Small fixes Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/cc7745b4..e4d2a1d2 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.05 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.04-05 Stats: 67 lines in 5 files changed: 31 ins; 8 del; 28 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From jvos at openjdk.java.net Tue Jan 7 07:55:14 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Tue, 7 Jan 2020 07:55:14 GMT Subject: RFR: 8232589: Remove CoreAudio Utility Classes In-Reply-To: References: Message-ID: On Wed, 18 Dec 2019 01:04:42 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8232589 > > - Removed CoreAudio Utility classes. > - Spectrum which was depended on CoreAudio Utility classes for doing computations will now run GStreamer spectrum element to do spectrum. Element will be run without pipeline and will be used as utility library to do spectrum calculation. I added extra APIs to bypass proper element initialization. > - Equalizer and audio unit (volume and balance) where modified, so we can run then directly without CoreAudio pipeline. The changes look ok to me, and the build + tests are nominal. Since there are new calculations being used now, I am slightly concerned about performance regression, but this is very hard to measure, so I suggest we build an EA release once the PR is merged. ------------- Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/69 From arapte at openjdk.java.net Tue Jan 7 09:47:16 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Tue, 7 Jan 2020 09:47:16 GMT Subject: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one Message-ID: This PR is a fix for [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) This issue is regression of [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). Issue. - `Parent.viewOrderChildren` is a list of children sorted according to view order. - `Parent.viewOrderChildren` is cleared and computed in `Parent.computeViewOrderChildren()` which is called from `Parent.doUpdatePeer()` when a `pulse `is received. - Below is the scenario mentioned in this issue, 1. `TabPane` is created with few `tabs`. 2. For each tab, a `TabHeaderSkin` is created with `setViewOrder(1)` and is added to `TabHeaderArea.headersRegion` 3. All these `TabHeaderSkin`s are added to `Parent.viewOrderChildren` on `pulse`. 4. When the `TabPane` is removed from scene, then on the next pulse the method `Parent.doUpdatePeer()` does not get called for `TabHeaderArea.headersRegion`, because it is not part for scenegraph anymore. So `Parent.computeViewOrderChildren()` does not get called and the `Parent.viewOrderChildren` does not get cleared, which causes the leak. Fix: Clear the `Parent.viewOrderChildren` list when marking `DirtyBits.PARENT_CHILDREN_VIEW_ORDER` as dirty. `Parent.viewOrderChildren` will be computed on next `pulse`. This will maintain lazy computation of `Parent.viewOrderChildren`. Added a system test, fails without fix and passes with. No failures in existing tests. ------------- Commits: - cbcc3161: [WIP] 8232824: Removing TabPane with strong referenced content causes memory leak from weak one Changes: https://git.openjdk.java.net/jfx/pull/79/files Webrev: https://webrevs.openjdk.java.net/jfx/79/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8232824 Stats: 120 lines in 2 files changed: 118 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/79.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/79/head:pull/79 PR: https://git.openjdk.java.net/jfx/pull/79 From jvos at openjdk.java.net Tue Jan 7 12:50:24 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Tue, 7 Jan 2020 12:50:24 GMT Subject: [Rev 01] RFR: 8236448: Remove unused and repair broken Android/Dalvik code In-Reply-To: References: Message-ID: > This allows to build the JavaFX jars and native libraries for Android devices The pull request has been updated with 1 additional commit. ------------- Added commits: - f8321fd0: copy (android) resources into directory where they are picked up by the jar task Changes: - all: https://git.openjdk.java.net/jfx/pull/75/files - new: https://git.openjdk.java.net/jfx/pull/75/files/504a2440..f8321fd0 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/75/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/75/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/75.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/75/head:pull/75 PR: https://git.openjdk.java.net/jfx/pull/75 From jvos at openjdk.java.net Tue Jan 7 13:32:54 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Tue, 7 Jan 2020 13:32:54 GMT Subject: [Rev 02] RFR: 8236448: Remove unused and repair broken Android/Dalvik code In-Reply-To: References: Message-ID: > This allows to build the JavaFX jars and native libraries for Android devices The pull request has been updated with 1 additional commit. ------------- Added commits: - 13699670: process reviewer comments Changes: - all: https://git.openjdk.java.net/jfx/pull/75/files - new: https://git.openjdk.java.net/jfx/pull/75/files/f8321fd0..13699670 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/75/webrev.02 - incr: https://webrevs.openjdk.java.net/jfx/75/webrev.01-02 Stats: 4 lines in 4 files changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/75.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/75/head:pull/75 PR: https://git.openjdk.java.net/jfx/pull/75 From thevenet.fred at free.fr Tue Jan 7 13:51:13 2020 From: thevenet.fred at free.fr (thevenet.fred at free.fr) Date: Tue, 7 Jan 2020 14:51:13 +0100 (CET) Subject: Proposed schedule for JavaFX 14 In-Reply-To: References: <536d8828-eb99-2aad-8e3b-d314f86c6b4a@oracle.com> <27fe44eb-610e-5204-8cb4-a3d98b3d6e8b@oracle.com> Message-ID: <1791939899.154506977.1578405073214.JavaMail.zimbra@free.fr> Hi Kevin, I am wondering about the likelihood for the fix to JDK-8088198 that I proposed in PR #68 (https://github.com/openjdk/jfx/pull/68) to make it into JavaFX 14. I think it is unlikely to be integrated into master by Thursday since it has yet to be fully reviewed, but since it is marked as a P3 bug, I understand that it could still be integrated during RDP1(provided it works as expected, of course); am I correct? In the event it doesn't make it on time for 14, would it qualify to be backported for inclusion in an intermediate release like 14.0.1, or would it have to wait for JavaFX 15? Thanks, Frederic. ----- Mail original ----- De: "Kevin Rushforth" ?: "openjfx-dev" Envoy?: Mardi 7 Janvier 2020 00:26:03 Objet: Re: Proposed schedule for JavaFX 14 This is a final reminder that JavaFX 14 enters rampdown phase one (RDP1) on January 9, 2020 at 23:59 Pacific time. Any change integrated to the default 'master' branch after that will be for JavaFX 15. I will fork a new 'jfx14' stabilization branch early Friday morning (Pacific time). As with previous releases, P1-P3 bug fixes, and test or documentation fixes of any priority can still get into JavaFX 14 during RDP1. I'll send out more details Friday morning. -- Kevin On 12/16/2019 11:34 AM, Kevin Rushforth wrote: > The announced RDP1 date is the first Monday of the new year. In taking > a closer look at the upcoming holiday schedule and accounting for > additional days off some will be taking before or after, this doesn't > allow enough time for the final stages of the review process to > complete, including CSR approval. It is quite possible that an > enhancement with a mostly-completed review and a CSR that is Finalized > this Thursday or Friday (Dec 19 or 20), won't be approved in time for > integration. > > To address this, we are delaying RDP1 by three days. The new RDP1 date > is: > > Thursday, Jan 9, 23:59 PST > > The dates for RDP2, code freeze, and GA are unchanged. > > Please be aware that this three-day extension isn't an invitation to > try to get additional features into 14 at the last minute, but rather > an adjustment to better align with the holiday schedule in order to > give the already-in-flight features that are nearing completion a > little more time to make it. It is still the case that if an > enhancement isn't ready (meaning API discussed & approved, code review > mostly done, and CSR finalized) by this Friday, it should be > retargeted to JavaFX 15. > > -- Kevin > > > On 12/10/2019 1:45 PM, Kevin Rushforth wrote: >> As a reminder, RDP1 for JavaFX 14 starts on January 6, 2020 (at 23:59 >> Pacific time). >> >> With the holidays approaching, please allow sufficient time for any >> feature that needs a CSR. New features should be far enough along in >> the review process so you can finalize the CSR before next Friday, >> Dec 20, or it is likely to miss the window for this release, in which >> case it can be targeted for JavaFX 15. >> >> During rampdown of JavaFX 14, the "master" branch of the jfx repo >> will be open for JavaFX 15 fixes. >> >> We will follow the same process as previous releases for getting >> fixes into JavaFX 14 during rampdown. I'll send a message with >> detailed information later, but generally candidates for fixing after >> RDP1 are P1-P3 bugs (as long as they are not risky) and test or doc >> bugs of any priority. >> >> -- Kevin >> >> >> On 9/20/2019 8:00 AM, Kevin Rushforth wrote: >>> Here is the proposed schedule for JavaFX 14. >>> >>> RDP1: Jan 6, 2020 (aka ?feature freeze?) >>> RDP2: Feb 3, 2020 >>> Freeze: Feb 24, 2020 >>> GA: March 10, 2020 >>> >>> We plan to fork a jfx14 stabilization branch at RDP1. The GA date is >>> expected to be one week ahead of JDK 14, matching what we did for 13. >>> >>> Please let Johan or me know if you have any questions. >>> >>> -- Kevin >>> >> > From thiago.sayao at clamed.com.br Tue Jan 7 14:18:39 2020 From: thiago.sayao at clamed.com.br (Thiago Milczarek Sayao) Date: Tue, 7 Jan 2020 14:18:39 +0000 Subject: How to reproduce a Window with native background? Message-ID: >From Window.java internal API: /** * Set the background of the window. * * In most cases the View covers the whole window, so the background color * of the window is never seen by the user. However, a window w/o a view * does display the background color in its content area. * * On some platforms setting the background color may produce flickering * when painting the content area of the View (even though the View covers * the whole window). Therefore it is recommended to set the background * color to windows w/o views only. */ public boolean setBackground(final float r, final float g, final float b) { Application.checkEventThread(); checkNotClosed(); return _setBackground(this.ptr, r, g, b); } How to reproduce this scenario? Create a window where this brackground is shown? Thanks. From kevin.rushforth at oracle.com Tue Jan 7 14:54:41 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 7 Jan 2020 06:54:41 -0800 Subject: Proposed schedule for JavaFX 14 In-Reply-To: <1791939899.154506977.1578405073214.JavaMail.zimbra@free.fr> References: <536d8828-eb99-2aad-8e3b-d314f86c6b4a@oracle.com> <27fe44eb-610e-5204-8cb4-a3d98b3d6e8b@oracle.com> <1791939899.154506977.1578405073214.JavaMail.zimbra@free.fr> Message-ID: Hi Frederic, P3 bug fixes can go in during RDP1 if they are safe enough fixes. The RDP2 deadline is Feb 3, so there is still time. Any bug that misses 14 and is ready for integration into mainline will go into 15. A case can be made for pulling in a very limited number of safe fixes from 15 into a 14.0.x release, but I wouldn't expect that in this case. If the fix is safe enough to get into 14, it will likely make it. If not, then it isn't a good candidate for 14.0.1 anyway. -- Kevin On 1/7/2020 5:51 AM, thevenet.fred at free.fr wrote: > Hi Kevin, > > I am wondering about the likelihood for the fix to JDK-8088198 that I > proposed in PR #68 (https://github.com/openjdk/jfx/pull/68) to make it into > JavaFX 14. > I think it is unlikely to be integrated into master by Thursday since it > has yet to be fully reviewed, but since it is marked as a P3 bug, I understand > that it could still be integrated during RDP1(provided it works as expected, > of course); am I correct? > In the event it doesn't make it on time for 14, would it qualify to be > backported for inclusion in an intermediate release like 14.0.1, or would > it have to wait for JavaFX 15? > > Thanks, > Frederic. > > ----- Mail original ----- > De: "Kevin Rushforth" > ?: "openjfx-dev" > Envoy?: Mardi 7 Janvier 2020 00:26:03 > Objet: Re: Proposed schedule for JavaFX 14 > > This is a final reminder that JavaFX 14 enters rampdown phase one (RDP1) > on January 9, 2020 at 23:59 Pacific time. > > Any change integrated to the default 'master' branch after that will be > for JavaFX 15. I will fork a new 'jfx14' stabilization branch early > Friday morning (Pacific time). As with previous releases, P1-P3 bug > fixes, and test or documentation fixes of any priority can still get > into JavaFX 14 during RDP1. I'll send out more details Friday morning. > > -- Kevin > > > On 12/16/2019 11:34 AM, Kevin Rushforth wrote: >> The announced RDP1 date is the first Monday of the new year. In taking >> a closer look at the upcoming holiday schedule and accounting for >> additional days off some will be taking before or after, this doesn't >> allow enough time for the final stages of the review process to >> complete, including CSR approval. It is quite possible that an >> enhancement with a mostly-completed review and a CSR that is Finalized >> this Thursday or Friday (Dec 19 or 20), won't be approved in time for >> integration. >> >> To address this, we are delaying RDP1 by three days. The new RDP1 date >> is: >> >> Thursday, Jan 9, 23:59 PST >> >> The dates for RDP2, code freeze, and GA are unchanged. >> >> Please be aware that this three-day extension isn't an invitation to >> try to get additional features into 14 at the last minute, but rather >> an adjustment to better align with the holiday schedule in order to >> give the already-in-flight features that are nearing completion a >> little more time to make it. It is still the case that if an >> enhancement isn't ready (meaning API discussed & approved, code review >> mostly done, and CSR finalized) by this Friday, it should be >> retargeted to JavaFX 15. >> >> -- Kevin >> >> >> On 12/10/2019 1:45 PM, Kevin Rushforth wrote: >>> As a reminder, RDP1 for JavaFX 14 starts on January 6, 2020 (at 23:59 >>> Pacific time). >>> >>> With the holidays approaching, please allow sufficient time for any >>> feature that needs a CSR. New features should be far enough along in >>> the review process so you can finalize the CSR before next Friday, >>> Dec 20, or it is likely to miss the window for this release, in which >>> case it can be targeted for JavaFX 15. >>> >>> During rampdown of JavaFX 14, the "master" branch of the jfx repo >>> will be open for JavaFX 15 fixes. >>> >>> We will follow the same process as previous releases for getting >>> fixes into JavaFX 14 during rampdown. I'll send a message with >>> detailed information later, but generally candidates for fixing after >>> RDP1 are P1-P3 bugs (as long as they are not risky) and test or doc >>> bugs of any priority. >>> >>> -- Kevin >>> >>> >>> On 9/20/2019 8:00 AM, Kevin Rushforth wrote: >>>> Here is the proposed schedule for JavaFX 14. >>>> >>>> RDP1: Jan 6, 2020 (aka ?feature freeze?) >>>> RDP2: Feb 3, 2020 >>>> Freeze: Feb 24, 2020 >>>> GA: March 10, 2020 >>>> >>>> We plan to fork a jfx14 stabilization branch at RDP1. The GA date is >>>> expected to be one week ahead of JDK 14, matching what we did for 13. >>>> >>>> Please let Johan or me know if you have any questions. >>>> >>>> -- Kevin >>>> From thevenet.fred at free.fr Tue Jan 7 15:18:00 2020 From: thevenet.fred at free.fr (thevenet.fred at free.fr) Date: Tue, 7 Jan 2020 16:18:00 +0100 (CET) Subject: Proposed schedule for JavaFX 14 In-Reply-To: References: <536d8828-eb99-2aad-8e3b-d314f86c6b4a@oracle.com> <27fe44eb-610e-5204-8cb4-a3d98b3d6e8b@oracle.com> <1791939899.154506977.1578405073214.JavaMail.zimbra@free.fr> Message-ID: <831632753.155087784.1578410280380.JavaMail.zimbra@free.fr> Ok, it is quite clear to me now. Thanks for the clarifications. Regards, Frederic. ----- Mail original ----- De: "Kevin Rushforth" ?: "thevenet fred" Cc: "openjfx-dev" Envoy?: Mardi 7 Janvier 2020 15:54:41 Objet: Re: Proposed schedule for JavaFX 14 Hi Frederic, P3 bug fixes can go in during RDP1 if they are safe enough fixes. The RDP2 deadline is Feb 3, so there is still time. Any bug that misses 14 and is ready for integration into mainline will go into 15. A case can be made for pulling in a very limited number of safe fixes from 15 into a 14.0.x release, but I wouldn't expect that in this case. If the fix is safe enough to get into 14, it will likely make it. If not, then it isn't a good candidate for 14.0.1 anyway. -- Kevin On 1/7/2020 5:51 AM, thevenet.fred at free.fr wrote: > Hi Kevin, > > I am wondering about the likelihood for the fix to JDK-8088198 that I > proposed in PR #68 (https://github.com/openjdk/jfx/pull/68) to make it into > JavaFX 14. > I think it is unlikely to be integrated into master by Thursday since it > has yet to be fully reviewed, but since it is marked as a P3 bug, I understand > that it could still be integrated during RDP1(provided it works as expected, > of course); am I correct? > In the event it doesn't make it on time for 14, would it qualify to be > backported for inclusion in an intermediate release like 14.0.1, or would > it have to wait for JavaFX 15? > > Thanks, > Frederic. > > ----- Mail original ----- > De: "Kevin Rushforth" > ?: "openjfx-dev" > Envoy?: Mardi 7 Janvier 2020 00:26:03 > Objet: Re: Proposed schedule for JavaFX 14 > > This is a final reminder that JavaFX 14 enters rampdown phase one (RDP1) > on January 9, 2020 at 23:59 Pacific time. > > Any change integrated to the default 'master' branch after that will be > for JavaFX 15. I will fork a new 'jfx14' stabilization branch early > Friday morning (Pacific time). As with previous releases, P1-P3 bug > fixes, and test or documentation fixes of any priority can still get > into JavaFX 14 during RDP1. I'll send out more details Friday morning. > > -- Kevin > > > On 12/16/2019 11:34 AM, Kevin Rushforth wrote: >> The announced RDP1 date is the first Monday of the new year. In taking >> a closer look at the upcoming holiday schedule and accounting for >> additional days off some will be taking before or after, this doesn't >> allow enough time for the final stages of the review process to >> complete, including CSR approval. It is quite possible that an >> enhancement with a mostly-completed review and a CSR that is Finalized >> this Thursday or Friday (Dec 19 or 20), won't be approved in time for >> integration. >> >> To address this, we are delaying RDP1 by three days. The new RDP1 date >> is: >> >> Thursday, Jan 9, 23:59 PST >> >> The dates for RDP2, code freeze, and GA are unchanged. >> >> Please be aware that this three-day extension isn't an invitation to >> try to get additional features into 14 at the last minute, but rather >> an adjustment to better align with the holiday schedule in order to >> give the already-in-flight features that are nearing completion a >> little more time to make it. It is still the case that if an >> enhancement isn't ready (meaning API discussed & approved, code review >> mostly done, and CSR finalized) by this Friday, it should be >> retargeted to JavaFX 15. >> >> -- Kevin >> >> >> On 12/10/2019 1:45 PM, Kevin Rushforth wrote: >>> As a reminder, RDP1 for JavaFX 14 starts on January 6, 2020 (at 23:59 >>> Pacific time). >>> >>> With the holidays approaching, please allow sufficient time for any >>> feature that needs a CSR. New features should be far enough along in >>> the review process so you can finalize the CSR before next Friday, >>> Dec 20, or it is likely to miss the window for this release, in which >>> case it can be targeted for JavaFX 15. >>> >>> During rampdown of JavaFX 14, the "master" branch of the jfx repo >>> will be open for JavaFX 15 fixes. >>> >>> We will follow the same process as previous releases for getting >>> fixes into JavaFX 14 during rampdown. I'll send a message with >>> detailed information later, but generally candidates for fixing after >>> RDP1 are P1-P3 bugs (as long as they are not risky) and test or doc >>> bugs of any priority. >>> >>> -- Kevin >>> >>> >>> On 9/20/2019 8:00 AM, Kevin Rushforth wrote: >>>> Here is the proposed schedule for JavaFX 14. >>>> >>>> RDP1: Jan 6, 2020 (aka ?feature freeze?) >>>> RDP2: Feb 3, 2020 >>>> Freeze: Feb 24, 2020 >>>> GA: March 10, 2020 >>>> >>>> We plan to fork a jfx14 stabilization branch at RDP1. The GA date is >>>> expected to be one week ahead of JDK 14, matching what we did for 13. >>>> >>>> Please let Johan or me know if you have any questions. >>>> >>>> -- Kevin >>>> From kcr at openjdk.java.net Tue Jan 7 20:38:39 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 7 Jan 2020 20:38:39 GMT Subject: RFR: 8233798: Ctrl-L character mistakenly removed from gstreamer.md Message-ID: <-4zo1JgA2cPujrabhW7drUAl1XxwcOpamiMIWruyObY=.044324c7-b716-47bf-a9d8-ae60c63aa3c8@github.com> Fix for [JDK-8233798](https://bugs.openjdk.java.net/browse/JDK-8233798) Simple fix to restore a Ctrl-L character that was mistakenly deleted as part of the cleanup fix done for [JDK-8222746](https://bugs.openjdk.java.net/browse/JDK-8222746). After the missing ^L is restored the license is once again identical between `gstreamer.md` and `glib.md` (and `webkit.md`) as it should be. ------------- Commits: - d09255bc: 8233798: Ctrl-L character mistakenly removed from gstreamer.md Changes: https://git.openjdk.java.net/jfx/pull/80/files Webrev: https://webrevs.openjdk.java.net/jfx/80/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8233798 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/80.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/80/head:pull/80 PR: https://git.openjdk.java.net/jfx/pull/80 From kcr at openjdk.java.net Tue Jan 7 20:38:59 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 7 Jan 2020 20:38:59 GMT Subject: RFR: 8233798: Ctrl-L character mistakenly removed from gstreamer.md In-Reply-To: <-4zo1JgA2cPujrabhW7drUAl1XxwcOpamiMIWruyObY=.044324c7-b716-47bf-a9d8-ae60c63aa3c8@github.com> References: <-4zo1JgA2cPujrabhW7drUAl1XxwcOpamiMIWruyObY=.044324c7-b716-47bf-a9d8-ae60c63aa3c8@github.com> Message-ID: On Tue, 7 Jan 2020 20:37:44 GMT, Kevin Rushforth wrote: > Fix for [JDK-8233798](https://bugs.openjdk.java.net/browse/JDK-8233798) > > Simple fix to restore a Ctrl-L character that was mistakenly deleted as part of the cleanup fix done for [JDK-8222746](https://bugs.openjdk.java.net/browse/JDK-8222746). After the missing ^L is restored the license is once again identical between `gstreamer.md` and `glib.md` (and `webkit.md`) as it should be. @sashamatveev can you review this? ------------- PR: https://git.openjdk.java.net/jfx/pull/80 From almatvee at openjdk.java.net Tue Jan 7 21:12:25 2020 From: almatvee at openjdk.java.net (Alexander Matveev) Date: Tue, 7 Jan 2020 21:12:25 GMT Subject: RFR: 8233798: Ctrl-L character mistakenly removed from gstreamer.md In-Reply-To: <-4zo1JgA2cPujrabhW7drUAl1XxwcOpamiMIWruyObY=.044324c7-b716-47bf-a9d8-ae60c63aa3c8@github.com> References: <-4zo1JgA2cPujrabhW7drUAl1XxwcOpamiMIWruyObY=.044324c7-b716-47bf-a9d8-ae60c63aa3c8@github.com> Message-ID: On Tue, 7 Jan 2020 20:37:44 GMT, Kevin Rushforth wrote: > Fix for [JDK-8233798](https://bugs.openjdk.java.net/browse/JDK-8233798) > > Simple fix to restore a Ctrl-L character that was mistakenly deleted as part of the cleanup fix done for [JDK-8222746](https://bugs.openjdk.java.net/browse/JDK-8222746). After the missing ^L is restored the license is once again identical between `gstreamer.md` and `glib.md` (and `webkit.md`) as it should be. Looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/80 From kcr at openjdk.java.net Tue Jan 7 21:20:12 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 7 Jan 2020 21:20:12 GMT Subject: [Integrated] RFR: 8233798: Ctrl-L character mistakenly removed from gstreamer.md In-Reply-To: <-4zo1JgA2cPujrabhW7drUAl1XxwcOpamiMIWruyObY=.044324c7-b716-47bf-a9d8-ae60c63aa3c8@github.com> References: <-4zo1JgA2cPujrabhW7drUAl1XxwcOpamiMIWruyObY=.044324c7-b716-47bf-a9d8-ae60c63aa3c8@github.com> Message-ID: <623e900f-6f7b-489d-aad7-5478b2e4cb35@openjdk.org> Changeset: df8b3c50 Author: Kevin Rushforth Date: 2020-01-07 21:19:25 +0000 URL: https://git.openjdk.java.net/jfx/commit/df8b3c50 8233798: Ctrl-L character mistakenly removed from gstreamer.md Reviewed-by: almatvee ! modules/javafx.media/src/main/legal/gstreamer.md From almatvee at openjdk.java.net Tue Jan 7 22:15:13 2020 From: almatvee at openjdk.java.net (Alexander Matveev) Date: Tue, 7 Jan 2020 22:15:13 GMT Subject: [Integrated] RFR: 8232589: Remove CoreAudio Utility Classes In-Reply-To: References: Message-ID: <327da043-8014-4199-88d0-3a5c12bb4fac@openjdk.org> Changeset: c9519b6e Author: Alexander Matveev Date: 2020-01-07 22:14:22 +0000 URL: https://git.openjdk.java.net/jfx/commit/c9519b6e 8232589: Remove CoreAudio Utility Classes Reviewed-by: kcr, jvos ! modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-good/gst/spectrum/gstspectrum.c ! modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gst-plugins-good/gst/spectrum/gstspectrum.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/AUBase.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/AUBase.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/AUInputElement.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/AUInputElement.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/AUOutputElement.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/AUOutputElement.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/AUPlugInDispatch.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/AUPlugInDispatch.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/AUScopeElement.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/AUScopeElement.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/ComponentBase.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/AUBase/ComponentBase.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/OtherBases/AUEffectBase.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/OtherBases/AUEffectBase.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/Utility/AUBaseHelper.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/Utility/AUBaseHelper.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/Utility/AUBuffer.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/Utility/AUBuffer.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/AudioUnits/AUPublic/Utility/AUSilentTimeout.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAAtomic.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAAtomicStack.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAAudioChannelLayout.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAAudioChannelLayout.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAAutoDisposer.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CABitOperations.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CADebugMacros.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CADebugMacros.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CADebugPrintf.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CADebugPrintf.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CADebugger.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CADebugger.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAException.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAHostTimeBase.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAHostTimeBase.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CALogMacros.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAMath.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAMutex.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAMutex.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAReferenceCounted.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CASpectralProcessor.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CASpectralProcessor.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAStreamBasicDescription.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAStreamBasicDescription.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAThreadSafeList.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAVectorUnit.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAVectorUnit.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAVectorUnitTypes.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAXException.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/CoreAudio/PublicUtility/CAXException.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/LICENSE.txt - modules/javafx.media/src/main/native/jfxmedia/platform/osx/CoreAudioUtilityClasses/ReadMe.txt ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.h ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.h ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.mm ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.cpp ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.h - modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFKernelProcessor.cpp - modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFKernelProcessor.h ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFSoundLevelUnit.cpp ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFSoundLevelUnit.h ! modules/javafx.media/src/main/native/jfxmedia/projects/mac/Makefile From kcr at openjdk.java.net Tue Jan 7 22:59:26 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 7 Jan 2020 22:59:26 GMT Subject: [Rev 02] RFR: 8236448: Remove unused and repair broken Android/Dalvik code In-Reply-To: References: Message-ID: On Tue, 7 Jan 2020 22:59:25 GMT, Johan Vos wrote: >> This allows to build the JavaFX jars and native libraries for Android devices > > The pull request has been updated with 1 additional commit. Looks good. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/75 From kevin.rushforth at oracle.com Tue Jan 7 23:06:34 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 7 Jan 2020 15:06:34 -0800 Subject: Maximized undecorated stage In-Reply-To: References: Message-ID: <81781b6e-63c9-7fed-da3e-690afd0fe97d@oracle.com> Ideally, we wouldn't have this sort of platform-specific behavior. I can see why the underlying platform might not support the concept of maximizing an undecorated stage, so we either need to disable it on Windows, live with the behavior, or else find some solution on macOS and Linux. -- Kevin On 1/6/2020 1:43 AM, Abhinay Agarwal wrote: > Hi, > > If maximize property is set to true for an undecorated Stage, the following behaviour is observed on different platforms: > > * Windows: Undecorated stage is maximized > * MacOS: Undecorated stage is not maximized > * Linux(Ubuntu): Undecorated stage is not maximized > > The following piece of code can be used to reproduce the behaviour: > > import javafx.application.Application; > import javafx.scene.Scene; > import javafx.scene.control.Label; > import javafx.scene.layout.StackPane; > import javafx.stage.Stage; > import javafx.stage.StageStyle; > > public class MaximizedStage extends Application { > public void start (Stage stage) { > StackPane sp = new StackPane(new Label("Hello")); > stage.setScene(new Scene (sp, 500, 500)); > stage.initStyle(StageStyle.UNDECORATED); > stage.show(); > stage.setMaximized(true); > } > } > > Is there a reason why the stage gets maximized on Windows but fails on other platforms? > > Regards, > Abhinay From kevin.rushforth at oracle.com Tue Jan 7 23:13:32 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 7 Jan 2020 15:13:32 -0800 Subject: Rate of embedded animations In-Reply-To: References: Message-ID: A rate in a "parent" transition should probably override the rate in a child Animation. There are a couple ways to do it, and it sounds like it doesn't really implement it right. 1. The public rate property values of child Animations within a parent Transition are ignored, but not updated. As long as the implementation is consistent in ignoring the rate property from the child Animation, this seems like a fine solution and is consistent with other properties where one property overrides another without modifying it. 2. Setting a rate on the parent Transition actually modifies the child node. This can work, but has more issues. What happens if you set the rate of the parent tansition and then set the rate of a child animation? What if you bind to the rate of a child animation? -- Kevin On 1/1/2020 1:04 PM, Nir Lisker wrote: > Hi, > > As part of my work in the animations package I've come across an undefined > spec. Is the rate of an animation that is embedded in a Parallel/Sequential > transition inherited and overridden by its parent? > > If I have an animations with a rate of 1 and a parent with a rate of 2, and > I add the animation to the parent, does the rate property change from 1 to > 2 (generating a change/invalidation event etc.)? Then, should any > subsequent changes to the parent's rate trigger a change in the child's > rate? > > The implementation is a bit messy in this regard. The rate and currentRate > values exist in both Animation and its ClipEnvelope, which is the source > for a couple of bugs. For example, changing the rate of a > ParallelTransition changes the child's ClipEnvelope's rate and currentRate, > but only the animation's currentRate (and not rate). Is it supposed to be > this way? > > What is clear is that it's not possible to change the rate of the embedded > animation directly. > > The docs do not talk about the rate of an embedded animation (they do talk > about the node property though). > > - Nir From ebresiedev at gmail.com Wed Jan 8 06:54:22 2020 From: ebresiedev at gmail.com (Eric Bresie) Date: Wed, 8 Jan 2020 00:54:22 -0600 Subject: Proposed schedule for JavaFX 14 In-Reply-To: 831632753.155087784.1578410280380.JavaMail.zimbra@free.fr References: cc85e35a-28c0-5f8a-521e-5cb447da4399@oracle.com 536d8828-eb99-2aad-8e3b-d314f86c6b4a@oracle.com 27fe44eb-610e-5204-8cb4-a3d98b3d6e8b@oracle.com c438a7f3-14bf-a545-f91f-4e4fbd2d159a@oracle.com 1791939899.154506977.1578405073214.JavaMail.zimbra@free.fr e6a947ba-63a5-317a-d8f3-6bd41966fca9@oracle.com e6a947ba-63a5-317a-d8f3-6bd41966fca9@oracle.com Message-ID: <74a479b0-f32f-43ef-a72b-a82f41fa537a@Erics-iPhone-X> Out of curiosity...are there any labels, milestones, targets or any such type added in github and/or bug systema for changes going in? Or is there a PR of some type with all relevant changes expected? Eric Bresie Ebresie at gmail.com > On January 7, 2020 at 9:18:00 AM CST, thevenet.fred at free.fr wrote: > Ok, it is quite clear to me now. > Thanks for the clarifications. > > Regards, > Frederic. > > ----- Mail original ----- > De: "Kevin Rushforth" > ?: "thevenet fred" > Cc: "openjfx-dev" > Envoy?: Mardi 7 Janvier 2020 15:54:41 > Objet: Re: Proposed schedule for JavaFX 14 > > Hi Frederic, > > P3 bug fixes can go in during RDP1 if they are safe enough fixes. The > RDP2 deadline is Feb 3, so there is still time. Any bug that misses 14 > and is ready for integration into mainline will go into 15. A case can > be made for pulling in a very limited number of safe fixes from 15 into > a 14.0.x release, but I wouldn't expect that in this case. If the fix is > safe enough to get into 14, it will likely make it. If not, then it > isn't a good candidate for 14.0.1 anyway. > > -- Kevin > > > On 1/7/2020 5:51 AM, thevenet.fred at free.fr wrote: > > Hi Kevin, > > > > I am wondering about the likelihood for the fix to JDK-8088198 that I > > proposed in PR #68 (https://github.com/openjdk/jfx/pull/68) to make it into > > JavaFX 14. > > I think it is unlikely to be integrated into master by Thursday since it > > has yet to be fully reviewed, but since it is marked as a P3 bug, I understand > > that it could still be integrated during RDP1(provided it works as expected, > > of course); am I correct? > > In the event it doesn't make it on time for 14, would it qualify to be > > backported for inclusion in an intermediate release like 14.0.1, or would > > it have to wait for JavaFX 15? > > > > Thanks, > > Frederic. > > > > ----- Mail original ----- > > De: "Kevin Rushforth" > > ?: "openjfx-dev" > > Envoy?: Mardi 7 Janvier 2020 00:26:03 > > Objet: Re: Proposed schedule for JavaFX 14 > > > > This is a final reminder that JavaFX 14 enters rampdown phase one (RDP1) > > on January 9, 2020 at 23:59 Pacific time. > > > > Any change integrated to the default 'master' branch after that will be > > for JavaFX 15. I will fork a new 'jfx14' stabilization branch early > > Friday morning (Pacific time). As with previous releases, P1-P3 bug > > fixes, and test or documentation fixes of any priority can still get > > into JavaFX 14 during RDP1. I'll send out more details Friday morning. > > > > -- Kevin > > > > > > On 12/16/2019 11:34 AM, Kevin Rushforth wrote: > > > The announced RDP1 date is the first Monday of the new year. In taking > > > a closer look at the upcoming holiday schedule and accounting for > > > additional days off some will be taking before or after, this doesn't > > > allow enough time for the final stages of the review process to > > > complete, including CSR approval. It is quite possible that an > > > enhancement with a mostly-completed review and a CSR that is Finalized > > > this Thursday or Friday (Dec 19 or 20), won't be approved in time for > > > integration. > > > > > > To address this, we are delaying RDP1 by three days. The new RDP1 date > > > is: > > > > > > Thursday, Jan 9, 23:59 PST > > > > > > The dates for RDP2, code freeze, and GA are unchanged. > > > > > > Please be aware that this three-day extension isn't an invitation to > > > try to get additional features into 14 at the last minute, but rather > > > an adjustment to better align with the holiday schedule in order to > > > give the already-in-flight features that are nearing completion a > > > little more time to make it. It is still the case that if an > > > enhancement isn't ready (meaning API discussed & approved, code review > > > mostly done, and CSR finalized) by this Friday, it should be > > > retargeted to JavaFX 15. > > > > > > -- Kevin > > > > > > > > > On 12/10/2019 1:45 PM, Kevin Rushforth wrote: > > > > As a reminder, RDP1 for JavaFX 14 starts on January 6, 2020 (at 23:59 > > > > Pacific time). > > > > > > > > With the holidays approaching, please allow sufficient time for any > > > > feature that needs a CSR. New features should be far enough along in > > > > the review process so you can finalize the CSR before next Friday, > > > > Dec 20, or it is likely to miss the window for this release, in which > > > > case it can be targeted for JavaFX 15. > > > > > > > > During rampdown of JavaFX 14, the "master" branch of the jfx repo > > > > will be open for JavaFX 15 fixes. > > > > > > > > We will follow the same process as previous releases for getting > > > > fixes into JavaFX 14 during rampdown. I'll send a message with > > > > detailed information later, but generally candidates for fixing after > > > > RDP1 are P1-P3 bugs (as long as they are not risky) and test or doc > > > > bugs of any priority. > > > > > > > > -- Kevin > > > > > > > > > > > > On 9/20/2019 8:00 AM, Kevin Rushforth wrote: > > > > > Here is the proposed schedule for JavaFX 14. > > > > > > > > > > RDP1: Jan 6, 2020 (aka ?feature freeze?) > > > > > RDP2: Feb 3, 2020 > > > > > Freeze: Feb 24, 2020 > > > > > GA: March 10, 2020 > > > > > > > > > > We plan to fork a jfx14 stabilization branch at RDP1. The GA date is > > > > > expected to be one week ahead of JDK 14, matching what we did for 13. > > > > > > > > > > Please let Johan or me know if you have any questions. > > > > > > > > > > -- Kevin > > > > > From kevin.rushforth at oracle.com Wed Jan 8 13:40:45 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 8 Jan 2020 05:40:45 -0800 Subject: Proposed schedule for JavaFX 14 In-Reply-To: <74a479b0-f32f-43ef-a72b-a82f41fa537a@Erics-iPhone-X> References: <74a479b0-f32f-43ef-a72b-a82f41fa537a@Erics-iPhone-X> Message-ID: <95817e05-c05b-f92f-98fb-3d46f9a8497e@oracle.com> Are you asking how to tell whether a PR is targeted for JavaFX 14 or 15 after the RDP1 fork? I'll send out details on Friday morning after the fork, but it's effectively the same as it's been for the last several releases. The 'master' branch of jfx is always where the current development release is built from. Today that would be JavaFX 14. As of Friday morning, it will be JavaFX 15. During rampdown of JavaFX 14, a PR can be made against the 'jfx14' branch to get into JavaFX 14 if the reviewer(s) agree that it meets the criteria for getting into 14. In JBS, a bug that is intended for 14 will have the fixVersion of opnejfx14, while a bug intended for 15 will have a fixVersion of openjfx15. At RDP1 of 14, most bugs should have their fixVersion updated to openjfx15. -- Kevin On 1/7/2020 10:54 PM, Eric Bresie wrote: > Out of curiosity...are there any labels, milestones, targets or any such type added in github and/or bug systema for changes going in? Or is there a PR of some type with all relevant changes expected? > > Eric Bresie > Ebresie at gmail.com >> On January 7, 2020 at 9:18:00 AM CST, thevenet.fred at free.fr wrote: >> Ok, it is quite clear to me now. >> Thanks for the clarifications. >> >> Regards, >> Frederic. >> >> ----- Mail original ----- >> De: "Kevin Rushforth" >> ?: "thevenet fred" >> Cc: "openjfx-dev" >> Envoy?: Mardi 7 Janvier 2020 15:54:41 >> Objet: Re: Proposed schedule for JavaFX 14 >> >> Hi Frederic, >> >> P3 bug fixes can go in during RDP1 if they are safe enough fixes. The >> RDP2 deadline is Feb 3, so there is still time. Any bug that misses 14 >> and is ready for integration into mainline will go into 15. A case can >> be made for pulling in a very limited number of safe fixes from 15 into >> a 14.0.x release, but I wouldn't expect that in this case. If the fix is >> safe enough to get into 14, it will likely make it. If not, then it >> isn't a good candidate for 14.0.1 anyway. >> >> -- Kevin >> >> >> On 1/7/2020 5:51 AM, thevenet.fred at free.fr wrote: >>> Hi Kevin, >>> >>> I am wondering about the likelihood for the fix to JDK-8088198 that I >>> proposed in PR #68 (https://github.com/openjdk/jfx/pull/68) to make it into >>> JavaFX 14. >>> I think it is unlikely to be integrated into master by Thursday since it >>> has yet to be fully reviewed, but since it is marked as a P3 bug, I understand >>> that it could still be integrated during RDP1(provided it works as expected, >>> of course); am I correct? >>> In the event it doesn't make it on time for 14, would it qualify to be >>> backported for inclusion in an intermediate release like 14.0.1, or would >>> it have to wait for JavaFX 15? >>> >>> Thanks, >>> Frederic. >>> >>> ----- Mail original ----- >>> De: "Kevin Rushforth" >>> ?: "openjfx-dev" >>> Envoy?: Mardi 7 Janvier 2020 00:26:03 >>> Objet: Re: Proposed schedule for JavaFX 14 >>> >>> This is a final reminder that JavaFX 14 enters rampdown phase one (RDP1) >>> on January 9, 2020 at 23:59 Pacific time. >>> >>> Any change integrated to the default 'master' branch after that will be >>> for JavaFX 15. I will fork a new 'jfx14' stabilization branch early >>> Friday morning (Pacific time). As with previous releases, P1-P3 bug >>> fixes, and test or documentation fixes of any priority can still get >>> into JavaFX 14 during RDP1. I'll send out more details Friday morning. >>> >>> -- Kevin >>> >>> >>> On 12/16/2019 11:34 AM, Kevin Rushforth wrote: >>>> The announced RDP1 date is the first Monday of the new year. In taking >>>> a closer look at the upcoming holiday schedule and accounting for >>>> additional days off some will be taking before or after, this doesn't >>>> allow enough time for the final stages of the review process to >>>> complete, including CSR approval. It is quite possible that an >>>> enhancement with a mostly-completed review and a CSR that is Finalized >>>> this Thursday or Friday (Dec 19 or 20), won't be approved in time for >>>> integration. >>>> >>>> To address this, we are delaying RDP1 by three days. The new RDP1 date >>>> is: >>>> >>>> Thursday, Jan 9, 23:59 PST >>>> >>>> The dates for RDP2, code freeze, and GA are unchanged. >>>> >>>> Please be aware that this three-day extension isn't an invitation to >>>> try to get additional features into 14 at the last minute, but rather >>>> an adjustment to better align with the holiday schedule in order to >>>> give the already-in-flight features that are nearing completion a >>>> little more time to make it. It is still the case that if an >>>> enhancement isn't ready (meaning API discussed & approved, code review >>>> mostly done, and CSR finalized) by this Friday, it should be >>>> retargeted to JavaFX 15. >>>> >>>> -- Kevin >>>> >>>> >>>> On 12/10/2019 1:45 PM, Kevin Rushforth wrote: >>>>> As a reminder, RDP1 for JavaFX 14 starts on January 6, 2020 (at 23:59 >>>>> Pacific time). >>>>> >>>>> With the holidays approaching, please allow sufficient time for any >>>>> feature that needs a CSR. New features should be far enough along in >>>>> the review process so you can finalize the CSR before next Friday, >>>>> Dec 20, or it is likely to miss the window for this release, in which >>>>> case it can be targeted for JavaFX 15. >>>>> >>>>> During rampdown of JavaFX 14, the "master" branch of the jfx repo >>>>> will be open for JavaFX 15 fixes. >>>>> >>>>> We will follow the same process as previous releases for getting >>>>> fixes into JavaFX 14 during rampdown. I'll send a message with >>>>> detailed information later, but generally candidates for fixing after >>>>> RDP1 are P1-P3 bugs (as long as they are not risky) and test or doc >>>>> bugs of any priority. >>>>> >>>>> -- Kevin >>>>> >>>>> >>>>> On 9/20/2019 8:00 AM, Kevin Rushforth wrote: >>>>>> Here is the proposed schedule for JavaFX 14. >>>>>> >>>>>> RDP1: Jan 6, 2020 (aka ?feature freeze?) >>>>>> RDP2: Feb 3, 2020 >>>>>> Freeze: Feb 24, 2020 >>>>>> GA: March 10, 2020 >>>>>> >>>>>> We plan to fork a jfx14 stabilization branch at RDP1. The GA date is >>>>>> expected to be one week ahead of JDK 14, matching what we did for 13. >>>>>> >>>>>> Please let Johan or me know if you have any questions. >>>>>> >>>>>> -- Kevin >>>>>> From jvos at openjdk.java.net Wed Jan 8 14:21:14 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Wed, 8 Jan 2020 14:21:14 GMT Subject: [Integrated] RFR: 8236448: Remove unused and repair broken Android/Dalvik code In-Reply-To: References: Message-ID: Changeset: e6587ff0 Author: Johan Vos Date: 2020-01-08 14:20:28 +0000 URL: https://git.openjdk.java.net/jfx/commit/e6587ff0 8236448: Remove unused and repair broken Android/Dalvik code Reviewed-by: kcr ! buildSrc/android.gradle ! modules/javafx.graphics/src/main/java/com/sun/glass/ui/android/DalvikInput.java ! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidInputDeviceRegistry.java ! modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleApplication.java ! modules/javafx.graphics/src/main/native-glass/monocle/EGL.c ! modules/javafx.graphics/src/main/native-glass/monocle/android/AndroidScreen.c - modules/javafx.graphics/src/main/native-glass/monocle/android/dalvikInput.c - modules/javafx.graphics/src/main/native-glass/monocle/android/dalvikInput.h ! modules/javafx.graphics/src/main/native-glass/monocle/android/dalvikUtils.c + modules/javafx.graphics/src/main/native-glass/monocle/android/nativeBridge.c + modules/javafx.graphics/src/main/native-glass/monocle/android/nativeBridge.h ! modules/javafx.graphics/src/main/native-prism-es2/monocle/MonocleGLFactory.c ! modules/javafx.graphics/src/main/native-prism-es2/monocle/eglUtils.c From mail at fabiankeller.de Wed Jan 8 15:30:19 2020 From: mail at fabiankeller.de (Fabian Keller) Date: Wed, 8 Jan 2020 16:30:19 +0100 Subject: OpenJFX is not using FontConfig Message-ID: Hi, I'm currently investigating a problem where openjfx is not using FontConfig on a CentOS machine. Error message: ... Loading FontFactory com.sun.javafx.font.freetype.FTFactory Subpixel: enabled Freetype2 Loaded (version 2.8.0) LCD support Disabled Fallback fontDir is /root/jdk-11.0.5+10/lib/fonts exists = false java.io.FileNotFoundException: null/allfonts.properties (No such file or directory) Fall back to opening the files *** FONTCONFIG LOCATED FONTS: Not using FontConfig Fontconfig returned no font for sans:regular:roman ... I'm using openjfx bundled with my application in a fat jar. (dependencies javafx-base, javafx-web, javafx-swing) (Tested openjfx versions: 11, 11.0.1, 13, 13.0.1) The jar is working without any problems on two different machines, one with a fresh installation of CentOS 7.4 with Gnome. On other existing machines (CentOS 7.4) i see the error above, terminating with jvm core dump due to no available fonts. I tested the behaviour with two jdk distributions from adoptopenjdk (OpenJDK11U-jdk_x64_linux_hotspot_11.0.5_10) and Bellsoft (bellsoft-jdk11.0.5+11). FontConfig seem's to work properly # fc-match sans.regular DejaVuSans.ttf: "DejaVu Sans" "Book" # fc-match sans:regular:roman DejaVuSans.ttf: "DejaVu Sans" "Book" The jvm command line i used: java -Dprism.useFontConfig=true -Dprism.debugfonts=true -Dprism.verbose=true -cp nalf.jar de.dummy.Main I took a look at the source which produces the line "Not using FontConfig": https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/com/sun/javafx/font/FontConfigManager.java#L161 If I read correctly the only case where this output can happen is if 'useFontConfig' is false. The only assignment of 'useFontConfig' is here: https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/com/sun/javafx/font/FontConfigManager.java#L52 useFontConfig should only be false if the property 'prism.useFontConfig' is not equals 'true'. But I set it explicitly to "true" (default should also be true). Does anybody have a clue, what's the problem or has anybody an idea how to debug this further? Best regards Fabian Keller From philip.race at oracle.com Wed Jan 8 16:59:25 2020 From: philip.race at oracle.com (Philip Race) Date: Wed, 08 Jan 2020 08:59:25 -0800 Subject: OpenJFX is not using FontConfig In-Reply-To: References: Message-ID: <5E160A6D.6070906@oracle.com> Perhaps you could trace the process to see if we successfully load the shared library ? Maybe we can't do that or can't initialise it for some reason. But Centos 7.4 is the same as RH 7.4 and OL 7.4 so this is surprising. Do you have the same fontconfig packages on working and non-working ? For example do both (or neither) have the fontconfig-develop (or whatever it is called) package as well as the runtime ? What does a pure Java SE (java 2d) app do on the same machine ? It also loads fontconfig to find fonts so does it succeed or does it fail too ? Try an Oracle produced OpenJDK build to tet this. -phil On 1/8/20, 7:30 AM, Fabian Keller wrote: > Hi, > I'm currently investigating a problem where openjfx is not using > FontConfig on a CentOS machine. > > Error message: > ... > Loading FontFactory com.sun.javafx.font.freetype.FTFactory > Subpixel: enabled > Freetype2 Loaded (version 2.8.0) > LCD support Disabled > Fallback fontDir is /root/jdk-11.0.5+10/lib/fonts exists = false > java.io.FileNotFoundException: null/allfonts.properties (No such file > or directory) > Fall back to opening the files > *** FONTCONFIG LOCATED FONTS: > Not using FontConfig > Fontconfig returned no font for sans:regular:roman > ... > > I'm using openjfx bundled with my application in a fat jar. > (dependencies javafx-base, javafx-web, javafx-swing) (Tested openjfx > versions: 11, 11.0.1, 13, 13.0.1) > The jar is working without any problems on two different machines, one > with a fresh installation of CentOS 7.4 with Gnome. > On other existing machines (CentOS 7.4) i see the error above, > terminating with jvm core dump due to no available fonts. > I tested the behaviour with two jdk distributions from adoptopenjdk > (OpenJDK11U-jdk_x64_linux_hotspot_11.0.5_10) and Bellsoft > (bellsoft-jdk11.0.5+11). > > FontConfig seem's to work properly > # fc-match sans.regular > DejaVuSans.ttf: "DejaVu Sans" "Book" > # fc-match sans:regular:roman > DejaVuSans.ttf: "DejaVu Sans" "Book" > > The jvm command line i used: > java -Dprism.useFontConfig=true -Dprism.debugfonts=true > -Dprism.verbose=true -cp nalf.jar de.dummy.Main > > I took a look at the source which produces the line "Not using FontConfig": > https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/com/sun/javafx/font/FontConfigManager.java#L161 > > If I read correctly the only case where this output can happen is if > 'useFontConfig' is false. > > The only assignment of 'useFontConfig' is here: > https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/com/sun/javafx/font/FontConfigManager.java#L52 > > useFontConfig should only be false if the property > 'prism.useFontConfig' is not equals 'true'. But I set it explicitly to > "true" (default should also be true). > > > Does anybody have a clue, what's the problem or has anybody an idea > how to debug this further? > > > Best regards > Fabian Keller From nlisker at gmail.com Wed Jan 8 18:19:06 2020 From: nlisker at gmail.com (Nir Lisker) Date: Wed, 8 Jan 2020 20:19:06 +0200 Subject: Skara - bot sending can-be-integrated message prematurely? In-Reply-To: <72e4e84c-873e-6857-cf4a-5c71638d1fa3@oracle.com> References: <20191216132355.Horde.6zrrRoo2wZbW4oyHrdTvLA1@webmail.df.eu> <97111c6f-d2c6-0d64-4467-b08aa69c72a6@oracle.com> <20191216154149.Horde.vV41KBIOtMzUVIGHz1bUkQ4@webmail.df.eu> <3f5e7f38-c9c2-e345-3e64-7336113fa0d2@oracle.com> <5DF98923.4070409@oracle.com> <72e4e84c-873e-6857-cf4a-5c71638d1fa3@oracle.com> Message-ID: I forgot to mention that I filed these: https://bugs.openjdk.java.net/browse/SKARA-218 https://bugs.openjdk.java.net/browse/SKARA-217 They weren't triaged, so maybe the Skara team needs to be notified. On Thu, Dec 19, 2019 at 6:24 PM Kevin Rushforth wrote: > FYI, for anyone interested, the Skara team submitted the following PR to > modify the "ready for integration" message: > > https://github.com/openjdk/skara/pull/343 > > We can file a follow-up RFE to have them consider adding "/reviewers" and > "/csr" commands. > > -- Kevin > > > On 12/18/2019 7:17 PM, Phil Race wrote: > > It would have to allow anyone who has reviewer status to add that comment. > Not just the author since if they knew we would have less need for it. > > -Phil. > > On Dec 18, 2019, at 11:31 AM, Kevin Rushforth > wrote: > > That's an interesting idea. It would, of course, need to disallow reducing > the number below the minimum specified in .jcheck/conf (e.g., we wouldn't > allow "/reviewers 0"). > > -- Kevin > > > On 12/18/2019 10:36 AM, Nir Lisker wrote: > > The client libraries in the OpenJDK do as a default rule, excusing simple >> fixes. >> > > Then maybe it would be helpful to have a "/reviewers n" command that will > tell the bot how many reviewers are needed. It's less convoluted than the > CSR tracking and basically replaces the comment a reviewer would make > anyway to inform the PR author how many reviewers they should wait for. > Extending the bot to look for n reviewers instead of the current 1 should > not be far fetched. > > > >> >> > On Wed, Dec 18, 2019 at 4:02 AM Philip Race > wrote: > >> >> >> On 12/16/19, 4:14 PM, Nir Lisker wrote: >> > Do other projects also have multi-reviewers requirements? >> >> The client libraries in the OpenJDK do as a default rule, excusing >> simple fixes. >> >> > >> > I would think that at least for a CSR, which is OpenJDK-wide, a request >> > could be put in with the Skara to track it. A Reviewer (or Committer?) >> > could invoke a /csr command which will require the PR author to provide >> a >> > link to the CSR, and check that it was approved as part of the patch >> > approval process. >> >> I think that if there is a CSR sub-task in JBS skara can key off whether >> that is approved. >> This does mean skara needs to probe JBS but SFAIK its doing that a >> hundred times >> a minute anyway. >> >> -phil. >> >> > >> > Not sure how complicated it would be to implement. >> > >> > - Nir >> > >> > On Mon, Dec 16, 2019 at 5:39 PM Kevin Rushforth< >> kevin.rushforth at oracle.com> >> > wrote: >> > >> >> That's a good question about whether we can ask for a slight rewording >> >> of the Skara bot message to indicate that there might be other things >> to >> >> check before "/integrate". I'll raise that question with the Skara >> team. >> >> >> >> As an aside, I noticed the other day that you typed "/integrate" after >> a >> >> single review, but in that case, there was no clear indication from >> Ajit >> >> (the first reviewer and the sponsor) that a second review was required, >> >> so I didn't comment on it. >> >> >> >> -- Kevin >> >> >> >> >> >> On 12/16/2019 6:41 AM, Jeanette Winzenburg wrote: >> >>> Kevin, >> >>> >> >>> thanks for the clarification :) My bad that I didn't re-read the >> >>> contrib.md. But then, who does? The lazy like myself do it >> >>> occasionally only (down to once and then forget about it) >> >>> >> >>> Maybe the bot message can be improved? With some indication that its >> >>> (the bot's) knowledge about review requirements is limited, so would >> >>> require a careful check by the contributor before actually post the >> >>> /integrate comment? Actually, I think I goofed the other day, was >> >>> safed only by Ajit who waited for the 2nd review before his /sponsor. >> >>> >> >>> -- Jeanette >> >>> >> >>> Zitat von Kevin Rushforth: >> >>> >> >>>> I added a comment to the two PRs in question, but it bears discussion >> >>>> here. >> >>>> >> >>>> The Skara bot can't know whether all criteria have been met. It >> >>>> can't, for example, know whether there are outstanding comments from >> >>>> some reviewers that need to be addressed. Nor does it know which PRs >> >>>> need two reviewers (or sometimes a third if there is a specific >> >>>> person we would like to review it), which ones need a CSR, etc. >> >>>> >> >>>> So having it state authoritatively that the PR is ready to integrate >> >>>> is a bit misleading. This is documented in the Code Review section of >> >>>> the CONTRIBUTING [1] doc: >> >>>> >> >>>>> NOTE: while the Skara tooling will indicate that the PR is ready to >> >>>>> integrate once the first reviewer with a "Reviewer" role in the >> >>>>> project has approved it, this may or may not be sufficient depending >> >>>>> on the type of fix. For example, you must wait for a second approval >> >>>>> for enhancements or high-impact bug fixes. >> >>>> If anyone can think of a way to improve this and make it more clear, >> >>>> that would be helpful. >> >>>> >> >>>> -- Kevin >> >>>> >> >>>> [1] https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md >> >>>> >> >>>> >> >>>> On 12/16/2019 4:23 AM, Jeanette Winzenburg wrote: >> >>>>> Looks like it assumes a pull request as properly reviewed as soon as >> >>>>> it gets a single approve - independent on how many reviewers are >> >>>>> required, see f.i. >> >>>>> >> >>>>> https://github.com/openjdk/jfx/pull/15#issuecomment-565964995 >> >>>>> https://github.com/openjdk/jfx/pull/6#issuecomment-566028296 >> >>>>> >> >>>>> -- Jeanette >> >>>>> >> >>> >> >>> >> >> >> > > > From nlisker at gmail.com Wed Jan 8 18:31:54 2020 From: nlisker at gmail.com (Nir Lisker) Date: Wed, 8 Jan 2020 20:31:54 +0200 Subject: Should Skara tooling invalidate approvals when new commits are pushed? [was: RFR: 8130738: Add tabSize property to Text and TextFlow] In-Reply-To: References: Message-ID: Looks like an all-or-nothing situation - either any commit requires re-approval or no commit requires re-approval. In this case, I would say that all commits should require re-approval since it's the safer approach. Having the issue stay in approved state after a significant change is much worse than requiring the reviewers to take a look at an insignificant commit and re-approve. The time is takes for a reviewer to go over a comment or formatting change is short and, I believe, not intrusive to their workflow. On Tue, Dec 31, 2019 at 7:48 PM Kevin Rushforth wrote: > Since this isn't directly related to the PR in question, I'm starting a > new thread. > > On 12/20/2019 7:22 PM, Philip Race wrote: > > On 12/20/19, 7:04 PM, Scott Palmer wrote: > >> I'm not sure if I'me supposed to try to integrate now that I've made > >> that 10 -> 0 change, or if the new change resets the need for review... > > > > It shows ready, which surprises me. > > Still learning skara .. I'd expect any change to reset as how can it > > know if it is > > a good or insignificant change or not no matter how the commenter > > characterised the issue ? > > Pushing a new commit doesn't automatically invalidate existing > approvals, although it is highlighted in the "Approvers" section that > the approval was for a prior commit: > > Approvers > Phil Race (prr - Reviewer) Note! Review applies to f846ad6 > > I remember bringing this up with the Skara team during my initial > testing, since I also had wondered whether pushing a new commit should > invalidate approvals. The current policy allows for doing trivial fixes > brought up when approving a review (e.g., a change in a comment or > formatting) without requiring all reviewers to re-approve. It matches > current practice for email-based reviews, so I think the current > behavior is a reasonable default. > > They did say that they could implement an optional feature (i.e., a > project would need to opt-in to this behavior, probably via a > .jcheck/conf property) to invalidate all approvals upon pushing a new > commit, but I don't think an RFE was filed to track it. > > This seems like it could be a valuable feature, although it does come > with a slight cost in terms of timing and flexibility. What do others > think? > > -- Kevin > > From jvos at openjdk.java.net Wed Jan 8 19:16:10 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Wed, 8 Jan 2020 19:16:10 GMT Subject: RFR: 8236808: javafx_iio can not be used in static environment Message-ID: <_JWiI5DVD1nZKpMWN9OyCKHbuuUPzI05gBYZMwwq5-8=.bbd8bc07-ebb3-4b25-9be4-896e4aab6f7e@github.com> The static JNI_OnLoad naming should be used whenever we are building a static lib (not only for iOS). We now have the STATIC_BUILD property to determine if we are making a static build, so we no longer need to check on ios specific patterns. Fix JDK-8236808 ------------- Commits: - 54c14bb8: The static JNI_OnLoad naming should be used whenever we are building Changes: https://git.openjdk.java.net/jfx/pull/81/files Webrev: https://webrevs.openjdk.java.net/jfx/81/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236808 Stats: 10 lines in 1 file changed: 0 ins; 8 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/81.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/81/head:pull/81 PR: https://git.openjdk.java.net/jfx/pull/81 From johan at lodgon.com Wed Jan 8 19:26:00 2020 From: johan at lodgon.com (Johan Vos) Date: Wed, 8 Jan 2020 20:26:00 +0100 Subject: Should Skara tooling invalidate approvals when new commits are pushed? [was: RFR: 8130738: Add tabSize property to Text and TextFlow] In-Reply-To: References: Message-ID: I agree. If the fix is trivial, the time for the reviewer will be really short. The more complex the fix, the more time it will take -- with the risk of being delayed to the next release. The github interface makes it very easy to inspect the new commit, hence a typo in javadoc can easily be fixed and re-approved. I think this approach is safer than the approach were "trivial" fixes don't need re-approval, as that approach leaves more room for interpretation (and probably even more interactions with the reviewers ("is this a trivial fix?")). - Johan Op wo 8 jan. 2020 om 19:34 schreef Nir Lisker : > Looks like an all-or-nothing situation - either any commit requires > re-approval or no commit requires re-approval. In this case, I would say > that all commits should require re-approval since it's the safer approach. > Having the issue stay in approved state after a significant change is much > worse than requiring the reviewers to take a look at an insignificant > commit and re-approve. The time is takes for a reviewer to go over a > comment or formatting change is short and, I believe, not intrusive to > their workflow. > > On Tue, Dec 31, 2019 at 7:48 PM Kevin Rushforth < > kevin.rushforth at oracle.com> > wrote: > > > Since this isn't directly related to the PR in question, I'm starting a > > new thread. > > > > On 12/20/2019 7:22 PM, Philip Race wrote: > > > On 12/20/19, 7:04 PM, Scott Palmer wrote: > > >> I'm not sure if I'me supposed to try to integrate now that I've made > > >> that 10 -> 0 change, or if the new change resets the need for > review... > > > > > > It shows ready, which surprises me. > > > Still learning skara .. I'd expect any change to reset as how can it > > > know if it is > > > a good or insignificant change or not no matter how the commenter > > > characterised the issue ? > > > > Pushing a new commit doesn't automatically invalidate existing > > approvals, although it is highlighted in the "Approvers" section that > > the approval was for a prior commit: > > > > Approvers > > Phil Race (prr - Reviewer) Note! Review applies to f846ad6 > > > > I remember bringing this up with the Skara team during my initial > > testing, since I also had wondered whether pushing a new commit should > > invalidate approvals. The current policy allows for doing trivial fixes > > brought up when approving a review (e.g., a change in a comment or > > formatting) without requiring all reviewers to re-approve. It matches > > current practice for email-based reviews, so I think the current > > behavior is a reasonable default. > > > > They did say that they could implement an optional feature (i.e., a > > project would need to opt-in to this behavior, probably via a > > .jcheck/conf property) to invalidate all approvals upon pushing a new > > commit, but I don't think an RFE was filed to track it. > > > > This seems like it could be a valuable feature, although it does come > > with a slight cost in terms of timing and flexibility. What do others > > think? > > > > -- Kevin > > > > > From kevin.rushforth at oracle.com Wed Jan 8 19:34:22 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 8 Jan 2020 11:34:22 -0800 Subject: Should Skara tooling invalidate approvals when new commits are pushed? [was: RFR: 8130738: Add tabSize property to Text and TextFlow] In-Reply-To: References: Message-ID: <482dd6a0-befd-6c95-e430-fc8789be6fd0@oracle.com> Does anyone strongly feel otherwise? If not, then I'll request the Skara team to enable this feature. -- Kevin On 1/8/2020 11:26 AM, Johan Vos wrote: > I agree. If the fix is trivial, the time for the reviewer will be > really short. The more complex the fix, the more time it will take -- > with the risk of being delayed to the next release. > The github interface makes it very easy to inspect the new commit, > hence a typo in javadoc can easily be fixed and re-approved. > > I think this approach is safer than the approach were "trivial" fixes > don't need re-approval, as that approach leaves more room for > interpretation (and probably even more interactions with the reviewers > ("is this a trivial fix?")). > > - Johan > > Op wo 8 jan. 2020 om 19:34 schreef Nir Lisker >: > > Looks like an all-or-nothing situation - either any commit requires > re-approval or no commit requires re-approval. In this case, I > would say > that all commits should require re-approval since it's the safer > approach. > Having the issue stay in approved state after a significant change > is much > worse than requiring the reviewers to take a look at an insignificant > commit and re-approve. The time is takes for a reviewer to go over a > comment or formatting change is short and, I believe, not intrusive to > their workflow. > > On Tue, Dec 31, 2019 at 7:48 PM Kevin Rushforth > > > wrote: > > > Since this isn't directly related to the PR in question, I'm > starting a > > new thread. > > > > On 12/20/2019 7:22 PM, Philip Race wrote: > > > On 12/20/19, 7:04 PM, Scott Palmer wrote: > > >> I'm not sure if I'me supposed to try to integrate now that > I've made > > >> that 10 ->? 0 change, or if the new change resets the need > for review... > > > > > > It shows ready, which surprises me. > > > Still learning skara .. I'd expect any change to reset as how > can it > > > know if it is > > > a? good or insignificant change or not no matter how the commenter > > > characterised the issue ? > > > > Pushing a new commit doesn't automatically invalidate existing > > approvals, although it is highlighted in the "Approvers" section > that > > the approval was for a prior commit: > > > >? ? ? Approvers > >? ? ? ? ? Phil Race (prr - Reviewer) Note! Review applies to f846ad6 > > > > I remember bringing this up with the Skara team during my initial > > testing, since I also had wondered whether pushing a new commit > should > > invalidate approvals. The current policy allows for doing > trivial fixes > > brought up when approving a review (e.g., a change in a comment or > > formatting) without requiring all reviewers to re-approve. It > matches > > current practice for email-based reviews, so I think the current > > behavior is a reasonable default. > > > > They did say that they could implement an optional feature (i.e., a > > project would need to opt-in to this behavior, probably via a > > .jcheck/conf property) to invalidate all approvals upon pushing > a new > > commit, but I don't think an RFE was filed to track it. > > > > This seems like it could be a valuable feature, although it does > come > > with a slight cost in terms of timing and flexibility. What do > others > > think? > > > > -- Kevin > > > > > From nlisker at openjdk.java.net Thu Jan 9 00:06:34 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Thu, 9 Jan 2020 00:06:34 GMT Subject: RFR: 8236753: Animations do not play backwards after being stopped Message-ID: The private field `lastPlayFinished` is responsible for 2 cases where an animation in `STOPPED` status does not play after `play()` is called if the rate is negative: 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is `false`. Setting a negative rate and calling `play()` will not jump to the end of the animation (in order to play it backwards) because the `if (lastPlayedFinished)` check is `false`. Creating the animation with `lastPlayFinished = true` fixes this. 2. When the animation is stopped (if it was not `STOPPED` already), `jumpTo(Duration.ZERO)` sets `lastPlayFinished` to `false`, which causes the same issue above with `play()`. Setting `lastPlayFinished = true` at the end `stop()` fixes this issue. A test was added for case 2 to check that the playing head indeed jumps to the end of the animation. Without this fix, it stays at the start. Testing case 1 will require a new animation instance since the one in the test is used prior, but I'm not sure it's very helpful. I'm still somewhat confused as to what constitutes a "last play finished". Any `jumpTo` resets `lastPlayFinished` to `false`, even if the jump is to the start/end of the animation. In this case, stopping an animation, jumping to its start/end, setting the rate to negative/positive, and playing, will do nothing as the end condition is reached immediately. This is what the behavior that was fixed for cases 1 and 2, but maybe this is also incorrect behavior for jumping to start/end. A test app is included in the "parent" [bug](https://bugs.openjdk.java.net/browse/JDK-8210238), which also mentions a bug relating to **pausing** and playing backwards, so be mindful of it when testing. ------------- Commits: - 3332a97f: Initial push of 8236753 Changes: https://git.openjdk.java.net/jfx/pull/82/files Webrev: https://webrevs.openjdk.java.net/jfx/82/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236753 Stats: 12 lines in 2 files changed: 10 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/82.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/82/head:pull/82 PR: https://git.openjdk.java.net/jfx/pull/82 From tsayao at openjdk.java.net Thu Jan 9 02:00:08 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Thu, 9 Jan 2020 02:00:08 GMT Subject: [Rev 06] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - 0dc70ab3: Use gtk_window_set_default_size for before-map sizing which is the appropriate function Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/e4d2a1d2..0dc70ab3 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.06 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.05-06 Stats: 66 lines in 2 files changed: 32 ins; 18 del; 16 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From kcr at openjdk.java.net Thu Jan 9 02:40:39 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 9 Jan 2020 02:40:39 GMT Subject: RFR: 8236733: Change JavaFX release version to 15 In-Reply-To: References: Message-ID: On Thu, 9 Jan 2020 02:39:09 GMT, Kevin Rushforth wrote: > JDK-8236733](https://bugs.openjdk.java.net/browse/JDK-8236733). > > Bump the release version to 15. As noted in the JBS issue, I will wait until right after the `jfx14` fork to integrate this. Reviewer: @arapte ------------- PR: https://git.openjdk.java.net/jfx/pull/83 From kcr at openjdk.java.net Thu Jan 9 02:40:39 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 9 Jan 2020 02:40:39 GMT Subject: RFR: 8236733: Change JavaFX release version to 15 Message-ID: JDK-8236733](https://bugs.openjdk.java.net/browse/JDK-8236733). Bump the release version to 15. As noted in the JBS issue, I will wait until right after the `jfx14` fork to integrate this. ------------- Commits: - 50f38ab6: 8236733: Change JavaFX release version to 15 Changes: https://git.openjdk.java.net/jfx/pull/83/files Webrev: https://webrevs.openjdk.java.net/jfx/83/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236733 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/83.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/83/head:pull/83 PR: https://git.openjdk.java.net/jfx/pull/83 From kcr at openjdk.java.net Thu Jan 9 02:54:14 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 9 Jan 2020 02:54:14 GMT Subject: RFR: 8236808: javafx_iio can not be used in static environment In-Reply-To: <_JWiI5DVD1nZKpMWN9OyCKHbuuUPzI05gBYZMwwq5-8=.bbd8bc07-ebb3-4b25-9be4-896e4aab6f7e@github.com> References: <_JWiI5DVD1nZKpMWN9OyCKHbuuUPzI05gBYZMwwq5-8=.bbd8bc07-ebb3-4b25-9be4-896e4aab6f7e@github.com> Message-ID: On Wed, 8 Jan 2020 19:14:29 GMT, Johan Vos wrote: > The static JNI_OnLoad naming should be used whenever we are building a static lib (not only for iOS). > We now have the STATIC_BUILD property to determine if we are making a > static build, so we no longer need to check on ios specific patterns. > > Fix JDK-8236808 ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/81 From jvos at openjdk.java.net Thu Jan 9 07:17:16 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Thu, 9 Jan 2020 07:17:16 GMT Subject: [Integrated] RFR: 8236808: javafx_iio can not be used in static environment In-Reply-To: <_JWiI5DVD1nZKpMWN9OyCKHbuuUPzI05gBYZMwwq5-8=.bbd8bc07-ebb3-4b25-9be4-896e4aab6f7e@github.com> References: <_JWiI5DVD1nZKpMWN9OyCKHbuuUPzI05gBYZMwwq5-8=.bbd8bc07-ebb3-4b25-9be4-896e4aab6f7e@github.com> Message-ID: <920d44cf-c6ac-48db-84fa-dceffae36d0f@openjdk.org> Changeset: f9070263 Author: Johan Vos Date: 2020-01-09 07:16:52 +0000 URL: https://git.openjdk.java.net/jfx/commit/f9070263 8236808: javafx_iio can not be used in static environment Reviewed-by: kcr ! modules/javafx.graphics/src/main/native-iio/jpegloader.c From adam at adamish.com Thu Jan 9 08:04:07 2020 From: adam at adamish.com (Adam Granger) Date: Thu, 09 Jan 2020 00:04:07 -0800 Subject: Memory leak in JavaFX 8 when changing skins Message-ID: <785950b91556abdf0073e5641129333823ebaa3f@webmail.adamish.com> Greetings, I realise this is now legacy for most people but we still widely use JavaFX 8. I appear to have discovered a memory leak when skin is changed The constructor com.sun.javafx.scene.control.skin.BehaviorSkinBase.BehaviorSkinBase adds an event listener ?? control.addEventHandler(ContextMenuEvent.CONTEXT_MENU_REQUESTED, contextMenuHandler); However this is never removed in the dispose() which prevents garbage collection of the previous skin. This problem is amplified by fact JavaFX appears to reload skins unnecessarily in a complex use case involving JFXPanel? - I've as-yet been unable to produce a SSCCE for this What I've discovered so far ?- CSS is reprocessed ?- javafx.scene.CssStyleHelper.canReuseStyleHelper(Node, StyleMap) returns false ?- node.styleHelper.resetToInitialValues(node); is called which then causes the "stock" skin load ?- custom skin (-fx-skin in our application CSS) is then loaded ?- stock skin cannot be GC'd and neither can our custom skin ?- appears to affect any subclass of BehaviorSkinBase Please could you confirm my analysis of this problem and suggest any workarounds? Regards, Adam From David.Grieve at microsoft.com Thu Jan 9 13:58:20 2020 From: David.Grieve at microsoft.com (David Grieve) Date: Thu, 9 Jan 2020 13:58:20 +0000 Subject: [EXTERNAL] Memory leak in JavaFX 8 when changing skins In-Reply-To: <785950b91556abdf0073e5641129333823ebaa3f@webmail.adamish.com> References: <785950b91556abdf0073e5641129333823ebaa3f@webmail.adamish.com> Message-ID: Possible workarounds would be to use Control.setSkin instead of -fx-skin, or to bind the skin property after it has been set to something other than the default. CSS should not mess with a bound property. > -----Original Message----- > From: openjfx-dev On Behalf Of > Adam Granger > Sent: Thursday, January 9, 2020 3:04 AM > To: openjfx-dev at openjdk.java.net > Subject: [EXTERNAL] Memory leak in JavaFX 8 when changing skins > > > Greetings, > > I realise this is now legacy for most people but we still widely use JavaFX 8. > > I appear to have discovered a memory leak when skin is changed > > The constructor > com.sun.javafx.scene.control.skin.BehaviorSkinBase.BehaviorSkinBase > adds an event listener > > ?? control.addEventHandler(ContextMenuEvent.CONTEXT_MENU_REQUESTE > D, > contextMenuHandler); > > However this is never removed in the dispose() which prevents garbage > collection of the previous skin. > > This problem is amplified by fact JavaFX appears to reload skins unnecessarily > in a complex use case involving JFXPanel? - I've as-yet been unable to > produce a SSCCE for this > > What I've discovered so far > ?- CSS is reprocessed > > ?- javafx.scene.CssStyleHelper.canReuseStyleHelper(Node, StyleMap) > returns false > ?- node.styleHelper.resetToInitialValues(node); is called which then causes > the "stock" skin load > ?- custom skin (-fx-skin in our application CSS) is then loaded > > ?- stock skin cannot be GC'd and neither can our custom skin > ?- appears to affect any subclass of BehaviorSkinBase > > Please could you confirm my analysis of this problem and suggest any > workarounds? > > Regards, > > Adam From tom.schindl at bestsolution.at Thu Jan 9 14:48:40 2020 From: tom.schindl at bestsolution.at (Tom Schindl) Date: Thu, 9 Jan 2020 15:48:40 +0100 Subject: DnD Move does not work on OS-X Message-ID: <6da9010f-e888-6cdb-79cf-35ed844a052d@bestsolution.at> Hi, I must be doing something completely wrong or there is a major bug in JavaFX-DnD from Java-8 upwards to JavaFX-14-ea. If you run the attached application on OS-X the and press the CMD-key while dragging you get null for the getTransferMode() inside DragOver and you don't get a DragDropped and null on the DragDone. I tracked that back to View#notifyDragOver() where one gets 0 from the native side. So am I missing something in my code? I also tried with https://docs.oracle.com/javafx/2/drag_drop/jfxpub-drag_drop.htm and it does not work either. So I guess it's a major bug in openjfx but before filing a jira-ticket I wanted to make extra sure it's not a stupid mistake, my german operating system, ... Tom -- Tom Schindl, CTO BestSolution.at EDV Systemhaus GmbH Salurnerstrasse 15. A-6020 Innsbruck Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck -------------- next part -------------- package bla; import java.util.UUID; import javafx.application.Application; import javafx.scene.Scene; import javafx.scene.input.ClipboardContent; import javafx.scene.input.Dragboard; import javafx.scene.input.TransferMode; import javafx.scene.layout.HBox; import javafx.scene.layout.VBox; import javafx.scene.paint.Color; import javafx.scene.shape.Rectangle; import javafx.stage.Stage; public class SampleApp extends Application { @Override public void start(Stage primaryStage) throws Exception { HBox b = new HBox(50); Rectangle sourceR = new Rectangle(300, 300); sourceR.setOnDragDetected( evt -> { Dragboard dragboard = sourceR.startDragAndDrop(TransferMode.ANY); ClipboardContent content = new ClipboardContent(); content.putString(UUID.randomUUID().toString()); dragboard.setContent(content); evt.consume(); }); sourceR.setOnDragDone( evt -> System.err.println("Done: " + evt.getTransferMode())); sourceR.setFill(Color.RED); Rectangle targetR = new Rectangle(300, 300); targetR.setOnDragOver( evt -> { evt.acceptTransferModes(TransferMode.ANY); System.err.println(evt.getTransferMode()); evt.consume(); }); targetR.setOnDragDropped( evt -> { System.err.println("Completed: " + evt.getTransferMode()); evt.setDropCompleted(true); evt.consume(); }); targetR.setFill(Color.BLUE); b.getChildren().setAll(sourceR, targetR); Scene s = new Scene(new VBox(b), 800, 600); primaryStage.setScene(s); primaryStage.show(); } public static void main(String[] args) { launch(args); } } From arapte at openjdk.java.net Thu Jan 9 16:12:06 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Thu, 9 Jan 2020 16:12:06 GMT Subject: RFR: 8236733: Change JavaFX release version to 15 In-Reply-To: References: Message-ID: On Thu, 9 Jan 2020 02:39:09 GMT, Kevin Rushforth wrote: > JDK-8236733](https://bugs.openjdk.java.net/browse/JDK-8236733). > > Bump the release version to 15. As noted in the JBS issue, I will wait until right after the `jfx14` fork to integrate this. Looks good to me. ------------- Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/83 From arapte at openjdk.java.net Thu Jan 9 16:20:36 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Thu, 9 Jan 2020 16:20:36 GMT Subject: RFR: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 23:50:29 GMT, Kevin Rushforth wrote: >> Hi Johan, I did miss to verify this angle. >> But have checked the code now and can confirm that, in a given function for all possible calls to `setMemErrorFlag()` there exists a call to `readAndClearMemErrorFlag()` in the same function. So it looks safe to remove the memory checks from `dispose()` > > I also looked at the code and don't see any mismatches (including those called from the `ACQUIRE_SURFACE` macro). I suppose you could restore the call, but since we are in a disposer thread throwing an exception doesn't seem like the right thing to do. You could log the error, but if we are sure there can be no pending errors, it might not be worth the effort. Yes Kevin, After looking at the code it can be concluded that there are no mismatches. So It seems good to remove those checks. But just in case of safety can keep those as logs too. ------------- PR: https://git.openjdk.java.net/jfx/pull/66 From nlisker at openjdk.java.net Thu Jan 9 18:00:29 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Thu, 9 Jan 2020 18:00:29 GMT Subject: [Rev 03] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Fri, 3 Jan 2020 23:02:56 GMT, Nir Lisker wrote: >>> I still need to test your sample app on Mac. >> >> I get the error with your sample app. It fails on Mac or Linux (Ubuntu 16.04) with the same error as I reported above. > > The error was for the cases of 2 and 3 lights (I was testing 1) and should be fixed now. My fault with copy-paste... that's why we use loops, but I guess this is some optimization for the es2 pipeline. I wonder if it's really worth it over a single shader looping over the number of lights like d3d does. > This will need a fair bit of testing to ensure that there are no regressions either in functionality or (especially) performance, in addition to tests for the new functionality. Which tests for the new functionality should I write? Up to the shader itself it's mostly just passing on variables, and the API is standard `DoubleProperty`s. I can test the dirty bits / redraw logic. > On the performance aspect, the inner loop of the lighting calculation now has an additional if test for the max range and additional arithmetic calculations for the attenuation. What we will need is a test program that we can run on Mac and Windows to measure the performance of rendering in a fill-rate-limited case. Ideally, we would not pay much of a performance hit in the default case where `ca == 1, la == 0, qa == 0`, but we first need to be able to measure the drop in performance before we can say whether it is acceptable. Can you point me to a similar performance test? I didn't see a way to easily measure FPS. I don't know how to avoid the `if` test for the `maxRange`, I'm open to suggestions. The only thing I can think of is if `maxRange` is infinite (the default), we will swap the shader for one that doesn't make that check. However, swapping shaders also costs performance. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From kcr at openjdk.java.net Fri Jan 10 00:19:55 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 10 Jan 2020 00:19:55 GMT Subject: RFR: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface In-Reply-To: References: Message-ID: On Thu, 9 Jan 2020 16:20:19 GMT, Ambarish Rapte wrote: >> I also looked at the code and don't see any mismatches (including those called from the `ACQUIRE_SURFACE` macro). I suppose you could restore the call, but since we are in a disposer thread throwing an exception doesn't seem like the right thing to do. You could log the error, but if we are sure there can be no pending errors, it might not be worth the effort. > > Yes Kevin, After looking at the code it can be concluded that there are no mismatches. So It seems good to remove those checks. But just in case of safety can keep those as logs too. I don't have a strong preference. Either removing the checks or leaving them in (with a log message rather than an exception) is fine with me. ------------- PR: https://git.openjdk.java.net/jfx/pull/66 From kcr at openjdk.java.net Fri Jan 10 00:20:45 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 10 Jan 2020 00:20:45 GMT Subject: [Rev 03] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: <5wmco96mDV2o6049nG257Ac_7cUWQzkRXClNSDHdTYY=.c046919f-25fb-4437-894a-2c5ed5ebc936@github.com> Message-ID: <2zH_P2Wsk4sJxjVr4Ld1hkmqvle077ttr6mQxfxgLv0=.3d1b3909-dac8-4114-9dc6-f575da7adfca@github.com> On Sat, 4 Jan 2020 18:22:29 GMT, Nir Lisker wrote: >> Right. This needs to talk about pixels. Perhaps there is a way to make it more clear that we are talking about pixels that are part of a rendered Shape3D, but I don't have a good suggestion right now. > > Maybe > > A light source that radiates light equally in all directions away from itself. The location of the light > source is a single point in space. The light affects {@code Shape3D}s in its {@code scope}. Any pixels in > the light's {@code range} that belong to a {@code Shape3D} will be illuminated by it according to the > computation specified in {@link PhongMaterial}. > The docs of `PhongMaterial` will need need to be updated too. Yes, I think that change to the docs looks good. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From kcr at openjdk.java.net Fri Jan 10 00:34:37 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 10 Jan 2020 00:34:37 GMT Subject: [Rev 03] RFR: 8217472: Add attenuation for PointLight In-Reply-To: References: Message-ID: On Thu, 9 Jan 2020 18:00:19 GMT, Nir Lisker wrote: >> The error was for the cases of 2 and 3 lights (I was testing 1) and should be fixed now. My fault with copy-paste... that's why we use loops, but I guess this is some optimization for the es2 pipeline. I wonder if it's really worth it over a single shader looping over the number of lights like d3d does. > >> This will need a fair bit of testing to ensure that there are no regressions either in functionality or (especially) performance, in addition to tests for the new functionality. > > Which tests for the new functionality should I write? Up to the shader itself it's mostly just passing on variables, and the API is standard `DoubleProperty`s. I can test the dirty bits / redraw logic. > >> On the performance aspect, the inner loop of the lighting calculation now has an additional if test for the max range and additional arithmetic calculations for the attenuation. What we will need is a test program that we can run on Mac and Windows to measure the performance of rendering in a fill-rate-limited case. Ideally, we would not pay much of a performance hit in the default case where `ca == 1, la == 0, qa == 0`, but we first need to be able to measure the drop in performance before we can say whether it is acceptable. > > Can you point me to a similar performance test? I didn't see a way to easily measure FPS. > I don't know how to avoid the `if` test for the `maxRange`, I'm open to suggestions. The only thing I can think of is if `maxRange` is infinite (the default), we will swap the shader for one that doesn't make that check. However, swapping shaders also costs performance. We have a few performance tests in apps/performance, but I don't know how up to date they are. They might give you a starting point on how to measure FPS, but really the harder part is going to be coming up with a workload -- a scene with a number of Shape3Ds with large triangles (so that they are fill-rate limited) and 1-3 lights, etc -- that you can use to measure rendering performance without measuring overhead. Typically you want a scene that is rendering continuously in the < 30 fps range, and more like 10 fps to minimize the overhead even more. Before we figure out whether we need to double the number of shaders (which was one of the ideas that I had as well), we need to know how much of a problem it is. Is it < 2% performance drop on typical cases on a variety of machines or it is a 25% drop (or more likely somewhere in between). If the perf drop is negligible, then it isn't worth doubling the shaders. If it is significant, then we probably need to. If we do need to double the shaders, I wouldn't do it based on the maxRange being infinite, rather I would do it based on whether attenuation is being used. That way the existing shaders would be unchanged, while the new shader would deal with both attenuation and the maxRange test. Hopefully, there won't be enough of a perf hit to require doubling the shaders, but we need to be able to measure it. For functional testing, in addition to the simple API tests, we want to make sure that the basic rendering is working with and without attenuation. Some sort of visual test where you verify that attenuation is / isn't happening as well as testing the cutoff. I wouldn't get too fancy with these...just a sanity test. ------------- PR: https://git.openjdk.java.net/jfx/pull/43 From kcr at openjdk.java.net Fri Jan 10 00:38:15 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 10 Jan 2020 00:38:15 GMT Subject: RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: References: Message-ID: On Wed, 8 Jan 2020 23:52:07 GMT, Nir Lisker wrote: > The private field `lastPlayFinished` is responsible for 2 cases where an animation in `STOPPED` status does not play after `play()` is called if the rate is negative: > > 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is `false`. Setting a negative rate and calling `play()` will not jump to the end of the animation (in order to play it backwards) because the `if (lastPlayedFinished)` check is `false`. Creating the animation with `lastPlayFinished = true` fixes this. However, `SequentialTransitionPlayTest#testCycleReverse`'s initial state test implies that the original behavior is correct. *That test currently fails with this change.* Either the fix is reverted or the test is corrected. > 2. When the animation is stopped (if it was not `STOPPED` already), `jumpTo(Duration.ZERO)` sets `lastPlayFinished` to `false`, which causes the same issue above with `play()`. Setting `lastPlayFinished = true` at the end `stop()` fixes this issue. > > A test was added for case 2 to check that the playing head indeed jumps to the end of the animation. Without this fix, it stays at the start. > > I'm still somewhat confused as to what constitutes a "last play finished". Any `jumpTo` resets `lastPlayFinished` to `false`, even if the jump is to the start/end of the animation. In this case, stopping an animation, jumping to its start/end, setting the rate to negative/positive, and playing, will do nothing as the end condition is reached immediately. This is what the behavior that was fixed for cases 1 and 2, but maybe this is also incorrect behavior for jumping to start/end. > > A test app is included in the "parent" [bug](https://bugs.openjdk.java.net/browse/JDK-8210238), which also mentions a bug relating to **pausing** and playing backwards, so be mindful of it when testing. I'll review this next week. This seems a fine candidate for openjfx14, so it (along with a couple other pending reviews that can be for 14) will be a good test of targeting a PR to the stabilization branch. I also request @arapte to review. ------------- PR: https://git.openjdk.java.net/jfx/pull/82 From kcr at openjdk.java.net Fri Jan 10 00:40:04 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 10 Jan 2020 00:40:04 GMT Subject: RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: References: Message-ID: On Fri, 10 Jan 2020 00:37:58 GMT, Kevin Rushforth wrote: >> The private field `lastPlayFinished` is responsible for 2 cases where an animation in `STOPPED` status does not play after `play()` is called if the rate is negative: >> >> 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is `false`. Setting a negative rate and calling `play()` will not jump to the end of the animation (in order to play it backwards) because the `if (lastPlayedFinished)` check is `false`. Creating the animation with `lastPlayFinished = true` fixes this. However, `SequentialTransitionPlayTest#testCycleReverse`'s initial state test implies that the original behavior is correct. *That test currently fails with this change.* Either the fix is reverted or the test is corrected. >> 2. When the animation is stopped (if it was not `STOPPED` already), `jumpTo(Duration.ZERO)` sets `lastPlayFinished` to `false`, which causes the same issue above with `play()`. Setting `lastPlayFinished = true` at the end `stop()` fixes this issue. >> >> A test was added for case 2 to check that the playing head indeed jumps to the end of the animation. Without this fix, it stays at the start. >> >> I'm still somewhat confused as to what constitutes a "last play finished". Any `jumpTo` resets `lastPlayFinished` to `false`, even if the jump is to the start/end of the animation. In this case, stopping an animation, jumping to its start/end, setting the rate to negative/positive, and playing, will do nothing as the end condition is reached immediately. This is what the behavior that was fixed for cases 1 and 2, but maybe this is also incorrect behavior for jumping to start/end. >> >> A test app is included in the "parent" [bug](https://bugs.openjdk.java.net/browse/JDK-8210238), which also mentions a bug relating to **pausing** and playing backwards, so be mindful of it when testing. > > I'll review this next week. This seems a fine candidate for openjfx14, so it (along with a couple other pending reviews that can be for 14) will be a good test of targeting a PR to the stabilization branch. > > I also request @arapte to review. I should add that it will depend on whether there are any regressions. One thing we do need to be careful of is introducing regressions during rampdown. ------------- PR: https://git.openjdk.java.net/jfx/pull/82 From tsayao at openjdk.java.net Fri Jan 10 01:54:45 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Fri, 10 Jan 2020 01:54:45 GMT Subject: [Rev 07] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - 209b7ac7: Better alternative calculation for no _NET_FRAME_EXTENTS WM extension Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/0dc70ab3..209b7ac7 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.07 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.06-07 Stats: 70 lines in 2 files changed: 54 ins; 3 del; 13 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From arapte at openjdk.java.net Fri Jan 10 08:18:35 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Fri, 10 Jan 2020 08:18:35 GMT Subject: RFR: 8227619: Potential memory leak in javafx.scene.control.ListView Message-ID: `ListView` does not get GCed because `SelectedItemsReadOnlyObservableList` adds a `ListChangeListener` to the (`ObservableList`) items of `ListView`. Adding a `WeakListChangeListener` instead of `ListChangeListener` fixes the issue. Added a unit test and verified that existing tests do not fail due to this change. ------------- Commits: - 60ee7d03: 8227619: Potential memory leak in javafx.scene.control.ListView Changes: https://git.openjdk.java.net/jfx/pull/84/files Webrev: https://webrevs.openjdk.java.net/jfx/84/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8227619 Stats: 32 lines in 2 files changed: 28 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/84.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/84/head:pull/84 PR: https://git.openjdk.java.net/jfx/pull/84 From r.lichtenberger at gmail.com Fri Jan 10 08:30:09 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Fri, 10 Jan 2020 09:30:09 +0100 Subject: Build Problems due to deprecations (linux) Message-ID: I've tried to run a build of OpenJFX and it fails due to some deprecations within gtk-2: ... In file included from /usr/include/gtk-2.0/gtk/gtkobject.h:37, from /usr/include/gtk-2.0/gtk/gtkwidget.h:36, from /usr/include/gtk-2.0/gtk/gtkcontainer.h:35, from /usr/include/gtk-2.0/gtk/gtkbin.h:35, from /usr/include/gtk-2.0/gtk/gtkwindow.h:36, from /usr/include/gtk-2.0/gtk/gtkdialog.h:35, from /usr/include/gtk-2.0/gtk/gtkaboutdialog.h:32, from /usr/include/gtk-2.0/gtk/gtk.h:33, from /home/rli/PWEs/jfx/modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c:36: /usr/include/gtk-2.0/gtk/gtktypeutils.h:236:1: error: 'GTypeDebugFlags' is deprecated [-Werror=deprecated-declarations] 236 | void gtk_type_init (GTypeDebugFlags debug_flags); | ^~~~ In file included from /usr/include/glib-2.0/gobject/gobject.h:24, from /usr/include/glib-2.0/gobject/gbinding.h:29, from /usr/include/glib-2.0/glib-object.h:23, from /usr/include/glib-2.0/gio/gioenums.h:28, from /usr/include/glib-2.0/gio/giotypes.h:28, from /usr/include/glib-2.0/gio/gio.h:26, from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30, from /usr/include/gtk-2.0/gdk/gdk.h:32, from /usr/include/gtk-2.0/gtk/gtk.h:32, from /home/rli/PWEs/jfx/modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c:36: /usr/include/glib-2.0/gobject/gtype.h:679:1: note: declared here 679 | { | ^ In file included from /usr/include/gtk-2.0/gtk/gtktoolitem.h:31, from /usr/include/gtk-2.0/gtk/gtktoolbutton.h:30, from /usr/include/gtk-2.0/gtk/gtkmenutoolbutton.h:30, from /usr/include/gtk-2.0/gtk/gtk.h:126, from /home/rli/PWEs/jfx/modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c:36: /usr/include/gtk-2.0/gtk/gtktooltips.h:73:3: error: 'GTimeVal' is deprecated: Use 'GDateTime' instead [-Werror=deprecated-declarations] 73 | GTimeVal last_popdown; | ^~~~~~~~ In file included from /usr/include/glib-2.0/glib/galloca.h:32, from /usr/include/glib-2.0/glib.h:30, from /usr/include/glib-2.0/gobject/gbinding.h:28, from /usr/include/glib-2.0/glib-object.h:23, from /usr/include/glib-2.0/gio/gioenums.h:28, from /usr/include/glib-2.0/gio/giotypes.h:28, from /usr/include/glib-2.0/gio/gio.h:26, from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30, from /usr/include/gtk-2.0/gdk/gdk.h:32, from /usr/include/gtk-2.0/gtk/gtk.h:32, from /home/rli/PWEs/jfx/modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c:36: /usr/include/glib-2.0/glib/gtypes.h:551:8: note: declared here 551 | struct _GTimeVal | ^~~~~~~~~ ... Questions: * Should I open a bug for that? * How can I turn off -Werror to proceed with the local build for now. I thought there was something in https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX but I can't find it (anymore) Best regards, Robert From r.lichtenberger at gmail.com Fri Jan 10 08:52:02 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Fri, 10 Jan 2020 09:52:02 +0100 Subject: "Using an IDE" Page outdated Message-ID: I've noticed that https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE seems a bit outdated (refers to JDK 1.8, a folder named "rt", which no longer exists, etc.). Could someone please update this page so that it is easier for newcomers to dive into the development of OpenJFX. Thanks, Robert From kcr at openjdk.java.net Fri Jan 10 13:20:14 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 10 Jan 2020 13:20:14 GMT Subject: [Integrated] RFR: 8236733: Change JavaFX release version to 15 In-Reply-To: References: Message-ID: Changeset: a557dd95 Author: Kevin Rushforth Date: 2020-01-10 13:19:21 +0000 URL: https://git.openjdk.java.net/jfx/commit/a557dd95 8236733: Change JavaFX release version to 15 Reviewed-by: arapte ! build.properties ! modules/javafx.base/src/test/java/test/com/sun/javafx/runtime/VersionInfoTest.java From kevin.rushforth at oracle.com Fri Jan 10 15:52:35 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 10 Jan 2020 07:52:35 -0800 Subject: OpenJFX 14 is in Rampdown Phase One (RDP1) Message-ID: OpenJFX 14 is now in Rampdown Phase One (RDP1) [1]. We have forked a new jfx14 branch [2] for stabilizing the OpenJFX 14 release. Here is the short summary of what this means: - The master branch of the jfx repo is available for integrating bug fixes or enhancements for OpenJFX 15. Most fixes will be integrated to master for 15. - The jfx14 branch of the jfx repo is now open for integrating fixes for OpenJFX 14 that meet the RDP1 criteria as outlined below. - Reviewers and Committers now have an additional responsibility to verify the target branch of each pull request. - I will periodically sync jfx14 --> master, meaning that developers should integrate fixes to one or the other, not both DETAILS: P1-P3 bug fixes, and test or doc fixes of any priority are good candidates for integrating to jfx14 during RDP1. The only hard restriction is that enhancements need explicit approval, over and above the review of the PR, to go into jfx14. The bar for such approval is high: we do not anticipate approving any more enhancements. We also need to be careful to avoid potentially risky fixes during this time. Note that these restrictions apply to the jfx14 branch. The master branch is open for all openjfx15 fixes, including enhancements. With the switch to git for our official repo, we are now using a single openjdk/jfx GitHub repo with stabilization branches [3] rather than creating separate stabilization repos, which we used to do with Mercurial. The jfx14 branch of the openjdk/jfx git repo is conceptually the same as the 13-dev/rt HG repo that was used for stabilizing openjfx13, but the mechanics are slightly different, so please be aware, especially if you are a Reviewer or Committer in the Project. This change should make it much easier for developers (no need to clone from multiple repos), and will allow all pull requests to all be in the same place, but care needs to be taken for any PR that is targeted to jfx14 to ensure that it doesn't contain any commits from master after the jfx14 fork date. What that means is that if you intend a PR to be for jfx14, don't merge master into your local source branch. IMPORTANT: Reviewers and Committers now have an extra responsibility to double-check the target branch of each PR that they review, integrate, or sponsor. By default a PR will be targeted to `master` which is the main development line (OpenJFX 15 as of today). A PR should be targeted to `jfx14` if, and only if, it is intended for OpenJFX 14 and meets the criteria for the current rampdown phase (we're in RDP1 as of today). Reviewers are advised to be extra cautious in approving potentially risky fixes targeted to `jfx14`. If there is a concern, then a reviewer can as part of the review indicate that the PR should be retargeted to `master` for 15. Reviewers also need to be extra careful when reviewing PRs targeted to jfx14 that it doesn't mistakenly contain any commits from the master branch. You'll be able to tell because the diffs will contain changes that are not part of the fix being reviewed. Such a PR will either need to be closed and redone, or it will need to be rebased and force-pushed. We will use the same rules for RDP1 that the JDK uses [4], with the same three modifications we did for the previous release: 1. Approval is needed from one of the OpenJFX project leads (not the OpenJDK project lead) 2. Since we are not part of the JDK, we need to use labels that do not collide with the JDK 14 release. As an obvious choice, derived from the JBS fix version, we will use "openjfx14-enhancement-request", "openjfx14-enhancement-yes", "openjfx14-enhancement-no" and "openjfx14-enhancement-nmi" as corresponding labels. 3. No explicit approval (no JBS labels) is needed to integrate P4 bugs to jfx14 branch during RDP1, as long as those bugs have otherwise met the usual code review criteria. Having said that, most P4 bugs should now go into master for openjfx15, since we do not want to risk anything that would destabilize the openjfx14 release without a compelling reason. Also, we have less than 4 weeks until RDP2 of openjfx14 and we would be better served fixing higher priority bugs. Note that doc bugs and test bugs of any priority are fine to fix for openjfx14 during this time. Let me know if there are any questions. -- Kevin [1] https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-December/024331.html [2] https://github.com/openjdk/jfx/tree/jfx14 [3] https://github.com/openjdk/jfx/branches/all [4] http://openjdk.java.net/jeps/3 From nlisker at gmail.com Fri Jan 10 16:52:26 2020 From: nlisker at gmail.com (Nir Lisker) Date: Fri, 10 Jan 2020 18:52:26 +0200 Subject: "Using an IDE" Page outdated In-Reply-To: References: Message-ID: Hi Robert, I've brought this up in the past. I think that the best solution is for someone from the community to take that task. I try to keep the Eclipse section updated, we will need someone for the other IDE's. - Nir On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger < r.lichtenberger at gmail.com> wrote: > I've noticed that > https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE > seems a bit outdated (refers to JDK 1.8, a folder named "rt", which no > longer exists, etc.). > > Could someone please update this page so that it is easier for newcomers to > dive into the development of OpenJFX. > > Thanks, > Robert > From kevin.rushforth at oracle.com Fri Jan 10 17:01:46 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 10 Jan 2020 09:01:46 -0800 Subject: Retargeting JBS bugs to openjfx15 Message-ID: <78f23350-91d0-e87f-a5a5-c78eb3521527@oracle.com> Now that we are in RDP1 for openjfx14, it's time to move all enhancements and most P4-P5 bugs (excluding doc and test bugs) to openjfx15. I plan to do a bulk move for these bugs shortly. If an assignee of a particular P4 bug later wants to propose a PR for the jfx14 branch, and if the reviewers agree it is safe enough and worth getting in, then the JBS bug can have its fix version updated back to openjfx14. Additionally, many P3 bugs should be moved, but that can be done on a case-by-case basis. -- Kevin From nlisker at gmail.com Sat Jan 11 01:08:08 2020 From: nlisker at gmail.com (Nir Lisker) Date: Sat, 11 Jan 2020 03:08:08 +0200 Subject: Rate of embedded animations In-Reply-To: References: Message-ID: > > What happens if you set the rate of the parent transition and then set the > rate of a child animation? > What if you bind to the rate of a child animation? There is already some code that touches this in the Animation's rate property: public void invalidated() { final double newRate = getRate(); if (isRunningEmbedded()) { if (isBound()) { unbind(); } set(oldRate); throw new IllegalStateException("Cannot set rate of embedded animation while running."); } isRunningEmbedded checks for a parent animation that is not STOPPED. That means that the rate of a child animation can only change while the parent is stopped, but it is ignored (the child's ClipEnvelope's rate is updated to the parent's rate instead). Binding to the rate property is never an issue, but it does give meaningless results since the rate is ignored. Binding the rate property itself will cause it to be unbinded. If we go with option 1, which is almost the current situation, there is only some cleanup needed when it comes to the relation between the Animation's rate and its ClipEnvelope's rate. If we go with option 2, we can eliminate the duplication of rate in the Animation and the ClipEnvelope (though ClipEvenope to Animation is somewhat like a peer to a Node, which duplicates the values as well, so maybe we want that?). The children's rate will always be the parent's rate. In this case the above code should probably be modified to account for STOPPED parents as well. A bound rate property will be unbinded and setting it will be either ignored or throw an exception. I'll note that currentRate is eliminated from the ClipEnvelope in the fix I'm working on, but as it's read-only, it's a different story. As long as the implementation > is consistent in ignoring the rate property from the child Animation, > this seems like a fine solution and is consistent with other properties > where one property overrides another without modifying it. Which other properties? delay, autoReverse, and cycleCount all work separately on the parent and child. For example, if both parent and child have autoReverse = true and cycleCount = 2, the animation will play forwards, backwards, forwards, backwards, so both are taken into account. On Wed, Jan 8, 2020 at 1:14 AM Kevin Rushforth wrote: > A rate in a "parent" transition should probably override the rate in a > child Animation. There are a couple ways to do it, and it sounds like it > doesn't really implement it right. > > 1. The public rate property values of child Animations within a parent > Transition are ignored, but not updated. As long as the implementation > is consistent in ignoring the rate property from the child Animation, > this seems like a fine solution and is consistent with other properties > where one property overrides another without modifying it. > > 2. Setting a rate on the parent Transition actually modifies the child > node. This can work, but has more issues. What happens if you set the > rate of the parent tansition and then set the rate of a child animation? > What if you bind to the rate of a child animation? > > -- Kevin > > On 1/1/2020 1:04 PM, Nir Lisker wrote: > > Hi, > > > > As part of my work in the animations package I've come across an > undefined > > spec. Is the rate of an animation that is embedded in a > Parallel/Sequential > > transition inherited and overridden by its parent? > > > > If I have an animations with a rate of 1 and a parent with a rate of 2, > and > > I add the animation to the parent, does the rate property change from 1 > to > > 2 (generating a change/invalidation event etc.)? Then, should any > > subsequent changes to the parent's rate trigger a change in the child's > > rate? > > > > The implementation is a bit messy in this regard. The rate and > currentRate > > values exist in both Animation and its ClipEnvelope, which is the source > > for a couple of bugs. For example, changing the rate of a > > ParallelTransition changes the child's ClipEnvelope's rate and > currentRate, > > but only the animation's currentRate (and not rate). Is it supposed to be > > this way? > > > > What is clear is that it's not possible to change the rate of the > embedded > > animation directly. > > > > The docs do not talk about the rate of an embedded animation (they do > talk > > about the node property though). > > > > - Nir > > From nlisker at gmail.com Sat Jan 11 02:45:42 2020 From: nlisker at gmail.com (Nir Lisker) Date: Sat, 11 Jan 2020 04:45:42 +0200 Subject: Rate of embedded animations In-Reply-To: References: Message-ID: I forgot to bring up https://bugs.openjdk.java.net/browse/JDK-8200206, which is also relevant to this discussion. The solution to that one is probably allowing only 1 parent, similar to the scenegraph policy. That will avoid parent animations fighting over the state of common children animations. On Sat, Jan 11, 2020 at 3:08 AM Nir Lisker wrote: > What happens if you set the rate of the parent transition and then set the >> rate of a child animation? >> > What if you bind to the rate of a child animation? > > > There is already some code that touches this in the Animation's rate > property: > > public void invalidated() { > final double newRate = getRate(); > if (isRunningEmbedded()) { > if (isBound()) { > unbind(); > } > set(oldRate); > throw new IllegalStateException("Cannot set rate of embedded > animation while running."); > } > > isRunningEmbedded checks for a parent animation that is not STOPPED. That > means that the rate of a child animation can only change while the parent > is stopped, but it is ignored (the child's ClipEnvelope's rate is updated > to the parent's rate instead). > Binding to the rate property is never an issue, but it does give > meaningless results since the rate is ignored. Binding the rate property > itself will cause it to be unbinded. > > If we go with option 1, which is almost the current situation, there is > only some cleanup needed when it comes to the relation between the > Animation's rate and its ClipEnvelope's rate. > > If we go with option 2, we can eliminate the duplication of rate in the > Animation and the ClipEnvelope (though ClipEvenope to Animation is somewhat > like a peer to a Node, which duplicates the values as well, so maybe we > want that?). The children's rate will always be the parent's rate. In this > case the above code should probably be modified to account for STOPPED > parents as well. A bound rate property will be unbinded and setting it will > be either ignored or throw an exception. > > I'll note that currentRate is eliminated from the ClipEnvelope in the fix > I'm working on, but as it's read-only, it's a different story. > > As long as the implementation >> is consistent in ignoring the rate property from the child Animation, >> this seems like a fine solution and is consistent with other properties >> where one property overrides another without modifying it. > > > Which other properties? delay, autoReverse, and cycleCount all work > separately on the parent and child. For example, if both parent and child > have autoReverse = true and cycleCount = 2, the animation will play > forwards, backwards, forwards, backwards, so both are taken into account. > > > On Wed, Jan 8, 2020 at 1:14 AM Kevin Rushforth > wrote: > >> A rate in a "parent" transition should probably override the rate in a >> child Animation. There are a couple ways to do it, and it sounds like it >> doesn't really implement it right. >> >> 1. The public rate property values of child Animations within a parent >> Transition are ignored, but not updated. As long as the implementation >> is consistent in ignoring the rate property from the child Animation, >> this seems like a fine solution and is consistent with other properties >> where one property overrides another without modifying it. >> >> 2. Setting a rate on the parent Transition actually modifies the child >> node. This can work, but has more issues. What happens if you set the >> rate of the parent tansition and then set the rate of a child animation? >> What if you bind to the rate of a child animation? >> >> -- Kevin >> >> On 1/1/2020 1:04 PM, Nir Lisker wrote: >> > Hi, >> > >> > As part of my work in the animations package I've come across an >> undefined >> > spec. Is the rate of an animation that is embedded in a >> Parallel/Sequential >> > transition inherited and overridden by its parent? >> > >> > If I have an animations with a rate of 1 and a parent with a rate of 2, >> and >> > I add the animation to the parent, does the rate property change from 1 >> to >> > 2 (generating a change/invalidation event etc.)? Then, should any >> > subsequent changes to the parent's rate trigger a change in the child's >> > rate? >> > >> > The implementation is a bit messy in this regard. The rate and >> currentRate >> > values exist in both Animation and its ClipEnvelope, which is the source >> > for a couple of bugs. For example, changing the rate of a >> > ParallelTransition changes the child's ClipEnvelope's rate and >> currentRate, >> > but only the animation's currentRate (and not rate). Is it supposed to >> be >> > this way? >> > >> > What is clear is that it's not possible to change the rate of the >> embedded >> > animation directly. >> > >> > The docs do not talk about the rate of an embedded animation (they do >> talk >> > about the node property though). >> > >> > - Nir >> >> From kcr at openjdk.java.net Sat Jan 11 17:53:55 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Sat, 11 Jan 2020 17:53:55 GMT Subject: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one In-Reply-To: References: Message-ID: On Tue, 7 Jan 2020 09:46:03 GMT, Ambarish Rapte wrote: > This PR is a fix for [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) > This issue is regression of [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). > > Issue. > - `Parent.viewOrderChildren` is a list of children sorted according to view order. > - `Parent.viewOrderChildren` is cleared and computed in `Parent.computeViewOrderChildren()` which is called from `Parent.doUpdatePeer()` when a `pulse `is received. > > - Below is the scenario mentioned in this issue, > 1. `TabPane` is created with few `tabs`. > 2. For each tab, a `TabHeaderSkin` is created with `setViewOrder(1)` and is added to `TabHeaderArea.headersRegion` > 3. All these `TabHeaderSkin`s are added to `Parent.viewOrderChildren` on `pulse`. > 4. When the `TabPane` is removed from scene, then on the next pulse the method `Parent.doUpdatePeer()` does not get called for `TabHeaderArea.headersRegion`, because it is not part for scenegraph anymore. > So `Parent.computeViewOrderChildren()` does not get called and the `Parent.viewOrderChildren` does not get cleared, which causes the leak. > > Fix: > Clear the `Parent.viewOrderChildren` list when marking `DirtyBits.PARENT_CHILDREN_VIEW_ORDER` as dirty. > `Parent.viewOrderChildren` will be computed on next `pulse`. > This will maintain lazy computation of `Parent.viewOrderChildren`. > > Added a system test, fails without fix and passes with. No failures in existing tests. @arapte - This bug looks like a good candidate for JavaFX 14. Can you retarget this PR to the jfx14 branch? ------------- PR: https://git.openjdk.java.net/jfx/pull/79 From tsayao at openjdk.java.net Sun Jan 12 01:00:42 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Sun, 12 Jan 2020 01:00:42 GMT Subject: [Rev 08] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - 9850bb71: Fix dialog with owner sizing Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/209b7ac7..9850bb71 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.08 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.07-08 Stats: 7 lines in 1 file changed: 0 ins; 3 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From tsayao at openjdk.java.net Sun Jan 12 01:28:47 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Sun, 12 Jan 2020 01:28:47 GMT Subject: [Rev 09] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: <_76aIZTlPIWQOheXR83SrgOL-lYXe4pWvfPNSS0Dgrk=.4ac927c8-d489-4fdb-939a-b40ab069f54e@github.com> > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - f99aebcf: Maybe fix background Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/9850bb71..f99aebcf Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.09 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.08-09 Stats: 12 lines in 1 file changed: 6 ins; 5 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From tsayao at openjdk.java.net Sun Jan 12 21:11:59 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Sun, 12 Jan 2020 21:11:59 GMT Subject: [Rev 10] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - f35fa9b1: Big cleanup Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/f99aebcf..f35fa9b1 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.10 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.09-10 Stats: 1836 lines in 5 files changed: 634 ins; 765 del; 437 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From abhinay_agarwal at live.com Mon Jan 13 05:45:22 2020 From: abhinay_agarwal at live.com (Abhinay Agarwal) Date: Mon, 13 Jan 2020 05:45:22 +0000 Subject: Maximized undecorated stage In-Reply-To: <81781b6e-63c9-7fed-da3e-690afd0fe97d@oracle.com> References: , <81781b6e-63c9-7fed-da3e-690afd0fe97d@oracle.com> Message-ID: Hi Kevin, Sounds logical. I will file an issue in the JBS. Best regards, Abhinay ________________________________ From: openjfx-dev on behalf of Kevin Rushforth Sent: Wednesday, January 8, 2020 4:36 AM To: openjfx-dev at openjdk.java.net Subject: Re: Maximized undecorated stage Ideally, we wouldn't have this sort of platform-specific behavior. I can see why the underlying platform might not support the concept of maximizing an undecorated stage, so we either need to disable it on Windows, live with the behavior, or else find some solution on macOS and Linux. -- Kevin On 1/6/2020 1:43 AM, Abhinay Agarwal wrote: > Hi, > > If maximize property is set to true for an undecorated Stage, the following behaviour is observed on different platforms: > > * Windows: Undecorated stage is maximized > * MacOS: Undecorated stage is not maximized > * Linux(Ubuntu): Undecorated stage is not maximized > > The following piece of code can be used to reproduce the behaviour: > > import javafx.application.Application; > import javafx.scene.Scene; > import javafx.scene.control.Label; > import javafx.scene.layout.StackPane; > import javafx.stage.Stage; > import javafx.stage.StageStyle; > > public class MaximizedStage extends Application { > public void start (Stage stage) { > StackPane sp = new StackPane(new Label("Hello")); > stage.setScene(new Scene (sp, 500, 500)); > stage.initStyle(StageStyle.UNDECORATED); > stage.show(); > stage.setMaximized(true); > } > } > > Is there a reason why the stage gets maximized on Windows but fails on other platforms? > > Regards, > Abhinay From thiago.sayao at clamed.com.br Mon Jan 13 11:52:41 2020 From: thiago.sayao at clamed.com.br (Thiago Milczarek Sayao) Date: Mon, 13 Jan 2020 11:52:41 +0000 Subject: [Rev 08] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com>, Message-ID: Hello users of this list. While fixing some bugs on glass-gtk backend I had some noticed some quite complex logic to mimic windows behavior on linux - for example, on linux window decorations are a job do the window manager - which may vary. So window sizes does not account decorations. Also, the gtk2 -> gtk3 migration could use some improvement because gtk3 does a lot of "deprecations" - even inside the gtk3 release cycle. There was a lot of code regarding applets and web start, which are discontinued. So this PR simplifies te code (specially sizing a positioning of windows), updates to gtk3 recent changes (while being compatible with older releases) and removes web start / applet code. It also eliminates some restrictions on DND. It will work with all text formats and all image formats that both gtk and javafx supports. It's working very well. So if anyone is willing to test, or take a look. I need to do more testing on: * Mouse grabs to mimic windows behavior; * Native _setBackground call Any pointers on uses cases for this is appreciated. Cheers. ________________________________ De: openjfx-dev em nome de Thiago Milczarek Sayao Enviado: s?bado, 11 de janeiro de 2020 22:00 Para: openjfx-dev at openjdk.java.net Assunto: Re: [Rev 08] RFR: WIP: 8236651: Simplify and update glass gtk backend > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > > > In general it reduces code size and complexity and hands more work to gtk. > > Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - 9850bb71: Fix dialog with owner sizing Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/209b7ac7..9850bb71 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.08 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.07-08 Stats: 7 lines in 1 file changed: 0 ins; 3 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From arapte at openjdk.java.net Mon Jan 13 16:49:57 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Mon, 13 Jan 2020 16:49:57 GMT Subject: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one In-Reply-To: References: Message-ID: On Mon, 13 Jan 2020 16:49:40 GMT, Kevin Rushforth wrote: >> @arapte - This bug looks like a good candidate for JavaFX 14. Can you retarget this PR to the jfx14 branch? > > This will need a second reviewer. > > @aghaisas can you review this, too? > > > @arapte - This bug looks like a good candidate for JavaFX 14. Can you retarget this PR to the jfx14 branch? Thanks for guiding Kevin, PR is now targeted to jfx14. ------------- PR: https://git.openjdk.java.net/jfx/pull/79 From kcr at openjdk.java.net Mon Jan 13 16:49:57 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 13 Jan 2020 16:49:57 GMT Subject: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one In-Reply-To: References: Message-ID: On Sat, 11 Jan 2020 17:53:40 GMT, Kevin Rushforth wrote: >> This PR is a fix for [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) >> This issue is regression of [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). >> >> Issue. >> - `Parent.viewOrderChildren` is a list of children sorted according to view order. >> - `Parent.viewOrderChildren` is cleared and computed in `Parent.computeViewOrderChildren()` which is called from `Parent.doUpdatePeer()` when a `pulse `is received. >> >> - Below is the scenario mentioned in this issue, >> 1. `TabPane` is created with few `tabs`. >> 2. For each tab, a `TabHeaderSkin` is created with `setViewOrder(1)` and is added to `TabHeaderArea.headersRegion` >> 3. All these `TabHeaderSkin`s are added to `Parent.viewOrderChildren` on `pulse`. >> 4. When the `TabPane` is removed from scene, then on the next pulse the method `Parent.doUpdatePeer()` does not get called for `TabHeaderArea.headersRegion`, because it is not part for scenegraph anymore. >> So `Parent.computeViewOrderChildren()` does not get called and the `Parent.viewOrderChildren` does not get cleared, which causes the leak. >> >> Fix: >> Clear the `Parent.viewOrderChildren` list when marking `DirtyBits.PARENT_CHILDREN_VIEW_ORDER` as dirty. >> `Parent.viewOrderChildren` will be computed on next `pulse`. >> This will maintain lazy computation of `Parent.viewOrderChildren`. >> >> Added a system test, fails without fix and passes with. No failures in existing tests. > > @arapte - This bug looks like a good candidate for JavaFX 14. Can you retarget this PR to the jfx14 branch? This will need a second reviewer. @aghaisas can you review this, too? ------------- PR: https://git.openjdk.java.net/jfx/pull/79 From nlisker at gmail.com Mon Jan 13 16:59:03 2020 From: nlisker at gmail.com (Nir Lisker) Date: Mon, 13 Jan 2020 18:59:03 +0200 Subject: "Using an IDE" Page outdated In-Reply-To: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> Message-ID: Never seen this problem before. Did you run a Gradle build? [1] It needs to generated required resources. Also, the Eclipse files for some projects are not updated (though for the modules they are fine, so it's not the problem you are having). My patch for them was pending review by other Eclipse users and no one tested it, so if you are up for it I could resume work on it. - Nir [1] https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-BuildandTest On Mon, Jan 13, 2020 at 5:35 PM Robert Lichtenberger < r.lichtenberger at synedra.com> wrote: > Hmm. Eclipse would suit me fine, so I've tried to import a current OpenJFX > repository to Eclipse but it gives me (among others) this error: > > Description Resource Path Location Type > Cannot nest > 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main/javafx.base' > inside library > 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main' base > Build path Build Path Problem > > The Workspace was completely new, all the other stuff (JDK 12, Java > Compiliance Level) should be ok. > > Do you have any idea what is going wrong here? Smells like module system > problems :-(. > > > Best regards, > > Robert > On 2020-01-10 17:52, Nir Lisker wrote: > > Hi Robert, > > I've brought this up in the past. > > I think that the best solution is for someone from the community to take > that task. I try to keep the Eclipse section updated, we will need someone > for the other IDE's. > > - Nir > > On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger < > r.lichtenberger at gmail.com> wrote: > >> I've noticed that >> https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE >> seems a bit outdated (refers to JDK 1.8, a folder named "rt", which no >> longer exists, etc.). >> >> Could someone please update this page so that it is easier for newcomers >> to >> dive into the development of OpenJFX. >> >> Thanks, >> Robert >> > From tsayao at openjdk.java.net Tue Jan 14 01:05:48 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Tue, 14 Jan 2020 01:05:48 GMT Subject: [Rev 11] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > - Removes Applet/Web Start code. > > In general it reduces code size and complexity and hands more work to gtk. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - 4b555624: Allow undecorated windows to be maximized. Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/f35fa9b1..4b555624 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.11 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.10-11 Stats: 20 lines in 2 files changed: 13 ins; 3 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From thiago.sayao at clamed.com.br Tue Jan 14 01:06:54 2020 From: thiago.sayao at clamed.com.br (Thiago Milczarek Sayao) Date: Tue, 14 Jan 2020 01:06:54 +0000 Subject: Maximized undecorated stage In-Reply-To: References: , <81781b6e-63c9-7fed-da3e-690afd0fe97d@oracle.com>, Message-ID: I have fixed it on Linux: https://github.com/openjdk/jfx/pull/77 Can be ported to the current code: void WindowContext::set_maximized(bool maximize) { is_maximized = maximize; if (maximize) { // enable the functionality GdkWMFunction wmf = (GdkWMFunction)(gdk_windowManagerFunctions | GDK_FUNC_MAXIMIZE); gdk_window_set_functions(gdk_window, wmf); gtk_window_maximize(GTK_WINDOW(gtk_widget)); } else { gtk_window_unmaximize(GTK_WINDOW(gtk_widget)); } } ________________________________ De: openjfx-dev em nome de Abhinay Agarwal Enviado: segunda-feira, 13 de janeiro de 2020 02:45 Para: Kevin Rushforth ; openjfx-dev at openjdk.java.net Assunto: Re: Maximized undecorated stage Hi Kevin, Sounds logical. I will file an issue in the JBS. Best regards, Abhinay ________________________________ From: openjfx-dev on behalf of Kevin Rushforth Sent: Wednesday, January 8, 2020 4:36 AM To: openjfx-dev at openjdk.java.net Subject: Re: Maximized undecorated stage Ideally, we wouldn't have this sort of platform-specific behavior. I can see why the underlying platform might not support the concept of maximizing an undecorated stage, so we either need to disable it on Windows, live with the behavior, or else find some solution on macOS and Linux. -- Kevin On 1/6/2020 1:43 AM, Abhinay Agarwal wrote: > Hi, > > If maximize property is set to true for an undecorated Stage, the following behaviour is observed on different platforms: > > * Windows: Undecorated stage is maximized > * MacOS: Undecorated stage is not maximized > * Linux(Ubuntu): Undecorated stage is not maximized > > The following piece of code can be used to reproduce the behaviour: > > import javafx.application.Application; > import javafx.scene.Scene; > import javafx.scene.control.Label; > import javafx.scene.layout.StackPane; > import javafx.stage.Stage; > import javafx.stage.StageStyle; > > public class MaximizedStage extends Application { > public void start (Stage stage) { > StackPane sp = new StackPane(new Label("Hello")); > stage.setScene(new Scene (sp, 500, 500)); > stage.initStyle(StageStyle.UNDECORATED); > stage.show(); > stage.setMaximized(true); > } > } > > Is there a reason why the stage gets maximized on Windows but fails on other platforms? > > Regards, > Abhinay From r.lichtenberger at gmail.com Tue Jan 14 07:12:21 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Tue, 14 Jan 2020 08:12:21 +0100 Subject: "Using an IDE" Page outdated In-Reply-To: References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> Message-ID: Yes, I did run a gradle build (for which I had to tweak buildSrc/linux.gradle to ignore some deprecations -- see my other post to the list) successfully. I use a completely fresh workspace, updated my JFX sources, I use Eclipse 2019-12 and jdk-13.0.1+9 on Fedora 31. These are my steps: * open eclipse, * choose "Import projects" then "Gradle" -> "Existing Gradle project" * give the top level folder of my repository (/home/rli/PWEs/jfx in my case) * Use the gradle wrapper (i.e. no changes on the wizards next page) * The project structure is given correctly, so I click finish Eclipse then loads the projects but gives out the aforementioned error. I've made a 1-minute video clip showing my steps: https://youtu.be/S9WnOHCbWLI I'll try to find out what is going wrong here. Could you tell me which versions (JFX sources, Eclipse, JDK) you are using? Am Mo., 13. Jan. 2020 um 17:59 Uhr schrieb Nir Lisker : > Never seen this problem before. Did you run a Gradle build? [1] It needs to > generated required resources. > > Also, the Eclipse files for some projects are not updated (though for the > modules they are fine, so it's not the problem you are having). My patch > for them was pending review by other Eclipse users and no one tested it, so > if you are up for it I could resume work on it. > > - Nir > > [1] > > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-BuildandTest > > On Mon, Jan 13, 2020 at 5:35 PM Robert Lichtenberger < > r.lichtenberger at synedra.com> wrote: > > > Hmm. Eclipse would suit me fine, so I've tried to import a current > OpenJFX > > repository to Eclipse but it gives me (among others) this error: > > > > Description Resource Path Location Type > > Cannot nest > > > 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main/javafx.base' > > inside library > > 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main' base > > Build path Build Path Problem > > > > The Workspace was completely new, all the other stuff (JDK 12, Java > > Compiliance Level) should be ok. > > > > Do you have any idea what is going wrong here? Smells like module system > > problems :-(. > > > > > > Best regards, > > > > Robert > > On 2020-01-10 17:52, Nir Lisker wrote: > > > > Hi Robert, > > > > I've brought this up in the past. > > > > I think that the best solution is for someone from the community to take > > that task. I try to keep the Eclipse section updated, we will need > someone > > for the other IDE's. > > > > - Nir > > > > On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger < > > r.lichtenberger at gmail.com> wrote: > > > >> I've noticed that > >> https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE > >> seems a bit outdated (refers to JDK 1.8, a folder named "rt", which no > >> longer exists, etc.). > >> > >> Could someone please update this page so that it is easier for newcomers > >> to > >> dive into the development of OpenJFX. > >> > >> Thanks, > >> Robert > >> > > > From tom.schindl at bestsolution.at Tue Jan 14 07:53:26 2020 From: tom.schindl at bestsolution.at (Tom Schindl) Date: Tue, 14 Jan 2020 08:53:26 +0100 Subject: "Using an IDE" Page outdated In-Reply-To: References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> Message-ID: <2b78ec0d-b6c1-ca1b-cb0e-e7a8bbe79e7a@bestsolution.at> Hi, I think Nir nor I uses them as gradle Projects because you have the .classpath, .project, ... . Tom On 14.01.20 08:12, Robert Lichtenberger wrote: > Yes, I did run a gradle build (for which I had to tweak > buildSrc/linux.gradle to ignore some deprecations -- see my other post to > the list) successfully. > > I use a completely fresh workspace, updated my JFX sources, I use Eclipse > 2019-12 and jdk-13.0.1+9 on Fedora 31. > > These are my steps: > * open eclipse, > * choose "Import projects" then "Gradle" -> "Existing Gradle project" > * give the top level folder of my repository (/home/rli/PWEs/jfx in my case) > * Use the gradle wrapper (i.e. no changes on the wizards next page) > * The project structure is given correctly, so I click finish > > Eclipse then loads the projects but gives out the aforementioned error. > > I've made a 1-minute video clip showing my steps: > https://youtu.be/S9WnOHCbWLI > > I'll try to find out what is going wrong here. Could you tell me which > versions (JFX sources, Eclipse, JDK) you are using? > > > Am Mo., 13. Jan. 2020 um 17:59 Uhr schrieb Nir Lisker : > >> Never seen this problem before. Did you run a Gradle build? [1] It needs to >> generated required resources. >> >> Also, the Eclipse files for some projects are not updated (though for the >> modules they are fine, so it's not the problem you are having). My patch >> for them was pending review by other Eclipse users and no one tested it, so >> if you are up for it I could resume work on it. >> >> - Nir >> >> [1] >> >> https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-BuildandTest >> >> On Mon, Jan 13, 2020 at 5:35 PM Robert Lichtenberger < >> r.lichtenberger at synedra.com> wrote: >> >>> Hmm. Eclipse would suit me fine, so I've tried to import a current >> OpenJFX >>> repository to Eclipse but it gives me (among others) this error: >>> >>> Description Resource Path Location Type >>> Cannot nest >>> >> 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main/javafx.base' >>> inside library >>> 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main' base >>> Build path Build Path Problem >>> >>> The Workspace was completely new, all the other stuff (JDK 12, Java >>> Compiliance Level) should be ok. >>> >>> Do you have any idea what is going wrong here? Smells like module system >>> problems :-(. >>> >>> >>> Best regards, >>> >>> Robert >>> On 2020-01-10 17:52, Nir Lisker wrote: >>> >>> Hi Robert, >>> >>> I've brought this up in the past. >>> >>> I think that the best solution is for someone from the community to take >>> that task. I try to keep the Eclipse section updated, we will need >> someone >>> for the other IDE's. >>> >>> - Nir >>> >>> On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger < >>> r.lichtenberger at gmail.com> wrote: >>> >>>> I've noticed that >>>> https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE >>>> seems a bit outdated (refers to JDK 1.8, a folder named "rt", which no >>>> longer exists, etc.). >>>> >>>> Could someone please update this page so that it is easier for newcomers >>>> to >>>> dive into the development of OpenJFX. >>>> >>>> Thanks, >>>> Robert >>>> >>> >> -- Tom Schindl, CTO BestSolution.at EDV Systemhaus GmbH Salurnerstrasse 15. A-6020 Innsbruck Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck From r.lichtenberger at gmail.com Tue Jan 14 08:11:36 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Tue, 14 Jan 2020 09:11:36 +0100 Subject: "Using an IDE" Page outdated In-Reply-To: <2b78ec0d-b6c1-ca1b-cb0e-e7a8bbe79e7a@bestsolution.at> References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> <2b78ec0d-b6c1-ca1b-cb0e-e7a8bbe79e7a@bestsolution.at> Message-ID: I've tried to import using "General" -> "Existing Projects in Workspace" but get lots of errors as well. When reducing the imported projects to base, graphics and controls: * base is ok * graphics has these errors: Description Resource Path Location Type Project 'graphics' is missing required source folder: 'build/hlsl/Decora' graphics Build path Build Path Problem Project 'graphics' is missing required source folder: 'build/hlsl/Prism' graphics Build path Build Path Problem * controls won't build due to errors in graphics Is hlsl the "High Level Shading Language" which may be specific to Windows? Am Di., 14. Jan. 2020 um 08:53 Uhr schrieb Tom Schindl < tom.schindl at bestsolution.at>: > Hi, > > I think Nir nor I uses them as gradle Projects because you have the > .classpath, .project, ... . > > Tom > > On 14.01.20 08:12, Robert Lichtenberger wrote: > > Yes, I did run a gradle build (for which I had to tweak > > buildSrc/linux.gradle to ignore some deprecations -- see my other post to > > the list) successfully. > > > > I use a completely fresh workspace, updated my JFX sources, I use Eclipse > > 2019-12 and jdk-13.0.1+9 on Fedora 31. > > > > These are my steps: > > * open eclipse, > > * choose "Import projects" then "Gradle" -> "Existing Gradle project" > > * give the top level folder of my repository (/home/rli/PWEs/jfx in my > case) > > * Use the gradle wrapper (i.e. no changes on the wizards next page) > > * The project structure is given correctly, so I click finish > > > > Eclipse then loads the projects but gives out the aforementioned error. > > > > I've made a 1-minute video clip showing my steps: > > https://youtu.be/S9WnOHCbWLI > > > > I'll try to find out what is going wrong here. Could you tell me which > > versions (JFX sources, Eclipse, JDK) you are using? > > > > > > Am Mo., 13. Jan. 2020 um 17:59 Uhr schrieb Nir Lisker >: > > > >> Never seen this problem before. Did you run a Gradle build? [1] It > needs to > >> generated required resources. > >> > >> Also, the Eclipse files for some projects are not updated (though for > the > >> modules they are fine, so it's not the problem you are having). My patch > >> for them was pending review by other Eclipse users and no one tested > it, so > >> if you are up for it I could resume work on it. > >> > >> - Nir > >> > >> [1] > >> > >> > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-BuildandTest > >> > >> On Mon, Jan 13, 2020 at 5:35 PM Robert Lichtenberger < > >> r.lichtenberger at synedra.com> wrote: > >> > >>> Hmm. Eclipse would suit me fine, so I've tried to import a current > >> OpenJFX > >>> repository to Eclipse but it gives me (among others) this error: > >>> > >>> Description Resource Path Location Type > >>> Cannot nest > >>> > >> > 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main/javafx.base' > >>> inside library > >>> 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main' base > >>> Build path Build Path Problem > >>> > >>> The Workspace was completely new, all the other stuff (JDK 12, Java > >>> Compiliance Level) should be ok. > >>> > >>> Do you have any idea what is going wrong here? Smells like module > system > >>> problems :-(. > >>> > >>> > >>> Best regards, > >>> > >>> Robert > >>> On 2020-01-10 17:52, Nir Lisker wrote: > >>> > >>> Hi Robert, > >>> > >>> I've brought this up in the past. > >>> > >>> I think that the best solution is for someone from the community to > take > >>> that task. I try to keep the Eclipse section updated, we will need > >> someone > >>> for the other IDE's. > >>> > >>> - Nir > >>> > >>> On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger < > >>> r.lichtenberger at gmail.com> wrote: > >>> > >>>> I've noticed that > >>>> https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE > >>>> seems a bit outdated (refers to JDK 1.8, a folder named "rt", which no > >>>> longer exists, etc.). > >>>> > >>>> Could someone please update this page so that it is easier for > newcomers > >>>> to > >>>> dive into the development of OpenJFX. > >>>> > >>>> Thanks, > >>>> Robert > >>>> > >>> > >> > > -- > Tom Schindl, CTO > BestSolution.at EDV Systemhaus GmbH > Salurnerstrasse 15. A-6020 Innsbruck > Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck > From nlisker at gmail.com Tue Jan 14 08:22:56 2020 From: nlisker at gmail.com (Nir Lisker) Date: Tue, 14 Jan 2020 10:22:56 +0200 Subject: "Using an IDE" Page outdated In-Reply-To: References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> <2b78ec0d-b6c1-ca1b-cb0e-e7a8bbe79e7a@bestsolution.at> Message-ID: I think your errors come from the note under "Using Gradle" in the Eclipse instructions. Gradle doesn't know how to create the correct Eclipse files, so it overrides the ones in the repo with its incorrect ones. Try to revert the changes to .project and .classpath files. You might still get a few errors when looking for external jars because the root project name is different, but these are trivial to fix. The base modules should have no errors at the very least. I should update the instructions to talk about the new repository since the current ones still mention mercurial. Is hlsl the "High Level Shading Language" which may be specific to Windows? Yes, but it should be ignored on non-Windows systems. I will have to recheck if there's any issue on Linux next time I boot into it, I don't remember any issues there. > > On Tue, Jan 14, 2020 at 10:12 AM Robert Lichtenberger < r.lichtenberger at gmail.com> wrote: > I've tried to import using "General" -> "Existing Projects in Workspace" > but get lots of errors as well. When reducing the imported projects to > base, graphics and controls: > * base is ok > * graphics has these errors: > Description Resource Path Location Type > Project 'graphics' is missing required source folder: 'build/hlsl/Decora' > graphics Build path Build Path Problem > Project 'graphics' is missing required source folder: 'build/hlsl/Prism' > graphics Build path Build Path Problem > * controls won't build due to errors in graphics > > Is hlsl the "High Level Shading Language" which may be specific to Windows? > > Am Di., 14. Jan. 2020 um 08:53 Uhr schrieb Tom Schindl < > tom.schindl at bestsolution.at>: > > > Hi, > > > > I think Nir nor I uses them as gradle Projects because you have the > > .classpath, .project, ... . > > > > Tom > > > > On 14.01.20 08:12, Robert Lichtenberger wrote: > > > Yes, I did run a gradle build (for which I had to tweak > > > buildSrc/linux.gradle to ignore some deprecations -- see my other post > to > > > the list) successfully. > > > > > > I use a completely fresh workspace, updated my JFX sources, I use > Eclipse > > > 2019-12 and jdk-13.0.1+9 on Fedora 31. > > > > > > These are my steps: > > > * open eclipse, > > > * choose "Import projects" then "Gradle" -> "Existing Gradle project" > > > * give the top level folder of my repository (/home/rli/PWEs/jfx in my > > case) > > > * Use the gradle wrapper (i.e. no changes on the wizards next page) > > > * The project structure is given correctly, so I click finish > > > > > > Eclipse then loads the projects but gives out the aforementioned error. > > > > > > I've made a 1-minute video clip showing my steps: > > > https://youtu.be/S9WnOHCbWLI > > > > > > I'll try to find out what is going wrong here. Could you tell me which > > > versions (JFX sources, Eclipse, JDK) you are using? > > > > > > > > > Am Mo., 13. Jan. 2020 um 17:59 Uhr schrieb Nir Lisker < > nlisker at gmail.com > > >: > > > > > >> Never seen this problem before. Did you run a Gradle build? [1] It > > needs to > > >> generated required resources. > > >> > > >> Also, the Eclipse files for some projects are not updated (though for > > the > > >> modules they are fine, so it's not the problem you are having). My > patch > > >> for them was pending review by other Eclipse users and no one tested > > it, so > > >> if you are up for it I could resume work on it. > > >> > > >> - Nir > > >> > > >> [1] > > >> > > >> > > > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-BuildandTest > > >> > > >> On Mon, Jan 13, 2020 at 5:35 PM Robert Lichtenberger < > > >> r.lichtenberger at synedra.com> wrote: > > >> > > >>> Hmm. Eclipse would suit me fine, so I've tried to import a current > > >> OpenJFX > > >>> repository to Eclipse but it gives me (among others) this error: > > >>> > > >>> Description Resource Path Location Type > > >>> Cannot nest > > >>> > > >> > > > 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main/javafx.base' > > >>> inside library > > >>> 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main' > base > > >>> Build path Build Path Problem > > >>> > > >>> The Workspace was completely new, all the other stuff (JDK 12, Java > > >>> Compiliance Level) should be ok. > > >>> > > >>> Do you have any idea what is going wrong here? Smells like module > > system > > >>> problems :-(. > > >>> > > >>> > > >>> Best regards, > > >>> > > >>> Robert > > >>> On 2020-01-10 17:52, Nir Lisker wrote: > > >>> > > >>> Hi Robert, > > >>> > > >>> I've brought this up in the past. > > >>> > > >>> I think that the best solution is for someone from the community to > > take > > >>> that task. I try to keep the Eclipse section updated, we will need > > >> someone > > >>> for the other IDE's. > > >>> > > >>> - Nir > > >>> > > >>> On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger < > > >>> r.lichtenberger at gmail.com> wrote: > > >>> > > >>>> I've noticed that > > >>>> https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE > > >>>> seems a bit outdated (refers to JDK 1.8, a folder named "rt", which > no > > >>>> longer exists, etc.). > > >>>> > > >>>> Could someone please update this page so that it is easier for > > newcomers > > >>>> to > > >>>> dive into the development of OpenJFX. > > >>>> > > >>>> Thanks, > > >>>> Robert > > >>>> > > >>> > > >> > > > > -- > > Tom Schindl, CTO > > BestSolution.at EDV Systemhaus GmbH > > Salurnerstrasse 15. A-6020 Innsbruck > > Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck > > > From tom.schindl at bestsolution.at Tue Jan 14 08:23:42 2020 From: tom.schindl at bestsolution.at (Tom Schindl) Date: Tue, 14 Jan 2020 09:23:42 +0100 Subject: "Using an IDE" Page outdated In-Reply-To: References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> <2b78ec0d-b6c1-ca1b-cb0e-e7a8bbe79e7a@bestsolution.at> Message-ID: Well those are created by the build not? I have to confess, that I did not setup Eclipse for OpenJFX-Development lately but I'm fairly certain those directories are generated by the build. Tom On 14.01.20 09:11, Robert Lichtenberger wrote: > I've tried to import using "General" -> "Existing Projects in Workspace" > but get lots of errors as well. When reducing the imported projects to > base, graphics and controls: > * base is ok > * graphics has these errors: > Description Resource Path Location Type > Project 'graphics' is missing required source folder: > 'build/hlsl/Decora' graphics Build path Build Path Problem > Project 'graphics' is missing required source folder: 'build/hlsl/Prism' > graphics Build path Build Path Problem > * controls won't build due to errors in graphics > > Is hlsl the "High Level Shading Language" which may be specific to Windows? > > Am Di., 14. Jan. 2020 um 08:53?Uhr schrieb Tom Schindl > >: > > Hi, > > I think Nir nor I uses them as gradle Projects because you have the > .classpath, .project, ... . > > Tom > > On 14.01.20 08:12, Robert Lichtenberger wrote: > > Yes, I did run a gradle build (for which I had to tweak > > buildSrc/linux.gradle to ignore some deprecations -- see my other > post to > > the list) successfully. > > > > I use a completely fresh workspace, updated my JFX sources, I use > Eclipse > > 2019-12 and jdk-13.0.1+9 on Fedora 31. > > > > These are my steps: > > * open eclipse, > > * choose "Import projects" then "Gradle" -> "Existing Gradle project" > > * give the top level folder of my repository (/home/rli/PWEs/jfx > in my case) > > * Use the gradle wrapper (i.e. no changes on the wizards next page) > > * The project structure is given correctly, so I click finish > > > > Eclipse then loads the projects but gives out the aforementioned > error. > > > > I've made a 1-minute video clip showing my steps: > > https://youtu.be/S9WnOHCbWLI > > > > I'll try to find out what is going wrong here. Could you tell me which > > versions (JFX sources, Eclipse, JDK) you are using? > > > > > > Am Mo., 13. Jan. 2020 um 17:59 Uhr schrieb Nir Lisker > >: > > > >> Never seen this problem before. Did you run a Gradle build? [1] > It needs to > >> generated required resources. > >> > >> Also, the Eclipse files for some projects are not updated (though > for the > >> modules they are fine, so it's not the problem you are having). > My patch > >> for them was pending review by other Eclipse users and no one > tested it, so > >> if you are up for it I could resume work on it. > >> > >> - Nir > >> > >> [1] > >> > >> > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-BuildandTest > >> > >> On Mon, Jan 13, 2020 at 5:35 PM Robert Lichtenberger < > >> r.lichtenberger at synedra.com > > wrote: > >> > >>> Hmm. Eclipse would suit me fine, so I've tried to import a current > >> OpenJFX > >>> repository to Eclipse but it gives me (among others) this error: > >>> > >>> Description? ? Resource? ? Path? ? Location? ? Type > >>> Cannot nest > >>> > >> > 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main/javafx.base' > >>> inside library > >>> 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main'? > ? base > >>>? ? ?Build path? ? Build Path Problem > >>> > >>> The Workspace was completely new, all the other stuff (JDK 12, Java > >>> Compiliance Level) should be ok. > >>> > >>> Do you have any idea what is going wrong here? Smells like > module system > >>> problems :-(. > >>> > >>> > >>> Best regards, > >>> > >>> Robert > >>> On 2020-01-10 17:52, Nir Lisker wrote: > >>> > >>> Hi Robert, > >>> > >>> I've brought this up in the past. > >>> > >>> I think that the best solution is for someone from the community > to take > >>> that task. I try to keep the Eclipse section updated, we will need > >> someone > >>> for the other IDE's. > >>> > >>> - Nir > >>> > >>> On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger < > >>> r.lichtenberger at gmail.com > wrote: > >>> > >>>> I've noticed that > >>>> https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE > >>>> seems a bit outdated (refers to JDK 1.8, a folder named "rt", > which no > >>>> longer exists, etc.). > >>>> > >>>> Could someone please update this page so that it is easier for > newcomers > >>>> to > >>>> dive into the development of OpenJFX. > >>>> > >>>> Thanks, > >>>> Robert > >>>> > >>> > >> > > -- > Tom Schindl, CTO > BestSolution.at EDV Systemhaus GmbH > Salurnerstrasse 15. A-6020 Innsbruck > Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck > -- Tom Schindl, CTO BestSolution.at EDV Systemhaus GmbH Salurnerstrasse 15. A-6020 Innsbruck Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck From r.lichtenberger at gmail.com Tue Jan 14 08:36:54 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Tue, 14 Jan 2020 09:36:54 +0100 Subject: "Using an IDE" Page outdated In-Reply-To: References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> <2b78ec0d-b6c1-ca1b-cb0e-e7a8bbe79e7a@bestsolution.at> Message-ID: I've just simply removed the two missing source folders and only one error remains: * The blank final field dialog may not have been initialized Dialog.java /controls/src/main/java/javafx/scene/control line 521 which seems to me like an error within the eclipse compiler. Ignoring this error, I've tried to execute test.javafx.scene.control.ButtonTest from the IDE but get: > Graphics Device initialization failed for : es2, sw > Error initializing QuantumRenderer: no suitable pipeline found > java.lang.RuntimeException: java.lang.RuntimeException: Error initializing > QuantumRenderer: no suitable pipeline found > at > javafx.graphics/com.sun.javafx.tk.quantum.QuantumRenderer.getInstance(QuantumRenderer.java:280) > ... > Debugging into com.sun.prism.GraphicsPipeline I can see that for com.sun.prism.es2.ES2Pipeline I get this exception: java.lang.UnsatisfiedLinkError: no prism_es2 in java.library.path: [/usr/lib64/mysql, /opt/synedra/lib/opencv-dcm, /home/rli/devel/repository/tool/linux/64, ., /usr/java/packages/lib, /usr/lib64, /lib64, /lib, /usr/lib] As mentioned on the wiki, I've added -Djava.library.path=/home/rli/PWEs/jfx/modules/javafx.graphics/build/module-lib as VM argument which fixes the loading of ES2Pipeline. However I still can't run the test, I get: java.lang.ExceptionInInitializerError at javafx.controls/test.javafx.scene.control.ButtonTest.setup(ButtonTest.java:83) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ... Caused by: java.lang.IllegalStateException: Toolkit not initialized at javafx.graphics/com.sun.javafx.application.PlatformImpl.runLater(PlatformImpl.java:410) at javafx.graphics/com.sun.javafx.application.PlatformImpl.runLater(PlatformImpl.java:405) at javafx.graphics/com.sun.javafx.application.PlatformImpl.setPlatformUserAgentStylesheet(PlatformImpl.java:695) at javafx.graphics/com.sun.javafx.application.PlatformImpl.setDefaultPlatformUserAgentStylesheet(PlatformImpl.java:657) at javafx.controls/javafx.scene.control.Control.(Control.java:99) ... 25 more java.lang.NullPointerException at javafx.controls/test.javafx.scene.control.ButtonTest.after(ButtonTest.java:93) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ... it seems the test does not wait for the toolkit to be initialized ... Am Di., 14. Jan. 2020 um 09:11 Uhr schrieb Robert Lichtenberger < r.lichtenberger at gmail.com>: > I've tried to import using "General" -> "Existing Projects in Workspace" > but get lots of errors as well. When reducing the imported projects to > base, graphics and controls: > * base is ok > * graphics has these errors: > Description Resource Path Location Type > Project 'graphics' is missing required source folder: 'build/hlsl/Decora' > graphics Build path Build Path Problem > Project 'graphics' is missing required source folder: 'build/hlsl/Prism' > graphics Build path Build Path Problem > * controls won't build due to errors in graphics > > Is hlsl the "High Level Shading Language" which may be specific to Windows? > > Am Di., 14. Jan. 2020 um 08:53 Uhr schrieb Tom Schindl < > tom.schindl at bestsolution.at>: > >> Hi, >> >> I think Nir nor I uses them as gradle Projects because you have the >> .classpath, .project, ... . >> >> Tom >> >> On 14.01.20 08:12, Robert Lichtenberger wrote: >> > Yes, I did run a gradle build (for which I had to tweak >> > buildSrc/linux.gradle to ignore some deprecations -- see my other post >> to >> > the list) successfully. >> > >> > I use a completely fresh workspace, updated my JFX sources, I use >> Eclipse >> > 2019-12 and jdk-13.0.1+9 on Fedora 31. >> > >> > These are my steps: >> > * open eclipse, >> > * choose "Import projects" then "Gradle" -> "Existing Gradle project" >> > * give the top level folder of my repository (/home/rli/PWEs/jfx in my >> case) >> > * Use the gradle wrapper (i.e. no changes on the wizards next page) >> > * The project structure is given correctly, so I click finish >> > >> > Eclipse then loads the projects but gives out the aforementioned error. >> > >> > I've made a 1-minute video clip showing my steps: >> > https://youtu.be/S9WnOHCbWLI >> > >> > I'll try to find out what is going wrong here. Could you tell me which >> > versions (JFX sources, Eclipse, JDK) you are using? >> > >> > >> > Am Mo., 13. Jan. 2020 um 17:59 Uhr schrieb Nir Lisker < >> nlisker at gmail.com>: >> > >> >> Never seen this problem before. Did you run a Gradle build? [1] It >> needs to >> >> generated required resources. >> >> >> >> Also, the Eclipse files for some projects are not updated (though for >> the >> >> modules they are fine, so it's not the problem you are having). My >> patch >> >> for them was pending review by other Eclipse users and no one tested >> it, so >> >> if you are up for it I could resume work on it. >> >> >> >> - Nir >> >> >> >> [1] >> >> >> >> >> https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-BuildandTest >> >> >> >> On Mon, Jan 13, 2020 at 5:35 PM Robert Lichtenberger < >> >> r.lichtenberger at synedra.com> wrote: >> >> >> >>> Hmm. Eclipse would suit me fine, so I've tried to import a current >> >> OpenJFX >> >>> repository to Eclipse but it gives me (among others) this error: >> >>> >> >>> Description Resource Path Location Type >> >>> Cannot nest >> >>> >> >> >> 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main/javafx.base' >> >>> inside library >> >>> 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main' >> base >> >>> Build path Build Path Problem >> >>> >> >>> The Workspace was completely new, all the other stuff (JDK 12, Java >> >>> Compiliance Level) should be ok. >> >>> >> >>> Do you have any idea what is going wrong here? Smells like module >> system >> >>> problems :-(. >> >>> >> >>> >> >>> Best regards, >> >>> >> >>> Robert >> >>> On 2020-01-10 17:52, Nir Lisker wrote: >> >>> >> >>> Hi Robert, >> >>> >> >>> I've brought this up in the past. >> >>> >> >>> I think that the best solution is for someone from the community to >> take >> >>> that task. I try to keep the Eclipse section updated, we will need >> >> someone >> >>> for the other IDE's. >> >>> >> >>> - Nir >> >>> >> >>> On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger < >> >>> r.lichtenberger at gmail.com> wrote: >> >>> >> >>>> I've noticed that >> >>>> https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE >> >>>> seems a bit outdated (refers to JDK 1.8, a folder named "rt", which >> no >> >>>> longer exists, etc.). >> >>>> >> >>>> Could someone please update this page so that it is easier for >> newcomers >> >>>> to >> >>>> dive into the development of OpenJFX. >> >>>> >> >>>> Thanks, >> >>>> Robert >> >>>> >> >>> >> >> >> >> -- >> Tom Schindl, CTO >> BestSolution.at EDV Systemhaus GmbH >> Salurnerstrasse 15. A-6020 Innsbruck >> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck >> > From tom.schindl at bestsolution.at Tue Jan 14 08:47:26 2020 From: tom.schindl at bestsolution.at (Tom Schindl) Date: Tue, 14 Jan 2020 09:47:26 +0100 Subject: "Using an IDE" Page outdated In-Reply-To: References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> <2b78ec0d-b6c1-ca1b-cb0e-e7a8bbe79e7a@bestsolution.at> Message-ID: <96dfdb57-dad2-6118-52aa-9da8c508c1d9@bestsolution.at> On 14.01.20 09:36, Robert Lichtenberger wrote: > I've just simply removed the two missing source folders and only one > error remains: > * The blank final field dialog may not have been initialized Dialog.java > /controls/src/main/java/javafx/scene/control line 521 > which seems to me like an error within the eclipse compiler. > > Ignoring this error, I've tried to execute yes it is and it is already logged in Bugzilla there - you can just remove final in your local workspace ;-) Tom -- Tom Schindl, CTO BestSolution.at EDV Systemhaus GmbH Salurnerstrasse 15. A-6020 Innsbruck Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck From tom.schindl at bestsolution.at Tue Jan 14 08:50:07 2020 From: tom.schindl at bestsolution.at (Tom Schindl) Date: Tue, 14 Jan 2020 09:50:07 +0100 Subject: "Using an IDE" Page outdated In-Reply-To: <96dfdb57-dad2-6118-52aa-9da8c508c1d9@bestsolution.at> References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> <2b78ec0d-b6c1-ca1b-cb0e-e7a8bbe79e7a@bestsolution.at> <96dfdb57-dad2-6118-52aa-9da8c508c1d9@bestsolution.at> Message-ID: <8c5c0f52-3df3-f467-5801-6f606ea8f1dc@bestsolution.at> I think the issue there is https://bugs.eclipse.org/bugs/show_bug.cgi?id=507629 as Nir commented there as well I'm fairly sure this is the one you see ;-) Tom On 14.01.20 09:47, Tom Schindl wrote: > On 14.01.20 09:36, Robert Lichtenberger wrote: >> I've just simply removed the two missing source folders and only one >> error remains: >> * The blank final field dialog may not have been initialized Dialog.java >> /controls/src/main/java/javafx/scene/control line 521 >> which seems to me like an error within the eclipse compiler. >> >> Ignoring this error, I've tried to execute > > yes it is and it is already logged in Bugzilla there - you can just > remove final in your local workspace ;-) > > Tom > -- Tom Schindl, CTO BestSolution.at EDV Systemhaus GmbH Salurnerstrasse 15. A-6020 Innsbruck Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck From nlisker at gmail.com Tue Jan 14 08:49:55 2020 From: nlisker at gmail.com (Nir Lisker) Date: Tue, 14 Jan 2020 10:49:55 +0200 Subject: "Using an IDE" Page outdated In-Reply-To: References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> <2b78ec0d-b6c1-ca1b-cb0e-e7a8bbe79e7a@bestsolution.at> Message-ID: > > The blank final field dialog may not have been initialized Dialog.java This is mentioned in the note under "Configure Eclipse to use the latest JDK". Did you end up reverting the .classpath and .project files? On Tue, Jan 14, 2020 at 10:37 AM Robert Lichtenberger < r.lichtenberger at gmail.com> wrote: > I've just simply removed the two missing source folders and only one error > remains: > * The blank final field dialog may not have been initialized Dialog.java > /controls/src/main/java/javafx/scene/control line 521 > which seems to me like an error within the eclipse compiler. > > Ignoring this error, I've tried to execute > test.javafx.scene.control.ButtonTest from the IDE but get: > > > Graphics Device initialization failed for : es2, sw > > Error initializing QuantumRenderer: no suitable pipeline found > > java.lang.RuntimeException: java.lang.RuntimeException: Error > initializing > > QuantumRenderer: no suitable pipeline found > > at > > > javafx.graphics/com.sun.javafx.tk.quantum.QuantumRenderer.getInstance(QuantumRenderer.java:280) > > ... > > > Debugging into com.sun.prism.GraphicsPipeline I can see that for > com.sun.prism.es2.ES2Pipeline I get this exception: > java.lang.UnsatisfiedLinkError: no prism_es2 in java.library.path: > [/usr/lib64/mysql, /opt/synedra/lib/opencv-dcm, > /home/rli/devel/repository/tool/linux/64, ., /usr/java/packages/lib, > /usr/lib64, /lib64, /lib, /usr/lib] > > As mentioned on the wiki, I've added > > -Djava.library.path=/home/rli/PWEs/jfx/modules/javafx.graphics/build/module-lib > as VM argument which fixes the loading of ES2Pipeline. > > However I still can't run the test, I get: > java.lang.ExceptionInInitializerError > at > > javafx.controls/test.javafx.scene.control.ButtonTest.setup(ButtonTest.java:83) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > ... > Caused by: java.lang.IllegalStateException: Toolkit not initialized > at > > javafx.graphics/com.sun.javafx.application.PlatformImpl.runLater(PlatformImpl.java:410) > at > > javafx.graphics/com.sun.javafx.application.PlatformImpl.runLater(PlatformImpl.java:405) > at > > javafx.graphics/com.sun.javafx.application.PlatformImpl.setPlatformUserAgentStylesheet(PlatformImpl.java:695) > at > > javafx.graphics/com.sun.javafx.application.PlatformImpl.setDefaultPlatformUserAgentStylesheet(PlatformImpl.java:657) > at javafx.controls/javafx.scene.control.Control.(Control.java:99) > ... 25 more > > java.lang.NullPointerException > at > > javafx.controls/test.javafx.scene.control.ButtonTest.after(ButtonTest.java:93) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > ... > > it seems the test does not wait for the toolkit to be initialized ... > > Am Di., 14. Jan. 2020 um 09:11 Uhr schrieb Robert Lichtenberger < > r.lichtenberger at gmail.com>: > > > I've tried to import using "General" -> "Existing Projects in Workspace" > > but get lots of errors as well. When reducing the imported projects to > > base, graphics and controls: > > * base is ok > > * graphics has these errors: > > Description Resource Path Location Type > > Project 'graphics' is missing required source folder: 'build/hlsl/Decora' > > graphics Build path Build Path Problem > > Project 'graphics' is missing required source folder: 'build/hlsl/Prism' > > graphics Build path Build Path Problem > > * controls won't build due to errors in graphics > > > > Is hlsl the "High Level Shading Language" which may be specific to > Windows? > > > > Am Di., 14. Jan. 2020 um 08:53 Uhr schrieb Tom Schindl < > > tom.schindl at bestsolution.at>: > > > >> Hi, > >> > >> I think Nir nor I uses them as gradle Projects because you have the > >> .classpath, .project, ... . > >> > >> Tom > >> > >> On 14.01.20 08:12, Robert Lichtenberger wrote: > >> > Yes, I did run a gradle build (for which I had to tweak > >> > buildSrc/linux.gradle to ignore some deprecations -- see my other post > >> to > >> > the list) successfully. > >> > > >> > I use a completely fresh workspace, updated my JFX sources, I use > >> Eclipse > >> > 2019-12 and jdk-13.0.1+9 on Fedora 31. > >> > > >> > These are my steps: > >> > * open eclipse, > >> > * choose "Import projects" then "Gradle" -> "Existing Gradle project" > >> > * give the top level folder of my repository (/home/rli/PWEs/jfx in my > >> case) > >> > * Use the gradle wrapper (i.e. no changes on the wizards next page) > >> > * The project structure is given correctly, so I click finish > >> > > >> > Eclipse then loads the projects but gives out the aforementioned > error. > >> > > >> > I've made a 1-minute video clip showing my steps: > >> > https://youtu.be/S9WnOHCbWLI > >> > > >> > I'll try to find out what is going wrong here. Could you tell me which > >> > versions (JFX sources, Eclipse, JDK) you are using? > >> > > >> > > >> > Am Mo., 13. Jan. 2020 um 17:59 Uhr schrieb Nir Lisker < > >> nlisker at gmail.com>: > >> > > >> >> Never seen this problem before. Did you run a Gradle build? [1] It > >> needs to > >> >> generated required resources. > >> >> > >> >> Also, the Eclipse files for some projects are not updated (though for > >> the > >> >> modules they are fine, so it's not the problem you are having). My > >> patch > >> >> for them was pending review by other Eclipse users and no one tested > >> it, so > >> >> if you are up for it I could resume work on it. > >> >> > >> >> - Nir > >> >> > >> >> [1] > >> >> > >> >> > >> > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-BuildandTest > >> >> > >> >> On Mon, Jan 13, 2020 at 5:35 PM Robert Lichtenberger < > >> >> r.lichtenberger at synedra.com> wrote: > >> >> > >> >>> Hmm. Eclipse would suit me fine, so I've tried to import a current > >> >> OpenJFX > >> >>> repository to Eclipse but it gives me (among others) this error: > >> >>> > >> >>> Description Resource Path Location Type > >> >>> Cannot nest > >> >>> > >> >> > >> > 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main/javafx.base' > >> >>> inside library > >> >>> 'home/rli/PWEs/jfx/modules/javafx.base/build/classes/java/main' > >> base > >> >>> Build path Build Path Problem > >> >>> > >> >>> The Workspace was completely new, all the other stuff (JDK 12, Java > >> >>> Compiliance Level) should be ok. > >> >>> > >> >>> Do you have any idea what is going wrong here? Smells like module > >> system > >> >>> problems :-(. > >> >>> > >> >>> > >> >>> Best regards, > >> >>> > >> >>> Robert > >> >>> On 2020-01-10 17:52, Nir Lisker wrote: > >> >>> > >> >>> Hi Robert, > >> >>> > >> >>> I've brought this up in the past. > >> >>> > >> >>> I think that the best solution is for someone from the community to > >> take > >> >>> that task. I try to keep the Eclipse section updated, we will need > >> >> someone > >> >>> for the other IDE's. > >> >>> > >> >>> - Nir > >> >>> > >> >>> On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger < > >> >>> r.lichtenberger at gmail.com> wrote: > >> >>> > >> >>>> I've noticed that > >> >>>> https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE > >> >>>> seems a bit outdated (refers to JDK 1.8, a folder named "rt", which > >> no > >> >>>> longer exists, etc.). > >> >>>> > >> >>>> Could someone please update this page so that it is easier for > >> newcomers > >> >>>> to > >> >>>> dive into the development of OpenJFX. > >> >>>> > >> >>>> Thanks, > >> >>>> Robert > >> >>>> > >> >>> > >> >> > >> > >> -- > >> Tom Schindl, CTO > >> BestSolution.at EDV Systemhaus GmbH > >> Salurnerstrasse 15. A-6020 Innsbruck > >> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck > >> > > > From r.lichtenberger at gmail.com Tue Jan 14 10:08:28 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Tue, 14 Jan 2020 11:08:28 +0100 Subject: "Using an IDE" Page outdated In-Reply-To: <8c5c0f52-3df3-f467-5801-6f606ea8f1dc@bestsolution.at> References: <911eff89-8fe0-159c-c37a-39c05aa4f0b1@synedra.com> <2b78ec0d-b6c1-ca1b-cb0e-e7a8bbe79e7a@bestsolution.at> <96dfdb57-dad2-6118-52aa-9da8c508c1d9@bestsolution.at> <8c5c0f52-3df3-f467-5801-6f606ea8f1dc@bestsolution.at> Message-ID: > > Did you end up reverting the .classpath and .project files? > I started over, not importing as gradle but as java projects. I also just found https://openjfx-dev.openjdk.java.narkive.com/AVCV7WXg/problem-running-tests-in-module-controls-inside-eclipse and with Tom's hint: > i run them with > > -Djava.library.path=/Users/tomschindl/OpenJFX/openjdk-jfx/build/sdk/lib > -Djavafx.toolkit=test.com.sun.javafx.pgstub.StubToolkit > I was finally able to run a test. Maybe Nir could add a note about those two properties in the section ""JUnit tests"? To sum up my findings/problems: * gradlew is not executable; This should easily be changeable and would make live easier for linux developers * Building with gradle didn't work out of the box due to deprecations in GTK2; * The netbeans/intellij parts of the Wiki page seem to be the most outdated whereas Nir is maintaining the eclipse part quite well. Maybe we should put eclipse to the top and/or recommend using eclipse then. Or at least warn the reader in the sections about netbeans and intellij beeing outdated. I am a longtime eclipse user but after reading the wiki page tried netbeans first (and failed miserably...) * Using gradle/buildship in eclipse is not the "preferred" way. Maybe we should remove this way altogether so as to not mislead people. I admit not having read the wiki thouroughly enough though :-). * hlsl problem under linux * To run unit tests two VM arguments must be set. These should be mentioned in the wiki. Thanks to everyone for helping me ;-). Am Di., 14. Jan. 2020 um 09:50 Uhr schrieb Tom Schindl < tom.schindl at bestsolution.at>: > I think the issue there is > https://bugs.eclipse.org/bugs/show_bug.cgi?id=507629 as Nir commented > there as well I'm fairly sure this is the one you see ;-) > > Tom > > On 14.01.20 09:47, Tom Schindl wrote: > > On 14.01.20 09:36, Robert Lichtenberger wrote: > >> I've just simply removed the two missing source folders and only one > >> error remains: > >> * The blank final field dialog may not have been initialized Dialog.java > >> /controls/src/main/java/javafx/scene/control line 521 > >> which seems to me like an error within the eclipse compiler. > >> > >> Ignoring this error, I've tried to execute > > > > yes it is and it is already logged in Bugzilla there - you can just > > remove final in your local workspace ;-) > > > > Tom > > > > -- > Tom Schindl, CTO > BestSolution.at EDV Systemhaus GmbH > Salurnerstrasse 15. A-6020 Innsbruck > Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck > From r.lichtenberger at gmail.com Tue Jan 14 11:00:56 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Tue, 14 Jan 2020 12:00:56 +0100 Subject: Running Web-Tests from eclipse Message-ID: As a follow-up to the long thread on using an IDE. I just found out that running test.javafx.scene.web.WebViewTest is not possible with -Djavafx.toolkit=test.com.sun.javafx.pgstub.StubToolkit. The test simply fails to start (waiting forever for com.sun.javafx.application.PlatformImpl.startupLatch). Instead one needs to add the graphics library and the webkit library with e.g. -Djava.library.path=/home/rli/PWEs/jfx/modules/javafx.graphics/build/module-lib:/home/rli/PWEs/jfx/modules/javafx.web/build/module-lib Maybe this could also be added to the wiki page? From tsayao at openjdk.java.net Tue Jan 14 11:31:11 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Tue, 14 Jan 2020 11:31:11 GMT Subject: RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> <31X4pHGnuhexI5Rz9Y8afMrdFl0pfNPKp9nMYMNcG50=.1f068b3f-0901-43f3-a2d1-8a12aa18b040@github.com> Message-ID: On Mon, 6 Jan 2020 22:57:31 GMT, Thiago Milczarek Sayao wrote: >> This sort of enhancement needs to be discussed on the openjfx-dev mailing list first. While the WIP PR might be used to illustrate what you have in mind to propose, it is premature to actually review the implementation without first discussing whether and it makes sense to do it, what the high-level goals are, etc. > > I understand. Will do that when the code works 100%. I have submitted the PR to avoid duplicated efforts and let people test it (if anyone is willing). Sizing and positioning completed and fairly tested. Will look into mouse grabbing. ------------- PR: https://git.openjdk.java.net/jfx/pull/77 From r.lichtenberger at gmail.com Tue Jan 14 11:40:31 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Tue, 14 Jan 2020 12:40:31 +0100 Subject: Removing unneeded imports from testcode Message-ID: I'm in the process of preparing a fix for JDK-8236912 and I (or rather eclipse) have noticed that WebViewTest contains an import of java.util.concurrent.FutureTask that is not needed. What is the correct way of handling such things: * Including them into the Pull-Request for the fix of JDK-8236912 * Leaving the unneeded import as-is. * Opening another issue Best regards, Robert From kevin.rushforth at oracle.com Tue Jan 14 11:51:38 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 14 Jan 2020 03:51:38 -0800 Subject: Removing unneeded imports from testcode In-Reply-To: References: Message-ID: <8350ec61-262c-a7eb-1253-2adaa23faa76@oracle.com> As a general rule, we avoid unrelated fixes. If your fix needed to add any new import, then I don't mind removing unused ones at the same time. If not, then you can either leave it as-is or file a cleanup issue. -- Kevin For test fixes, I don't mind On 1/14/2020 3:40 AM, Robert Lichtenberger wrote: > I'm in the process of preparing a fix for JDK-8236912 and I (or rather > eclipse) have noticed that WebViewTest contains an import of > java.util.concurrent.FutureTask that is not needed. > What is the correct way of handling such things: > * Including them into the Pull-Request for the fix of JDK-8236912 > * Leaving the unneeded import as-is. > * Opening another issue > Best regards, > Robert From rlichten at openjdk.java.net Tue Jan 14 12:02:20 2020 From: rlichten at openjdk.java.net (Robert Lichtenberger) Date: Tue, 14 Jan 2020 12:02:20 GMT Subject: RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons Message-ID: As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped. ------------- Commits: - 542ff60e: Fix null pointer exception when clicking into WebViews with forward/back mouse button. - 2109d5a0: Merge remote-tracking branch 'upstream/master' - acfa63be: Merge remote-tracking branch 'upstream/master' - 7c5cf198: 8232524: Test cleanup: terminate background thread upon failure. - 7e80839f: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating - 8ecf3545: JDK-8232524 fixed. Changes: https://git.openjdk.java.net/jfx/pull/85/files Webrev: https://webrevs.openjdk.java.net/jfx/85/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236912 Stats: 18 lines in 2 files changed: 15 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/85.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/85/head:pull/85 PR: https://git.openjdk.java.net/jfx/pull/85 From kcr at openjdk.java.net Tue Jan 14 12:06:58 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 14 Jan 2020 12:06:58 GMT Subject: RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 12:01:11 GMT, Robert Lichtenberger wrote: > As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped. The PR title should match the title of the bug report in JBS exactly. Can you change it to: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 This will need two reviewers. I'll review it and also request @guruhb to review. ------------- PR: https://git.openjdk.java.net/jfx/pull/85 From r.lichtenberger at gmail.com Tue Jan 14 12:09:29 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Tue, 14 Jan 2020 13:09:29 +0100 Subject: RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons In-Reply-To: References: Message-ID: How strange: Other commits to the master branch of my forked repository (relating to another issue, already integrated into OpenJFX) are also showing up here. But the change really only consists of 542ff60e which contains the fix for JDK-8236912. My older contributions were not checked into a separate branch (of my fork), maybe that was the problem. If there is anything else I did wrong, please tell me ;-). The Changes-Link and the Webrev correctly show that only two files are changed. Am Di., 14. Jan. 2020 um 13:02 Uhr schrieb Robert Lichtenberger < rlichten at openjdk.java.net>: > As documented in JDK-8236912, WebView did not check whether the idMap > really contained a mapping for the given button, making it prone to errors, > when things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed > WebViews and a fix which works analogously to the check whether the given > event type is mapped. > > ------------- > > Commits: > - 542ff60e: Fix null pointer exception when clicking into WebViews with > forward/back mouse button. > - 2109d5a0: Merge remote-tracking branch 'upstream/master' > - acfa63be: Merge remote-tracking branch 'upstream/master' > - 7c5cf198: 8232524: Test cleanup: terminate background thread upon > failure. > - 7e80839f: 8232524: SynchronizedObservableMap cannot be be protected for > copying/iterating > - 8ecf3545: JDK-8232524 fixed. > > Changes: https://git.openjdk.java.net/jfx/pull/85/files > Webrev: https://webrevs.openjdk.java.net/jfx/85/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8236912 > Stats: 18 lines in 2 files changed: 15 ins; 0 del; 3 mod > Patch: https://git.openjdk.java.net/jfx/pull/85.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/85/head:pull/85 > > PR: https://git.openjdk.java.net/jfx/pull/85 > From r.lichtenberger at gmail.com Tue Jan 14 12:11:44 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Tue, 14 Jan 2020 13:11:44 +0100 Subject: RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons In-Reply-To: References: Message-ID: PR title changed. Am Di., 14. Jan. 2020 um 13:07 Uhr schrieb Kevin Rushforth < kcr at openjdk.java.net>: > On Tue, 14 Jan 2020 12:01:11 GMT, Robert Lichtenberger < > rlichten at openjdk.org> wrote: > > > As documented in JDK-8236912, WebView did not check whether the idMap > really contained a mapping for the given button, making it prone to errors, > when things are extended (as has happened here). > > > > The fix consists of two test cases that show the problem in unfixed > WebViews and a fix which works analogously to the check whether the given > event type is mapped. > > The PR title should match the title of the bug report in JBS exactly. Can > you change it to: > > 8236912: NullPointerException when clicking in WebView with Button 4 or > Button 5 > > This will need two reviewers. I'll review it and also request @guruhb to > review. > > ------------- > > PR: https://git.openjdk.java.net/jfx/pull/85 > From ghb at openjdk.java.net Tue Jan 14 12:12:46 2020 From: ghb at openjdk.java.net (Guru Hb) Date: Tue, 14 Jan 2020 12:12:46 GMT Subject: RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 12:01:11 GMT, Robert Lichtenberger wrote: > As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped. +1, Looks good to me. ------------- Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/85 From kcr at openjdk.java.net Tue Jan 14 12:16:29 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 14 Jan 2020 12:16:29 GMT Subject: RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 12:12:37 GMT, Guru Hb wrote: >> As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). >> >> The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped. > > +1, Looks good to me. @effad - The extra commits and merge are no problem, provided that you want to get this into openjfx15. However, if you intend to get this into openjfx14, as currently targeted in JBS, then you will need to: 1. Rebase your `JDK-8236912` branch on top of the upstream `jfx14` branch 2. Force-push your branch: `git push --force origin JDK-8236912` 3. Edit this PR and change the target to the `jfx14` branch ------------- PR: https://git.openjdk.java.net/jfx/pull/85 From kcr at openjdk.java.net Tue Jan 14 12:40:30 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 14 Jan 2020 12:40:30 GMT Subject: RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 12:16:14 GMT, Kevin Rushforth wrote: >> +1, Looks good to me. > > @effad - The extra commits and merge are no problem, provided that you want to get this into openjfx15. > > However, if you intend to get this into openjfx14, as currently targeted in JBS, then you will need to: > > 1. Rebase your `JDK-8236912` branch on top of the upstream `jfx14` branch > 2. Force-push your branch: `git push --force origin JDK-8236912` > 3. Edit this PR and change the target to the `jfx14` branch NOTE that this PR is not yet ready for integration. In addition to needing one more reviewer (me), there is the open question of which branch it should be targeted to. @effad I think that this should go into openjfx14, so the above steps I listed will allow for this. @guruhb can you please cancel your review (click the "re-request review" icon next to your review) until the above is done? ------------- PR: https://git.openjdk.java.net/jfx/pull/85 From rlichten at openjdk.java.net Tue Jan 14 12:53:06 2020 From: rlichten at openjdk.java.net (Robert Lichtenberger) Date: Tue, 14 Jan 2020 12:53:06 GMT Subject: [Rev 01] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: > As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped. The pull request has been updated with 2 additional commits. ------------- Added commits: - 283c5476: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating - 6aecab95: JDK-8232524 fixed. Changes: - all: https://git.openjdk.java.net/jfx/pull/85/files - new: https://git.openjdk.java.net/jfx/pull/85/files/542ff60e..283c5476 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/85/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/85/webrev.00-01 Stats: 91 lines in 2 files changed: 91 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/85.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/85/head:pull/85 PR: https://git.openjdk.java.net/jfx/pull/85 From rlichten at openjdk.java.net Tue Jan 14 12:56:47 2020 From: rlichten at openjdk.java.net (Robert Lichtenberger) Date: Tue, 14 Jan 2020 12:56:47 GMT Subject: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 12:40:16 GMT, Kevin Rushforth wrote: >> @effad - The extra commits and merge are no problem, provided that you want to get this into openjfx15. >> >> However, if you intend to get this into openjfx14, as currently targeted in JBS, then you will need to: >> >> 1. Rebase your `JDK-8236912` branch on top of the upstream `jfx14` branch >> 2. Force-push your branch: `git push --force origin JDK-8236912` >> 3. Edit this PR and change the target to the `jfx14` branch > > NOTE that this PR is not yet ready for integration. In addition to needing one more reviewer (me), there is the open question of which branch it should be targeted to. > > @effad I think that this should go into openjfx14, so the above steps I listed will allow for this. > > @guruhb can you please cancel your review (click the "re-request review" icon next to your review) until the above is done? I've rebased my branch like this: git fetch upstream git rebase upstream/jfx14 git pull git push and changed the base branch of this PR to jfx14. Hope that was the correct way to do this ;-). ------------- PR: https://git.openjdk.java.net/jfx/pull/85 From kcr at openjdk.java.net Tue Jan 14 14:00:15 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 14 Jan 2020 14:00:15 GMT Subject: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: <_O90urpActWZWHMTxjUwlZo3FDy3sFVX5ENvK9W7w18=.378f3f6f-5d3e-46fd-90d1-3c7a3000209b@github.com> On Tue, 14 Jan 2020 12:56:32 GMT, Robert Lichtenberger wrote: >> NOTE that this PR is not yet ready for integration. In addition to needing one more reviewer (me), there is the open question of which branch it should be targeted to. >> >> @effad I think that this should go into openjfx14, so the above steps I listed will allow for this. >> >> @guruhb can you please cancel your review (click the "re-request review" icon next to your review) until the above is done? > > I've rebased my branch like this: > git fetch upstream > git rebase upstream/jfx14 > git pull > git push > and changed the base branch of this PR to jfx14. Hope that was the correct way to do this ;-). Your branch still has commits from `master` after jfx14 was branched. This was the problem: git pull This pulled in additional changes from master that were already in your branch and effectively undid the rebase. You need to redo it, but this time instead of pulling changes after you rebase, you should simply do: git push --force origin JDK-8236912 ------------- PR: https://git.openjdk.java.net/jfx/pull/85 From rlichten at openjdk.java.net Tue Jan 14 14:07:18 2020 From: rlichten at openjdk.java.net (Robert Lichtenberger) Date: Tue, 14 Jan 2020 14:07:18 GMT Subject: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: > As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped. The pull request has been updated with a new target base due to a merge or a rebase. ------------- Commits: - 8c3f6017: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating - 829920cf: JDK-8232524 fixed. - 401b4484: Fix null pointer exception when clicking into WebViews with forward/back mouse button. - 3bf7e920: 8236733: Change JavaFX release version to 15 - 0967bbd3: 8232524: Test cleanup: terminate background thread upon failure. - e50b0533: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating - 9d1979e7: JDK-8232524 fixed. Changes: https://git.openjdk.java.net/jfx/pull/85/files Webrev: https://webrevs.openjdk.java.net/jfx/85/webrev.02 Stats: 205 lines in 6 files changed: 198 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jfx/pull/85.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/85/head:pull/85 PR: https://git.openjdk.java.net/jfx/pull/85 From rlichten at openjdk.java.net Tue Jan 14 14:12:37 2020 From: rlichten at openjdk.java.net (Robert Lichtenberger) Date: Tue, 14 Jan 2020 14:12:37 GMT Subject: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: <_O90urpActWZWHMTxjUwlZo3FDy3sFVX5ENvK9W7w18=.378f3f6f-5d3e-46fd-90d1-3c7a3000209b@github.com> References: <_O90urpActWZWHMTxjUwlZo3FDy3sFVX5ENvK9W7w18=.378f3f6f-5d3e-46fd-90d1-3c7a3000209b@github.com> Message-ID: On Tue, 14 Jan 2020 14:00:08 GMT, Kevin Rushforth wrote: >> I've rebased my branch like this: >> git fetch upstream >> git rebase upstream/jfx14 >> git pull >> git push >> and changed the base branch of this PR to jfx14. Hope that was the correct way to do this ;-). > > Your branch still has commits from `master` after jfx14 was branched. This was the problem: > git pull > > This pulled in additional changes from master that were already in your branch and effectively undid the rebase. You need to redo it, but this time instead of pulling changes after you rebase, you should simply do: > git push --force origin JDK-8236912 > ``` > git push --force origin JDK-8236912 > ``` I did git rebase upstream/jfx14 git push --force origin JDK-8236912 but that has messed up things further, didn't it? ------------- PR: https://git.openjdk.java.net/jfx/pull/85 From ghb at openjdk.java.net Tue Jan 14 14:13:57 2020 From: ghb at openjdk.java.net (Guru Hb) Date: Tue, 14 Jan 2020 14:13:57 GMT Subject: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 14:13:54 GMT, Robert Lichtenberger wrote: >> As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). >> >> The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped. > > The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Partially reviewed, Need to re-check after the change of branch. ------------- Changes requested by ghb (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/85 From kcr at openjdk.java.net Tue Jan 14 14:43:24 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 14 Jan 2020 14:43:24 GMT Subject: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 14:13:45 GMT, Guru Hb wrote: >> The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. > > Partially reviewed, Need to re-check after the change of branch. Oh, I see the problem. In addition to rebasing you need to exclude any commits that are from the `master` branch and are not your. So what you really need to do is: git rebase -i upstream/jfx14 git push --force origin JDK-8236912 Sorry for not anticipating this problem. ------------- PR: https://git.openjdk.java.net/jfx/pull/85 From rlichten at openjdk.java.net Tue Jan 14 14:50:45 2020 From: rlichten at openjdk.java.net (Robert Lichtenberger) Date: Tue, 14 Jan 2020 14:50:45 GMT Subject: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: > As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped. Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR. ------------- Added commits: - aa03cf1f: Fix null pointer exception when clicking into WebViews with forward/back mouse button. Changes: - all: https://git.openjdk.java.net/jfx/pull/85/files - new: https://git.openjdk.java.net/jfx/pull/85/files/8c3f6017..aa03cf1f Webrevs: - full: https://webrevs.openjdk.java.net/jfx/85/webrev.03 - incr: https://webrevs.openjdk.java.net/jfx/85/webrev.02-03 Stats: 187 lines in 4 files changed: 0 ins; 183 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/85.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/85/head:pull/85 PR: https://git.openjdk.java.net/jfx/pull/85 From rlichten at openjdk.java.net Tue Jan 14 14:55:45 2020 From: rlichten at openjdk.java.net (Robert Lichtenberger) Date: Tue, 14 Jan 2020 14:55:45 GMT Subject: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 14:43:03 GMT, Kevin Rushforth wrote: >> Partially reviewed, Need to re-check after the change of branch. > > Oh, I see the problem. In addition to rebasing you need to exclude any commits that are from the `master` branch and are not your. So what you really need to do is: > > git rebase -i upstream/jfx14 > > git push --force origin JDK-8236912 > > Sorry for not anticipating this problem. > Sorry for not anticipating this problem. I am sorry for not knowing git well enough. Thank you for your patience and help ;-). I think the PR now contains what it should ;-). ------------- PR: https://git.openjdk.java.net/jfx/pull/85 From kcr at openjdk.java.net Tue Jan 14 15:08:47 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 14 Jan 2020 15:08:47 GMT Subject: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 14:55:31 GMT, Robert Lichtenberger wrote: >> Oh, I see the problem. In addition to rebasing you need to exclude any commits that are from the `master` branch and are not your. So what you really need to do is: >> >> git rebase -i upstream/jfx14 >> >> git push --force origin JDK-8236912 >> >> Sorry for not anticipating this problem. > >> Sorry for not anticipating this problem. > I am sorry for not knowing git well enough. Thank you for your patience and help ;-). I think the PR now contains what it should ;-). Yes, it looks fine now, so it is ready for review. And this is one thing that can be a bit tricky about using git with multiple branches. Btw, I was going to suggest `git rebase -i` the first time (it's what I always do in such a situation), but thought I could save you a step. Lesson learned. :) ------------- PR: https://git.openjdk.java.net/jfx/pull/85 From johan.vos at gluonhq.com Tue Jan 14 15:22:08 2020 From: johan.vos at gluonhq.com (Johan Vos) Date: Tue, 14 Jan 2020 16:22:08 +0100 Subject: Backport 8224636 to OpenJFX 11 Message-ID: Hi Kevin, I request permission to backport JDK-8224636 to OpenJFX 11 (11-dev). The patch applies clean. - Johan From kevin.rushforth at oracle.com Tue Jan 14 15:25:14 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 14 Jan 2020 07:25:14 -0800 Subject: Backport 8224636 to OpenJFX 11 In-Reply-To: References: Message-ID: <255fe8f5-8211-167b-4c89-6dd73af334ee@oracle.com> Approved. On 1/14/2020 7:22 AM, Johan Vos wrote: > Hi Kevin, > > I request permission to backport JDK-8224636 to OpenJFX 11 (11-dev). > The patch applies clean. > > - Johan From arapte at openjdk.java.net Tue Jan 14 16:50:31 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Tue, 14 Jan 2020 16:50:31 GMT Subject: RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: References: Message-ID: On Fri, 10 Jan 2020 00:39:53 GMT, Kevin Rushforth wrote: >> I'll review this next week. This seems a fine candidate for openjfx14, so it (along with a couple other pending reviews that can be for 14) will be a good test of targeting a PR to the stabilization branch. >> >> I also request @arapte to review. > > I should add that it will depend on whether there are any regressions. One thing we do need to be careful of is introducing regressions during rampdown. The fix looks good to me. After this change the steps needed for playing an `Animation` backwards will change. Earlier this was documented with `Animation.play()` API as below. ------------- To play an `Animation` backwards from the end: animation.setRate(negative rate); animation.jumpTo(overall duration of animation); animation.play(); ------------- After this PR call to `jumpTo()` won't be needed here. So this PR may need a document change for `Animation.play()`. Also to note that the behavior of above mentioned three calls remains same with the changes in this change. ------------- PR: https://git.openjdk.java.net/jfx/pull/82 From kevin.rushforth at oracle.com Tue Jan 14 17:02:49 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 14 Jan 2020 09:02:49 -0800 Subject: [14] RFR: Request to sync January 2020 CPU changes into jfx [jfx14 branch] Message-ID: <65a9396a-6e8c-d0c4-535a-8297625cecf4@oracle.com> Johan and Phil, I request approval to sync changes from to the just-released January 2020 CPU release into the 'jfx14' branch of the 'jfx' repo. Here is the aggregate set of changes for the fixes: https://github.com/kevinrushforth/jfx/compare/f907026...16cea41 The aggregate diffs are empty, since subsequent changes in mainline superseded each of these fixes, but it is still a good idea to push them (as we have done in the past in similar situations). NOTE: Since this is an integration of already-reviewed fixes into the jfx14 branch of the jfx repo, I will push it directly rather than via a pull request. -- Kevin From kevin.rushforth at oracle.com Tue Jan 14 17:03:16 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 14 Jan 2020 09:03:16 -0800 Subject: [11][13] RFR: Request to backport October 2019 CPU changes Message-ID: Hi Johan, I request approval to backport the changes from the just-released January 2020 CPU to 11-dev and 13-dev. https://cr.openjdk.java.net/~kcr/cpu-2001-sync/11-dev/webrev/ This is a straight backport (patch applies cleanly) of the four FX fixes that went into the January CPU. The 13-dev patches are 100% identical to the 11-dev, so I only posted one of them. Thanks. -- Kevin From johan.vos at gluonhq.com Tue Jan 14 17:06:03 2020 From: johan.vos at gluonhq.com (Johan Vos) Date: Tue, 14 Jan 2020 18:06:03 +0100 Subject: [14] RFR: Request to sync January 2020 CPU changes into jfx [jfx14 branch] In-Reply-To: <65a9396a-6e8c-d0c4-535a-8297625cecf4@oracle.com> References: <65a9396a-6e8c-d0c4-535a-8297625cecf4@oracle.com> Message-ID: Approved. On Tue, Jan 14, 2020, 18:03 Kevin Rushforth wrote: > Johan and Phil, > > I request approval to sync changes from to the just-released January > 2020 CPU release into the 'jfx14' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: > > https://github.com/kevinrushforth/jfx/compare/f907026...16cea41 > > The aggregate diffs are empty, since subsequent changes in mainline > superseded each of these fixes, but it is still a good idea to push them > (as we have done in the past in similar situations). > > NOTE: Since this is an integration of already-reviewed fixes into the > jfx14 branch of the jfx repo, I will push it directly rather than via a > pull request. > > -- Kevin > > From johan.vos at gluonhq.com Tue Jan 14 17:06:35 2020 From: johan.vos at gluonhq.com (Johan Vos) Date: Tue, 14 Jan 2020 18:06:35 +0100 Subject: [11][13] RFR: Request to backport October 2019 CPU changes In-Reply-To: References: Message-ID: Approved. On Tue, Jan 14, 2020, 18:04 Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the changes from the just-released > January 2020 CPU to 11-dev and 13-dev. > > https://cr.openjdk.java.net/~kcr/cpu-2001-sync/11-dev/webrev/ > > This is a straight backport (patch applies cleanly) of the four FX fixes > that went into the January CPU. The 13-dev patches are 100% identical to > the 11-dev, so I only posted one of them. > > Thanks. > > -- Kevin > > > From johan.vos at gluonhq.com Tue Jan 14 17:46:10 2020 From: johan.vos at gluonhq.com (Johan Vos) Date: Tue, 14 Jan 2020 18:46:10 +0100 Subject: RFR: Request to backport patches into JFX-11 Message-ID: Hi Kevin, I ask permission to backport the following issues into 11-dev: JDK-8231590 : Update location of jfx repo to GitHub in third-party legal files JDK-8231854 : Change Mercurial to git in various README files JDK-8218640 : Update ICU4C to version 64.2 JDK-8232522 : FX: Update copyright year in docs, readme files to 2020 - Johan From kevin.rushforth at oracle.com Tue Jan 14 17:51:56 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 14 Jan 2020 09:51:56 -0800 Subject: RFR: Request to backport patches into JFX-11 In-Reply-To: References: Message-ID: <460a2c7a-e9c2-73bc-1bad-d832a57e5548@oracle.com> Approved. -- Kevin On 1/14/2020 9:46 AM, Johan Vos wrote: > Hi Kevin, > > I ask permission to backport the following issues into 11-dev: > > JDK-8231590 : Update > location of jfx repo to GitHub in third-party legal files > JDK-8231854 : Change > Mercurial to git in various README files > JDK-8218640 : Update > ICU4C to version 64.2 > JDK-8232522 : FX: Update > copyright year in docs, readme files to 2020 > > - Johan From swpalmer at gmail.com Tue Jan 14 19:22:50 2020 From: swpalmer at gmail.com (Scott Palmer) Date: Tue, 14 Jan 2020 14:22:50 -0500 Subject: RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: References: Message-ID: <7A65156C-D306-48E1-A43C-5720C70439E2@gmail.com> > On Jan 14, 2020, at 11:50 AM, Ambarish Rapte wrote: > > On Fri, 10 Jan 2020 00:39:53 GMT, Kevin Rushforth wrote: > >>> I'll review this next week. This seems a fine candidate for openjfx14, so it (along with a couple other pending reviews that can be for 14) will be a good test of targeting a PR to the stabilization branch. >>> >>> I also request @arapte to review. >> >> I should add that it will depend on whether there are any regressions. One thing we do need to be careful of is introducing regressions during rampdown. > > The fix looks good to me. > After this change the steps needed for playing an `Animation` backwards will change. > Earlier this was documented with `Animation.play()` API as below. > ------------- > To play an `Animation` backwards from the end: > animation.setRate(negative rate); > animation.jumpTo(overall duration of animation); > animation.play(); > ------------- > > After this PR call to `jumpTo()` won't be needed here. > So this PR may need a document change for `Animation.play()`. > Also to note that the behavior of above mentioned three calls remains same with the changes in this change. If the jumpTo isn?t required, then this isn?t this a change in behaviour? I?m wonder in particular if this has an effect on cycleCount. If cycleCount is set to 2 does the animation play the same number of times with or without the jumpTo both before and after this change? Scott From tsayao at openjdk.java.net Wed Jan 15 02:16:09 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Wed, 15 Jan 2020 02:16:09 GMT Subject: [Rev 12] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > - Removes Applet/Web Start code. > > In general it reduces code size and complexity and hands more work to gtk. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - 2bfac077: Mouse pointer grab Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/4b555624..2bfac077 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.12 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.11-12 Stats: 94 lines in 3 files changed: 81 ins; 10 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From nlisker at gmail.com Wed Jan 15 06:15:05 2020 From: nlisker at gmail.com (Nir Lisker) Date: Wed, 15 Jan 2020 08:15:05 +0200 Subject: Running Web-Tests from eclipse In-Reply-To: References: Message-ID: I updated the eclipse instructions. Have a look. Thanks, Nir On Tue, Jan 14, 2020 at 1:01 PM Robert Lichtenberger < r.lichtenberger at gmail.com> wrote: > As a follow-up to the long thread on using an IDE. I just found out that > running test.javafx.scene.web.WebViewTest is not possible with > -Djavafx.toolkit=test.com.sun.javafx.pgstub.StubToolkit. > > The test simply fails to start (waiting forever for > com.sun.javafx.application.PlatformImpl.startupLatch). > > Instead one needs to add the graphics library and the webkit library with > e.g. > > -Djava.library.path=/home/rli/PWEs/jfx/modules/javafx.graphics/build/module-lib:/home/rli/PWEs/jfx/modules/javafx.web/build/module-lib > > Maybe this could also be added to the wiki page? > From r.lichtenberger at gmail.com Wed Jan 15 06:54:55 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Wed, 15 Jan 2020 07:54:55 +0100 Subject: Running Web-Tests from eclipse In-Reply-To: References: Message-ID: This looks good to me. Thanks, Robert Am Mi., 15. Jan. 2020 um 07:15 Uhr schrieb Nir Lisker : > I updated the eclipse instructions. Have a look. > > Thanks, > Nir > > On Tue, Jan 14, 2020 at 1:01 PM Robert Lichtenberger < > r.lichtenberger at gmail.com> wrote: > >> As a follow-up to the long thread on using an IDE. I just found out that >> running test.javafx.scene.web.WebViewTest is not possible with >> -Djavafx.toolkit=test.com.sun.javafx.pgstub.StubToolkit. >> >> The test simply fails to start (waiting forever for >> com.sun.javafx.application.PlatformImpl.startupLatch). >> >> Instead one needs to add the graphics library and the webkit library with >> e.g. >> >> -Djava.library.path=/home/rli/PWEs/jfx/modules/javafx.graphics/build/module-lib:/home/rli/PWEs/jfx/modules/javafx.web/build/module-lib >> >> Maybe this could also be added to the wiki page? >> > From johan.vos at gluonhq.com Wed Jan 15 10:30:33 2020 From: johan.vos at gluonhq.com (Johan Vos) Date: Wed, 15 Jan 2020 11:30:33 +0100 Subject: RFR: 8237194: increase release version in 11-dev Message-ID: Hi Kevin, Please review http://cr.openjdk.java.net/~jvos/8237194/webrev.00/ which is a fix for https://bugs.openjdk.java.net/browse/JDK-8237194 Thanks, - Johan From johan.vos at gluonhq.com Wed Jan 15 10:44:01 2020 From: johan.vos at gluonhq.com (Johan Vos) Date: Wed, 15 Jan 2020 11:44:01 +0100 Subject: RFR: 8237195: increase release version in 13-dev Message-ID: Hi Kevin, Please review http://cr.openjdk.java.net/~jvos/8237195/webrev.00/ which fixes https://bugs.openjdk.java.net/browse/JDK-8237195 Thanks, - Johan From kevin.rushforth at oracle.com Wed Jan 15 14:46:37 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 15 Jan 2020 06:46:37 -0800 Subject: RFR: 8237194: increase release version in 11-dev In-Reply-To: References: Message-ID: +1 -- Kevin On 1/15/2020 2:30 AM, Johan Vos wrote: > Hi Kevin, > > Please review http://cr.openjdk.java.net/~jvos/8237194/webrev.00/ which is > a fix for https://bugs.openjdk.java.net/browse/JDK-8237194 > > Thanks, > > - Johan From kevin.rushforth at oracle.com Wed Jan 15 14:47:03 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 15 Jan 2020 06:47:03 -0800 Subject: RFR: 8237195: increase release version in 13-dev In-Reply-To: References: Message-ID: +1 -- Kevin On 1/15/2020 2:44 AM, Johan Vos wrote: > Hi Kevin, > > Please review http://cr.openjdk.java.net/~jvos/8237195/webrev.00/ which > fixes https://bugs.openjdk.java.net/browse/JDK-8237195 > > Thanks, > > - Johan From johan.vos at gluonhq.com Wed Jan 15 16:46:51 2020 From: johan.vos at gluonhq.com (Johan Vos) Date: Wed, 15 Jan 2020 17:46:51 +0100 Subject: RFR: 8237203: release notes for 13.0.2 Message-ID: Hi Kevin, Please review http://cr.openjdk.java.net/~jvos/8237203/webrev.00/ which provides a fix for https://bugs.openjdk.java.net/browse/JDK-8237203 thanks, - Johan From kevin.rushforth at oracle.com Wed Jan 15 16:49:04 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 15 Jan 2020 08:49:04 -0800 Subject: RFR: 8237203: release notes for 13.0.2 In-Reply-To: References: Message-ID: <86456747-edd2-f4f3-c9f1-e05df340e6bd@oracle.com> +1 -- Kevin On 1/15/2020 8:46 AM, Johan Vos wrote: > Hi Kevin, > > Please review http://cr.openjdk.java.net/~jvos/8237203/webrev.00/ which > provides a fix for https://bugs.openjdk.java.net/browse/JDK-8237203 > > thanks, > > - Johan From ebresiedev at gmail.com Wed Jan 15 20:42:01 2020 From: ebresiedev at gmail.com (Eric Bresie) Date: Wed, 15 Jan 2020 14:42:01 -0600 Subject: "Using an IDE" Page outdated (Openjfx) In-Reply-To: CA+0ynh9g3SubanxaDM3hVy6wVxLK6qWH6r_1yOadvz_wansStA@mail.gmail.com References: CA+f4zAEcxMyDG5PKk5hQB5ziKA2fCth7aAiBkwTjLtb_T0RJ6g@mail.gmail.com CA+f4zAEcxMyDG5PKk5hQB5ziKA2fCth7aAiBkwTjLtb_T0RJ6g@mail.gmail.com Message-ID: <939010e4-7425-475c-9b54-b612a4cf6e24@Erics-iPhone-X> Anyone on the Netbeans community want to provide any updates on the openjfx IDE page listed below? Eric Bresie Ebresie at gmail.com > On January 10, 2020 at 10:52:26 AM CST, Nir Lisker wrote: > Hi Robert, > > I've brought this up in the past. > > I think that the best solution is for someone from the community to take > that task. I try to keep the Eclipse section updated, we will need someone > for the other IDE's. > > - Nir > > On Fri, Jan 10, 2020 at 10:54 AM Robert Lichtenberger < > r.lichtenberger at gmail.com> wrote: > > > I've noticed that > > https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE > > seems a bit outdated (refers to JDK 1.8, a folder named "rt", which no > > longer exists, etc.). > > > > Could someone please update this page so that it is easier for newcomers to > > dive into the development of OpenJFX. > > > > Thanks, > > Robert > > From nlisker at openjdk.java.net Thu Jan 16 01:06:49 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Thu, 16 Jan 2020 01:06:49 GMT Subject: RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 16:50:12 GMT, Ambarish Rapte wrote: >> I should add that it will depend on whether there are any regressions. One thing we do need to be careful of is introducing regressions during rampdown. > > The fix looks good to me. > After this change the steps needed for playing an `Animation` backwards will change. > Earlier this was documented with `Animation.play()` API as below. > > ------------- > To play an `Animation` backwards from the end: > animation.setRate(negative rate); > animation.jumpTo(overall duration of animation); > animation.play(); > ------------- > > After this PR call to `jumpTo()` won't be needed here. > So this PR may need a document change for `Animation.play()`. > Also to note that the behavior of above mentioned three calls remains same with the changes in this change. > If cycleCount is set to 2 does the animation play the same number of times with or without the jumpTo both before and after this change? Before the change: * With `jumpTo`: plays backwards 2 times. * Without `jumpTo`: doesn't play no mater how many times you call `play()`. Compare with the case where `cycleCount` is 1, in which case the first call does nothing (moves the playing head to the start) and the second one plays backwards. After the change: * With `jumpTo`: plays backwards 2 times. * Without `jumpTo`: plays backwards 2 times. > If the jumpTo isn't required, then this isn't this a change in behaviour? Current code with `jumpTo` will behave the same. The question (which I presented initially) is whether this behavior is considered a bug or not when it comes to the initial state of an animation. It is certainly a bug when `stop()` is called, so I assume it is similar for the initial state. ------------- PR: https://git.openjdk.java.net/jfx/pull/82 From nlisker at openjdk.java.net Thu Jan 16 01:10:11 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Thu, 16 Jan 2020 01:10:11 GMT Subject: RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: References: Message-ID: On Thu, 16 Jan 2020 01:06:30 GMT, Nir Lisker wrote: >> The fix looks good to me. >> After this change the steps needed for playing an `Animation` backwards will change. >> Earlier this was documented with `Animation.play()` API as below. >> >> ------------- >> To play an `Animation` backwards from the end: >> animation.setRate(negative rate); >> animation.jumpTo(overall duration of animation); >> animation.play(); >> ------------- >> >> After this PR call to `jumpTo()` won't be needed here. >> So this PR may need a document change for `Animation.play()`. >> Also to note that the behavior of above mentioned three calls remains same with the changes in this change. > >> If cycleCount is set to 2 does the animation play the same number of times with or without the jumpTo both before and after this change? > > Before the change: > * With `jumpTo`: plays backwards 2 times. > * Without `jumpTo`: doesn't play no mater how many times you call `play()`. Compare with the case where `cycleCount` is 1, in which case the first call does nothing (moves the playing head to the start) and the second one plays backwards. > > After the change: > * With `jumpTo`: plays backwards 2 times. > * Without `jumpTo`: plays backwards 2 times. > >> If the jumpTo isn't required, then this isn't this a change in behaviour? > > Current code with `jumpTo` will behave the same. The question (which I presented initially) is whether this behavior is considered a bug or not when it comes to the initial state of an animation. It is certainly a bug when `stop()` is called, so I assume it is similar for the initial state. > So this PR may need a document change for `Animation.play()` Yes, and the docs need clarification in other places anyway. The [parent issue](https://bugs.openjdk.java.net/browse/JDK-8210238) from which this bug was isolated talks about these. Not sure at what point I will go over it since `Animation` is going to get some more changes in the (hopefully) near future. ------------- PR: https://git.openjdk.java.net/jfx/pull/82 From tom.schindl at bestsolution.at Thu Jan 16 07:31:04 2020 From: tom.schindl at bestsolution.at (Tom Schindl) Date: Thu, 16 Jan 2020 08:31:04 +0100 Subject: DnD Move does not work on OS-X In-Reply-To: <6da9010f-e888-6cdb-79cf-35ed844a052d@bestsolution.at> References: <6da9010f-e888-6cdb-79cf-35ed844a052d@bestsolution.at> Message-ID: I filed https://bugs.openjdk.java.net/browse/JDK-8237329 Tom On 09.01.20 15:48, Tom Schindl wrote: > I also tried with > https://docs.oracle.com/javafx/2/drag_drop/jfxpub-drag_drop.htm and it > does not work either. -- Tom Schindl, CTO BestSolution.at EDV Systemhaus GmbH Salurnerstrasse 15. A-6020 Innsbruck Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck From arapte at openjdk.java.net Thu Jan 16 11:28:52 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Thu, 16 Jan 2020 11:28:52 GMT Subject: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: <24CUZqZ2Q14eKcfZHO_3N7R0Xh6Y2OflY1gQKEk2TJs=.1e454465-c305-4111-b35a-6a29ff8f1046@github.com> On Thu, 16 Jan 2020 10:55:11 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1306: > >> 1305: int verticalTileNb = (int) Math.ceil(height / (double) maxTextureSize); >> 1306: int horizontalTileNb = (int) Math.ceil(width / (double) maxTextureSize); >> 1307: for (int i = 0; i < horizontalTileNb; i++) { > > A suggestion for this arithmetic. > int verticalTileNb = height / maxTextureSize + 1; > int horizontalTileNb = width / maxTextureSize + 1; > This will avoid the type casting and floating point operations. However I leave it to you to change or not. Assuming `Nb` in `verticalTileNb` stands for number, I would recommend to change the names as `numVerticalTiles` and `numHorizontalTiles` ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From arapte at openjdk.java.net Thu Jan 16 11:28:50 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Thu, 16 Jan 2020 11:28:50 GMT Subject: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: On Thu, 16 Jan 2020 11:28:46 GMT, Frederic Thevenet wrote: >> This PR aims to address the following issue: JDK-8088198 Exception thrown from snapshot if dimensions are larger than max texture size >> >> In order to do that, it simply captures snapshots in multiple tiles of maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the tiles into a a single image. >> Other than that, the logic used to do the actual snapshot is unchanged. >> >> Tests using the existing SnapshotCommon class have been added in a new file named Snapshot3Test under SystemTest/test/javafx/scene. >> These tests pass with the proposed fix, and fail without, throwing " java.lang.IllegalArgumentException: Unrecognized image loader: null" > > The pull request has been updated with 1 additional commit. The fix itself looks good and seems safe for 14. I do have few minor changes in test file and suggestions in fix code, please take a look. Also verified that large sized snapshots are created correctly. modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1303: > 1302: if (height > maxTextureSize || width > maxTextureSize) { > 1303: // The requested size for the screenshot is to big to fit a single texture, > 1304: // so we need to take several snapshot tiles and merge them into single image (fixes JDK-8088198) Should be `too` big to fit modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1306: > 1305: int verticalTileNb = (int) Math.ceil(height / (double) maxTextureSize); > 1306: int horizontalTileNb = (int) Math.ceil(width / (double) maxTextureSize); > 1307: for (int i = 0; i < horizontalTileNb; i++) { A suggestion for this arithmetic. int verticalTileNb = height / maxTextureSize + 1; int horizontalTileNb = width / maxTextureSize + 1; This will avoid the type casting and floating point operations. However I leave it to you to change or not. modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1312: > 1311: int tileWidth = Math.min(maxTextureSize, width - xOffset); > 1312: int tileHeight = Math.min(maxTextureSize, height - yOffset); > 1313: WritableImage tile = doSnapshotTile(scene, xMin + xOffset, yMin + yOffset, tileWidth, tileHeight, root, transform, depthBuffer, fill, camera, null); `int xOffset = i * maxTextureSize;` `int tileWidth = Math.min(maxTextureSize, width - xOffset);` These two lines should be moved to the outer loop of horizontal tabs. tests/system/src/test/java/test/javafx/scene/Snapshot3Test.java line 1: > 1: package test.javafx.scene; > 2: Copyright header should be added to all new files. You can copy the header from any other file ([header sample](https://github.com/openjdk/jfx/blob/20325e1c3ec4c4e81af74d3d43bf3a803dbe1a51/tests/system/src/test/java/test/javafx/scene/Snapshot2Test.java#L1).) Only change would be that, this file would contain only year `2020` in the copyright header. tests/system/src/test/java/test/javafx/scene/Snapshot3Test.java line 39: > 38: public void teardownEach() { > 39: } > 40: This empty method is not needed. tests/system/src/test/java/test/javafx/scene/Snapshot3Test.java line 65: > 64: > 65: Please remove the extra empty lines, 3, 62, 65. tests/system/src/test/java/test/javafx/scene/Snapshot3Test.java line 59: > 58: Image image = rect.snapshot(params, null); > 59: assertEquals(VALUE_LARGER_THAN_TEXTURE_SIZE, (int) image.getHeight()); > 60: }); Should add `assertNull(image);` before the `assertEquals` tests/system/src/test/java/test/javafx/scene/Snapshot3Test.java line 11: > 10: > 11: import static org.junit.Assert.*; > 12: Usually we avoid wild imports and import only the specific classes. ------------- Changes requested by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/68 From mpaus at openjdk.java.net Thu Jan 16 11:56:20 2020 From: mpaus at openjdk.java.net (Michael Paus) Date: Thu, 16 Jan 2020 11:56:20 GMT Subject: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: <24CUZqZ2Q14eKcfZHO_3N7R0Xh6Y2OflY1gQKEk2TJs=.1e454465-c305-4111-b35a-6a29ff8f1046@github.com> References: <24CUZqZ2Q14eKcfZHO_3N7R0Xh6Y2OflY1gQKEk2TJs=.1e454465-c305-4111-b35a-6a29ff8f1046@github.com> Message-ID: <2iH6z7Dd7E8YmNP5c09iujnjjlD_BnYYMJBM0QeJ4lc=.c1e76c10-abe4-4633-864e-71b2ab07c840@github.com> On Thu, 16 Jan 2020 10:55:38 GMT, Ambarish Rapte wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1306: >> >>> 1305: int verticalTileNb = (int) Math.ceil(height / (double) maxTextureSize); >>> 1306: int horizontalTileNb = (int) Math.ceil(width / (double) maxTextureSize); >>> 1307: for (int i = 0; i < horizontalTileNb; i++) { >> >> A suggestion for this arithmetic. >> int verticalTileNb = height / maxTextureSize + 1; >> int horizontalTileNb = width / maxTextureSize + 1; >> This will avoid the type casting and floating point operations. However I leave it to you to change or not. > > Assuming `Nb` in `verticalTileNb` stands for number, I would recommend to change the names as `numVerticalTiles` and `numHorizontalTiles` I think the proposed code changes are wrong in case that `height / maxTextureSize` is an exact integer. (Same for width). I normally add the 1 only if `height % maxTextureSize != 0` ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From arapte at openjdk.java.net Thu Jan 16 11:59:47 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Thu, 16 Jan 2020 11:59:47 GMT Subject: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: On Thu, 16 Jan 2020 11:28:21 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > The fix itself looks good and seems safe for 14. > I do have few minor changes in test file and suggestions in fix code, please take a look. > Also verified that large sized snapshots are created correctly. > > > Upon closer inspection, I believe that the tests I added in Snapshot3Test are indeed redundant and less complete than the 4 ignored test in Snapshot2Test. > I therefore propose to remove Snapshot3Test.java entirely and to re-enable the 4 testSnapshotBig* test instead. I did miss this comment, The test in `Snapshot2Test` look sufficient and you can get rid of `Snapshot3Test.java` and so all my comments :) ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From github.com+7450507+fthevenet at openjdk.java.net Thu Jan 16 13:57:00 2020 From: github.com+7450507+fthevenet at openjdk.java.net (Frederic Thevenet) Date: Thu, 16 Jan 2020 13:57:00 GMT Subject: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: <2iH6z7Dd7E8YmNP5c09iujnjjlD_BnYYMJBM0QeJ4lc=.c1e76c10-abe4-4633-864e-71b2ab07c840@github.com> References: <24CUZqZ2Q14eKcfZHO_3N7R0Xh6Y2OflY1gQKEk2TJs=.1e454465-c305-4111-b35a-6a29ff8f1046@github.com> <2iH6z7Dd7E8YmNP5c09iujnjjlD_BnYYMJBM0QeJ4lc=.c1e76c10-abe4-4633-864e-71b2ab07c840@github.com> Message-ID: On Thu, 16 Jan 2020 11:56:10 GMT, Michael Paus wrote: >> Assuming `Nb` in `verticalTileNb` stands for number, I would recommend to change the names as `numVerticalTiles` and `numHorizontalTiles` > > I think the proposed code changes are wrong in case that `height / maxTextureSize` is an exact integer. (Same for width). I normally add the 1 only if `height % maxTextureSize != 0` Indeed, substituting the floating math for integer math requires an extra test on the remainder to be correct. Since this code isn't located in a tight loop, I'm not sure this optimization is worth making the code less straight forward. What do you all think? ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From github.com+7450507+fthevenet at openjdk.java.net Thu Jan 16 14:07:26 2020 From: github.com+7450507+fthevenet at openjdk.java.net (Frederic Thevenet) Date: Thu, 16 Jan 2020 14:07:26 GMT Subject: [Rev 02] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: > This PR aims to address the following issue: JDK-8088198 Exception thrown from snapshot if dimensions are larger than max texture size > > In order to do that, it simply captures snapshots in multiple tiles of maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the tiles into a a single image. > Other than that, the logic used to do the actual snapshot is unchanged. > > Tests using the existing SnapshotCommon class have been added in a new file named Snapshot3Test under SystemTest/test/javafx/scene. > These tests pass with the proposed fix, and fail without, throwing " java.lang.IllegalArgumentException: Unrecognized image loader: null" The pull request has been updated with 2 additional commits. ------------- Added commits: - 50191728: Several changes following code review - d4ecb734: Removed Snapshot3Test.java and re-enabled ignored tests in Snapshot2Test.java Changes: - all: https://git.openjdk.java.net/jfx/pull/68/files - new: https://git.openjdk.java.net/jfx/pull/68/files/9986809d..50191728 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/68/webrev.02 - incr: https://webrevs.openjdk.java.net/jfx/68/webrev.01-02 Stats: 82 lines in 3 files changed: 1 ins; 71 del; 10 mod Patch: https://git.openjdk.java.net/jfx/pull/68.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/68/head:pull/68 PR: https://git.openjdk.java.net/jfx/pull/68 From mpaus at openjdk.java.net Thu Jan 16 14:16:51 2020 From: mpaus at openjdk.java.net (Michael Paus) Date: Thu, 16 Jan 2020 14:16:51 GMT Subject: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: <24CUZqZ2Q14eKcfZHO_3N7R0Xh6Y2OflY1gQKEk2TJs=.1e454465-c305-4111-b35a-6a29ff8f1046@github.com> <2iH6z7Dd7E8YmNP5c09iujnjjlD_BnYYMJBM0QeJ4lc=.c1e76c10-abe4-4633-864e-71b2ab07c840@github.com> Message-ID: On Thu, 16 Jan 2020 13:56:44 GMT, Frederic Thevenet wrote: >> I think the proposed code changes are wrong in case that `height / maxTextureSize` is an exact integer. (Same for width). I normally add the 1 only if `height % maxTextureSize != 0` > > Indeed, substituting the floating math for integer math requires an extra test on the remainder to be correct. > Since this code isn't located in a tight loop, I'm not sure this optimization is worth making the code less straight forward. What do you all think? I think it is not worth it. ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From kcr at openjdk.java.net Thu Jan 16 14:26:36 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 16 Jan 2020 14:26:36 GMT Subject: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: <24CUZqZ2Q14eKcfZHO_3N7R0Xh6Y2OflY1gQKEk2TJs=.1e454465-c305-4111-b35a-6a29ff8f1046@github.com> <2iH6z7Dd7E8YmNP5c09iujnjjlD_BnYYMJBM0QeJ4lc=.c1e76c10-abe4-4633-864e-71b2ab07c840@github.com> Message-ID: On Thu, 16 Jan 2020 14:16:37 GMT, Michael Paus wrote: >> Indeed, substituting the floating math for integer math requires an extra test on the remainder to be correct. >> Since this code isn't located in a tight loop, I'm not sure this optimization is worth making the code less straight forward. What do you all think? > > I think it is not worth it. I agree. I do like the suggestion to rename the variables, though. ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From github.com+7450507+fthevenet at openjdk.java.net Thu Jan 16 16:19:58 2020 From: github.com+7450507+fthevenet at openjdk.java.net (Frederic Thevenet) Date: Thu, 16 Jan 2020 16:19:58 GMT Subject: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: <_KvVLKw85jkJ5h2Ktk4U9dqTIHdVmhujxTVvFcAMJSE=.e9213e77-1853-49fb-b985-e67bfb8fae45@github.com> On Thu, 16 Jan 2020 10:58:12 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1312: > >> 1311: int tileWidth = Math.min(maxTextureSize, width - xOffset); >> 1312: int tileHeight = Math.min(maxTextureSize, height - yOffset); >> 1313: WritableImage tile = doSnapshotTile(scene, xMin + xOffset, yMin + yOffset, tileWidth, tileHeight, root, transform, depthBuffer, fill, camera, null); > > `int xOffset = i * maxTextureSize;` > `int tileWidth = Math.min(maxTextureSize, width - xOffset);` > > These two lines should be moved to the outer loop of horizontal tabs. done in 501917284e0490d16b1831fcd854e31a779449b9 ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From github.com+7450507+fthevenet at openjdk.java.net Thu Jan 16 16:20:38 2020 From: github.com+7450507+fthevenet at openjdk.java.net (Frederic Thevenet) Date: Thu, 16 Jan 2020 16:20:38 GMT Subject: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: On Thu, 16 Jan 2020 10:47:26 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1303: > >> 1302: if (height > maxTextureSize || width > maxTextureSize) { >> 1303: // The requested size for the screenshot is to big to fit a single texture, >> 1304: // so we need to take several snapshot tiles and merge them into single image (fixes JDK-8088198) > > Should be `too` big to fit done in 501917284e0490d16b1831fcd854e31a779449b9 ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From wookey.dean at gmail.com Thu Jan 16 16:33:36 2020 From: wookey.dean at gmail.com (Dean Wookey) Date: Thu, 16 Jan 2020 18:33:36 +0200 Subject: CssStyleHelper canReuseStyleHelper Message-ID: Hi Ajit, David, I came accross a potential issue introduced by JDK-8090462 ( https://bugs.openjdk.java.net/browse/JDK-8090462), ( https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab). The issue is in the canReuseStyleHelper method. canReuseStyleHelper is called as a result of changes to the scene graph and for other reasons. The original code found the parent helper in the following way: Styleable parent = node.getStyleableParent(); while (parent != null) { if (parent instanceof Node) { parentHelper = ((Node) parent).styleHelper; if (parentHelper != null) break; } parent = parent.getStyleableParent(); } This gets the parent helper for the new parent of the node. The code now ( https://github.com/openjdk/jfx/blob/20325e1c3ec4c4e81af74d3d43bf3a803dbe1a51/modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java#L322 ): CssStyleHelper parentHelper = getStyleHelper(node.styleHelper.firstStyleableAncestor); gets the helper of the previous parent of the node since firstStyleableAncestor hasn't been updated to reflect the current state of the scene graph yet. This means if you move a node, it could keep its CssStyleHelper even if it's under completely new parents. I'm not sure if this is actually causing any problems. It would be helpful if I knew the kind of things that could go wrong if you reuse a style helper so that I could design a test that highlighted the issue. Can you perhaps think of cases where this could go badly? Dean From github.com+7450507+fthevenet at openjdk.java.net Thu Jan 16 16:45:31 2020 From: github.com+7450507+fthevenet at openjdk.java.net (Frederic Thevenet) Date: Thu, 16 Jan 2020 16:45:31 GMT Subject: [Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: <24CUZqZ2Q14eKcfZHO_3N7R0Xh6Y2OflY1gQKEk2TJs=.1e454465-c305-4111-b35a-6a29ff8f1046@github.com> <2iH6z7Dd7E8YmNP5c09iujnjjlD_BnYYMJBM0QeJ4lc=.c1e76c10-abe4-4633-864e-71b2ab07c840@github.com> Message-ID: On Thu, 16 Jan 2020 14:26:24 GMT, Kevin Rushforth wrote: >> I think it is not worth it. > > I agree. I do like the suggestion to rename the variables, though. done in 501917284e0490d16b1831fcd854e31a779449b9 ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From nlisker at openjdk.java.net Thu Jan 16 17:00:50 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Thu, 16 Jan 2020 17:00:50 GMT Subject: [Rev 02] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: On Thu, 16 Jan 2020 17:00:47 GMT, Frederic Thevenet wrote: >> This PR aims to address the following issue: JDK-8088198 Exception thrown from snapshot if dimensions are larger than max texture size >> >> In order to do that, it simply captures snapshots in multiple tiles of maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the tiles into a a single image. >> Other than that, the logic used to do the actual snapshot is unchanged. >> >> Tests using the existing SnapshotCommon class have been added in a new file named Snapshot3Test under SystemTest/test/javafx/scene. >> These tests pass with the proposed fix, and fail without, throwing " java.lang.IllegalArgumentException: Unrecognized image loader: null" > > The pull request has been updated with 2 additional commits. I tested this fix against the repro code in https://github.com/javafxports/openjdk-jfx/issues/433 (which is [JDK-8222238](https://bugs.openjdk.java.net/browse/JDK-8222238)), but there is still an NPE. I'm not certain that this fix is supposed to solve that bug, but according to the comments, the root cause is the same as [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082), which is related to this one. It's worth to take a look to see if something was missed. modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1290: > 1289: int yMin = (int)Math.floor(y); > 1290: int xMax = (int)Math.ceil(x + w); > 1291: int yMax = (int)Math.ceil(y + h); While you're working in the area, this code can be written as int width, height; if (wimg == null) { int xMax = (int)Math.ceil(x + w); int yMax = (int)Math.ceil(y + h); width = Math.max(xMax - xMin, 1); height = Math.max(yMax - yMin, 1); wimg = new WritableImage(width, height); } else { to avoid unnecessary computations. modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1313: > 1312: int tileHeight = Math.min(maxTextureSize, height - yOffset); > 1313: WritableImage tile = doSnapshotTile(scene, xMin + xOffset, yMin + yOffset, tileWidth, tileHeight, root, transform, depthBuffer, fill, camera, null); > 1314: wimg.getPixelWriter().setPixels(xOffset, yOffset, tileWidth, tileHeight, tile.getPixelReader(), 0, 0); This line is too long and needs to break into 2. I think that the limit is 135 characters. modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1316: > 1315: } > 1316: } > 1317: } else { I would extract this code into its own method similar to `doSnapshotTile`: `assemble(scene, xMin, yMin, width, height, root, transform, depthBuffer, fill, camera, wimg, maxTextureSize);` (`assemble` is a bad name, I didn't think about a better one). The method can return he resulting `WritableImage`, but it is not needed since it is manipulated via "side-effects". I would, however, bring it line with the `else` clause - either both use `wimg = methodName(..., wimg, ...);` or just `methodName(..., wimg, ...);`. This is fine since the input `WritableImage` is never `null`. From a readability point of view, using return values seems better. ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From David.Grieve at microsoft.com Thu Jan 16 19:01:38 2020 From: David.Grieve at microsoft.com (David Grieve) Date: Thu, 16 Jan 2020 19:01:38 +0000 Subject: [EXTERNAL] CssStyleHelper canReuseStyleHelper In-Reply-To: References: Message-ID: I'd create a scenegraph R .-----+-----. A B .----+----. C D Where C and D are Labels. Then I'd set a font style on A and a different font style on B. C and D should pick up the font style of A. Then move D to B and see if it still has A's font style. It may be necessary to have a more deeply nested scene graph. The potential issue is that the node that got moved could pick up the old set of styles if the style helper is not renewed. Ultimately, canReuseStyleHelper will return false if the set of styles for the new parent (line 110 or so in CssStyleHelper.java) are different. > -----Original Message----- > From: openjfx-dev On Behalf Of > Dean Wookey > Sent: Thursday, January 16, 2020 11:34 AM > To: openjfx-dev at openjdk.java.net Mailing dev at openjdk.java.net>; David Grieve > Cc: aghaisas at openjdk.org > Subject: [EXTERNAL] CssStyleHelper canReuseStyleHelper > > Hi Ajit, David, > > I came accross a potential issue introduced by JDK-8090462 ( > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs > .openjdk.java.net%2Fbrowse%2FJDK- > 8090462&data=02%7C01%7Cdavid.grieve%40microsoft.com%7C235930d > fab7f4f7f15ba08d79aa21774%7C72f988bf86f141af91ab2d7cd011db47%7C1%7 > C0%7C637147893881930150&sdata=awsMTPYkp7GmSrYsoy9I6M%2F6uj > X7thgZhBVY9UKcjpU%3D&reserved=0), ( > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fopenjdk%2Fjfx%2Fcommit%2F834b0d05e7a2a8351403ec4a121ea > b312d80fd24%23diff- > 9ec098280fa1aeed53c70243347e76ab&data=02%7C01%7Cdavid.grieve% > 40microsoft.com%7C235930dfab7f4f7f15ba08d79aa21774%7C72f988bf86f141 > af91ab2d7cd011db47%7C1%7C0%7C637147893881930150&sdata=ZhWS > dmlJ9rLzIkqnohWTacJKPb8FNrG5yApF0fwP8g4%3D&reserved=0). > The issue is in the canReuseStyleHelper method. canReuseStyleHelper is > called as a result of changes to the scene graph and for other reasons. The > original code found the parent helper in the following way: > > Styleable parent = node.getStyleableParent(); > while (parent != null) { > if (parent instanceof Node) { > parentHelper = ((Node) parent).styleHelper; > if (parentHelper != null) break; > } > parent = parent.getStyleableParent(); > } > > This gets the parent helper for the new parent of the node. The code now ( > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fopenjdk%2Fjfx%2Fblob%2F20325e1c3ec4c4e81af74d3d43bf3a803 > dbe1a51%2Fmodules%2Fjavafx.graphics%2Fsrc%2Fmain%2Fjava%2Fjavafx% > 2Fscene%2FCssStyleHelper.java%23L322&data=02%7C01%7Cdavid.griev > e%40microsoft.com%7C235930dfab7f4f7f15ba08d79aa21774%7C72f988bf86f > 141af91ab2d7cd011db47%7C1%7C0%7C637147893881930150&sdata=nJR > 3ocKaIsf6HWNjHtseEbqLbEvbW7%2FzQS1B%2F39GVyI%3D&reserved= > 0 > ): > > CssStyleHelper parentHelper = > getStyleHelper(node.styleHelper.firstStyleableAncestor); > > gets the helper of the previous parent of the node since > firstStyleableAncestor hasn't been updated to reflect the current state of the > scene graph yet. This means if you move a node, it could keep its > CssStyleHelper even if it's under completely new parents. > > I'm not sure if this is actually causing any problems. It would be helpful if I > knew the kind of things that could go wrong if you reuse a style helper so > that I could design a test that highlighted the issue. > > Can you perhaps think of cases where this could go badly? > > Dean From r.lichtenberger at gmail.com Fri Jan 17 07:29:43 2020 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Fri, 17 Jan 2020 08:29:43 +0100 Subject: Correct branch for PR? Message-ID: I have a testcase + fix ready for JDK-8237372 (A null pointer exception in TabPaneSkin if only a mouse release event is sent to the skin). To avoid the kind of confusion I created with my last pull request ;-) * For what branch should I create the pull request? (From my point of view jfx14 is preferable, since this is a real bug affecting our software) * Will pull requests for jfx14 (like my last one) be automatically pushed forward to the master branch? Best regards, Robert From wookey.dean at gmail.com Fri Jan 17 09:50:29 2020 From: wookey.dean at gmail.com (Dean Wookey) Date: Fri, 17 Jan 2020 11:50:29 +0200 Subject: [EXTERNAL] CssStyleHelper canReuseStyleHelper In-Reply-To: References: Message-ID: Hi David, Thanks, I wrote that test as a graphics module test and it does fail. https://gist.github.com/DeanWookey/2624945e3ba037f00c39c0bfd0b22cef It passes if you move node.styleHelper.firstStyleableAncestor = findFirstStyleableAncestor(node); (line 134) to line 321. I imagine there is some performance impact if you do this. I'm not sure it affects anything other than fonts at the moment. Pseudoclasses recalculate the entire tree every time, so they appear to be fine. Dean On Thu, Jan 16, 2020 at 9:01 PM David Grieve wrote: > I'd create a scenegraph > > R > .-----+-----. > A B > .----+----. > C D > > Where C and D are Labels. Then I'd set a font style on A and a different > font style on B. > C and D should pick up the font style of A. Then move D to B and see if it > still has A's > font style. > > It may be necessary to have a more deeply nested scene graph. > > The potential issue is that the node that got moved could pick up the old > set of styles > if the style helper is not renewed. > > Ultimately, canReuseStyleHelper will return false if the set of styles for > the > new parent (line 110 or so in CssStyleHelper.java) are different. > > > -----Original Message----- > > From: openjfx-dev On Behalf Of > > Dean Wookey > > Sent: Thursday, January 16, 2020 11:34 AM > > To: openjfx-dev at openjdk.java.net Mailing > dev at openjdk.java.net>; David Grieve > > Cc: aghaisas at openjdk.org > > Subject: [EXTERNAL] CssStyleHelper canReuseStyleHelper > > > > Hi Ajit, David, > > > > I came accross a potential issue introduced by JDK-8090462 ( > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs > > .openjdk.java.net%2Fbrowse%2FJDK- > > 8090462&data=02%7C01%7Cdavid.grieve%40microsoft.com%7C235930d > > fab7f4f7f15ba08d79aa21774%7C72f988bf86f141af91ab2d7cd011db47%7C1%7 > > C0%7C637147893881930150&sdata=awsMTPYkp7GmSrYsoy9I6M%2F6uj > > X7thgZhBVY9UKcjpU%3D&reserved=0), ( > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > > ub.com%2Fopenjdk%2Fjfx%2Fcommit%2F834b0d05e7a2a8351403ec4a121ea > > b312d80fd24%23diff- > > 9ec098280fa1aeed53c70243347e76ab&data=02%7C01%7Cdavid.grieve% > > 40microsoft.com%7C235930dfab7f4f7f15ba08d79aa21774%7C72f988bf86f141 > > af91ab2d7cd011db47%7C1%7C0%7C637147893881930150&sdata=ZhWS > > dmlJ9rLzIkqnohWTacJKPb8FNrG5yApF0fwP8g4%3D&reserved=0). > > The issue is in the canReuseStyleHelper method. canReuseStyleHelper is > > called as a result of changes to the scene graph and for other reasons. > The > > original code found the parent helper in the following way: > > > > Styleable parent = node.getStyleableParent(); > > while (parent != null) { > > if (parent instanceof Node) { > > parentHelper = ((Node) parent).styleHelper; > > if (parentHelper != null) break; > > } > > parent = parent.getStyleableParent(); > > } > > > > This gets the parent helper for the new parent of the node. The code now > ( > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > > ub.com%2Fopenjdk%2Fjfx%2Fblob%2F20325e1c3ec4c4e81af74d3d43bf3a803 > > dbe1a51%2Fmodules%2Fjavafx.graphics%2Fsrc%2Fmain%2Fjava%2Fjavafx% > > 2Fscene%2FCssStyleHelper.java%23L322&data=02%7C01%7Cdavid.griev > > e%40microsoft.com%7C235930dfab7f4f7f15ba08d79aa21774%7C72f988bf86f > > 141af91ab2d7cd011db47%7C1%7C0%7C637147893881930150&sdata=nJR > > 3ocKaIsf6HWNjHtseEbqLbEvbW7%2FzQS1B%2F39GVyI%3D&reserved= > > 0 > > ): > > > > CssStyleHelper parentHelper = > > getStyleHelper(node.styleHelper.firstStyleableAncestor); > > > > gets the helper of the previous parent of the node since > > firstStyleableAncestor hasn't been updated to reflect the current state > of the > > scene graph yet. This means if you move a node, it could keep its > > CssStyleHelper even if it's under completely new parents. > > > > I'm not sure if this is actually causing any problems. It would be > helpful if I > > knew the kind of things that could go wrong if you reuse a style helper > so > > that I could design a test that highlighted the issue. > > > > Can you perhaps think of cases where this could go badly? > > > > Dean > From github.com+7450507+fthevenet at openjdk.java.net Fri Jan 17 11:28:17 2020 From: github.com+7450507+fthevenet at openjdk.java.net (Frederic Thevenet) Date: Fri, 17 Jan 2020 11:28:17 GMT Subject: [Rev 02] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: <16XxegMp9uAyf0Ni0BZBbd0npwtacp2YZtL7f7Fgvq0=.96a3a6cf-cbfd-4ffa-b7f7-8336914150f4@github.com> On Thu, 16 Jan 2020 17:00:32 GMT, Nir Lisker wrote: >> The pull request has been updated with 2 additional commits. > > I tested this fix against the repro code in https://github.com/javafxports/openjdk-jfx/issues/433 (which is [JDK-8222238](https://bugs.openjdk.java.net/browse/JDK-8222238)), but there is still an NPE. I'm not certain that this fix is supposed to solve that bug, but according to the comments, the root cause is the same as [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082), which is related to this one. It's worth to take a look to see if something was missed. > > > I tested this fix against the repro code in [javafxports/openjdk-jfx#433](https://github.com/javafxports/openjdk-jfx/issues/433) (which is [JDK-8222238](https://bugs.openjdk.java.net/browse/JDK-8222238)), but there is still an NPE. I'm not certain that this fix is supposed to solve that bug, but according to the comments, the root cause is the same as [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082), which is related to this one. It's worth to take a look to see if something was missed. Although JDK-8189082 (and potentially others) are indeed likely to share the same root cause, the fix proposed here won't have an effect on anything else than snapshots, since the tiling is done at the Scene level rather than within QuantumToolkit. I purposefully choose to take the "easy" way out to limit the potential side-effects of the change, but I agree that on the other hand supporting tiling when needed directly in QuantumToolkit::renderToImage would have the potential to solve a whole category of issues. Also, from a very pragmatic angle, because of the increased complexity and scope and the risks that come with it, I'm not very optimistic that this change could realistically make it into jfx14 and to be honest I'm quite eager to get the screenshot feature in my app working properly ASAP. I'd be willing to try and work on a more generic fix under the umbrella of JDK-8189082, that'd be targeted at 15, while still having this fix included as part 14; but that means this should (ideally) be reverted once it becomes useless. I don't know if the idea of having a "temporary fix" approach seems acceptable in that context. ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From thiago.sayao at clamed.com.br Fri Jan 17 11:32:44 2020 From: thiago.sayao at clamed.com.br (Thiago Milczarek Sayao) Date: Fri, 17 Jan 2020 11:32:44 +0000 Subject: Correct branch for PR? In-Reply-To: References: Message-ID: AFAIK, use master. They will decide to backport to a point release or not. ________________________________ De: openjfx-dev em nome de Robert Lichtenberger Enviado: sexta-feira, 17 de janeiro de 2020 04:29 Para: openjfx-dev at openjdk.java.net Mailing Assunto: Correct branch for PR? I have a testcase + fix ready for JDK-8237372 (A null pointer exception in TabPaneSkin if only a mouse release event is sent to the skin). To avoid the kind of confusion I created with my last pull request ;-) * For what branch should I create the pull request? (From my point of view jfx14 is preferable, since this is a real bug affecting our software) * Will pull requests for jfx14 (like my last one) be automatically pushed forward to the master branch? Best regards, Robert From wookey.dean at gmail.com Fri Jan 17 11:57:59 2020 From: wookey.dean at gmail.com (Dean Wookey) Date: Fri, 17 Jan 2020 13:57:59 +0200 Subject: [EXTERNAL] CssStyleHelper canReuseStyleHelper In-Reply-To: References: Message-ID: It's also a problem with variables defined in css, as well as inherited values like visibility (cursor seems to work differently), eg: .a { col: red; } .b { col: blue; } .leaf { -fx-background-color: col} Then move leaf from branch a to b. Likewise .a { visibility: collapse; } .b { visibility: visible; } .leaf { visibility: inherit;} If you move a node from branch a to branch b, it stays invisible. Again that one like fix solves all these problems. I've created JDK-8237469 . On Fri, Jan 17, 2020 at 11:50 AM Dean Wookey wrote: > Hi David, > > Thanks, I wrote that test as a graphics module test and it does fail. > https://gist.github.com/DeanWookey/2624945e3ba037f00c39c0bfd0b22cef > > It passes if you move > > node.styleHelper.firstStyleableAncestor = > findFirstStyleableAncestor(node); (line 134) > > to line 321. I imagine there is some performance impact if you do this. > I'm not sure it affects anything other than fonts at the moment. > Pseudoclasses recalculate the entire tree every time, so they appear to be > fine. > > Dean > > On Thu, Jan 16, 2020 at 9:01 PM David Grieve > wrote: > >> I'd create a scenegraph >> >> R >> .-----+-----. >> A B >> .----+----. >> C D >> >> Where C and D are Labels. Then I'd set a font style on A and a different >> font style on B. >> C and D should pick up the font style of A. Then move D to B and see if >> it still has A's >> font style. >> >> It may be necessary to have a more deeply nested scene graph. >> >> The potential issue is that the node that got moved could pick up the old >> set of styles >> if the style helper is not renewed. >> >> Ultimately, canReuseStyleHelper will return false if the set of styles >> for the >> new parent (line 110 or so in CssStyleHelper.java) are different. >> >> > -----Original Message----- >> > From: openjfx-dev On Behalf Of >> > Dean Wookey >> > Sent: Thursday, January 16, 2020 11:34 AM >> > To: openjfx-dev at openjdk.java.net Mailing > > dev at openjdk.java.net>; David Grieve >> > Cc: aghaisas at openjdk.org >> > Subject: [EXTERNAL] CssStyleHelper canReuseStyleHelper >> > >> > Hi Ajit, David, >> > >> > I came accross a potential issue introduced by JDK-8090462 ( >> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs >> > .openjdk.java.net%2Fbrowse%2FJDK- >> > 8090462&data=02%7C01%7Cdavid.grieve%40microsoft.com%7C235930d >> > fab7f4f7f15ba08d79aa21774%7C72f988bf86f141af91ab2d7cd011db47%7C1%7 >> > C0%7C637147893881930150&sdata=awsMTPYkp7GmSrYsoy9I6M%2F6uj >> > X7thgZhBVY9UKcjpU%3D&reserved=0), ( >> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >> > ub.com%2Fopenjdk%2Fjfx%2Fcommit%2F834b0d05e7a2a8351403ec4a121ea >> > b312d80fd24%23diff- >> > 9ec098280fa1aeed53c70243347e76ab&data=02%7C01%7Cdavid.grieve% >> > 40microsoft.com%7C235930dfab7f4f7f15ba08d79aa21774%7C72f988bf86f141 >> > af91ab2d7cd011db47%7C1%7C0%7C637147893881930150&sdata=ZhWS >> > dmlJ9rLzIkqnohWTacJKPb8FNrG5yApF0fwP8g4%3D&reserved=0). >> > The issue is in the canReuseStyleHelper method. canReuseStyleHelper is >> > called as a result of changes to the scene graph and for other reasons. >> The >> > original code found the parent helper in the following way: >> > >> > Styleable parent = node.getStyleableParent(); >> > while (parent != null) { >> > if (parent instanceof Node) { >> > parentHelper = ((Node) parent).styleHelper; >> > if (parentHelper != null) break; >> > } >> > parent = parent.getStyleableParent(); >> > } >> > >> > This gets the parent helper for the new parent of the node. The code >> now ( >> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >> > ub.com%2Fopenjdk%2Fjfx%2Fblob%2F20325e1c3ec4c4e81af74d3d43bf3a803 >> > dbe1a51%2Fmodules%2Fjavafx.graphics%2Fsrc%2Fmain%2Fjava%2Fjavafx% >> > 2Fscene%2FCssStyleHelper.java%23L322&data=02%7C01%7Cdavid.griev >> > e%40microsoft.com%7C235930dfab7f4f7f15ba08d79aa21774%7C72f988bf86f >> > 141af91ab2d7cd011db47%7C1%7C0%7C637147893881930150&sdata=nJR >> > 3ocKaIsf6HWNjHtseEbqLbEvbW7%2FzQS1B%2F39GVyI%3D&reserved= >> > 0 >> > ): >> > >> > CssStyleHelper parentHelper = >> > getStyleHelper(node.styleHelper.firstStyleableAncestor); >> > >> > gets the helper of the previous parent of the node since >> > firstStyleableAncestor hasn't been updated to reflect the current state >> of the >> > scene graph yet. This means if you move a node, it could keep its >> > CssStyleHelper even if it's under completely new parents. >> > >> > I'm not sure if this is actually causing any problems. It would be >> helpful if I >> > knew the kind of things that could go wrong if you reuse a style helper >> so >> > that I could design a test that highlighted the issue. >> > >> > Can you perhaps think of cases where this could go badly? >> > >> > Dean >> > From kevin.rushforth at oracle.com Fri Jan 17 13:02:37 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 17 Jan 2020 05:02:37 -0800 Subject: Correct branch for PR? In-Reply-To: References: Message-ID: <8e8eb6fc-2271-4393-a60e-46e83a48b87f@oracle.com> Since this is a P3 bug, you can target this to jfx14 as long as the fix is safe. The reviewers might ask for it to be retargeted to master, but that won't be a problem (going the other way is the direction that requires more care and a possible rebase). -- Kevin On 1/16/2020 11:29 PM, Robert Lichtenberger wrote: > I have a testcase + fix ready for JDK-8237372 (A null pointer exception in > TabPaneSkin if only a mouse release event is sent to the skin). > > To avoid the kind of confusion I created with my last pull request ;-) > * For what branch should I create the pull request? (From my point of view > jfx14 is preferable, since this is a real bug affecting our software) > * Will pull requests for jfx14 (like my last one) be automatically pushed > forward to the master branch? > > Best regards, > Robert From dwookey at openjdk.java.net Fri Jan 17 14:18:02 2020 From: dwookey at openjdk.java.net (Dean Wookey) Date: Fri, 17 Jan 2020 14:18:02 GMT Subject: RFR: 8237469: CssStyleHelper reuse check fixed Message-ID: Everything passes with the fix and 5 of the new tests fail without the fix. removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest movingBranchToDifferentBranchGetsNewCssVariableTest removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue removingThenAddingNodeToDifferentBranchGetsIneritableStyle movingNodeToDifferentBranchGetsNewFontStyleTest I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is? ------------- Commits: - 0749dde7: 8237469: Fixed whitespace issues - 4e696401: 8237469: CssStyleHelper reuse check fixed Changes: https://git.openjdk.java.net/jfx/pull/87/files Webrev: https://webrevs.openjdk.java.net/jfx/87/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8237469 Stats: 606 lines in 2 files changed: 603 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/87.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/87/head:pull/87 PR: https://git.openjdk.java.net/jfx/pull/87 From github.com+7450507+fthevenet at openjdk.java.net Fri Jan 17 14:28:02 2020 From: github.com+7450507+fthevenet at openjdk.java.net (Frederic Thevenet) Date: Fri, 17 Jan 2020 14:28:02 GMT Subject: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: > This PR aims to address the following issue: JDK-8088198 Exception thrown from snapshot if dimensions are larger than max texture size > > In order to do that, it simply captures snapshots in multiple tiles of maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the tiles into a a single image. > Other than that, the logic used to do the actual snapshot is unchanged. > > Tests using the existing SnapshotCommon class have been added in a new file named Snapshot3Test under SystemTest/test/javafx/scene. > These tests pass with the proposed fix, and fail without, throwing " java.lang.IllegalArgumentException: Unrecognized image loader: null" The pull request has been updated with 2 additional commits. ------------- Added commits: - 8966936f: Wrapped long line - 8e44dea2: Refactored height & weight calculation to avoid unnecessary computations Changes: - all: https://git.openjdk.java.net/jfx/pull/68/files - new: https://git.openjdk.java.net/jfx/pull/68/files/50191728..8966936f Webrevs: - full: https://webrevs.openjdk.java.net/jfx/68/webrev.03 - incr: https://webrevs.openjdk.java.net/jfx/68/webrev.02-03 Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/68.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/68/head:pull/68 PR: https://git.openjdk.java.net/jfx/pull/68 From github.com+7450507+fthevenet at openjdk.java.net Fri Jan 17 14:39:31 2020 From: github.com+7450507+fthevenet at openjdk.java.net (Frederic Thevenet) Date: Fri, 17 Jan 2020 14:39:31 GMT Subject: [Rev 02] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: On Thu, 16 Jan 2020 16:08:05 GMT, Nir Lisker wrote: >> The pull request has been updated with 2 additional commits. > > modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1316: > >> 1315: } >> 1316: } >> 1317: } else { > > I would extract this code into its own method similar to `doSnapshotTile`: > > `assemble(scene, xMin, yMin, width, height, root, transform, depthBuffer, fill, camera, wimg, maxTextureSize);` > > (`assemble` is a bad name, I didn't think about a better one). > > The method can return he resulting `WritableImage`, but it is not needed since it is manipulated via "side-effects". I would, however, bring it line with the `else` clause - either both use `wimg = methodName(..., wimg, ...);` or just `methodName(..., wimg, ...);`. This is fine since the input `WritableImage` is never `null`. From a readability point of view, using return values seems better. I'm not 100% convinced this would really add much to the readability of the code; I extracted the code from `doSnapshotTile` in its own method because it is called twice (on both sides of the `if (height > maxTextureSize || width > maxTextureSize)` condition, actually), but this isn't the case here. I've got no strong feeling against it either, so I don't know; anybody else care to comment? ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From github.com+7450507+fthevenet at openjdk.java.net Fri Jan 17 17:26:10 2020 From: github.com+7450507+fthevenet at openjdk.java.net (Frederic Thevenet) Date: Fri, 17 Jan 2020 17:26:10 GMT Subject: [Rev 02] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: <16XxegMp9uAyf0Ni0BZBbd0npwtacp2YZtL7f7Fgvq0=.96a3a6cf-cbfd-4ffa-b7f7-8336914150f4@github.com> References: <16XxegMp9uAyf0Ni0BZBbd0npwtacp2YZtL7f7Fgvq0=.96a3a6cf-cbfd-4ffa-b7f7-8336914150f4@github.com> Message-ID: On Fri, 17 Jan 2020 11:28:03 GMT, Frederic Thevenet wrote: >> I tested this fix against the repro code in https://github.com/javafxports/openjdk-jfx/issues/433 (which is [JDK-8222238](https://bugs.openjdk.java.net/browse/JDK-8222238)), but there is still an NPE. I'm not certain that this fix is supposed to solve that bug, but according to the comments, the root cause is the same as [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082), which is related to this one. It's worth to take a look to see if something was missed. > >> >> >> I tested this fix against the repro code in [javafxports/openjdk-jfx#433](https://github.com/javafxports/openjdk-jfx/issues/433) (which is [JDK-8222238](https://bugs.openjdk.java.net/browse/JDK-8222238)), but there is still an NPE. I'm not certain that this fix is supposed to solve that bug, but according to the comments, the root cause is the same as [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082), which is related to this one. It's worth to take a look to see if something was missed. > > Although JDK-8189082 (and potentially others) are indeed likely to share the same root cause, the fix proposed here won't have an effect on anything else than snapshots, since the tiling is done at the Scene level rather than within QuantumToolkit. > I purposefully choose to take the "easy" way out to limit the potential side-effects of the change, but I agree that on the other hand supporting tiling when needed directly in QuantumToolkit::renderToImage would have the potential to solve a whole category of issues. > Also, from a very pragmatic angle, because of the increased complexity and scope and the risks that come with it, I'm not very optimistic that this change could realistically make it into jfx14 and to be honest I'm quite eager to get the screenshot feature in my app working properly ASAP. > > I'd be willing to try and work on a more generic fix under the umbrella of JDK-8189082, that'd be targeted at 15, while still having this fix included as part 14; but that means this should (ideally) be reverted once it becomes useless. > I don't know if the idea of having a "temporary fix" approach seems acceptable in that context. Wel,l upon closer inspection it appears `QuantumToolkit::renderToImage` is only really used by `Scene::doSnapshot` anyway. Rendering of a the content of an NGSubScene (the underlying issue in JDK-8189082) is handled in a completely different code path, and I suspect this is also true for Canvas, where I hear a similar kind of issue exists. So from my (admittedly limited) understanding, fixing all problems at once would requires handling the tiling transparently within `RTTexture` (or more exactly inside all of its GraphicsPipeline specifics implementations) which seems quite a bit more complicated and risky. ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From kcr at openjdk.java.net Fri Jan 17 18:40:46 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 17 Jan 2020 18:40:46 GMT Subject: RFR: 8237469: CssStyleHelper reuse check fixed In-Reply-To: References: Message-ID: On Fri, 17 Jan 2020 14:09:54 GMT, Dean Wookey wrote: > Everything passes with the fix and 5 of the new tests fail without the fix. > > removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest > movingBranchToDifferentBranchGetsNewCssVariableTest > removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue > removingThenAddingNodeToDifferentBranchGetsIneritableStyle > movingNodeToDifferentBranchGetsNewFontStyleTest > > I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is? > > Originally introduced here: https://bugs.openjdk.java.net/browse/JDK-8090462/ https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab I mentioned this in the JBS bug as well: I suspect that [JDK-8234877](https://bugs.openjdk.java.net/browse/JDK-8234877) has the same root cause as this one. Can you run the HelloCSS test program as described in that bug with your patch from this PR and see if it also fixes that bug? ------------- PR: https://git.openjdk.java.net/jfx/pull/87 From kcr at openjdk.java.net Fri Jan 17 18:42:45 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 17 Jan 2020 18:42:45 GMT Subject: RFR: 8237469: CssStyleHelper reuse check fixed In-Reply-To: References: Message-ID: <2fHHhFU9n2ggGfbJNU4aQj31qItjC930t2rMhcWLy1Q=.a8310b33-3b27-4f4f-a7e9-c021745f0b1b@github.com> On Fri, 17 Jan 2020 18:40:34 GMT, Kevin Rushforth wrote: >> Everything passes with the fix and 5 of the new tests fail without the fix. >> >> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest >> movingBranchToDifferentBranchGetsNewCssVariableTest >> removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue >> removingThenAddingNodeToDifferentBranchGetsIneritableStyle >> movingNodeToDifferentBranchGetsNewFontStyleTest >> >> I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is? >> >> Originally introduced here: https://bugs.openjdk.java.net/browse/JDK-8090462/ https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab > > I mentioned this in the JBS bug as well: I suspect that [JDK-8234877](https://bugs.openjdk.java.net/browse/JDK-8234877) has the same root cause as this one. Can you run the HelloCSS test program as described in that bug with your patch from this PR and see if it also fixes that bug? This will need (at least) two reviewers. I request @aghaisas and @dsgrieve to review (I'll review it as well next week, once I'm done with the more urgent reviews). ------------- PR: https://git.openjdk.java.net/jfx/pull/87 From kcr at openjdk.java.net Fri Jan 17 19:22:37 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 17 Jan 2020 19:22:37 GMT Subject: [Rev 02] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: On Fri, 17 Jan 2020 14:39:14 GMT, Frederic Thevenet wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1316: >> >>> 1315: } >>> 1316: } >>> 1317: } else { >> >> I would extract this code into its own method similar to `doSnapshotTile`: >> >> `assemble(scene, xMin, yMin, width, height, root, transform, depthBuffer, fill, camera, wimg, maxTextureSize);` >> >> (`assemble` is a bad name, I didn't think about a better one). >> >> The method can return he resulting `WritableImage`, but it is not needed since it is manipulated via "side-effects". I would, however, bring it line with the `else` clause - either both use `wimg = methodName(..., wimg, ...);` or just `methodName(..., wimg, ...);`. This is fine since the input `WritableImage` is never `null`. From a readability point of view, using return values seems better. > > I'm not 100% convinced this would really add much to the readability of the code; I extracted the code from `doSnapshotTile` in its own method because it is called twice (on both sides of the `if (height > maxTextureSize || width > maxTextureSize)` condition, actually), but this isn't the case here. > I've got no strong feeling against it either, so I don't know; anybody else care to comment? I also don't have a strong opinion, so I'm OK with you leaving it as-is. ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From nlisker at openjdk.java.net Fri Jan 17 19:25:06 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Fri, 17 Jan 2020 19:25:06 GMT Subject: [Rev 02] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: On Fri, 17 Jan 2020 19:22:24 GMT, Kevin Rushforth wrote: >> I'm not 100% convinced this would really add much to the readability of the code; I extracted the code from `doSnapshotTile` in its own method because it is called twice (on both sides of the `if (height > maxTextureSize || width > maxTextureSize)` condition, actually), but this isn't the case here. >> I've got no strong feeling against it either, so I don't know; anybody else care to comment? > > I also don't have a strong opinion, so I'm OK with you leaving it as-is. Fine to leave as-is. ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From kcr at openjdk.java.net Fri Jan 17 19:32:07 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 17 Jan 2020 19:32:07 GMT Subject: [Rev 02] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: <16XxegMp9uAyf0Ni0BZBbd0npwtacp2YZtL7f7Fgvq0=.96a3a6cf-cbfd-4ffa-b7f7-8336914150f4@github.com> Message-ID: On Fri, 17 Jan 2020 17:25:51 GMT, Frederic Thevenet wrote: >>> >>> >>> I tested this fix against the repro code in [javafxports/openjdk-jfx#433](https://github.com/javafxports/openjdk-jfx/issues/433) (which is [JDK-8222238](https://bugs.openjdk.java.net/browse/JDK-8222238)), but there is still an NPE. I'm not certain that this fix is supposed to solve that bug, but according to the comments, the root cause is the same as [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082), which is related to this one. It's worth to take a look to see if something was missed. >> >> Although JDK-8189082 (and potentially others) are indeed likely to share the same root cause, the fix proposed here won't have an effect on anything else than snapshots, since the tiling is done at the Scene level rather than within QuantumToolkit. >> I purposefully choose to take the "easy" way out to limit the potential side-effects of the change, but I agree that on the other hand supporting tiling when needed directly in QuantumToolkit::renderToImage would have the potential to solve a whole category of issues. >> Also, from a very pragmatic angle, because of the increased complexity and scope and the risks that come with it, I'm not very optimistic that this change could realistically make it into jfx14 and to be honest I'm quite eager to get the screenshot feature in my app working properly ASAP. >> >> I'd be willing to try and work on a more generic fix under the umbrella of JDK-8189082, that'd be targeted at 15, while still having this fix included as part 14; but that means this should (ideally) be reverted once it becomes useless. >> I don't know if the idea of having a "temporary fix" approach seems acceptable in that context. > > Wel,l upon closer inspection it appears `QuantumToolkit::renderToImage` is only really used by `Scene::doSnapshot` anyway. Rendering of a the content of an NGSubScene (the underlying issue in JDK-8189082) is handled in a completely different code path, and I suspect this is also true for Canvas, where I hear a similar kind of issue exists. > So from my (admittedly limited) understanding, fixing all problems at once would requires handling the tiling transparently within `RTTexture` (or more exactly inside all of its GraphicsPipeline specifics implementations) which seems quite a bit more complicated and risky. > upon closer inspection it appears `QuantumToolkit::renderToImage` is only really used by `Scene::doSnapshot` anyway. Correct. > So from my (admittedly limited) understanding, fixing all problems at once would requires handling the tiling transparently within `RTTexture` (or more exactly inside all of its GraphicsPipeline specifics implementations) which seems quite a bit more complicated and risky. That would be one approach (extending RTT to handle tiling automatically), but I'm not at all sure that it would be the best one. It would as you note, be more complicated and risky. I have no problem with your current proposed approach. I agree with @arapte that this seems safe for openjfx14. To that end, can you retarget this PR to the `jfx14` branch? Since there are no post-jfx14 commits from master in your local branch, this should be as simple as editing the PR and changing the target. Then we can complete the review, hopefully next week. ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From kcr at openjdk.java.net Fri Jan 17 22:48:29 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 17 Jan 2020 22:48:29 GMT Subject: RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: References: Message-ID: On Thu, 16 Jan 2020 01:09:56 GMT, Nir Lisker wrote: >>> If cycleCount is set to 2 does the animation play the same number of times with or without the jumpTo both before and after this change? >> >> Before the change: >> * With `jumpTo`: plays backwards 2 times. >> * Without `jumpTo`: doesn't play no mater how many times you call `play()`. Compare with the case where `cycleCount` is 1, in which case the first call does nothing (moves the playing head to the start) and the second one plays backwards. >> >> After the change: >> * With `jumpTo`: plays backwards 2 times. >> * Without `jumpTo`: plays backwards 2 times. >> >>> If the jumpTo isn't required, then this isn't this a change in behaviour? >> >> Current code with `jumpTo` will behave the same. The question (which I presented initially) is whether this behavior is considered a bug or not when it comes to the initial state of an animation. It is certainly a bug when `stop()` is called, so I assume it is similar for the initial state. > >> So this PR may need a document change for `Animation.play()` > > Yes, and the docs need clarification in other places anyway. The [parent issue](https://bugs.openjdk.java.net/browse/JDK-8210238) from which this bug was isolated talks about these. Not sure at what point I will go over it since `Animation` is going to get some more changes in the (hopefully) near future. Based on my testing, and thinking through all of the implications of the fix, I think the proposed fix is correct. I modified the Timeline.java test program attached to [JDK-8210238](https://bugs.openjdk.java.net/browse/JDK-8210238) to add controls for auto-reverse and cycle count (1, 2, or INDEFINITE), and attached it as TimelineTest2.java. I tried several combinations, and the change in behavior looks correct in all cases to me. As you point out in the description, the failing unit test, [SequentialTransitionPlayTest.testCycleReverse](https://github.com/openjdk/jfx/blob/16cea4111b25a00f812b2f6ba8a54adbcffc1c86/modules/javafx.graphics/src/test/java/test/javafx/animation/SequentialTransitionPlayTest.java#L632) is coded to test for the existing behavior when you first call play with `rate = -1`. I think it likely that this is merely because that's how it worked rather than because there was deliberate thought given to whether it was the right behavior. So I think the right thing to do is fix the test. You also mentioned that jumping, even to the start or end, sets `lastPlayFinished` to `false`. I believe this is correct behavior and should not be changed. As part of my testing, I ran into what may be a bug, but since the behavior is the same with or without your patch, I think it would be best to file a new bug and deal with it separately (if, in fact, it is a bug). Here are the steps I used: 1. Run TimelineTest2 2. Select cycle=2; Select AutoReverse 3. Play animation: it correctly goes forward from start to end and then backwards from end to start 3. Set rate=-1 5. Play animation: BUG? It still goes forward from start to end and then backwards from end to start Subsequent calls to play do what I would expect, in that it goes backwards from end to start and then forward from start to end. The same thing happens when switching back to rate=1 : the first time it continues the direction it was prior to changing the rate. ------------- PR: https://git.openjdk.java.net/jfx/pull/82 From kcr at openjdk.java.net Fri Jan 17 23:18:40 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 17 Jan 2020 23:18:40 GMT Subject: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 In-Reply-To: References: Message-ID: On Fri, 17 Jan 2020 23:18:40 GMT, Robert Lichtenberger wrote: >> As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). >> >> The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped. > > Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR. Looks good to me. @guruhb can you re-review this when you get a chance? ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/85 From kcr at openjdk.java.net Fri Jan 17 23:40:36 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 17 Jan 2020 23:40:36 GMT Subject: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one In-Reply-To: References: Message-ID: On Mon, 13 Jan 2020 16:49:41 GMT, Ambarish Rapte wrote: >> This will need a second reviewer. >> >> @aghaisas can you review this, too? > >> >> >> @arapte - This bug looks like a good candidate for JavaFX 14. Can you retarget this PR to the jfx14 branch? > > Thanks for guiding Kevin, PR is now targeted to jfx14. The fix looks good. I'll take a closer look at the unit test later. Speaking of tests...since the addition of the `TabPane` reordering logic was a victim of the already-existing leak in the `viewOrderChildren` list in `Parent`, it should be possible to write a test case using a Group node and a few Shape nodes, using setViewOrder directly on the Group node (this would be in addition to the system test you wrote). Can you take a look at adding one? It might even be possible to do it as a `javafx.graphics` module unit test rather than a system test, although you would need to see if the bug reproduced there (I suspect it will). ------------- PR: https://git.openjdk.java.net/jfx/pull/79 From nlisker at openjdk.java.net Sat Jan 18 02:07:47 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Sat, 18 Jan 2020 02:07:47 GMT Subject: [Rev 01] RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: References: Message-ID: <8E-6q3Esm-3cPv-QMMoPIqTFW2jOgwFHCKPIwFG1MlI=.4f298bff-55ad-4243-975f-0c32992c2cdc@github.com> > The private field `lastPlayFinished` is responsible for 2 cases where an animation in `STOPPED` status does not play after `play()` is called if the rate is negative: > > 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is `false`. Setting a negative rate and calling `play()` will not jump to the end of the animation (in order to play it backwards) because the `if (lastPlayedFinished)` check is `false`. Creating the animation with `lastPlayFinished = true` fixes this. However, `SequentialTransitionPlayTest#testCycleReverse`'s initial state test implies that the original behavior is correct. *That test currently fails with this change.* Either the fix is reverted or the test is corrected. > 2. When the animation is stopped (if it was not `STOPPED` already), `jumpTo(Duration.ZERO)` sets `lastPlayFinished` to `false`, which causes the same issue above with `play()`. Setting `lastPlayFinished = true` at the end `stop()` fixes this issue. > > A test was added for case 2 to check that the playing head indeed jumps to the end of the animation. Without this fix, it stays at the start. > > I'm still somewhat confused as to what constitutes a "last play finished". Any `jumpTo` resets `lastPlayFinished` to `false`, even if the jump is to the start/end of the animation. In this case, stopping an animation, jumping to its start/end, setting the rate to negative/positive, and playing, will do nothing as the end condition is reached immediately. This is what the behavior that was fixed for cases 1 and 2, but maybe this is also incorrect behavior for jumping to start/end. > > A test app is included in the "parent" [bug](https://bugs.openjdk.java.net/browse/JDK-8210238), which also mentions a bug relating to **pausing** and playing backwards, so be mindful of it when testing. The pull request has been updated with 1 additional commit. ------------- Added commits: - 18098da9: Fixed SequentialTransitionPlayTest.testCycleReverse test Changes: - all: https://git.openjdk.java.net/jfx/pull/82/files - new: https://git.openjdk.java.net/jfx/pull/82/files/3332a97f..18098da9 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/82/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/82/webrev.00-01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/82.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/82/head:pull/82 PR: https://git.openjdk.java.net/jfx/pull/82 From nlisker at openjdk.java.net Sat Jan 18 02:14:45 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Sat, 18 Jan 2020 02:14:45 GMT Subject: RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: References: Message-ID: On Fri, 17 Jan 2020 22:48:11 GMT, Kevin Rushforth wrote: >>> So this PR may need a document change for `Animation.play()` >> >> Yes, and the docs need clarification in other places anyway. The [parent issue](https://bugs.openjdk.java.net/browse/JDK-8210238) from which this bug was isolated talks about these. Not sure at what point I will go over it since `Animation` is going to get some more changes in the (hopefully) near future. > > Based on my testing, and thinking through all of the implications of the fix, I think the proposed fix is correct. I modified the Timeline.java test program attached to [JDK-8210238](https://bugs.openjdk.java.net/browse/JDK-8210238) to add controls for auto-reverse and cycle count (1, 2, or INDEFINITE), and attached it as TimelineTest2.java. I tried several combinations, and the change in behavior looks correct in all cases to me. > > As you point out in the description, the failing unit test, [SequentialTransitionPlayTest.testCycleReverse](https://github.com/openjdk/jfx/blob/16cea4111b25a00f812b2f6ba8a54adbcffc1c86/modules/javafx.graphics/src/test/java/test/javafx/animation/SequentialTransitionPlayTest.java#L632) is coded to test for the existing behavior when you first call play with `rate = -1`. I think it likely that this is merely because that's how it worked rather than because there was deliberate thought given to whether it was the right behavior. So I think the right thing to do is fix the test. > > You also mentioned that jumping, even to the start or end, sets `lastPlayFinished` to `false`. I believe this is correct behavior and should not be changed. > > As part of my testing, I ran into what may be a bug, but since the behavior is the same with or without your patch, I think it would be best to file a new bug and deal with it separately (if, in fact, it is a bug). > > Here are the steps I used: > > 1. Run TimelineTest2 > 2. Select cycle=2; Select AutoReverse > 3. Play animation: it correctly goes forward from start to end and then backwards from end to start > 3. Set rate=-1 > 5. Play animation: BUG? It still goes forward from start to end and then backwards from end to start > Subsequent calls to play do what I would expect, in that it goes backwards from end to start and then forward from start to end. > The same thing happens when switching back to rate=1 : the first time it continues the direction it was prior to changing the rate. > So I think the right thing to do is fix the test. Since the animation plays from the end for an arbitrary duration (at least I think it's arbitrary, compared to a pulse), I changed the assert to check that the property value is in the playing range of the animation and not equals to some specific value. ------------- PR: https://git.openjdk.java.net/jfx/pull/82 From dwookey at openjdk.java.net Sat Jan 18 08:12:19 2020 From: dwookey at openjdk.java.net (Dean Wookey) Date: Sat, 18 Jan 2020 08:12:19 GMT Subject: RFR: 8237469: CssStyleHelper reuse check fixed In-Reply-To: <2fHHhFU9n2ggGfbJNU4aQj31qItjC930t2rMhcWLy1Q=.a8310b33-3b27-4f4f-a7e9-c021745f0b1b@github.com> References: <2fHHhFU9n2ggGfbJNU4aQj31qItjC930t2rMhcWLy1Q=.a8310b33-3b27-4f4f-a7e9-c021745f0b1b@github.com> Message-ID: <43YjUCaYDCdc6JVLd91Y7q-ek8WUNRxI4wnV5Zdt-Z0=.92e2dfaa-24fa-4a81-88ed-8dee4732dc1d@github.com> On Fri, 17 Jan 2020 18:42:34 GMT, Kevin Rushforth wrote: >> I mentioned this in the JBS bug as well: I suspect that [JDK-8234877](https://bugs.openjdk.java.net/browse/JDK-8234877) has the same root cause as this one. Can you run the HelloCSS test program as described in that bug with your patch from this PR and see if it also fixes that bug? > > This will need (at least) two reviewers. I request @aghaisas and @dsgrieve to review (I'll review it as well next week, once I'm done with the more urgent reviews). > I mentioned this in the JBS bug as well: I suspect that [JDK-8234877](https://bugs.openjdk.java.net/browse/JDK-8234877) has the same root cause as this one. Can you run the HelloCSS test program as described in that bug with your patch from this PR and see if it also fixes that bug? I ran it and it seems to work. The button is always red in the red pane and always yellow in the yellow one. ------------- PR: https://git.openjdk.java.net/jfx/pull/87 From arapte at openjdk.java.net Mon Jan 20 05:07:11 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Mon, 20 Jan 2020 05:07:11 GMT Subject: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: On Mon, 20 Jan 2020 05:07:11 GMT, Frederic Thevenet wrote: >> This PR aims to address the following issue: JDK-8088198 Exception thrown from snapshot if dimensions are larger than max texture size >> >> In order to do that, it simply captures snapshots in multiple tiles of maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the tiles into a a single image. >> Other than that, the logic used to do the actual snapshot is unchanged. >> >> Tests using the existing SnapshotCommon class have been added in a new file named Snapshot3Test under SystemTest/test/javafx/scene. >> These tests pass with the proposed fix, and fail without, throwing " java.lang.IllegalArgumentException: Unrecognized image loader: null" > > The pull request has been updated with 2 additional commits. Looks good to me. Below is just an observation about time taken by the API, Platform: `Windows10`, `maxTextureSize`: 4096 For a snapshot of (4096 * n, 4096 * n): each call to `doSnapshotTile()` takes ~100 ms, and each call to `setPixels()` takes ~30 ms. Please wait for one more approval before integrating. ------------- Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/68 From rlichten at openjdk.java.net Mon Jan 20 10:02:15 2020 From: rlichten at openjdk.java.net (Robert Lichtenberger) Date: Mon, 20 Jan 2020 10:02:15 GMT Subject: RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag Message-ID: Test simulates a single mouse-released event. Fix simply guards against the null case. ------------- Commits: - 923a63b2: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: https://git.openjdk.java.net/jfx/pull/89/files Webrev: https://webrevs.openjdk.java.net/jfx/89/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8237372 Stats: 29 lines in 2 files changed: 21 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jfx/pull/89.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/89/head:pull/89 PR: https://git.openjdk.java.net/jfx/pull/89 From jvos at openjdk.java.net Mon Jan 20 11:11:55 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Mon, 20 Jan 2020 11:11:55 GMT Subject: RFR: 8237078: Media build code broken on XCode 11 Message-ID: Fix JDK-8237078 replace the objc_msgSend call with a direct objC call. The fix works on XCode 10.1 and XCode 11.3 Tested using java -Djfxmedia.platforms=OSXPlatform with MediaPlayer playing an mp3. ------------- Commits: - 33582c1d: Fix 8237078 : media build code broken on XCode 11 Changes: https://git.openjdk.java.net/jfx/pull/90/files Webrev: https://webrevs.openjdk.java.net/jfx/90/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8237078 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/90.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/90/head:pull/90 PR: https://git.openjdk.java.net/jfx/pull/90 From github.com+7450507+fthevenet at openjdk.java.net Mon Jan 20 11:24:27 2020 From: github.com+7450507+fthevenet at openjdk.java.net (Frederic Thevenet) Date: Mon, 20 Jan 2020 11:24:27 GMT Subject: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: On Mon, 20 Jan 2020 05:06:50 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 2 additional commits. > > Looks good to me. > Below is just an observation about time taken by the API, > Platform: Windows10, `maxTextureSize`: 4096 > For a snapshot of (4096 * n, 4096 * n): each call to `doSnapshotTile()` takes ~100 ms, and each call to `setPixels()` takes ~30 ms. > > Please wait for one more approval before integrating. > > > Looks good to me. > Below is just an observation about time taken by the API, > Platform: Windows10, `maxTextureSize`: 4096 > For a snapshot of (4096 * n, 4096 * n): each call to `doSnapshotTile()` takes ~100 ms, and each call to `setPixels()` takes ~30 ms. > > Please wait for one more approval before integrating. Do you have the same kind of measurements for similar uses cases without this patch? I'm expecting performances to remain the same for snapshots less than `maxTextureSize*maxTextureSize` in size, since there is no extra pixel copy in that case, and the rest of the code if globally unchanged. Still there exists a window for performance regressions, which for instance on Windows 10 w/ the D3D rendering pipeline would be when one of the dimension of a snapshot is >4096 and <8192: in that case a snapshot would require up to 4 extra copy pixels steps with this patch. This is due to the fact that the old code would accept to render in a texture of a size up to the non-clamped max texture size (8192 in D3D, 16384 in ES2), but because I couldn't find a clean way to access the non clamped maxTextureSize exposed by the render factory from the Scene class, I settled for Prsim.maxTextureSize, which is the clamped value (4096 by default). I haven't dug deep enough in the code to understand precisely why the max texture size is clamped to 4096 by default, but assuming that it is for a good reason wouldn't that also apply in that case? Or is it always safe to use the non-clamped value in that particular case? ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From github.com+725090+jkaving at openjdk.java.net Mon Jan 20 14:53:01 2020 From: github.com+725090+jkaving at openjdk.java.net (Johan Kaving) Date: Mon, 20 Jan 2020 14:53:01 GMT Subject: RFR: 8236839: System menubar removed when other menubars are created or modified Message-ID: This pull request fixes the sceneProperty listener in `MenuBarSkin` so that we leave the current system menubar alone when other menubars are changed. It also adds a test case that reproduces the problem before the fix. ------------- Commits: - 7910ab27: Don't always remove system menubar Changes: https://git.openjdk.java.net/jfx/pull/86/files Webrev: https://webrevs.openjdk.java.net/jfx/86/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8236839 Stats: 33 lines in 2 files changed: 32 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/86.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/86/head:pull/86 PR: https://git.openjdk.java.net/jfx/pull/86 From kcr at openjdk.java.net Mon Jan 20 14:53:02 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 20 Jan 2020 14:53:02 GMT Subject: RFR: 8236839: System menubar removed when other menubars are created or modified In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 20:06:58 GMT, Johan Kaving wrote: >> This pull request fixes the sceneProperty listener in `MenuBarSkin` so that we leave the >> current system menubar alone when other menubars are changed. >> >> It also adds a test case that reproduces the problem before the fix. > > I just realised that I did not make the commit with the same email address that I used on the OCA (but both addresses are linked to my GitHub account). > Will this be a problem? > Should I redo the commit with the correct email address and do a force push to my branch? No, it's not a problem. The commit email address doesn't matter as long as your OCA can be validated. ------------- PR: https://git.openjdk.java.net/jfx/pull/86 From github.com+725090+jkaving at openjdk.java.net Mon Jan 20 14:53:02 2020 From: github.com+725090+jkaving at openjdk.java.net (Johan Kaving) Date: Mon, 20 Jan 2020 14:53:02 GMT Subject: RFR: 8236839: System menubar removed when other menubars are created or modified In-Reply-To: References: Message-ID: On Tue, 14 Jan 2020 19:50:28 GMT, Johan Kaving wrote: > This pull request fixes the sceneProperty listener in `MenuBarSkin` so that we leave the > current system menubar alone when other menubars are changed. > > It also adds a test case that reproduces the problem before the fix. I just realised that I did not make the commit with the same email address that I used on the OCA (but both addresses are linked to my GitHub account). Will this be a problem? Should I redo the commit with the correct email address and do a force push to my branch? ------------- PR: https://git.openjdk.java.net/jfx/pull/86 From guru.hb at oracle.com Mon Jan 20 16:46:43 2020 From: guru.hb at oracle.com (Guru) Date: Mon, 20 Jan 2020 22:16:43 +0530 Subject: [RFR] 8233942: Update to 609.1 version of WebKit Message-ID: <174ECC19-3C9B-4068-B49C-6054451551A4@oracle.com> Hi Kevin, Johan, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8233942 PR : https://github.com/openjdk/jfx/pull/91 Fix has latest GTK Webkit 2.26 (609.1) merged into jfx. Tested : Basic sanity by loading many Top 20 webpages using HelloWebView on three different platform (Mac OS X, Windows 10 and Linux). Thanks, Guru From ghb at openjdk.java.net Tue Jan 21 09:27:28 2020 From: ghb at openjdk.java.net (Guru Hb) Date: Tue, 21 Jan 2020 09:27:28 GMT Subject: RFR: 8233942: Update to 609.1 version of WebKit Message-ID: Updated GTK Webkit 2.26 (609.1) into jfx. ------------- Commits: - 8b48b1e0: 8233942: Update to 609.1 version of WebKit Changes: https://git.openjdk.java.net/jfx/pull/91/files Webrev: https://webrevs.openjdk.java.net/jfx/91/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8233942 Stats: 279532 lines in 5731 files changed: 169844 ins; 72559 del; 37129 mod Patch: https://git.openjdk.java.net/jfx/pull/91.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/91/head:pull/91 PR: https://git.openjdk.java.net/jfx/pull/91 From kcr at openjdk.java.net Tue Jan 21 18:02:28 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 21 Jan 2020 18:02:28 GMT Subject: RFR: 8233942: Update to 609.1 version of WebKit In-Reply-To: References: Message-ID: On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote: > Updated GTK Webkit 2.26 (609.1) into jfx. A sanity check of the patch looks good to me: I did a build / test on all three platforms. I'll do a bit more testing, and also review the JavaFX-specific files, before completing my review. To the latter point, I took the patch, applied it to my personal fork, and then split it into two commits, one of which has the changes to the files that I wanted to take a closer look at (finding just those files in the original PR when there are over 5,000 files would be impractical -- impossible given GitHub's 3000 file limitation in the file diff veiwer). In case this is useful to other reviewers, [click here](https://github.com/kevinrushforth/jfx/compare/fa6df1ecacc1334b256ffd96dd15cd7dfb1fc108...83d114aed6f9f30ebd90a567192537f62328ffa5) for the diffs. It only includes 87 files, many of which are cmake files for platforms other than `Java` so don't really need to be reviewed. ------------- PR: https://git.openjdk.java.net/jfx/pull/91 From kcr at openjdk.java.net Tue Jan 21 18:44:42 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 21 Jan 2020 18:44:42 GMT Subject: RFR: 8237078: Media build code broken on XCode 11 In-Reply-To: References: Message-ID: On Mon, 20 Jan 2020 11:10:07 GMT, Johan Vos wrote: > Fix JDK-8237078 > replace the objc_msgSend call with a direct objC call. > The fix works on XCode 10.1 and XCode 11.3 > > Tested using > java -Djfxmedia.platforms=OSXPlatform > with MediaPlayer playing an mp3. I verified the fix, and confirmed that the new code is executed. This seems safe enough that a single reviewer is sufficient, although @sashamatveev might want to review as well. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/90 From kcr at openjdk.java.net Tue Jan 21 19:06:41 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 21 Jan 2020 19:06:41 GMT Subject: RFR: 8233942: Update to 609.1 version of WebKit In-Reply-To: References: Message-ID: On Tue, 21 Jan 2020 18:02:14 GMT, Kevin Rushforth wrote: >> Updated GTK Webkit 2.26 (609.1) into jfx. > > A sanity check of the patch looks good to me: I did a build / test on all three platforms. I'll do a bit more testing, and also review the JavaFX-specific files, before completing my review. > > To the latter point, I took the patch, applied it to my personal fork, and then split it into two commits, one of which has the changes to the files that I wanted to take a closer look at (finding just those files in the original PR when there are over 5,000 files would be impractical -- impossible given GitHub's 3000 file limitation in the file diff veiwer). > > In case this is useful to other reviewers, [click here](https://github.com/kevinrushforth/jfx/compare/fa6df1ecacc1334b256ffd96dd15cd7dfb1fc108...83d114aed6f9f30ebd90a567192537f62328ffa5) for the diffs. It only includes 87 files, many of which are cmake files for platforms other than `Java` so don't really need to be reviewed. This will need at least two reviewers, including myself and @johanvos ------------- PR: https://git.openjdk.java.net/jfx/pull/91 From kcr at openjdk.java.net Tue Jan 21 19:12:07 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 21 Jan 2020 19:12:07 GMT Subject: RFR: 8233942: Update to 609.1 version of WebKit In-Reply-To: References: Message-ID: On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote: > Updated GTK Webkit 2.26 (609.1) into jfx. Everything looks good to me. Here are a couple things I noticed that may warrant a follow-up issue to address them: 1. Unimplemented methods: * FileSystemJava.cpp: * truncateFile * MappedFileData::MappedFileData * MappedFileData::mapFileHandle * unmapViewOfFile * FrameLoaderClientJava.cpp: * didSaveToPageCache * didRestoreFromPageCache 2. General cleanup: * PageCacheJava.cpp: // FIXME: Openjfx2.26 rename pagecache to backforwardcache ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/91 From kcr at openjdk.java.net Tue Jan 21 19:23:52 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 21 Jan 2020 19:23:52 GMT Subject: RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag In-Reply-To: References: Message-ID: <21vrFgU1LwJj_HAVlFbBOUIiJ1uyk8smbibXgukRA5Y=.070dbce7-a338-4ab2-b74e-bd74dba60a44@github.com> On Mon, 20 Jan 2020 10:00:55 GMT, Robert Lichtenberger wrote: > Test simulates a single mouse-released event. > Fix simply guards against the null case. @arapte - can you review this? The only question I have is whether is is expected that `dragTabHeader` can be null. If we understand why it is null, and that it isn't an error for it to be null, then the fix is fine. If its being null is unexpected, then the fix might just be masking the real problem. There isn't enough information in this PR to be able to evaluate this. ------------- PR: https://git.openjdk.java.net/jfx/pull/89 From kcr at openjdk.java.net Tue Jan 21 19:57:57 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 21 Jan 2020 19:57:57 GMT Subject: [Rev 01] RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: <8E-6q3Esm-3cPv-QMMoPIqTFW2jOgwFHCKPIwFG1MlI=.4f298bff-55ad-4243-975f-0c32992c2cdc@github.com> References: <8E-6q3Esm-3cPv-QMMoPIqTFW2jOgwFHCKPIwFG1MlI=.4f298bff-55ad-4243-975f-0c32992c2cdc@github.com> Message-ID: On Tue, 21 Jan 2020 19:57:56 GMT, Nir Lisker wrote: >> The private field `lastPlayFinished` is responsible for 2 cases where an animation in `STOPPED` status does not play after `play()` is called if the rate is negative: >> >> 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is `false`. Setting a negative rate and calling `play()` will not jump to the end of the animation (in order to play it backwards) because the `if (lastPlayedFinished)` check is `false`. Creating the animation with `lastPlayFinished = true` fixes this. However, `SequentialTransitionPlayTest#testCycleReverse`'s initial state test implies that the original behavior is correct. *That test currently fails with this change.* Either the fix is reverted or the test is corrected. >> 2. When the animation is stopped (if it was not `STOPPED` already), `jumpTo(Duration.ZERO)` sets `lastPlayFinished` to `false`, which causes the same issue above with `play()`. Setting `lastPlayFinished = true` at the end `stop()` fixes this issue. >> >> A test was added for case 2 to check that the playing head indeed jumps to the end of the animation. Without this fix, it stays at the start. >> >> I'm still somewhat confused as to what constitutes a "last play finished". Any `jumpTo` resets `lastPlayFinished` to `false`, even if the jump is to the start/end of the animation. In this case, stopping an animation, jumping to its start/end, setting the rate to negative/positive, and playing, will do nothing as the end condition is reached immediately. This is what the behavior that was fixed for cases 1 and 2, but maybe this is also incorrect behavior for jumping to start/end. >> >> A test app is included in the "parent" [bug](https://bugs.openjdk.java.net/browse/JDK-8210238), which also mentions a bug relating to **pausing** and playing backwards, so be mindful of it when testing. > > The pull request has been updated with 1 additional commit. Approved. The fix looks fine to me, and now passes all unit tests. The change you made to the test is what I would expect (I had done a similar thing locally to get them to pass when I was testing). Regarding the question that came up earlier in the review about modifying the docs to remove the call to `jumpTo` from the example, I do not recommend changing the docs as part of this fix. The existing example code is still correct. More importantly, the code snippet in question is part of the docs for `Animation::play`, and isn't just talking about playing when stopped. If you play after a paused animation and want to play backwards from the end, then the `jumpTo` is still needed. Additionally, there are other questionable aspects of the Animation docs. For example, consider the following: > When rate > 0 (forward play), if an Animation is already positioned at the end, the first cycle will not be played This is misleading in that it is only true after an explicit call to "jumpTo(end)". If you play a forward animation to completion, then it isn't. My point for bring it up is that I don't really want to make changes to the docs without considering the larger implications. Please wait for @arapte to finish reviewing. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/82 From michaelstrau2 at gmail.com Tue Jan 21 19:59:25 2020 From: michaelstrau2 at gmail.com (=?UTF-8?Q?Michael_Strau=C3=9F?=) Date: Tue, 21 Jan 2020 20:59:25 +0100 Subject: Add command support for actionable controls Message-ID: 1. Abstract: Controls that are derived from ButtonBase generally represent an operation that is triggered by the control. In many cases, the control also reflects whether the operation can currently be invoked (i.e. whether the control is enabled or disabled), or whether the operation is currently running. Software patterns like MVVM often encapsulate this behavior for the purpose of decoupling business logic from UI code. 2. Implementation: I propose adding the following interface that represents the entirety of such an operation: interface Command { ReadOnlyBooleanProperty canExecuteProperty(); ReadOnlyBooleanProperty executingProperty(); void execute(); void execute(T parameter); } An application's business logic can expose operations as implementations of the Command interface, and define the conditions when the operation can be executed. Additionally, ButtonBase should be extended by adding the following two properties: /** * The button's command, which is invoked whenever the button is fired. * If a command is set on the button, {@link Node#disableProperty()} is automatically * bound to {@link Command#canExecuteProperty()}. Any previous binding is removed. */ ObjectProperty> commandProperty(); /** * The button's command parameter. * When the command is invoked, this parameter will be passed to the command implementation. */ ObjectProperty commandParameterProperty(); These two properties are lazily instantiated to prevent allocations if an application doesn't use commands. In general, Commands are an opt-in feature, so existing code that makes no use of commands is not impacted. The command is invoked whenever the control fires an ActionEvent. This can be achieved by overriding Node.fireEvent(Event) in ButtonBase and checking for the presence of an ActionEvent. I can provide a PR with an implementation of this feature. Michael From tom.schindl at bestsolution.at Tue Jan 21 20:13:58 2020 From: tom.schindl at bestsolution.at (Tom Schindl) Date: Tue, 21 Jan 2020 21:13:58 +0100 Subject: Add command support for actionable controls In-Reply-To: References: Message-ID: <017bd4e8-7eba-6cb4-6704-69bf72940c17@bestsolution.at> Hi, I see where you are coming from but IMHO JavaFX should focus on being a Graphic and UI-Toolkit and not leak any patterns into the core API. These are just by 2 cents so other might have another opinion. Tom On 21.01.20 20:59, Michael Strau? wrote: > 1. Abstract: > Controls that are derived from ButtonBase generally represent an operation > that is triggered by the control. > In many cases, the control also reflects whether the operation can > currently be invoked (i.e. whether the control is enabled or disabled), or > whether the operation is currently running. > Software patterns like MVVM often encapsulate this behavior for the purpose > of decoupling business logic from UI code. > > > 2. Implementation: > I propose adding the following interface that represents the entirety of > such an operation: > > interface Command { > ReadOnlyBooleanProperty canExecuteProperty(); > ReadOnlyBooleanProperty executingProperty(); > void execute(); > void execute(T parameter); > } > > An application's business logic can expose operations as implementations of > the Command interface, and define the conditions when the operation can be > executed. > > Additionally, ButtonBase should be extended by adding the following two > properties: > > /** > * The button's command, which is invoked whenever the button is fired. > * If a command is set on the button, {@link Node#disableProperty()} is > automatically > * bound to {@link Command#canExecuteProperty()}. Any previous binding is > removed. > */ > ObjectProperty> commandProperty(); > > /** > * The button's command parameter. > * When the command is invoked, this parameter will be passed to the > command implementation. > */ > ObjectProperty commandParameterProperty(); > > These two properties are lazily instantiated to prevent allocations if an > application doesn't use commands. > In general, Commands are an opt-in feature, so existing code that makes no > use of commands is not impacted. > > The command is invoked whenever the control fires an ActionEvent. This can > be achieved by overriding Node.fireEvent(Event) in ButtonBase and checking > for the presence of an ActionEvent. > > I can provide a PR with an implementation of this feature. > > Michael > -- Tom Schindl, CTO BestSolution.at EDV Systemhaus GmbH Salurnerstrasse 15. A-6020 Innsbruck Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck From kevin.rushforth at oracle.com Tue Jan 21 20:39:18 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 21 Jan 2020 12:39:18 -0800 Subject: Add command support for actionable controls In-Reply-To: <017bd4e8-7eba-6cb4-6704-69bf72940c17@bestsolution.at> References: <017bd4e8-7eba-6cb4-6704-69bf72940c17@bestsolution.at> Message-ID: <1a27bd9a-0ad3-2407-6e91-61783c55c123@oracle.com> We are very unlikely to consider such an enhancement. This would be a somewhat different take on the idea of an Actions framework, which has been discussed several times before without a good resolution. -- Kevin On 1/21/2020 12:13 PM, Tom Schindl wrote: > Hi, > > I see where you are coming from but IMHO JavaFX should focus on being a > Graphic and UI-Toolkit and not leak any patterns into the core API. > > These are just by 2 cents so other might have another opinion. > > Tom > > On 21.01.20 20:59, Michael Strau? wrote: >> 1. Abstract: >> Controls that are derived from ButtonBase generally represent an operation >> that is triggered by the control. >> In many cases, the control also reflects whether the operation can >> currently be invoked (i.e. whether the control is enabled or disabled), or >> whether the operation is currently running. >> Software patterns like MVVM often encapsulate this behavior for the purpose >> of decoupling business logic from UI code. >> >> >> 2. Implementation: >> I propose adding the following interface that represents the entirety of >> such an operation: >> >> interface Command { >> ReadOnlyBooleanProperty canExecuteProperty(); >> ReadOnlyBooleanProperty executingProperty(); >> void execute(); >> void execute(T parameter); >> } >> >> An application's business logic can expose operations as implementations of >> the Command interface, and define the conditions when the operation can be >> executed. >> >> Additionally, ButtonBase should be extended by adding the following two >> properties: >> >> /** >> * The button's command, which is invoked whenever the button is fired. >> * If a command is set on the button, {@link Node#disableProperty()} is >> automatically >> * bound to {@link Command#canExecuteProperty()}. Any previous binding is >> removed. >> */ >> ObjectProperty> commandProperty(); >> >> /** >> * The button's command parameter. >> * When the command is invoked, this parameter will be passed to the >> command implementation. >> */ >> ObjectProperty commandParameterProperty(); >> >> These two properties are lazily instantiated to prevent allocations if an >> application doesn't use commands. >> In general, Commands are an opt-in feature, so existing code that makes no >> use of commands is not impacted. >> >> The command is invoked whenever the control fires an ActionEvent. This can >> be achieved by overriding Node.fireEvent(Event) in ButtonBase and checking >> for the presence of an ActionEvent. >> >> I can provide a PR with an implementation of this feature. >> >> Michael >> From almatvee at openjdk.java.net Tue Jan 21 21:38:07 2020 From: almatvee at openjdk.java.net (Alexander Matveev) Date: Tue, 21 Jan 2020 21:38:07 GMT Subject: RFR: 8237078: Media build code broken on XCode 11 In-Reply-To: References: Message-ID: On Mon, 20 Jan 2020 11:10:07 GMT, Johan Vos wrote: > Fix JDK-8237078 > replace the objc_msgSend call with a direct objC call. > The fix works on XCode 10.1 and XCode 11.3 > > Tested using > java -Djfxmedia.platforms=OSXPlatform > with MediaPlayer playing an mp3. Looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/90 From kcr at openjdk.java.net Tue Jan 21 21:53:47 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 21 Jan 2020 21:53:47 GMT Subject: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size In-Reply-To: References: Message-ID: On Mon, 20 Jan 2020 11:24:05 GMT, Frederic Thevenet wrote: >> Looks good to me. >> Below is just an observation about time taken by the API, >> Platform: Windows10, `maxTextureSize`: 4096 >> For a snapshot of (4096 * n, 4096 * n): each call to `doSnapshotTile()` takes ~100 ms, and each call to `setPixels()` takes ~30 ms. >> >> Please wait for one more approval before integrating. > >> >> >> Looks good to me. >> Below is just an observation about time taken by the API, >> Platform: Windows10, `maxTextureSize`: 4096 >> For a snapshot of (4096 * n, 4096 * n): each call to `doSnapshotTile()` takes ~100 ms, and each call to `setPixels()` takes ~30 ms. >> >> Please wait for one more approval before integrating. > > Do you have the same kind of measurements for similar uses cases without this patch? I'm expecting performances to remain the same for snapshots less than `maxTextureSize*maxTextureSize` in size, since there is no extra pixel copy in that case, and the rest of the code if globally unchanged. > > Still there exists a window for performance regressions, which for instance on Windows 10 w/ the D3D rendering pipeline would be when one of the dimension of a snapshot is >4096 and <8192: in that case a snapshot would require up to 4 extra copy pixels steps with this patch. > This is due to the fact that the old code would accept to render in a texture of a size up to the non-clamped max texture size (8192 in D3D, 16384 in ES2), but because I couldn't find a clean way to access the non clamped maxTextureSize exposed by the render factory from the Scene class, I settled for Prsim.maxTextureSize, which is the clamped value (4096 by default). > I haven't dug deep enough in the code to understand precisely why the max texture size is clamped to 4096 by default, but assuming that it is for a good reason wouldn't that also apply in that case? Or is it always safe to use the non-clamped value in that particular case? I haven't done any testing yet, but I have two comments on the patch: 1. Using the clamped texture size as the upper limit is the right thing to do, but `Prism.maxTexture` isn't guaranteed to be that size. The `Prism.maxTexture` constant represents the value to clamp the texture size to. In the event that D3D or OpenGL were to report a maximum less than the value of `Prism.maxTexture` (unlikely, but maybe on some low-end embedded systems?), then that value is what should be used. The way to get the clamped texture size is to call [`ResourceFactory::getMaximumTextureSize`](https://github.com/openjdk/jfx/blob/jfx14/modules/javafx.graphics/src/main/java/com/sun/prism/ResourceFactory.java#L222), but you can't do that directly from the scene graph code. 2. Allocating multiple `WritableImage` objects and using `PixelWriter::setPixels` to stitch them together will take more temporary memory, and is likely to be slower, than having the snapshot code write into a subimage of the larger allocated image directly. Having said that, the current proposed solution is still better than the current behavior is almost all cases, although there could be a performance hit in the case of an 8K x 8K image, which will now be tiled. I want to do a more careful review and some testing. If any other users of snapshot have any comments or concerns, they would be welcome. I think the best long-term solution might be to modify the [`QuantumToolkit::renderToImage`](https://github.com/openjdk/jfx/blob/jfx14/modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java#L1490) method, although that would certainly be out of scope for JavaFX 14. ------------- PR: https://git.openjdk.java.net/jfx/pull/68 From kevin.rushforth at oracle.com Tue Jan 21 23:30:26 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 21 Jan 2020 15:30:26 -0800 Subject: Rate of embedded animations In-Reply-To: References: Message-ID: <851e9863-f7bd-8cd4-ba82-89b9ba52e1b7@oracle.com> This got buried in my inbox, and I missed seeing it. I'll respond inline. On 1/10/2020 6:45 PM, Nir Lisker wrote: > I forgot to bring up https://bugs.openjdk.java.net/browse/JDK-8200206, > which is also relevant to this discussion. The solution to that one is > probably allowing only 1 parent, similar to the scenegraph policy. > That will avoid parent animations fighting over the state of common > children animations. Good point. Regardless of which approach (1 or 2) we go with, I agree that allowing only a single parent transition is best. I note that this would be a semantic change, though, so even though we ought to decide what we want the behavior to be, actually enforcing a single parent is probably best left to JavaFX 15 (I note that https://bugs.openjdk.java.net/browse/JDK-8200206 is targeted to 15). > On Sat, Jan 11, 2020 at 3:08 AM Nir Lisker > wrote: > > What happens if you set the rate of the parent transition and > then set the rate of a child animation? > > What if you bind to the rate of a child animation? > > > There is already some code that touches this in the Animation's > rate property: > > public void invalidated() { > ? ? final double newRate = getRate(); > ? ? if (isRunningEmbedded()) { > ? ? ? ? if (isBound()) { > ? ? ? ? ? ? unbind(); > ? ? ? ? } > ? ? ? ? set(oldRate); > ? ? ? ? throw new IllegalStateException("Cannot set rate of > embedded animation while running."); > ? ? } > > isRunningEmbedded checks for a parent animation that is not > STOPPED. That means that the rate of a child animation can only > change while the parent is stopped, but it is ignored (the child's > ClipEnvelope's rate is updated to the parent's rate instead). > Binding to the rate property is never an issue, but it does give > meaningless results since the rate is ignored. Binding the rate > property itself will cause it to be unbinded. > > If we go with option 1, which is almost the current situation, > there is only some cleanup needed when it comes to the relation > between the Animation's rate and its ClipEnvelope's rate. > This (option 1) seems easiest, but I can see am argument for either approach. Remind me again, which JBS bug you are planning to use to fix this issue? > If we go with option 2, we can eliminate the duplication of rate > in the Animation and the ClipEnvelope (though ClipEvenope to > Animation is somewhat like a peer to a Node, which duplicates the > values as well, so maybe we want that?). The children's rate will > always be the parent's rate. In this case the above code should > probably be modified to account for STOPPED parents as well. A > bound rate property will be unbinded and setting it will be either > ignored or throw an exception. > Yes, I would agree with this. > > I'll note that currentRate is eliminated from the ClipEnvelope in > the fix I'm working on, but as it's read-only, it's a different story. > > As long as the implementation > is consistent in ignoring the rate property from the child > Animation, > this seems like a fine solution and is consistent with other > properties > where one property overrides another without modifying it. > > > Which other properties? > I meant outside animation. Node.opacity for example. You can set it to any value and it is clamped on use. I realize that this is a different situation. > delay, autoReverse, and cycleCount all work separately on the > parent and child. For example, if both parent and child have > autoReverse = true and cycleCount = 2, the animation will play > forwards, backwards, forwards, backwards, so both are taken into > account. > OK. -- Kevin > On Wed, Jan 8, 2020 at 1:14 AM Kevin Rushforth > > > wrote: > > A rate in a "parent" transition should probably override the > rate in a > child Animation. There are a couple ways to do it, and it > sounds like it > doesn't really implement it right. > > 1. The public rate property values of child Animations within > a parent > Transition are ignored, but not updated. As long as the > implementation > is consistent in ignoring the rate property from the child > Animation, > this seems like a fine solution and is consistent with other > properties > where one property overrides another without modifying it. > > 2. Setting a rate on the parent Transition actually modifies > the child > node. This can work, but has more issues. What happens if you > set the > rate of the parent tansition and then set the rate of a child > animation? > What if you bind to the rate of a child animation? > > -- Kevin > > On 1/1/2020 1:04 PM, Nir Lisker wrote: > > Hi, > > > > As part of my work in the animations package I've come > across an undefined > > spec. Is the rate of an animation that is embedded in a > Parallel/Sequential > > transition inherited and overridden by its parent? > > > > If I have an animations with a rate of 1 and a parent with a > rate of 2, and > > I add the animation to the parent, does the rate property > change from 1 to > > 2 (generating a change/invalidation event etc.)? Then, > should any > > subsequent changes to the parent's rate trigger a change in > the child's > > rate? > > > > The implementation is a bit messy in this regard. The rate > and currentRate > > values exist in both Animation and its ClipEnvelope, which > is the source > > for a couple of bugs. For example, changing the rate of a > > ParallelTransition changes the child's ClipEnvelope's rate > and currentRate, > > but only the animation's currentRate (and not rate). Is it > supposed to be > > this way? > > > > What is clear is that it's not possible to change the rate > of the embedded > > animation directly. > > > > The docs do not talk about the rate of an embedded animation > (they do talk > > about the node property though). > > > > - Nir > From kcr at openjdk.java.net Tue Jan 21 23:54:35 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 21 Jan 2020 23:54:35 GMT Subject: RFR: 8237078: Media build code broken on XCode 11 In-Reply-To: References: Message-ID: On Tue, 21 Jan 2020 21:37:54 GMT, Alexander Matveev wrote: >> Fix JDK-8237078 >> replace the objc_msgSend call with a direct objC call. >> The fix works on XCode 10.1 and XCode 11.3 >> >> Tested using >> java -Djfxmedia.platforms=OSXPlatform >> with MediaPlayer playing an mp3. > > Looks good. @johanvos can you change the PR title to match the JBS title? 8237078: [macOS] Media build broken on XCode 11 ------------- PR: https://git.openjdk.java.net/jfx/pull/90 From nlisker at gmail.com Wed Jan 22 00:51:14 2020 From: nlisker at gmail.com (Nir Lisker) Date: Wed, 22 Jan 2020 02:51:14 +0200 Subject: Rate of embedded animations In-Reply-To: <851e9863-f7bd-8cd4-ba82-89b9ba52e1b7@oracle.com> References: <851e9863-f7bd-8cd4-ba82-89b9ba52e1b7@oracle.com> Message-ID: Then I will take approach 1 for now. Remind me again, which JBS bug you are planning to use to fix this issue? https://bugs.openjdk.java.net/browse/JDK-8236858 On Wed, Jan 22, 2020 at 1:31 AM Kevin Rushforth wrote: > This got buried in my inbox, and I missed seeing it. > > I'll respond inline. > > > On 1/10/2020 6:45 PM, Nir Lisker wrote: > > I forgot to bring up https://bugs.openjdk.java.net/browse/JDK-8200206, > which is also relevant to this discussion. The solution to that one is > probably allowing only 1 parent, similar to the scenegraph policy. That > will avoid parent animations fighting over the state of common children > animations. > > > Good point. Regardless of which approach (1 or 2) we go with, I agree that > allowing only a single parent transition is best. I note that this would be > a semantic change, though, so even though we ought to decide what we want > the behavior to be, actually enforcing a single parent is probably best > left to JavaFX 15 (I note that > https://bugs.openjdk.java.net/browse/JDK-8200206 is targeted to 15). > > On Sat, Jan 11, 2020 at 3:08 AM Nir Lisker wrote: > >> What happens if you set the rate of the parent transition and then set >>> the rate of a child animation? >>> >> What if you bind to the rate of a child animation? >> >> >> There is already some code that touches this in the Animation's rate >> property: >> >> public void invalidated() { >> final double newRate = getRate(); >> if (isRunningEmbedded()) { >> if (isBound()) { >> unbind(); >> } >> set(oldRate); >> throw new IllegalStateException("Cannot set rate of embedded >> animation while running."); >> } >> >> isRunningEmbedded checks for a parent animation that is not STOPPED. That >> means that the rate of a child animation can only change while the parent >> is stopped, but it is ignored (the child's ClipEnvelope's rate is updated >> to the parent's rate instead). >> Binding to the rate property is never an issue, but it does give >> meaningless results since the rate is ignored. Binding the rate property >> itself will cause it to be unbinded. >> >> If we go with option 1, which is almost the current situation, there is >> only some cleanup needed when it comes to the relation between the >> Animation's rate and its ClipEnvelope's rate. >> > > This (option 1) seems easiest, but I can see am argument for either > approach. > > Remind me again, which JBS bug you are planning to use to fix this issue? > > If we go with option 2, we can eliminate the duplication of rate in the >> Animation and the ClipEnvelope (though ClipEvenope to Animation is somewhat >> like a peer to a Node, which duplicates the values as well, so maybe we >> want that?). The children's rate will always be the parent's rate. In this >> case the above code should probably be modified to account for STOPPED >> parents as well. A bound rate property will be unbinded and setting it will >> be either ignored or throw an exception. >> > > Yes, I would agree with this. > > >> I'll note that currentRate is eliminated from the ClipEnvelope in the fix >> I'm working on, but as it's read-only, it's a different story. >> >> As long as the implementation >>> is consistent in ignoring the rate property from the child Animation, >>> this seems like a fine solution and is consistent with other properties >>> where one property overrides another without modifying it. >> >> >> Which other properties? >> > > I meant outside animation. Node.opacity for example. You can set it to any > value and it is clamped on use. I realize that this is a different > situation. > > > delay, autoReverse, and cycleCount all work separately on the parent and >> child. For example, if both parent and child have autoReverse = true and >> cycleCount = 2, the animation will play forwards, backwards, forwards, >> backwards, so both are taken into account. >> > > OK. > > -- Kevin > > > On Wed, Jan 8, 2020 at 1:14 AM Kevin Rushforth >> wrote: >> >>> A rate in a "parent" transition should probably override the rate in a >>> child Animation. There are a couple ways to do it, and it sounds like it >>> doesn't really implement it right. >>> >>> 1. The public rate property values of child Animations within a parent >>> Transition are ignored, but not updated. As long as the implementation >>> is consistent in ignoring the rate property from the child Animation, >>> this seems like a fine solution and is consistent with other properties >>> where one property overrides another without modifying it. >>> >>> 2. Setting a rate on the parent Transition actually modifies the child >>> node. This can work, but has more issues. What happens if you set the >>> rate of the parent tansition and then set the rate of a child animation? >>> What if you bind to the rate of a child animation? >>> >>> -- Kevin >>> >>> On 1/1/2020 1:04 PM, Nir Lisker wrote: >>> > Hi, >>> > >>> > As part of my work in the animations package I've come across an >>> undefined >>> > spec. Is the rate of an animation that is embedded in a >>> Parallel/Sequential >>> > transition inherited and overridden by its parent? >>> > >>> > If I have an animations with a rate of 1 and a parent with a rate of >>> 2, and >>> > I add the animation to the parent, does the rate property change from >>> 1 to >>> > 2 (generating a change/invalidation event etc.)? Then, should any >>> > subsequent changes to the parent's rate trigger a change in the child's >>> > rate? >>> > >>> > The implementation is a bit messy in this regard. The rate and >>> currentRate >>> > values exist in both Animation and its ClipEnvelope, which is the >>> source >>> > for a couple of bugs. For example, changing the rate of a >>> > ParallelTransition changes the child's ClipEnvelope's rate and >>> currentRate, >>> > but only the animation's currentRate (and not rate). Is it supposed to >>> be >>> > this way? >>> > >>> > What is clear is that it's not possible to change the rate of the >>> embedded >>> > animation directly. >>> > >>> > The docs do not talk about the rate of an embedded animation (they do >>> talk >>> > about the node property though). >>> > >>> > - Nir >>> >>> > From arapte at openjdk.java.net Wed Jan 22 09:03:12 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Wed, 22 Jan 2020 09:03:12 GMT Subject: RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag In-Reply-To: References: Message-ID: On Mon, 20 Jan 2020 10:00:55 GMT, Robert Lichtenberger wrote: > Test simulates a single mouse-released event. > Fix simply guards against the null case. The scenario mentioned in [JDK-8237372](https://bugs.openjdk.java.net/browse/JDK-8237372) seems valid scenario. However I am not sure if the scenario can be avoided or not. Irrespective of that, the code in question should be corrected. Suggested a minor change. modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java line 2216: > 2215: // Animate tab header being dragged to its final position. > 2216: if (dragTabHeader != null) { > 2217: dragHeaderSourceX = dragTabHeader.getLayoutX(); This is a situation when reorder was not started. So a check as `else if (dragState == DragState.REORDER)` seems more correct instead of `null` check. With this `else if` the `return;` on line 2213 can be removed. ------------- PR: https://git.openjdk.java.net/jfx/pull/89 From jvos at openjdk.java.net Wed Jan 22 12:27:30 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Wed, 22 Jan 2020 12:27:30 GMT Subject: [Integrated] RFR: 8237078: Media build code broken on XCode 11 In-Reply-To: References: Message-ID: <1f4a9337-0371-4c79-9ded-74288c11e8e1@openjdk.org> Changeset: be22e853 Author: Johan Vos Date: 2020-01-22 12:26:17 +0000 URL: https://git.openjdk.java.net/jfx/commit/be22e853 8237078: [macOS] Media build broken on XCode 11 Reviewed-by: kcr, almatvee ! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.mm From Rony.Flatscher at wu.ac.at Wed Jan 22 13:44:01 2020 From: Rony.Flatscher at wu.ac.at (Rony G. Flatscher) Date: Wed, 22 Jan 2020 14:44:01 +0100 Subject: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script In-Reply-To: <029b4f44-bf12-e99f-bf60-118b5638dcff@wu.ac.at> References: <5bca4803-6372-7569-254c-3d08a57accb0@wu.ac.at> <91dcbb22-2acf-3c51-6f89-a0d394688bed@wu.ac.at> <1ea149d7-69a5-dd3a-f5d6-82b08921d2a9@oracle.com> <9e391ac6-c9ab-47be-88f4-a1214290f371@oracle.com> <4a81fc93-c933-3ab9-363e-2a9ef54632c6@wu.ac.at> <2f8f8701-5400-ae48-abf1-285de1e18f3b@oracle.com> <39b317bf-4aac-16be-e82d-6519452d8af8@wu.ac.at> <029b4f44-bf12-e99f-bf60-118b5638dcff@wu.ac.at> Message-ID: Last November I submitted an appropriate bug report and mailed the testcase on November 27th per Oracle's request without hearing anything to this date. Therefore I was wondering how long such an assessment usually takes place and what to do? (Maybe it "fell off the desk" due to the end-of-year stress and Christmas vacation?) Any advice? ---rony On 21.11.2019 15:39, Rony G. Flatscher wrote: > As the zip-archive attachment got stripped, for a brief time the zip-archive can be fetched from > . > > ---rony > > On 21.11.2019 15:29, Rony G. Flatscher wrote: >> On 15.11.2019 16:08, Rony G. Flatscher wrote: >>> On 14.11.2019 22:57, Kevin Rushforth wrote: >>>> On 11/14/2019 10:12 AM, Rony G. Flatscher wrote: >>>>> On 14.11.2019 16:34, Rony G. Flatscher wrote: >>>>>> On 13.11.2019 19:50, Kevin Rushforth wrote: >>>>>>> On 11/13/2019 9:42 AM, Rony G. Flatscher wrote: >>>>> ... cut ... >>>>>>>> To reproduce the testcase one would need ooRexx and the Java bridge BSF4ooRexx (all >>>>>>>> opensource) for >>>>>>>> which I could come up with a zip-archive (assuming binaries within should be 64-bit) and a >>>>>>>> script to >>>>>>>> set up the environment either for Windows, Linux or MacOS, whatever you advise. Would that be >>>>>>>> o.k.? >>>>>>> We prefer not to rely on third-party libraries for test cases. In any case we would not be able to >>>>>>> use that for a regression test / unit test. >>>>> If test units really seem to be important in this particular case, one possibility would be to >>>>> create a minimalistic ScriptEngine implementation in pure Java just for the sole purpose to allow >>>>> the creation of a test unit that is able to assert that FXMLLoader puts the ScriptEngine.ARGV and >>>>> ScriptEngine.FILENAME entries into the ENGINE_SCOPE Bindings. E.g. having the ScriptEngine's eval() >>>>> methods return the ScriptContext at invocation time in order to allow inspection of the Bindings. >>>>> This way it would become also possible to write in addition test units that also check whether all >>>>> FXML elements that carry a fx:id are really placed into the GLOBAL_SCOPE Bindings. >>>> Something like that seems reasonable, and would avoid a dependence on Nashorn, which in addition >>>> to having all the problems you mentioned, is deprecated for removal. >>>> >>>>> However, >>>> Did you have something more to add? >>> No, sorry for that. Rewrote my e-mail and had sent it too early by mistake and without noticing. >>> >>> Will study all the procedures and create a testcase to be submitted at >>> as per your advice (and will report back under this thread once submitted). The testcase would use >>> an artificial ScriptEngine implementation that could be used for testunit testing as well. This >>> might take a while due to other obligations that I will have to meet during the next few days. >>> >>> ---rony >> O.K., so came up with a test case that contains an artificial script engine implementation for >> logging the eval() invocations together with the scripts to execute and the ScriptContext >> ENGINE_SCOPE and GLOBAL_SCOPE Bindings at the time of the invocation. (It is meant to be also usable >> for creating script engine related test units for Java script hosts.) >> >> Packaged the source and binaries of that script engine as jar file that one merely needs to put on >> the CLASSPATH or add as a module. >> >> An updated FXMLLoader patch suggesting a fix is included as well. This version appends the line >> number to the file name if the script to be evaluated is embedded in the fxml-file, such that in >> case of an error it becomes possible to quickly find it in larger fxml files. >> >> With the zip-archive done I went to the Oracle Java Bug Database and just entered a bug report at >> got the internal "ID : 9062887". >> >> As it was not possible to attach/upload the zip-archive at this point, I will attach the zip-archive >> (contains all sources and binaries) to this e-mail. The contained reads: >> >> Testcase that demonstrates that FXMLLoader does not set [1] >> ScriptEngine.FILENAME and [2] ScriptEngine.ARGV entries in >> ScriptContext.ENGINE_SCOPE Bindings. >> >> To run the test case: >> >> - unzip testcaseFXMLLoaderScriptEngines.zip, >> >> - change into "testcaseFXMLLoaderScriptEngines" subdirectory, >> >> - run the testcase by issuing the following command: >> >> ? - Unix: >> >> ??????? java -cp .:RgfPseudoScriptEngine.jar FXMLLoaderTestCase4ScriptEngineScope >> >> ? - Windows: >> >> ??????? java -cp .;RgfPseudoScriptEngine.jar FXMLLoaderTestCase4ScriptEngineScope >> >> FXMLLoaderTestCase4ScriptEngineScope loads "demo_01.fxml" which is a controller >> that uses the pseudo script language rgf.scriptEngine.RgfPseudoScriptEngine, >> which logs the eval() invocations with the script code and the Bindings of the >> ScriptContext. >> >> Comparing "demo_01.fxml" and the output of the above test case demonstrates that >> FXMLLoader does not popuplate the [3] ENGINE_SCOPE Bindings with the filename of >> the script that gets evaluated, nor does add the ARGV entry to the ENGINE_SCOPE >> Bindings in the case of events (just an entry named "event"). >> >> In case of errors (during development or deployment) it is not possible >> therefore to point to the file (external file or the fxml-file defining >> explicitly script code) in which a runtime error has occurred. >> >> In the case of an event callback, if ARGV was defined the script code could >> directly fetch and interact with the supplied event object argument.? In the >> case that a script engine does not automatically make Bindings entry available >> as implicit variables (e.g.? for scoping reasons) it becomes cumbersome or even >> impossible in some script engine implementations (if they do not provide access >> to the Bindings) to get at the event argument of the callback invocation. >> >> The JSR-223 specifications lists all the (reserved) ScriptEngine constants that >> are meant to be used as reserved keys for the ENGINE_SCOPE Bindings, whenever >> appropriate cf.? [0] p.? l50 ff.? (A ScriptEngine is supposed to populate and >> maintain the ENGINE_SCOPE Bindings hence the definition of these constants with >> the class.) >> >> Running the above program on Windows yields the output captured and supplied in >> [4]. >> >> The supplied patch [5] changes FXMLLoader.java such, >> >> - that the ScriptEngine.FILENAME entry is always set in the ENGINE_SCOPE >> ? Bindings. In the case that the scripts are hosted in a fxml-file that file >> ? path will be used together with an appended string that hints at the location >> ? in the fxml file from where the script has been taken for evaluation. In the >> ? case of event handling scripts that appended string hints at the location in >> ? the fxml-file where the event attribute with the script code got used. >> >> - and that the ScriptEngine.ARGV entry is always set in the ENGINE_SCOPE >> ? Bindings for event callbacks using the 'event' object as the single argument. >> >> Applying the patch and running the above program on Linux yields the output >> captured and supplied in [6]. >> >> --- >> >> The jar-file [7] needs merely to be put on the CLASSPATH (or MODULE_PATH as a >> proper module-info.class is included, the module name is "rgf.scriptEngine") to >> make the pseudo scripting language available and to run the supplied testcase. >> The RgfPseudoScriptEngine (script engine name and extension is "rpsl") >> implementation should also make it possible to create test units for asserting >> that Java script hosts are populating the ScriptContext Bindings according to >> specifications. >> >> All Java classes come with their source code (the script engine service file and >> module-info.{java|class} are contained in the jar file). >> >> Having signed the OCA you may use all of the supplied code freely. >> >> If there is anything you need or that I could provide, please let me know. >> >> ---rony >> >> [0] JSR-223 specification at , download >> ??? : >> ??? "java_scripting-1_0-fr-spec.pdf" >> >> [1] >> >> >> [2] >> >> >> [3] >> >> >> [4] Output of running the testcase on Windows (Java 8): "info/Demo_output_without_fix.txt" >> >> [5] FXMLLoader patch: "info/diff_add_FILENAME_ARGV_to_FXMLLoader_preferable_20191121.txt" >> >> [6] Output of running the testcase after patching FXMLLoader with [5] on Linux (OpenJDK 11.0.5): >> ??? "info/Demo_output_with_fix_and_linenumbers.txt" >> >> [7] Pseudo script engine implementation to be put on the CLASSPATH or MODULE_PATH (module >> ??? name "rgf.scriptEngine"): >> >> [8] FXML test case: >> >> ??? - FXMLLoaderTestCase4ScriptEngineScope.{java|class} >> ????? ... loads "demo_01.rxml" and dumps the engine and global Bindings >> >> ??? - demo_01.fxml >> ??? ... FXML file using scripts in the pseudo script language [7] as controller, >> ??????? either as external or embedded scripts, including scripts for event >> ??????? handling Action and MouseClicked events >> >> ??? - demo_01_bottomscript.rpsl? ... serving as external script file >> >> ??? - demo_01_middlescript.rpsl? ... serving as external script file >> >> ??? - demo_01_topscript.rpsl???? ... serving as external script file >> >> If there is anything else I can/should do, please advise. >> (Being on the road in the next few days it might take me until the beginning of next week to get back.) >> >> ---rony From dgrieve at openjdk.java.net Wed Jan 22 15:00:48 2020 From: dgrieve at openjdk.java.net (David Grieve) Date: Wed, 22 Jan 2020 15:00:48 GMT Subject: RFR: 8237469: CssStyleHelper reuse check fixed In-Reply-To: References: Message-ID: <4nH9CJeHvFv63JTh0thKODzzPH2N9Cp0wlgo7oYwGvQ=.17d9dbb4-1658-4d15-9815-7884f8674c7c@github.com> On Fri, 17 Jan 2020 14:09:54 GMT, Dean Wookey wrote: > Everything passes with the fix and 5 of the new tests fail without the fix. > > removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest > movingBranchToDifferentBranchGetsNewCssVariableTest > removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue > removingThenAddingNodeToDifferentBranchGetsIneritableStyle > movingNodeToDifferentBranchGetsNewFontStyleTest > > I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is? > > Originally introduced here: https://bugs.openjdk.java.net/browse/JDK-8090462/ https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab Changes requested by dgrieve (Reviewer). modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line 134: > 133: node.styleHelper.triggerStates.addAll(triggerStates[0]); > 134: > 135: updateParentTriggerStates(node, depth, triggerStates); In canReuseStyleHelper, there is this check // If the style maps are the same instance, we can re-use the current styleHelper if the cacheContainer is null. // Under this condition, there are no styles for this node _and_ no styles inherit. if (node.styleHelper.cacheContainer == null) { return true; } And later in the same function is a check for (parent == null) that returns true. In both cases, firstStyleableAncestor will still point to the old first-styleable ancestor. ------------- PR: https://git.openjdk.java.net/jfx/pull/87 From dwookey at openjdk.java.net Wed Jan 22 15:25:30 2020 From: dwookey at openjdk.java.net (Dean Wookey) Date: Wed, 22 Jan 2020 15:25:30 GMT Subject: RFR: 8237469: CssStyleHelper reuse check fixed In-Reply-To: <4nH9CJeHvFv63JTh0thKODzzPH2N9Cp0wlgo7oYwGvQ=.17d9dbb4-1658-4d15-9815-7884f8674c7c@github.com> References: <4nH9CJeHvFv63JTh0thKODzzPH2N9Cp0wlgo7oYwGvQ=.17d9dbb4-1658-4d15-9815-7884f8674c7c@github.com> Message-ID: On Wed, 22 Jan 2020 15:00:14 GMT, David Grieve wrote: >> Everything passes with the fix and 5 of the new tests fail without the fix. >> >> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest >> movingBranchToDifferentBranchGetsNewCssVariableTest >> removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue >> removingThenAddingNodeToDifferentBranchGetsIneritableStyle >> movingNodeToDifferentBranchGetsNewFontStyleTest >> >> I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is? >> >> Originally introduced here: https://bugs.openjdk.java.net/browse/JDK-8090462/ https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab > > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line 134: > >> 133: node.styleHelper.triggerStates.addAll(triggerStates[0]); >> 134: >> 135: updateParentTriggerStates(node, depth, triggerStates); > > In canReuseStyleHelper, there is this check > // If the style maps are the same instance, we can re-use the current styleHelper if the cacheContainer is null. > // Under this condition, there are no styles for this node _and_ no styles inherit. > if (node.styleHelper.cacheContainer == null) { > return true; > } > And later in the same function is a check for (parent == null) that returns true. In both cases, firstStyleableAncestor will still point to the old first-styleable ancestor. Thanks. For some reason I thought all the early exits out of the method returned false. I'll push a fix. ------------- PR: https://git.openjdk.java.net/jfx/pull/87 From anthonyv.be at outlook.com Wed Jan 22 16:07:53 2020 From: anthonyv.be at outlook.com (Anthony Vanelverdinghe) Date: Wed, 22 Jan 2020 16:07:53 +0000 Subject: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script In-Reply-To: References: <5bca4803-6372-7569-254c-3d08a57accb0@wu.ac.at> <91dcbb22-2acf-3c51-6f89-a0d394688bed@wu.ac.at> <1ea149d7-69a5-dd3a-f5d6-82b08921d2a9@oracle.com> <9e391ac6-c9ab-47be-88f4-a1214290f371@oracle.com> <4a81fc93-c933-3ab9-363e-2a9ef54632c6@wu.ac.at> <2f8f8701-5400-ae48-abf1-285de1e18f3b@oracle.com> <39b317bf-4aac-16be-e82d-6519452d8af8@wu.ac.at> <029b4f44-bf12-e99f-bf60-118b5638dcff@wu.ac.at>, Message-ID: Hi Rony Your issue has been converted into a JDK issue, with your testcase attached [1]. Normally you should?ve received an e-mail at the time of this conversion, but you can check this yourself by using the internal review ID as in [2]. If you?d like to contribute a fix, see [3]. Kind regards, Anthony [1] https://bugs.openjdk.java.net/browse/JDK-8234959 [2] https://bugs.openjdk.java.net/browse/JI-9062887 [3] https://github.com/openjdk/jfx From: Rony G. Flatscher Sent: Wednesday, 22 January 2020 14:44 To: openjfx-dev at openjdk.java.net Subject: Re: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script Last November I submitted an appropriate bug report and mailed the testcase on November 27th per Oracle's request without hearing anything to this date. Therefore I was wondering how long such an assessment usually takes place and what to do? (Maybe it "fell off the desk" due to the end-of-year stress and Christmas vacation?) Any advice? ---rony On 21.11.2019 15:39, Rony G. Flatscher wrote: > As the zip-archive attachment got stripped, for a brief time the zip-archive can be fetched from > . > > ---rony > > On 21.11.2019 15:29, Rony G. Flatscher wrote: >> On 15.11.2019 16:08, Rony G. Flatscher wrote: >>> On 14.11.2019 22:57, Kevin Rushforth wrote: >>>> On 11/14/2019 10:12 AM, Rony G. Flatscher wrote: >>>>> On 14.11.2019 16:34, Rony G. Flatscher wrote: >>>>>> On 13.11.2019 19:50, Kevin Rushforth wrote: >>>>>>> On 11/13/2019 9:42 AM, Rony G. Flatscher wrote: >>>>> ... cut ... >>>>>>>> To reproduce the testcase one would need ooRexx and the Java bridge BSF4ooRexx (all >>>>>>>> opensource) for >>>>>>>> which I could come up with a zip-archive (assuming binaries within should be 64-bit) and a >>>>>>>> script to >>>>>>>> set up the environment either for Windows, Linux or MacOS, whatever you advise. Would that be >>>>>>>> o.k.? >>>>>>> We prefer not to rely on third-party libraries for test cases. In any case we would not be able to >>>>>>> use that for a regression test / unit test. >>>>> If test units really seem to be important in this particular case, one possibility would be to >>>>> create a minimalistic ScriptEngine implementation in pure Java just for the sole purpose to allow >>>>> the creation of a test unit that is able to assert that FXMLLoader puts the ScriptEngine.ARGV and >>>>> ScriptEngine.FILENAME entries into the ENGINE_SCOPE Bindings. E.g. having the ScriptEngine's eval() >>>>> methods return the ScriptContext at invocation time in order to allow inspection of the Bindings. >>>>> This way it would become also possible to write in addition test units that also check whether all >>>>> FXML elements that carry a fx:id are really placed into the GLOBAL_SCOPE Bindings. >>>> Something like that seems reasonable, and would avoid a dependence on Nashorn, which in addition >>>> to having all the problems you mentioned, is deprecated for removal. >>>> >>>>> However, >>>> Did you have something more to add? >>> No, sorry for that. Rewrote my e-mail and had sent it too early by mistake and without noticing. >>> >>> Will study all the procedures and create a testcase to be submitted at >>> as per your advice (and will report back under this thread once submitted). The testcase would use >>> an artificial ScriptEngine implementation that could be used for testunit testing as well. This >>> might take a while due to other obligations that I will have to meet during the next few days. >>> >>> ---rony >> O.K., so came up with a test case that contains an artificial script engine implementation for >> logging the eval() invocations together with the scripts to execute and the ScriptContext >> ENGINE_SCOPE and GLOBAL_SCOPE Bindings at the time of the invocation. (It is meant to be also usable >> for creating script engine related test units for Java script hosts.) >> >> Packaged the source and binaries of that script engine as jar file that one merely needs to put on >> the CLASSPATH or add as a module. >> >> An updated FXMLLoader patch suggesting a fix is included as well. This version appends the line >> number to the file name if the script to be evaluated is embedded in the fxml-file, such that in >> case of an error it becomes possible to quickly find it in larger fxml files. >> >> With the zip-archive done I went to the Oracle Java Bug Database and just entered a bug report at >> got the internal "ID : 9062887". >> >> As it was not possible to attach/upload the zip-archive at this point, I will attach the zip-archive >> (contains all sources and binaries) to this e-mail. The contained reads: >> >> Testcase that demonstrates that FXMLLoader does not set [1] >> ScriptEngine.FILENAME and [2] ScriptEngine.ARGV entries in >> ScriptContext.ENGINE_SCOPE Bindings. >> >> To run the test case: >> >> - unzip testcaseFXMLLoaderScriptEngines.zip, >> >> - change into "testcaseFXMLLoaderScriptEngines" subdirectory, >> >> - run the testcase by issuing the following command: >> >> - Unix: >> >> java -cp .:RgfPseudoScriptEngine.jar FXMLLoaderTestCase4ScriptEngineScope >> >> - Windows: >> >> java -cp .;RgfPseudoScriptEngine.jar FXMLLoaderTestCase4ScriptEngineScope >> >> FXMLLoaderTestCase4ScriptEngineScope loads "demo_01.fxml" which is a controller >> that uses the pseudo script language rgf.scriptEngine.RgfPseudoScriptEngine, >> which logs the eval() invocations with the script code and the Bindings of the >> ScriptContext. >> >> Comparing "demo_01.fxml" and the output of the above test case demonstrates that >> FXMLLoader does not popuplate the [3] ENGINE_SCOPE Bindings with the filename of >> the script that gets evaluated, nor does add the ARGV entry to the ENGINE_SCOPE >> Bindings in the case of events (just an entry named "event"). >> >> In case of errors (during development or deployment) it is not possible >> therefore to point to the file (external file or the fxml-file defining >> explicitly script code) in which a runtime error has occurred. >> >> In the case of an event callback, if ARGV was defined the script code could >> directly fetch and interact with the supplied event object argument. In the >> case that a script engine does not automatically make Bindings entry available >> as implicit variables (e.g. for scoping reasons) it becomes cumbersome or even >> impossible in some script engine implementations (if they do not provide access >> to the Bindings) to get at the event argument of the callback invocation. >> >> The JSR-223 specifications lists all the (reserved) ScriptEngine constants that >> are meant to be used as reserved keys for the ENGINE_SCOPE Bindings, whenever >> appropriate cf. [0] p. l50 ff. (A ScriptEngine is supposed to populate and >> maintain the ENGINE_SCOPE Bindings hence the definition of these constants with >> the class.) >> >> Running the above program on Windows yields the output captured and supplied in >> [4]. >> >> The supplied patch [5] changes FXMLLoader.java such, >> >> - that the ScriptEngine.FILENAME entry is always set in the ENGINE_SCOPE >> Bindings. In the case that the scripts are hosted in a fxml-file that file >> path will be used together with an appended string that hints at the location >> in the fxml file from where the script has been taken for evaluation. In the >> case of event handling scripts that appended string hints at the location in >> the fxml-file where the event attribute with the script code got used. >> >> - and that the ScriptEngine.ARGV entry is always set in the ENGINE_SCOPE >> Bindings for event callbacks using the 'event' object as the single argument. >> >> Applying the patch and running the above program on Linux yields the output >> captured and supplied in [6]. >> >> --- >> >> The jar-file [7] needs merely to be put on the CLASSPATH (or MODULE_PATH as a >> proper module-info.class is included, the module name is "rgf.scriptEngine") to >> make the pseudo scripting language available and to run the supplied testcase. >> The RgfPseudoScriptEngine (script engine name and extension is "rpsl") >> implementation should also make it possible to create test units for asserting >> that Java script hosts are populating the ScriptContext Bindings according to >> specifications. >> >> All Java classes come with their source code (the script engine service file and >> module-info.{java|class} are contained in the jar file). >> >> Having signed the OCA you may use all of the supplied code freely. >> >> If there is anything you need or that I could provide, please let me know. >> >> ---rony >> >> [0] JSR-223 specification at , download >> : >> "java_scripting-1_0-fr-spec.pdf" >> >> [1] >> >> >> [2] >> >> >> [3] >> >> >> [4] Output of running the testcase on Windows (Java 8): "info/Demo_output_without_fix.txt" >> >> [5] FXMLLoader patch: "info/diff_add_FILENAME_ARGV_to_FXMLLoader_preferable_20191121.txt" >> >> [6] Output of running the testcase after patching FXMLLoader with [5] on Linux (OpenJDK 11.0.5): >> "info/Demo_output_with_fix_and_linenumbers.txt" >> >> [7] Pseudo script engine implementation to be put on the CLASSPATH or MODULE_PATH (module >> name "rgf.scriptEngine"): >> >> [8] FXML test case: >> >> - FXMLLoaderTestCase4ScriptEngineScope.{java|class} >> ... loads "demo_01.rxml" and dumps the engine and global Bindings >> >> - demo_01.fxml >> ... FXML file using scripts in the pseudo script language [7] as controller, >> either as external or embedded scripts, including scripts for event >> handling Action and MouseClicked events >> >> - demo_01_bottomscript.rpsl ... serving as external script file >> >> - demo_01_middlescript.rpsl ... serving as external script file >> >> - demo_01_topscript.rpsl ... serving as external script file >> >> If there is anything else I can/should do, please advise. >> (Being on the road in the next few days it might take me until the beginning of next week to get back.) >> >> ---rony From dwookey at openjdk.java.net Wed Jan 22 16:26:10 2020 From: dwookey at openjdk.java.net (Dean Wookey) Date: Wed, 22 Jan 2020 16:26:10 GMT Subject: [Rev 01] RFR: 8237469: CssStyleHelper reuse check fixed In-Reply-To: References: Message-ID: <8GTA0ist_AM_kquybyA5mj-dq6FPH5fO-vYXb1Ir-Xc=.57c7a535-c6e6-4745-8781-81be60dd212a@github.com> > Everything passes with the fix and 5 of the new tests fail without the fix. > > removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest > movingBranchToDifferentBranchGetsNewCssVariableTest > removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue > removingThenAddingNodeToDifferentBranchGetsIneritableStyle > movingNodeToDifferentBranchGetsNewFontStyleTest > > I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is? > > Originally introduced here: https://bugs.openjdk.java.net/browse/JDK-8090462/ https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab The pull request has been updated with 1 additional commit. ------------- Added commits: - 782f55e3: 8237469: Moved firstStyleableAncestor call to before canReuseStyleHelper can return true Changes: - all: https://git.openjdk.java.net/jfx/pull/87/files - new: https://git.openjdk.java.net/jfx/pull/87/files/0749dde7..782f55e3 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/87/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/87/webrev.00-01 Stats: 5 lines in 1 file changed: 3 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/87.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/87/head:pull/87 PR: https://git.openjdk.java.net/jfx/pull/87 From dgrieve at openjdk.java.net Wed Jan 22 17:03:50 2020 From: dgrieve at openjdk.java.net (David Grieve) Date: Wed, 22 Jan 2020 17:03:50 GMT Subject: [Rev 01] RFR: 8237469: CssStyleHelper reuse check fixed In-Reply-To: <8GTA0ist_AM_kquybyA5mj-dq6FPH5fO-vYXb1Ir-Xc=.57c7a535-c6e6-4745-8781-81be60dd212a@github.com> References: <8GTA0ist_AM_kquybyA5mj-dq6FPH5fO-vYXb1Ir-Xc=.57c7a535-c6e6-4745-8781-81be60dd212a@github.com> Message-ID: On Wed, 22 Jan 2020 17:03:49 GMT, Dean Wookey wrote: >> Everything passes with the fix and 5 of the new tests fail without the fix. >> >> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest >> movingBranchToDifferentBranchGetsNewCssVariableTest >> removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue >> removingThenAddingNodeToDifferentBranchGetsIneritableStyle >> movingNodeToDifferentBranchGetsNewFontStyleTest >> >> I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is? >> >> Originally introduced here: https://bugs.openjdk.java.net/browse/JDK-8090462/ https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab > > The pull request has been updated with 1 additional commit. Marked as reviewed by dgrieve (Reviewer). ------------- PR: https://git.openjdk.java.net/jfx/pull/87 From Rony.Flatscher at wu.ac.at Wed Jan 22 17:52:12 2020 From: Rony.Flatscher at wu.ac.at (Rony G. Flatscher) Date: Wed, 22 Jan 2020 18:52:12 +0100 Subject: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script In-Reply-To: References: <5bca4803-6372-7569-254c-3d08a57accb0@wu.ac.at> <91dcbb22-2acf-3c51-6f89-a0d394688bed@wu.ac.at> <1ea149d7-69a5-dd3a-f5d6-82b08921d2a9@oracle.com> <9e391ac6-c9ab-47be-88f4-a1214290f371@oracle.com> <4a81fc93-c933-3ab9-363e-2a9ef54632c6@wu.ac.at> <2f8f8701-5400-ae48-abf1-285de1e18f3b@oracle.com> <39b317bf-4aac-16be-e82d-6519452d8af8@wu.ac.at> <029b4f44-bf12-e99f-bf60-118b5638dcff@wu.ac.at> Message-ID: <12554239-08b5-8440-8c21-f56729a4e928@wu.ac.at> Hi Anthony, On 22.01.2020 17:07, Anthony Vanelverdinghe wrote: > Your issue has been converted into a JDK issue, with your testcase attached [1]. Thank you *very* much for this information! > Normally you should?ve received an e-mail at the time of this conversion, Just searched all my e-mail folders and could not find it (looking for "FXMLLoader" in the subject of e-mails as the bug title contains that word) but could not find a matching e-mail for whatever reasons. > but you can check this yourself by using the internal review ID as in [2]. If you?d like to > contribute a fix, see [3]. > > ? > > Kind regards, Anthony > > ? > > [1] https://bugs.openjdk.java.net/browse/JDK-8234959 > > > [2] https://bugs.openjdk.java.net/browse/JI-9062887 > > [3] https://github.com/openjdk/jfx > Thank you also for these links (and I learned something new on how to check for it using the internal review id with your [2], thanks a lot for this hint as well)! Will go back and study all the necessary procedures (forgot a lot since reading them the last time) and will try to contribute the fix in the proper way but it may take me a little while (currently quite busy around here). --- Maybe one more question: there would be an optimization possible by compiling scripts for script engines that have the javax.script.Compilable interface implemented and use the compiled version to execute/evaluate the scripts (may be helpful for event handler code e.g. for onMouseMove event handlers). Can the fix include such an optimization or should there be a separate discussion/RFE for it beforehand? (Adding this would be trivial in the context of the fix, however the bug description would not hint at such an optimization.) ---rony From arapte at openjdk.java.net Wed Jan 22 17:55:05 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Wed, 22 Jan 2020 17:55:05 GMT Subject: [Rev 01] RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one In-Reply-To: References: Message-ID: > This PR is a fix for [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) > This issue is regression of [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). > > Issue. > - `Parent.viewOrderChildren` is a list of children sorted according to view order. > - `Parent.viewOrderChildren` is cleared and computed in `Parent.computeViewOrderChildren()` which is called from `Parent.doUpdatePeer()` when a `pulse `is received. > > - Below is the scenario mentioned in this issue, > 1. `TabPane` is created with few `tabs`. > 2. For each tab, a `TabHeaderSkin` is created with `setViewOrder(1)` and is added to `TabHeaderArea.headersRegion` > 3. All these `TabHeaderSkin`s are added to `Parent.viewOrderChildren` on `pulse`. > 4. When the `TabPane` is removed from scene, then on the next pulse the method `Parent.doUpdatePeer()` does not get called for `TabHeaderArea.headersRegion`, because it is not part for scenegraph anymore. > So `Parent.computeViewOrderChildren()` does not get called and the `Parent.viewOrderChildren` does not get cleared, which causes the leak. > > Fix: > Clear the `Parent.viewOrderChildren` list when marking `DirtyBits.PARENT_CHILDREN_VIEW_ORDER` as dirty. > `Parent.viewOrderChildren` will be computed on next `pulse`. > This will maintain lazy computation of `Parent.viewOrderChildren`. > > Added a system test, fails without fix and passes with. No failures in existing tests. The pull request has been updated with 1 additional commit. ------------- Added commits: - d64f6c86: Adding system test using Group and Shape Changes: - all: https://git.openjdk.java.net/jfx/pull/79/files - new: https://git.openjdk.java.net/jfx/pull/79/files/cbcc3161..d64f6c86 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/79/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/79/webrev.00-01 Stats: 117 lines in 1 file changed: 117 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/79.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/79/head:pull/79 PR: https://git.openjdk.java.net/jfx/pull/79 From arapte at openjdk.java.net Wed Jan 22 17:55:06 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Wed, 22 Jan 2020 17:55:06 GMT Subject: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one In-Reply-To: References: Message-ID: On Fri, 17 Jan 2020 23:40:18 GMT, Kevin Rushforth wrote: >>> >>> >>> @arapte - This bug looks like a good candidate for JavaFX 14. Can you retarget this PR to the jfx14 branch? >> >> Thanks for guiding Kevin, PR is now targeted to jfx14. > > The fix looks good. I'll take a closer look at the unit test later. > > Speaking of tests...since the addition of the `TabPane` reordering logic was a victim of the already-existing leak in the `viewOrderChildren` list in `Parent`, it should be possible to write a test case using a Group node and a few Shape nodes, using setViewOrder directly on the Group node (this would be in addition to the system test you wrote). Can you take a look at adding one? It might even be possible to do it as a `javafx.graphics` module unit test rather than a system test, although you would need to see if the bug reproduced there (I suspect it will). > > > The fix looks good. I'll take a closer look at the unit test later. > > Speaking of tests...since the addition of the `TabPane` reordering logic was a victim of the already-existing leak in the `viewOrderChildren` list in `Parent`, it should be possible to write a test case using a Group node and a few Shape nodes, using setViewOrder directly on the Group node (this would be in addition to the system test you wrote). Can you take a look at adding one? It might even be possible to do it as a `javafx.graphics` module unit test rather than a system test, although you would need to see if the bug reproduced there (I suspect it will). Hello Kevin, The bug can be reproduced with system test written using `Group` and `Shape` which is very similar to `TabPaneHeaderLeakTest` test. but it seems the bug is not reproducible with unit test. I tried a unit test very similar to the newly added system test `ShapeViewOrderLeakTest`, but looks like `Parent.viewOrderChildren` list does not get populated and so the issue does not occur. ------------- PR: https://git.openjdk.java.net/jfx/pull/79 From arapte at openjdk.java.net Wed Jan 22 17:55:27 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Wed, 22 Jan 2020 17:55:27 GMT Subject: [Rev 01] RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: <8E-6q3Esm-3cPv-QMMoPIqTFW2jOgwFHCKPIwFG1MlI=.4f298bff-55ad-4243-975f-0c32992c2cdc@github.com> References: <8E-6q3Esm-3cPv-QMMoPIqTFW2jOgwFHCKPIwFG1MlI=.4f298bff-55ad-4243-975f-0c32992c2cdc@github.com> Message-ID: <18PZuXiOMp72fLfEUoajufFMHuGSpw5Rt9DVSs4FWPs=.93e171dc-a66f-4c71-8d29-e97780a32612@github.com> On Wed, 22 Jan 2020 17:55:27 GMT, Nir Lisker wrote: >> The private field `lastPlayFinished` is responsible for 2 cases where an animation in `STOPPED` status does not play after `play()` is called if the rate is negative: >> >> 1. When the animation is created, it is `STOPPED` and `lastPlayFinished` is `false`. Setting a negative rate and calling `play()` will not jump to the end of the animation (in order to play it backwards) because the `if (lastPlayedFinished)` check is `false`. Creating the animation with `lastPlayFinished = true` fixes this. However, `SequentialTransitionPlayTest#testCycleReverse`'s initial state test implies that the original behavior is correct. *That test currently fails with this change.* Either the fix is reverted or the test is corrected. >> 2. When the animation is stopped (if it was not `STOPPED` already), `jumpTo(Duration.ZERO)` sets `lastPlayFinished` to `false`, which causes the same issue above with `play()`. Setting `lastPlayFinished = true` at the end `stop()` fixes this issue. >> >> A test was added for case 2 to check that the playing head indeed jumps to the end of the animation. Without this fix, it stays at the start. >> >> I'm still somewhat confused as to what constitutes a "last play finished". Any `jumpTo` resets `lastPlayFinished` to `false`, even if the jump is to the start/end of the animation. In this case, stopping an animation, jumping to its start/end, setting the rate to negative/positive, and playing, will do nothing as the end condition is reached immediately. This is what the behavior that was fixed for cases 1 and 2, but maybe this is also incorrect behavior for jumping to start/end. >> >> A test app is included in the "parent" [bug](https://bugs.openjdk.java.net/browse/JDK-8210238), which also mentions a bug relating to **pausing** and playing backwards, so be mindful of it when testing. > > The pull request has been updated with 1 additional commit. The changes look good to me. ------------- Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/82 From jvos at openjdk.java.net Wed Jan 22 18:29:00 2020 From: jvos at openjdk.java.net (Johan Vos) Date: Wed, 22 Jan 2020 18:29:00 GMT Subject: RFR: 8233942: Update to 609.1 version of WebKit In-Reply-To: References: Message-ID: On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote: > Updated GTK Webkit 2.26 (609.1) into jfx. Marked as reviewed by jvos (Reviewer). ------------- PR: https://git.openjdk.java.net/jfx/pull/91 From nlisker at openjdk.java.net Wed Jan 22 20:58:33 2020 From: nlisker at openjdk.java.net (Nir Lisker) Date: Wed, 22 Jan 2020 20:58:33 GMT Subject: [Integrated] RFR: 8236753: Animations do not play backwards after being stopped In-Reply-To: References: Message-ID: Changeset: 9ae37f1f Author: Nir Lisker Date: 2020-01-22 20:58:12 +0000 URL: https://git.openjdk.java.net/jfx/commit/9ae37f1f 8236753: Animations do not play backwards after being stopped Reviewed-by: kcr, arapte ! modules/javafx.graphics/src/main/java/javafx/animation/Animation.java ! modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationTest.java ! modules/javafx.graphics/src/test/java/test/javafx/animation/SequentialTransitionPlayTest.java From kcr at openjdk.java.net Wed Jan 22 23:58:51 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Wed, 22 Jan 2020 23:58:51 GMT Subject: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one In-Reply-To: References: Message-ID: On Wed, 22 Jan 2020 17:53:38 GMT, Ambarish Rapte wrote: >> The fix looks good. I'll take a closer look at the unit test later. >> >> Speaking of tests...since the addition of the `TabPane` reordering logic was a victim of the already-existing leak in the `viewOrderChildren` list in `Parent`, it should be possible to write a test case using a Group node and a few Shape nodes, using setViewOrder directly on the Group node (this would be in addition to the system test you wrote). Can you take a look at adding one? It might even be possible to do it as a `javafx.graphics` module unit test rather than a system test, although you would need to see if the bug reproduced there (I suspect it will). > >> >> >> The fix looks good. I'll take a closer look at the unit test later. >> >> Speaking of tests...since the addition of the `TabPane` reordering logic was a victim of the already-existing leak in the `viewOrderChildren` list in `Parent`, it should be possible to write a test case using a Group node and a few Shape nodes, using setViewOrder directly on the Group node (this would be in addition to the system test you wrote). Can you take a look at adding one? It might even be possible to do it as a `javafx.graphics` module unit test rather than a system test, although you would need to see if the bug reproduced there (I suspect it will). > > Hello Kevin, > The bug can be reproduced with system test written using `Group` and `Shape` which is very similar to `TabPaneHeaderLeakTest` test. but it seems the bug is not reproducible with unit test. I tried a unit test very similar to the newly added system test `ShapeViewOrderLeakTest`, but looks like `Parent.viewOrderChildren` list does not get populated and so the issue does not occur. > The bug can be reproduced with system test written using `Group` and `Shape` which is very similar to `TabPaneHeaderLeakTest` test. but it seems the bug is not reproducible with unit test. I tried a unit test very similar to the newly added system test `ShapeViewOrderLeakTest`, but looks like `Parent.viewOrderChildren` list does not get populated and so the issue does not occur. Did you run a pulse? That would be needed in order to sync the changes down to the peer. In any event, it is fine to use a system test if you can't get it to fail with a unit test. I have three cleanup comments that are apply to both of the new tests. The first is the most important of these. 1. Test classes should not extend from `javafx.application.Application`. You should use a nested class that extends Application. See [this comment on PR #34](https://github.com/openjdk/jfx/pull/34#pullrequestreview-322619657) for at least one reason why. 2. The initFX method can be simplified using a pattern we've adopted in our newer tests. See [QuadraticCssTimeTest.java](https://github.com/openjdk/jfx/blob/jfx14/tests/system/src/test/java/test/javafx/scene/QuadraticCssTimeTest.java#L84) 3. Most tests run `startupLatch::countDown` in a `Platform.runLater` call. ------------- PR: https://git.openjdk.java.net/jfx/pull/79 From tsayao at openjdk.java.net Thu Jan 23 01:06:09 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Thu, 23 Jan 2020 01:06:09 GMT Subject: [Rev 13] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > - Removes Applet/Web Start code. > > In general it reduces code size and complexity and hands more work to gtk. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with 1 additional commit. ------------- Added commits: - cb2d9fb6: Work on mouse grab Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/2bfac077..cb2d9fb6 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.13 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.12-13 Stats: 27 lines in 2 files changed: 17 ins; 2 del; 8 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From ajoseph at openjdk.java.net Thu Jan 23 02:25:24 2020 From: ajoseph at openjdk.java.net (Arun Joseph) Date: Thu, 23 Jan 2020 02:25:24 GMT Subject: RFR: 8233942: Update to 609.1 version of WebKit In-Reply-To: References: Message-ID: On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote: > Updated GTK Webkit 2.26 (609.1) into jfx. Marked as reviewed by ajoseph (Author). ------------- PR: https://git.openjdk.java.net/jfx/pull/91 From arapte at openjdk.java.net Thu Jan 23 12:46:05 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Thu, 23 Jan 2020 12:46:05 GMT Subject: [Rev 02] RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one In-Reply-To: References: Message-ID: > This PR is a fix for [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) > This issue is regression of [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). > > Issue. > - `Parent.viewOrderChildren` is a list of children sorted according to view order. > - `Parent.viewOrderChildren` is cleared and computed in `Parent.computeViewOrderChildren()` which is called from `Parent.doUpdatePeer()` when a `pulse `is received. > > - Below is the scenario mentioned in this issue, > 1. `TabPane` is created with few `tabs`. > 2. For each tab, a `TabHeaderSkin` is created with `setViewOrder(1)` and is added to `TabHeaderArea.headersRegion` > 3. All these `TabHeaderSkin`s are added to `Parent.viewOrderChildren` on `pulse`. > 4. When the `TabPane` is removed from scene, then on the next pulse the method `Parent.doUpdatePeer()` does not get called for `TabHeaderArea.headersRegion`, because it is not part for scenegraph anymore. > So `Parent.computeViewOrderChildren()` does not get called and the `Parent.viewOrderChildren` does not get cleared, which causes the leak. > > Fix: > Clear the `Parent.viewOrderChildren` list when marking `DirtyBits.PARENT_CHILDREN_VIEW_ORDER` as dirty. > `Parent.viewOrderChildren` will be computed on next `pulse`. > This will maintain lazy computation of `Parent.viewOrderChildren`. > > Added a system test, fails without fix and passes with. No failures in existing tests. The pull request has been updated with 1 additional commit. ------------- Added commits: - 7c204691: Fixed review comments Changes: - all: https://git.openjdk.java.net/jfx/pull/79/files - new: https://git.openjdk.java.net/jfx/pull/79/files/d64f6c86..7c204691 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/79/webrev.02 - incr: https://webrevs.openjdk.java.net/jfx/79/webrev.01-02 Stats: 61 lines in 2 files changed: 6 ins; 10 del; 45 mod Patch: https://git.openjdk.java.net/jfx/pull/79.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/79/head:pull/79 PR: https://git.openjdk.java.net/jfx/pull/79 From arapte at openjdk.java.net Thu Jan 23 12:46:06 2020 From: arapte at openjdk.java.net (Ambarish Rapte) Date: Thu, 23 Jan 2020 12:46:06 GMT Subject: RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one In-Reply-To: References: Message-ID: On Wed, 22 Jan 2020 23:58:29 GMT, Kevin Rushforth wrote: >>> >>> >>> The fix looks good. I'll take a closer look at the unit test later. >>> >>> Speaking of tests...since the addition of the `TabPane` reordering logic was a victim of the already-existing leak in the `viewOrderChildren` list in `Parent`, it should be possible to write a test case using a Group node and a few Shape nodes, using setViewOrder directly on the Group node (this would be in addition to the system test you wrote). Can you take a look at adding one? It might even be possible to do it as a `javafx.graphics` module unit test rather than a system test, although you would need to see if the bug reproduced there (I suspect it will). >> >> Hello Kevin, >> The bug can be reproduced with system test written using `Group` and `Shape` which is very similar to `TabPaneHeaderLeakTest` test. but it seems the bug is not reproducible with unit test. I tried a unit test very similar to the newly added system test `ShapeViewOrderLeakTest`, but looks like `Parent.viewOrderChildren` list does not get populated and so the issue does not occur. > >> The bug can be reproduced with system test written using `Group` and `Shape` which is very similar to `TabPaneHeaderLeakTest` test. but it seems the bug is not reproducible with unit test. I tried a unit test very similar to the newly added system test `ShapeViewOrderLeakTest`, but looks like `Parent.viewOrderChildren` list does not get populated and so the issue does not occur. > > Did you run a pulse? That would be needed in order to sync the changes down to the peer. In any event, it is fine to use a system test if you can't get it to fail with a unit test. > > I have three cleanup comments that apply to both of the new tests. The first is the most important of these. > > 1. Test classes should not extend from `javafx.application.Application`. You should use a nested class that extends Application. See [this comment on PR #34](https://github.com/openjdk/jfx/pull/34#pullrequestreview-322619657) for at least one reason why. > > 2. The initFX method can be simplified using a pattern we've adopted in our newer tests. See [QuadraticCssTimeTest.java](https://github.com/openjdk/jfx/blob/jfx14/tests/system/src/test/java/test/javafx/scene/QuadraticCssTimeTest.java#L84) > > 3. Most tests run `startupLatch::countDown` in a `Platform.runLater` call. > Did you run a pulse? That would be needed in order to sync the changes down to the peer. In any event, it is fine to use a system test if you can't get it to fail with a unit test. > Yes Kevin, I had tried using `Toolkit.getToolkit().firePulse();`. But the test did not fail without fix. I am not sure if I am missing anything with unit test, Ideally it should reproduce with unit test too. Have updated the PR to fix the other review comments. ------------- PR: https://git.openjdk.java.net/jfx/pull/79 From tsayao at openjdk.java.net Thu Jan 23 12:51:24 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Thu, 23 Jan 2020 12:51:24 GMT Subject: [Rev 14] RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> Message-ID: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ; > - Replaces (pointer and focus) grabbing with a gtk approach; > - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity; > - Simplified cursor changing; > - Reduced the use of gtk/gdk deprecated functions; > - Removes Applet/Web Start code; > - Fixes https://bugs.openjdk.java.net/browse/JDK-8237491; > > In general it reduces code size and complexity and hands more work to gtk. > > ![image](https://user-images.githubusercontent.com/30704286/71791073-58779d00-3012-11ea-89e5-07588f7a41cc.png) The pull request has been updated with a new target base due to a merge or a rebase. ------------- Commits: - 694641f6: JDK-8236651 Simplify and update glass gtk backend - 9397a748: Merge pull request #4 from openjdk/master Changes: https://git.openjdk.java.net/jfx/pull/77/files Webrev: https://webrevs.openjdk.java.net/jfx/77/webrev.14 Stats: 3361 lines in 12 files changed: 777 ins; 1802 del; 782 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77 From kcr at openjdk.java.net Thu Jan 23 12:52:00 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 23 Jan 2020 12:52:00 GMT Subject: [Rev 02] RFR: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one In-Reply-To: References: Message-ID: <2Y5QNeY4sMG6Y3FWMI14RxXQcnCT311CAZx4gf1irrI=.8c21fe31-b92d-403d-80f4-ddf03c881dc8@github.com> On Thu, 23 Jan 2020 12:51:59 GMT, Ambarish Rapte wrote: >> This PR is a fix for [JDK-8232824](https://bugs.openjdk.java.net/browse/JDK-8232824) >> This issue is regression of [JDK-8187074](https://bugs.openjdk.java.net/browse/JDK-8187074). >> >> Issue. >> - `Parent.viewOrderChildren` is a list of children sorted according to view order. >> - `Parent.viewOrderChildren` is cleared and computed in `Parent.computeViewOrderChildren()` which is called from `Parent.doUpdatePeer()` when a `pulse `is received. >> >> - Below is the scenario mentioned in this issue, >> 1. `TabPane` is created with few `tabs`. >> 2. For each tab, a `TabHeaderSkin` is created with `setViewOrder(1)` and is added to `TabHeaderArea.headersRegion` >> 3. All these `TabHeaderSkin`s are added to `Parent.viewOrderChildren` on `pulse`. >> 4. When the `TabPane` is removed from scene, then on the next pulse the method `Parent.doUpdatePeer()` does not get called for `TabHeaderArea.headersRegion`, because it is not part for scenegraph anymore. >> So `Parent.computeViewOrderChildren()` does not get called and the `Parent.viewOrderChildren` does not get cleared, which causes the leak. >> >> Fix: >> Clear the `Parent.viewOrderChildren` list when marking `DirtyBits.PARENT_CHILDREN_VIEW_ORDER` as dirty. >> `Parent.viewOrderChildren` will be computed on next `pulse`. >> This will maintain lazy computation of `Parent.viewOrderChildren`. >> >> Added a system test, fails without fix and passes with. No failures in existing tests. > > The pull request has been updated with 1 additional commit. Looks good. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/79 From jpereda at openjdk.java.net Thu Jan 23 13:11:52 2020 From: jpereda at openjdk.java.net (Jose Pereda) Date: Thu, 23 Jan 2020 13:11:52 GMT Subject: RFR: 8157224: isNPOTSupported check is too strict Message-ID: This PR enables support for 3D on iOS devices, as they use OpenGL ES 2.0, which has (limited) support for npot support. ------------- Commits: - 1bef8cf6: Enable 3D support on iOS Changes: https://git.openjdk.java.net/jfx/pull/92/files Webrev: https://webrevs.openjdk.java.net/jfx/92/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8157224 Stats: 7 lines in 1 file changed: 5 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/92.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/92/head:pull/92 PR: https://git.openjdk.java.net/jfx/pull/92 From kcr at openjdk.java.net Thu Jan 23 13:16:06 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 23 Jan 2020 13:16:06 GMT Subject: RFR: 8157224: isNPOTSupported check is too strict In-Reply-To: References: Message-ID: On Thu, 23 Jan 2020 13:02:42 GMT, Jose Pereda wrote: > This PR enables support for 3D on iOS devices, as they use OpenGL ES 2.0, which has (limited) support for npot support. Marked as reviewed by kcr (Lead). ------------- PR: https://git.openjdk.java.net/jfx/pull/92 From thiago.sayao at clamed.com.br Thu Jan 23 13:30:01 2020 From: thiago.sayao at clamed.com.br (Thiago Milczarek Sayao) Date: Thu, 23 Jan 2020 13:30:01 +0000 Subject: Machine hangs when build with -PCOMPILE_WEBKIT=true Message-ID: Hi, I have tried on different machines - they totally hang or present a fatal compiler error when compiling webkit. Sometimes (rarely) it works. This is on Ubuntu 18.04.3. Anyone has got this problem and found a solution? Cheers. From tsayao at openjdk.java.net Thu Jan 23 14:17:02 2020 From: tsayao at openjdk.java.net (Thiago Milczarek Sayao) Date: Thu, 23 Jan 2020 14:17:02 GMT Subject: RFR: WIP: 8236651: Simplify and update glass gtk backend In-Reply-To: References: <18qiCT5oGbDR-HA0CvK7izwp1QwkAcJXmqyQ3mPlCo8=.57178071-ad2a-47cd-8a92-6cc758704223@github.com> <31X4pHGnuhexI5Rz9Y8afMrdFl0pfNPKp9nMYMNcG50=.1f068b3f-0901-43f3-a2d1-8a12aa18b040@github.com> Message-ID: On Tue, 14 Jan 2020 11:30:49 GMT, Thiago Milczarek Sayao wrote: >> I understand. Will do that when the code works 100%. I have submitted the PR to avoid duplicated efforts and let people test it (if anyone is willing). > > Sizing and positioning completed and fairly tested. > > Will look into mouse grabbing. Performance test (on my setup, it runs slightly faster with this patch): import javafx.application.Application; import javafx.application.Platform; import javafx.scene.Scene; import javafx.scene.control.Label; import javafx.stage.Stage; import java.time.Duration; import java.time.Instant; import java.util.Timer; import java.util.TimerTask; public class HelloFx extends Application { public HelloFx() { } @Override public void start(Stage stage) { Instant start = Instant.now(); Scene mainScene = new Scene(new Label("Perfomance test"), 600, 600); stage.setScene(mainScene); stage.show(); for (int i=0; i<1000; i++) { Stage stage1 = new Stage(); Scene scene = new Scene(new Label("hi"), 200, 200); stage1.setScene(scene); stage1.setOnShown(e -> new Timer().schedule( new TimerTask() { @Override public void run() { Platform.runLater(stage1::hide); } }, 100 )); stage1.showAndWait(); } stage.close(); Instant end = Instant.now(); System.out.println(Duration.between(start, end).toString() .substring(2) .replaceAll("(\\d[HMS])(?!$)", "$1 ") .toLowerCase()); Platform.exit(); } } ------------- PR: https://git.openjdk.java.net/jfx/pull/77 From kcr at openjdk.java.net Thu Jan 23 14:37:41 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 23 Jan 2020 14:37:41 GMT Subject: [Integrated] RFR: 8157224: isNPOTSupported check is too strict In-Reply-To: References: Message-ID: Changeset: f5ee9631 Author: Jose Pereda Committer: Kevin Rushforth Date: 2020-01-23 14:36:36 +0000 URL: https://git.openjdk.java.net/jfx/commit/f5ee9631 8157224: isNPOTSupported check is too strict Reviewed-by: kcr ! modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2Pipeline.java From anthonyv.be at outlook.com Thu Jan 23 17:09:43 2020 From: anthonyv.be at outlook.com (Anthony Vanelverdinghe) Date: Thu, 23 Jan 2020 18:09:43 +0100 Subject: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script In-Reply-To: <12554239-08b5-8440-8c21-f56729a4e928@wu.ac.at> References: <5bca4803-6372-7569-254c-3d08a57accb0@wu.ac.at> <91dcbb22-2acf-3c51-6f89-a0d394688bed@wu.ac.at> <1ea149d7-69a5-dd3a-f5d6-82b08921d2a9@oracle.com> <9e391ac6-c9ab-47be-88f4-a1214290f371@oracle.com> <4a81fc93-c933-3ab9-363e-2a9ef54632c6@wu.ac.at> <2f8f8701-5400-ae48-abf1-285de1e18f3b@oracle.com> <39b317bf-4aac-16be-e82d-6519452d8af8@wu.ac.at> <029b4f44-bf12-e99f-bf60-118b5638dcff@wu.ac.at> <12554239-08b5-8440-8c21-f56729a4e928@wu.ac.at> Message-ID: On 22/01/2020 18:52, Rony G. Flatscher wrote: > Hi Anthony, > > On 22.01.2020 17:07, Anthony Vanelverdinghe wrote: >> Your issue has been converted into a JDK issue, with your testcase >> attached [1]. > > Thank you *very* much for this information! > >> Normally you should?ve received an e-mail at the time of this >> conversion, > > Just searched all my e-mail folders and could not find it (looking for > "FXMLLoader" in the subject of e-mails as the bug title contains that > word) but could not find a matching e-mail for whatever reasons. > >> but you can check this yourself by using the internal review ID as in >> [2]. If you?d like to contribute a fix, see [3]. >> >> Kind regards, Anthony >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8234959 >> >> >> [2] https://bugs.openjdk.java.net/browse/JI-9062887 >> >> >> [3] https://github.com/openjdk/jfx >> > Thank you also for these links (and I learned something new on how to > check for it using the internal review id with your [2], thanks a lot > for this hint as well)! > > Will go back and study all the necessary procedures (forgot a lot > since reading them the last time) and will try to contribute the fix > in the proper way but it may take me a little while (currently quite > busy around here). > > --- > > Maybe one more question: there would be an optimization possible by > compiling scripts for script engines that have the > javax.script.Compilable interface implemented and use the compiled > version to execute/evaluate the scripts (may be helpful for event > handler code e.g. for onMouseMove event handlers). Can the fix include > such an optimization or should there be a separate discussion/RFE for > it beforehand? (Adding this would be trivial in the context of the > fix, however the bug description would not hint at such an optimization.) > In my opinion, this should be filed as a separate issue, since it's unrelated to the current issue and is an enhancement, rather than a bug. > > ---rony > > Kind regards, Anthony From ghb at openjdk.java.net Thu Jan 23 18:53:35 2020 From: ghb at openjdk.java.net (Guru Hb) Date: Thu, 23 Jan 2020 18:53:35 GMT Subject: [Integrated] RFR: 8233942: Update to 609.1 version of WebKit In-Reply-To: References: Message-ID: <0eb0e3fb-c938-442e-82f6-554924e8a3f3@openjdk.org> Changeset: b2d85645 Author: Guru Hb Date: 2020-01-23 18:52:57 +0000 URL: https://git.openjdk.java.net/jfx/commit/b2d85645 8233942: Update to 609.1 version of WebKit Co-authored-by: Guru HB Co-authored-by: Arun Joseph Co-authored-by: Kevin Rushforth Reviewed-by: kcr, jvos, ajoseph ! modules/javafx.web/src/main/legal/webkit.md ! modules/javafx.web/src/main/native/CMakeLists.txt ! modules/javafx.web/src/main/native/Source/CMakeLists.txt ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/APICast.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSAPIGlobalObject.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSBase.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSBaseInternal.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSBasePrivate.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSCallbackConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSCallbackObject.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSCallbackObjectFunctions.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSClassRef.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSClassRef.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSContext.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSContextPrivate.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSContextRef.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSContextRef.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSContextRefInternal.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSContextRefPrivate.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSManagedValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSMarkingConstraintPrivate.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSObjectRef.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSObjectRef.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSObjectRefPrivate.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSRemoteInspector.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSScript.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSScriptInternal.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSScriptRef.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSScriptSourceProvider.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSStringRef.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSTypedArray.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSValuePrivate.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSValueRef.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSValueRef.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSVirtualMachineInternal.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSVirtualMachinePrivate.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/OpaqueJSString.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/API/WebKitAvailability.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/CMakeLists.txt ! modules/javafx.web/src/main/native/Source/JavaScriptCore/DerivedSources-input.xcfilelist ! modules/javafx.web/src/main/native/Source/JavaScriptCore/DerivedSources-output.xcfilelist ! modules/javafx.web/src/main/native/Source/JavaScriptCore/DerivedSources.make - modules/javafx.web/src/main/native/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCorePreLink.cmd ! modules/javafx.web/src/main/native/Source/JavaScriptCore/KeywordLookupGenerator.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/PlatformJava.cmake - modules/javafx.web/src/main/native/Source/JavaScriptCore/PlatformPlayStation.cmake ! modules/javafx.web/src/main/native/Source/JavaScriptCore/Scripts/check-xcfilelists.sh ! modules/javafx.web/src/main/native/Source/JavaScriptCore/Scripts/jsmin.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/Scripts/make-js-file-arrays.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_combined_header.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_wrapper_header.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/Scripts/wkbuiltins/builtins_templates.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/Sources.txt ! modules/javafx.web/src/main/native/Source/JavaScriptCore/SourcesGTK.txt ! modules/javafx.web/src/main/native/Source/JavaScriptCore/SourcesWPE.txt ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/ARM64Assembler.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/ARM64EAssembler.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/ARM64Registers.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/ARMv7Assembler.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/ARMv7Registers.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/AbortReason.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/CPU.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/CPU.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/CodeLocation.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/LinkBuffer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/LinkBuffer.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MIPSAssembler.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MIPSRegisters.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssembler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssembler.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssemblerARM64.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssemblerARM64.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssemblerARM64E.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssemblerX86.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/ProbeStack.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/RegisterInfo.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/X86Assembler.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/X86Registers.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/X86_64Registers.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/assembler/testmasm.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ArgumentRegValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ArgumentRegValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3AtomicValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3AtomicValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Bank.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3BasicBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3BasicBlockInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3BlockInsertionSet.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3CCallValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3CCallValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3CheckValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3CheckValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Common.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Common.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Const32Value.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Const32Value.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Const64Value.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Const64Value.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ConstDoubleValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ConstDoubleValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ConstFloatValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ConstFloatValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ConstPtrValue.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3EliminateDeadCode.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3EliminateDeadCode.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ExtractValue.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ExtractValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3FenceValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3FenceValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3FixSSA.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Generate.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3LowerMacros.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3LowerToAir.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3MemoryValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3MemoryValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3MoveConstants.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3NativeTraits.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Opcode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Opcode.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3OptimizeAssociativeExpressionTrees.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3OptimizeAssociativeExpressionTrees.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3PatchpointSpecial.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3PatchpointValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3PatchpointValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3PhiChildren.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Procedure.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Procedure.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ProcedureInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3PureCSE.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3PureCSE.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ReduceLoopStrength.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ReduceLoopStrength.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ReduceStrength.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3SlotBaseValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3SlotBaseValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3StackmapSpecial.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3StackmapSpecial.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3StackmapValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3StackmapValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3SwitchValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3SwitchValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Type.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Type.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3TypeMap.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3UpsilonValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3UpsilonValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3UseCounts.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Validate.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Value.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Value.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ValueInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ValueKey.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ValueKey.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ValueRep.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3ValueRep.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3VariableValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3VariableValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3WasmAddressValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3WasmAddressValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3Width.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirArg.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirArg.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirCCallingConvention.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirCode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirDisassembler.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirGenerate.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirHandleCalleeSaves.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirHandleCalleeSaves.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirLowerMacros.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/AirOpcode.opcodes ! modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/air/testair.cpp - modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/testb3.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/testb3.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/testb3_1.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/testb3_2.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/testb3_3.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/testb3_4.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/testb3_5.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/testb3_6.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/testb3_7.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/testb3_8.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bindings/ScriptFunctionCall.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bindings/ScriptValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/ArrayPrototype.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/AsyncFromSyncIteratorPrototype.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/AsyncGeneratorPrototype.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/BuiltinExecutables.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/BuiltinExecutables.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/BuiltinNames.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/BuiltinNames.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/GlobalOperations.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/MapPrototype.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/ModuleLoader.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/PromiseConstructor.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/PromiseOperations.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/PromisePrototype.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/RegExpPrototype.js + modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/RegExpStringIteratorPrototype.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/SetPrototype.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/StringPrototype.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/TypedArrayPrototype.js = modules/javafx.web/src/main/native/Source/JavaScriptCore/builtins/WebAssembly.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/AccessCase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/AccessCaseSnippetParams.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/AccessCaseSnippetParams.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/AdaptiveInferredPropertyValueWatchpointBase.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ArrayAllocationProfile.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ArrayAllocationProfile.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ArrayProfile.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ArrayProfile.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ByValInfo.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeBasicBlock.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeConventions.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeDumper.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeDumper.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeGeneratorification.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.h - modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeList.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeList.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeRewriter.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeRewriter.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/BytecodeUseDef.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CallLinkInfo.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CallLinkInfo.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CallLinkStatus.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CallLinkStatus.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CallVariant.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CallVariant.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CodeBlock.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CodeBlockInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CodeBlockJettisoningWatchpoint.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CodeBlockWithJITType.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CodeOrigin.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/CodeOrigin.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/DFGExitProfile.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/DataFormat.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/DeferredCompilationCallback.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/DeferredSourceDump.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/DeferredSourceDump.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/EvalCodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ExecutableToCodeBlockEdge.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ExecutionCounter.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ExecutionCounter.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ExitFlag.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ExitingJITType.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/Fits.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/FunctionCodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/GetByIdMetadata.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/GetByIdStatus.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/GetByIdStatus.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/GetByIdVariant.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/GetByIdVariant.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/GetterSetterAccessCase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/GlobalCodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ICStatusMap.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ICStatusUtils.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InByIdStatus.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InByIdStatus.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InByIdVariant.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InByIdVariant.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InlineCallFrame.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InlineCallFrame.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InstanceOfAccessCase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InstanceOfStatus.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InstanceOfVariant.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/Instruction.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InstructionStream.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/InternalFunctionAllocationProfile.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/IntrinsicGetterAccessCase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/JumpTable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/LLIntCallLinkInfo.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/LazyOperandValueProfile.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/MetadataTable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/MetadataTable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ModuleNamespaceAccessCase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ModuleProgramCodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ObjectAllocationProfile.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ObjectAllocationProfileInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ObjectPropertyCondition.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ObjectPropertyCondition.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/Opcode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/Opcode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/OpcodeSize.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/Operands.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/PolyProtoAccessChain.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/PolyProtoAccessChain.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ProgramCodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/PropertyCondition.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/PropertyCondition.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ProxyableAccessCase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/PutByIdStatus.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/PutByIdStatus.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/PutByIdVariant.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/PutByIdVariant.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/RecordedStatuses.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/RecordedStatuses.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/SpeculatedType.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/SpeculatedType.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/StructureSet.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/StructureSet.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/StructureStubClearingWatchpoint.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/StructureStubClearingWatchpoint.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/StructureStubInfo.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/StructureStubInfo.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/TypeLocation.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedEvalCodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedFunctionCodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedGlobalCodeBlock.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedMetadataTableInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedModuleProgramCodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/UnlinkedProgramCodeBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ValueProfile.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/ValueRecovery.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/VirtualRegister.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/Watchpoint.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecode/Watchpoint.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/config.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/debugger/Breakpoint.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/debugger/Debugger.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/debugger/Debugger.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/debugger/DebuggerParseData.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/debugger/DebuggerParseData.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/debugger/DebuggerScope.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGAbstractValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGAbstractValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGAdaptiveStructureWatchpoint.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGAdaptiveStructureWatchpoint.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGAdjacencyList.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGArgumentsEliminationPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGArgumentsUtilities.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGArrayMode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGArrayifySlowPathGenerator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGBasicBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGCFAPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGCPSRethreadingPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGCSEPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGCallArrayAllocatorSlowPathGenerator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGCapabilities.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGCapabilities.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGClobberize.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGClobbersExitState.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGCommon.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGCommonData.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGDesiredIdentifiers.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGDesiredWatchpoints.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGDesiredWatchpoints.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGDisassembler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGDoesGC.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGDriver.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGFlowIndexing.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGFlowMap.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGForAllKills.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGFrozenValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGGenerationInfo.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGGraph.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGGraph.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGIntegerCheckCombiningPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGJITCode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGJITCode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGJITCompiler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGJITCompiler.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGLICMPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGLazyJSValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGLiveCatchVariablePreservationPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGLivenessAnalysisPhase.cpp - modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGMaximalFlushInsertionPhase.cpp - modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGMaximalFlushInsertionPhase.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGMayExit.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGMinifiedID.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGMinifiedIDInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGMinifiedNode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGMinifiedNode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGNode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGNode.h - modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGNodeAllocator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGNodeType.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOSRAvailabilityAnalysisPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOSRAvailabilityAnalysisPhase.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOSREntry.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOSREntrypointCreationPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOSRExit.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOSRExit.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOSRExitBase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOSRExitPreparation.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOperations.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGOperations.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGPhantomInsertionPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGPhase.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGPlan.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGPlan.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGPreciseLocalClobberize.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGPureValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGPureValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGRegisteredStructureSet.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGSSAConversionPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGSafeToExecute.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGStoreBarrierClusteringPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGStoreBarrierInsertionPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGStructureAbstractValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGThunks.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGThunks.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGTierUpCheckInjectionPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGTypeCheckHoistingPhase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGUseKind.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGValidate.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGValueRepReductionPhase.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGValueRepReductionPhase.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGValueSource.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGVariableAccessData.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGVariableAccessData.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGVariableEvent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGWorklist.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/DFGWorklist.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/dfg/testdfg.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/disassembler/Disassembler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/domjit/DOMJITSignature.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/dynbench.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLAbbreviatedTypes.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLCapabilities.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLCompile.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLExitValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLExitValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLFail.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLJITCode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLJITFinalizer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLLink.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLOSREntry.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLOperations.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLOutput.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLState.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLThunks.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/ftl/FTLThunks.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/generator/Argument.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/generator/DSL.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/generator/Metadata.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/generator/Opcode.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/generator/Section.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/AlignedMemoryAllocator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/AlignedMemoryAllocator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/BlockDirectory.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/CellContainer.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/CellContainerInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/CompleteSubspace.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/CompleteSubspace.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/ConservativeRoots.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/FastMallocAlignedMemoryAllocator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/FastMallocAlignedMemoryAllocator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/FreeList.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/GCActivityCallback.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/GCAssertions.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/GCIncomingRefCounted.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/GCIncomingRefCountedInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/GCIncomingRefCountedSet.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/GCIncomingRefCountedSetInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/GCSegmentedArray.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/GigacageAlignedMemoryAllocator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/GigacageAlignedMemoryAllocator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HandleSet.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HandleSet.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/Heap.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/Heap.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HeapAnalyzer.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HeapCell.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HeapCellInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HeapInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HeapProfiler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HeapProfiler.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HeapSnapshot.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HeapSnapshot.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/HeapSnapshotBuilder.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/IsoCellSet.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/IsoSubspace.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/IsoSubspace.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/IsoSubspacePerVM.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/JITStubRoutineSet.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/JITStubRoutineSet.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/LargeAllocation.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/LargeAllocation.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/LocalAllocator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/LocalAllocator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/LocalAllocatorInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/MachineStackMarker.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/MarkedBlock.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/MarkedBlock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/MarkedBlockInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/MarkedSpace.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/MarkedSpace.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/MarkingConstraintSet.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/MarkingConstraintSolver.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/MarkingConstraintSolver.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/PackedCellPtr.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/SlotVisitor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/SlotVisitor.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/SlotVisitorInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/StopIfNecessaryTimer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/StopIfNecessaryTimer.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/Strong.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/WeakBlock.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/heap/WeakSet.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/AsyncStackTrace.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/ConsoleMessage.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/ConsoleMessage.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/ContentSearchUtilities.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InjectedScript.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InjectedScript.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InjectedScriptBase.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InjectedScriptHost.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InjectedScriptManager.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InjectedScriptManager.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InjectedScriptModule.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InjectedScriptSource.js ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/InspectorBackendDispatcherCompatibility.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/JSInjectedScriptHost.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/JSInjectedScriptHostPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/JSJavaScriptCallFramePrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/ScriptArguments.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/ScriptArguments.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/ScriptDebugListener.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/ScriptDebugServer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/ScriptDebugServer.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorAuditAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorAuditAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorConsoleAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorConsoleAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorHeapAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorHeapAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorTargetAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/InspectorTargetAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/JSGlobalObjectAuditAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/JSGlobalObjectAuditAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/JSGlobalObjectDebuggerAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/JSGlobalObjectDebuggerAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/ApplicationCache.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/Audit.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/CPUProfiler.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/CSS.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/Canvas.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/Console.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/DOM.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/DOMDebugger.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/Debugger.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/Memory.json - modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/OverlayTypes.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/Page.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/Recording.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/Runtime.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/ScriptProfiler.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/protocol/Timeline.json + modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/remote/RemoteControllableTarget.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/remote/RemoteInspector.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/remote/RemoteInspector.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/scripts/codegen/generator.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/scripts/codegen/objc_generator_templates.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/interpreter/CLoopStack.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/interpreter/CallFrame.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/interpreter/CallFrame.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/interpreter/CallFrameInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/interpreter/FrameTracers.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/interpreter/Interpreter.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/interpreter/StackVisitor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/interpreter/StackVisitor.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/AssemblyHelpers.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/AssemblyHelpers.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/BinarySwitch.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/BinarySwitch.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/CCallHelpers.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/CachedRecovery.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/CallFrameShuffleData.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/CallFrameShuffler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/ExecutableAllocator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/ExecutableAllocator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/GPRInfo.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/ICStats.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/ICStats.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/IntrinsicEmitter.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JIT.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JIT.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITArithmetic.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITCall.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITCall32_64.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITCode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITCode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITDisassembler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITDivGenerator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITExceptions.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITExceptions.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITMathIC.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITOpcodes.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITOpcodes32_64.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITOperations.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITOperations.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITPropertyAccess.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITThunks.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITThunks.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITToDFGDeferredCompilationCallback.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JITWorklist.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/JSInterfaceJIT.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/PCToCodeOriginMap.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/PCToCodeOriginMap.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/RegisterSet.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/RegisterSet.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/Repatch.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/Repatch.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/SnippetOperand.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/SpecializedThunkJIT.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/SpillRegistersMode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/ThunkGenerator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/ThunkGenerators.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jit/ThunkGenerators.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/jsc.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LLIntData.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LLIntData.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LLIntEntrypoint.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LLIntEntrypoint.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LLIntSlowPaths.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LLIntThunks.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LLIntThunks.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LowLevelInterpreter.asm ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm ! modules/javafx.web/src/main/native/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm ! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/arm.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/arm64.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/asm.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/ast.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/backends.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/cloop.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/instructions.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/mips.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/registers.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/offlineasm/x86.rb ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/ASTBuilder.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/Lexer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/Lexer.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/ModuleAnalyzer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/ModuleAnalyzer.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/NodeConstructors.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/Nodes.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/Nodes.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/Parser.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/Parser.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/ParserArena.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/ParserError.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/ParserModes.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/ParserTokens.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/ResultType.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/SourceCode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/SourceCodeKey.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/SourceProvider.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/SyntaxChecker.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/UnlinkedSourceCode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/VariableEnvironment.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/parser/VariableEnvironment.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerBytecode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerBytecodes.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerCompilation.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerCompilation.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerCompiledBytecode.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerEvent.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerOSRExit.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerOSRExit.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerOSRExitSite.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerOriginStack.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerOriginStack.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/profiler/ProfilerUID.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/AbstractModuleRecord.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayBuffer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayBuffer.h - modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.cpp - modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpointSet.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpointSet.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayBufferView.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayBufferView.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayConstructor.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayIteratorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ArrayPrototype.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/AsyncFromSyncIteratorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/AsyncFunctionConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/AsyncFunctionPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/AsyncGeneratorFunctionConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/AsyncGeneratorFunctionPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/AsyncGeneratorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/AsyncIteratorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/AtomicsObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/BasicBlockLocation.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/BigIntConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/BigIntPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/BooleanConstructor.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/BundlePath.mm ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Butterfly.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ButterflyInlines.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/BytecodeCacheError.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/BytecodeCacheError.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CachePayload.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CachePayload.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CacheUpdate.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CacheUpdate.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CachedBytecode.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CachedBytecode.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CachedTypes.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CachedTypes.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CagedBarrierPtr.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CatchScope.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ClassInfo.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ClonedArguments.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CodeCache.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CodeCache.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CodeSpecializationKind.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CommonIdentifiers.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CommonIdentifiers.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/CommonSlowPaths.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Completion.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Completion.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ConfigFile.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ConsoleClient.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ConsoleObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ConsoleTypes.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ConstructData.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/DataView.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/DataView.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/DateConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/DateConversion.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/DatePrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/DirectArguments.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/DirectArguments.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/DirectEvalExecutable.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/DoublePredictionFuzzerAgent.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/DoublePredictionFuzzerAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Error.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Error.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ErrorConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ErrorInstance.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ErrorInstance.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ErrorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ErrorType.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/EvalExecutable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/EvalExecutable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Exception.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Exception.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ExceptionHelpers.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ExceptionScope.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FunctionConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FunctionExecutable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FunctionExecutable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FunctionExecutableDump.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FunctionExecutableInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FunctionPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FunctionPrototype.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FunctionRareData.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FunctionRareData.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FuzzerAgent.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/FuzzerAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/GeneratorFunctionConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/GeneratorFunctionPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/GeneratorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/GenericArguments.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/GenericArgumentsInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/GenericTypedArrayView.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/GetterSetter.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/GlobalExecutable.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/GlobalExecutable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/HashMapImpl.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Identifier.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Identifier.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IdentifierInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IndexingType.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IndirectEvalExecutable.cpp - modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/InferredValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/InferredValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/InferredValueInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/InitializeThreading.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/InternalFunction.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/InternalFunction.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlCollator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlCollator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlCollatorConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlCollatorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlDateTimeFormatConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlNumberFormat.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlNumberFormat.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlNumberFormatConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlObject.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlPluralRules.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlPluralRulesConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/IteratorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSArray.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSArray.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSArrayBufferPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSArrayBufferPrototype.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSArrayBufferView.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSArrayBufferView.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSArrayInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSAsyncFunction.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSAsyncGeneratorFunction.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSAsyncGeneratorFunction.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSBigInt.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSBigInt.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSCJSValue.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSCJSValue.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSCJSValueInlines.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSCPtrTag.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSCPtrTag.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSCast.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSCell.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSCell.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSCellInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSDateMath.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSFixedArray.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSFunction.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSFunction.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSFunctionInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSGeneratorFunction.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSGlobalObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSGlobalObject.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSGlobalObjectInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSImmutableButterfly.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSImmutableButterfly.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSLexicalEnvironment.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSLock.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSLock.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSMicrotask.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSModuleEnvironment.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSModuleLoader.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSModuleLoader.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSModuleRecord.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSONObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSObject.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSObjectInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSPromisePrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSRunLoopTimer.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSSegmentedVariableObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSSegmentedVariableObject.h - modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSSegmentedVariableObjectHeapCellType.cpp - modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSSegmentedVariableObjectHeapCellType.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSString.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSString.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSStringInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSStringJoiner.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSSymbolTableObject.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSTemplateObjectDescriptor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSTemplateObjectDescriptor.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSTypeInfo.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSTypedArrayViewConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSWeakObjectRef.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/JSWeakObjectRef.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/LazyClassStructure.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/LazyProperty.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/LazyPropertyInlines.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/LeafExecutable.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/LeafExecutable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/LiteralParser.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Lookup.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/MapConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/MapIteratorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/MapPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/MatchResult.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/MathCommon.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/MathObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ModuleProgramExecutable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ModuleProgramExecutable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/NativeErrorConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/NullGetterFunction.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/NullSetterFunction.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/NumberConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/NumberPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/NumericStrings.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ObjectConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ObjectPropertyChangeAdaptiveWatchpoint.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ObjectPrototype.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ObjectToStringAdaptiveStructureWatchpoint.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ObjectToStringAdaptiveStructureWatchpoint.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Operations.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Options.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Options.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ProgramExecutable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ProgramExecutable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/PromiseDeferredTimer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/PromiseDeferredTimer.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/PropertyMapHashTable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/PropertyName.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/PropertyNameArray.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/PropertySlot.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/PropertyTable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ProxyConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ProxyObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ProxyObject.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RandomizingFuzzerAgent.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RandomizingFuzzerAgent.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ReflectObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExp.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExp.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpCache.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpCache.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpCachedResult.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpCachedResult.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpGlobalData.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpKey.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpMatchesArray.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpMatchesArray.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpObject.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpPrototype.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpStringIteratorPrototype.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RegExpStringIteratorPrototype.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RuntimeType.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/RuntimeType.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SamplingProfiler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SamplingProfiler.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ScopedArgumentsTable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ScopedArgumentsTable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ScriptExecutable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ScriptExecutable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SetConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SetIteratorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SetPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SmallStrings.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SparseArrayValueMap.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StackFrame.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StackFrame.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StrictEvalActivation.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StrictEvalActivation.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StringConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StringIteratorPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StringObject.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StringObject.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StringPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StringPrototypeInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StringRecursionChecker.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Structure.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Structure.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StructureCache.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StructureCache.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StructureChain.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StructureChain.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StructureIDTable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StructureInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StructureRareData.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/StructureRareData.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Symbol.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Symbol.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SymbolConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SymbolPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SymbolTable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SymbolTable.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SymbolTableInlines.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/SymbolTableOrScopeDepth.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/TestRunnerUtils.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ThrowScope.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/ThrowScope.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/TypeProfiler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/TypeProfiler.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/TypeSet.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/TypeSet.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/VM.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/VM.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/VMTraps.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/VMTraps.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/Watchdog.h - modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WatchdogMac.cpp - modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WatchdogNone.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WeakMapConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WeakMapImpl.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WeakMapImplInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WeakMapPrototype.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WeakObjectRefConstructor.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WeakObjectRefConstructor.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WeakObjectRefPrototype.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WeakObjectRefPrototype.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WeakSetConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/runtime/WeakSetPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/shell/CMakeLists.txt - modules/javafx.web/src/main/native/Source/JavaScriptCore/shell/PlatformJSCOnly.cmake ! modules/javafx.web/src/main/native/Source/JavaScriptCore/testRegExp.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/tools/CodeProfile.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/tools/FunctionOverrides.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/tools/FunctionOverrides.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/tools/HeapVerifier.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/tools/JSDollarVM.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/tools/SigillCrashAnalyzer.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/tools/VMInspector.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/tools/VMInspector.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmB3IRGenerator.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmBBQPlan.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmBBQPlan.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmBBQPlanInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmBinding.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmCallee.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmCallee.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmCalleeRegistry.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmCalleeRegistry.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmCallingConvention.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmCapabilities.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmCodeBlock.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmCodeBlock.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmCompilationMode.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmCompilationMode.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmContext.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmContext.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmContextInlines.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmExceptionType.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmFormat.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmFunctionParser.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmIndexOrName.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmInstance.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmInstance.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmLimits.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmMemory.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmMemory.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmMemoryInformation.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmMemoryInformation.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmModuleInformation.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmModuleParser.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmNameSectionParser.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmOMGForOSREntryPlan.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmOMGForOSREntryPlan.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmOMGPlan.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmOMGPlan.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmOSREntryData.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmOperations.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmOperations.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmParser.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmSectionParser.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmSectionParser.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmSignature.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmSignature.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmStreamingParser.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmStreamingParser.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmTable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmTable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmThunks.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmThunks.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmTierUpCount.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmTierUpCount.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmValidate.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/WasmWorklist.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/generateWasmOpsHeader.py ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSToWasm.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSToWasmICCallee.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSToWasmICCallee.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssembly.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssembly.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyCodeBlockHeapCellType.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyCompileError.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyLinkError.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyMemory.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyRuntimeError.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyRuntimeError.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyTable.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/JSWebAssemblyTable.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WasmToJS.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WasmToJS.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyFunctionHeapCellType.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyFunctionHeapCellType.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyInstanceConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyInstancePrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyMemoryPrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyModuleConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp - modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp - modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyToJSCallee.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyToJSCallee.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyWrapperFunction.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/js/WebAssemblyWrapperFunction.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/wasm/wasm.json ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/RegularExpression.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrFlags.cpp + modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrFlags.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrInterpreter.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrInterpreter.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrJIT.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrJIT.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrParser.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrPattern.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrPattern.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrUnicodeProperties.cpp ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/YarrUnicodeProperties.h ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/create_regex_tables ! modules/javafx.web/src/main/native/Source/JavaScriptCore/yarr/generateYarrUnicodePropertyTables.py ! modules/javafx.web/src/main/native/Source/WTF/CMakeLists.txt ! modules/javafx.web/src/main/native/Source/WTF/Scripts/generate-unified-source-bundles.rb ! modules/javafx.web/src/main/native/Source/WTF/benchmarks/HashSetDFGReplay.cpp ! modules/javafx.web/src/main/native/Source/WTF/benchmarks/LockFairnessTest.cpp ! modules/javafx.web/src/main/native/Source/WTF/benchmarks/LockSpeedTest.cpp + modules/javafx.web/src/main/native/Source/WTF/wtf/AggregateLogger.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Assertions.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/Assertions.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Atomics.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/AutodrainedPool.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Bag.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/BitVector.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/BitVector.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Bitmap.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/BlockPtr.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/BloomFilter.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Box.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/BumpPointerAllocator.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CMakeLists.txt ! modules/javafx.web/src/main/native/Source/WTF/wtf/CPUTime.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CagedPtr.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CagedUniquePtr.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CheckedArithmetic.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CheckedBoolean.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CommaPrinter.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CompactPointerTuple.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CompilationThread.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/CompilationThread.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Compiler.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CompletionHandler.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ConcurrentBuffer.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ConcurrentPtrHashSet.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ConcurrentVector.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Condition.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CountingLock.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CrossThreadCopier.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CrossThreadQueue.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CrossThreadTask.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CrossThreadTaskHandler.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/CrossThreadTaskHandler.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/CryptographicallyRandomNumber.cpp + modules/javafx.web/src/main/native/Source/WTF/wtf/DataMutex.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/DateMath.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/DateMath.h - modules/javafx.web/src/main/native/Source/WTF/wtf/DeprecatedOptional.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Deque.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Dominators.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/DoublyLinkedList.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/DumbPtrTraits.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/DumbValueTraits.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Expected.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/FastBitVector.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/FastMalloc.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/FeatureDefines.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/FileMetadata.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/FilePrintStream.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/FileSystem.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/FileSystem.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ForbidHeapAllocation.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Forward.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Function.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Gigacage.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/Gigacage.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/GraphNodeWorklist.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/GregorianDateTime.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/HashMap.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/HashSet.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/HashTable.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/HashTraits.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Hasher.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/HexNumber.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Indenter.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/IndexMap.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/IndexSet.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/IndexSparseSet.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/IndexedContainerIterator.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Insertion.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/IsoMalloc.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/IsoMallocInlines.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/IteratorAdaptors.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/IteratorRange.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/JSONValues.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/KeyValuePair.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ListHashSet.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Liveness.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Locker.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/LocklessBag.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Logger.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/Logger.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/LoggerHelper.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/LoggingHashID.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/MD5.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/MachSendRight.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/MainThread.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/MainThread.h + modules/javafx.web/src/main/native/Source/WTF/wtf/MainThreadData.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Markable.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/MathExtras.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/MediaTime.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/MediaTime.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/MemoryFootprint.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/MemoryPressureHandler.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/MemoryPressureHandler.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/MessageQueue.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/MetaAllocator.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/MetaAllocator.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/MonotonicTime.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/NaturalLoops.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/NeverDestroyed.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/NoLock.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Noncopyable.h + modules/javafx.web/src/main/native/Source/WTF/wtf/Nonmovable.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/OSAllocator.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ObjectIdentifier.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/OptionSet.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Optional.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/OrderMaker.h + modules/javafx.web/src/main/native/Source/WTF/wtf/Packed.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/PackedIntVector.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/PageBlock.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ParallelJobsGeneric.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/ParallelJobsOpenMP.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ParkingLot.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Platform.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/PlatformJSCOnly.cmake ! modules/javafx.web/src/main/native/Source/WTF/wtf/PlatformJava.cmake ! modules/javafx.web/src/main/native/Source/WTF/wtf/PlatformPlayStation.cmake ! modules/javafx.web/src/main/native/Source/WTF/wtf/PlatformRegisters.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/PointerPreparations.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/PrintStream.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/PriorityQueue.h + modules/javafx.web/src/main/native/Source/WTF/wtf/PtrTag.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/PtrTag.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/RandomDevice.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Range.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/RangeSet.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/RecursableLambda.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/RedBlackTree.h + modules/javafx.web/src/main/native/Source/WTF/wtf/RefCounted.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/RefCounted.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/RefCountedLeakCounter.cpp + modules/javafx.web/src/main/native/Source/WTF/wtf/ResourceUsage.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/RetainPtr.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/RunLoop.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/RunLoop.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/RunLoopTimer.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/SHA1.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Seconds.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/SegmentedVector.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/SentinelLinkedList.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/SetForScope.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/SingleRootGraph.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/SinglyLinkedList.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/SizeLimits.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/SmallPtrSet.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/SpanningTree.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Spectrum.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/StackBounds.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/StackBounds.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/StackShot.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/StackShotProfiler.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/StackStats.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/StackTrace.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/StdLibExtras.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/StreamBuffer.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/SynchronizedFixedQueue.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/SystemTracing.h + modules/javafx.web/src/main/native/Source/WTF/wtf/TaggedArrayStoragePtr.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ThreadGroup.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ThreadSafeRefCounted.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ThreadSpecific.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Threading.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/Threading.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/ThreadingPrimitives.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/TimeWithDynamicClockType.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/TimingScope.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/TimingScope.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/TinyLRUCache.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/TinyPtrSet.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/URL.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/URLHash.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/URLHelpers.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/URLHelpers.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/URLParser.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/URLParser.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/UUID.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/UnalignedAccess.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Unexpected.h - modules/javafx.web/src/main/native/Source/WTF/wtf/UniStdExtras.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/UniStdExtras.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/UniqueRef.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/VMTags.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Variant.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/Vector.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/VectorTraits.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/WTFAssertions.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/WTFSemaphore.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/WallTime.h + modules/javafx.web/src/main/native/Source/WTF/wtf/WeakHashSet.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/WeakPtr.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/WeakRandom.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/WordLock.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/cocoa/CPUTimeCocoa.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/cocoa/FileSystemCocoa.mm ! modules/javafx.web/src/main/native/Source/WTF/wtf/cocoa/MainThreadCocoa.mm ! modules/javafx.web/src/main/native/Source/WTF/wtf/cocoa/MemoryFootprintCocoa.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm ! modules/javafx.web/src/main/native/Source/WTF/wtf/cocoa/NSURLExtras.mm + modules/javafx.web/src/main/native/Source/WTF/wtf/cocoa/ResourceUsageCocoa.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/cocoa/SoftLinking.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/bignum-dtoa.cc ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/bignum-dtoa.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/bignum.cc ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/bignum.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/cached-powers.cc ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/cached-powers.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/diy-fp.cc ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/diy-fp.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/double-conversion.cc ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/double-conversion.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/fast-dtoa.cc ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/fast-dtoa.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/fixed-dtoa.cc ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/fixed-dtoa.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/strtod.cc ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/strtod.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/dtoa/utils.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/fuchsia/CPUTimeFuchsia.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/generic/MainThreadGeneric.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/java/FileSystemJava.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/linux/CurrentProcessMemoryStatus.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/mac/AppKitCompatibilityDeclarations.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/persistence/PersistentCoders.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/persistence/PersistentCoders.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/posix/FileSystemPOSIX.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/posix/ThreadingPOSIX.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/spi/darwin/SandboxSPI.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/spi/darwin/XPCSPI.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/spi/darwin/dyldSPI.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/ASCIILiteral.h + modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomString.cpp + modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomString.h + modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomStringHash.h + modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomStringImpl.cpp + modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomStringImpl.h + modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomStringTable.cpp + modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomStringTable.h - modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomicString.cpp - modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomicString.h - modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomicStringHash.h - modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomicStringImpl.cpp - modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomicStringImpl.h - modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomicStringTable.cpp - modules/javafx.web/src/main/native/Source/WTF/wtf/text/AtomicStringTable.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/CString.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/ExternalStringImpl.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/LineBreakIteratorPoolICU.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/NullTextBreakIterator.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/OrdinalNumber.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringBuffer.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringBuilder.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringBuilder.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringCommon.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringConcatenate.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringConcatenateNumbers.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringHash.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringHasher.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringImpl.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringImpl.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringOperators.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringView.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/StringView.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/SymbolImpl.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/SymbolRegistry.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/TextBreakIterator.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/TextBreakIterator.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/TextPosition.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/TextStream.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/ValueToString.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/WTFString.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/WTFString.h + modules/javafx.web/src/main/native/Source/WTF/wtf/text/cf/AtomStringImplCF.cpp - modules/javafx.web/src/main/native/Source/WTF/wtf/text/cf/AtomicStringImplCF.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/cf/TextBreakIteratorCF.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/cocoa/TextBreakIteratorInternalICUCocoa.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/icu/TextBreakIteratorICU.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/icu/UTextProviderLatin1.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/text/win/WCharStringExtras.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/threads/BinarySemaphore.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/unicode/Collator.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/unicode/UTF8Conversion.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/unicode/UTF8Conversion.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/unix/CPUTimeUnix.cpp + modules/javafx.web/src/main/native/Source/WTF/wtf/unix/UniStdExtrasUnix.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/CPUTimeWin.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/FileSystemWin.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/GDIObject.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/LanguageWin.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/MainThreadWin.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/PathWalker.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/PathWalker.h ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/RunLoopWin.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/ThreadSpecificWin.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/ThreadingWin.cpp ! modules/javafx.web/src/main/native/Source/WTF/wtf/win/Win32Handle.h ! modules/javafx.web/src/main/native/Source/WebCore/CMakeLists.txt ! modules/javafx.web/src/main/native/Source/WebCore/DerivedSources-input.xcfilelist ! modules/javafx.web/src/main/native/Source/WebCore/DerivedSources-output.xcfilelist ! modules/javafx.web/src/main/native/Source/WebCore/DerivedSources.make + modules/javafx.web/src/main/native/Source/WebCore/Headers.cmake ! modules/javafx.web/src/main/native/Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayPayment.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizedEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayPaymentMethod.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayPaymentMethodSelectedEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayRequestBase.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePaySession.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePaySession.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePaySession.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayShippingContactSelectedEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayShippingContactSelectedEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayShippingMethodSelectedEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayValidateMerchantEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/ApplePayValidateMerchantEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/PaymentCoordinator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/PaymentCoordinator.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/PaymentCoordinatorClient.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/PaymentRequestValidator.mm ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/PaymentSession.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/PaymentSession.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/beacon/NavigatorBeacon.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/CacheStorageConnection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/CacheStorageConnection.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/DOMCache.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/DOMCache.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/DOMCacheEngine.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/DOMCacheEngine.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/DOMCacheStorage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/DOMCacheStorage.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/DOMWindowCaches.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/cache/WorkerGlobalScopeCaches.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/credentialmanagement/NavigatorCredentials.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/CDM.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/CDM.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/MediaKeySession.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/MediaKeyStatusMap.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/MediaKeyStatusMap.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivate.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/entriesapi/DOMFileSystem.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/entriesapi/DOMFileSystem.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/entriesapi/FileSystemDirectoryEntry.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/entriesapi/FileSystemDirectoryReader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/entriesapi/FileSystemDirectoryReader.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/entriesapi/FileSystemEntry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/entriesapi/FileSystemEntry.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/entriesapi/FileSystemFileEntry.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchBody.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchBody.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchBodyConsumer.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchBodyOwner.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchHeaders.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchRequest.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchResponse.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/fetch/FetchResponse.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/gamepad/GamepadEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/gamepad/GamepadEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/gamepad/GamepadManager.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp - modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/Coordinates.cpp - modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/Coordinates.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/Coordinates.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeoNotifier.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeoNotifier.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/Geolocation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/Geolocation.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/Geolocation.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationClient.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationController.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationCoordinates.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationCoordinates.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationCoordinates.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationPosition.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationPosition.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationPositionData.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationPositionError.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/GeolocationPositionError.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/Geoposition.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/Geoposition.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/NavigatorGeolocation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/NavigatorGeolocation.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/PositionCallback.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/PositionCallback.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/PositionError.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/PositionError.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/PositionErrorCallback.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/PositionErrorCallback.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/geolocation/ios/GeolocationPositionDataIOS.mm ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBCursor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBCursor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBCursorWithValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBCursorWithValue.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBDatabase.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBFactory.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBGetAllResult.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBGetAllResult.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBGetResult.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBGetResult.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBIndex.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBIndex.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBKey.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBKeyData.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBKeyRange.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBObjectStore.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBRequest.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBRequest.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBRequestCompletionEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBRequestCompletionEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBTransaction.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBValue.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/client/TransactionOperation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/client/TransactionOperation.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/IDBBackingStore.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/IDBSerializationContext.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/IDBSerializationContext.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/IDBServer.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/IndexValueEntry.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/IndexValueStore.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/IndexValueStore.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBError.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBError.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBIterateCursorData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBRequestData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBResultData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBResultData.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacapabilities/AudioConfiguration.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacapabilities/MediaCapabilitiesDecodingInfo.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacapabilities/MediaCapabilitiesEncodingInfo.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacapabilities/MediaDecodingConfiguration.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacapabilities/MediaEncodingConfiguration.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacapabilities/VideoConfiguration.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediarecorder/BlobEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediarecorder/BlobEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediarecorder/MediaRecorder.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediarecorder/MediaRecorderErrorEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediarecorder/MediaRecorderErrorEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasession/MediaRemoteControls.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasource/MediaSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasource/MediaSource.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasource/MediaSourceRegistry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasource/MediaSourceRegistry.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasource/SourceBuffer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasource/SourceBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasource/SourceBufferList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediasource/SourceBufferList.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaDeviceInfo.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaDeviceInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaDeviceInfo.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaDevices.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaDevices.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaDevicesEnumerationRequest.cpp - modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaDevicesEnumerationRequest.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaDevicesRequest.cpp - modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaDevicesRequest.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaStream.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaStream.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaStream.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaStreamRegistry.cpp - modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaStreamRegistry.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaStreamTrack.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/NavigatorMediaDevices.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/NavigatorMediaDevices.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCDTMFSender.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCDTMFSender.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCDataChannel.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCDataChannel.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCDataChannelEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCDataChannelEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCIceCandidate.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCIceTransport.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCIceTransport.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCPeerConnection.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCPeerConnection.js ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCPeerConnectionInternals.js ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCRtpReceiver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCRtpReceiver.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCRtpSender.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCRtpSender.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCRtpSender.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCRtpSenderBackend.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCSessionDescription.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCSessionDescription.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCTrackEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/RTCTrackEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/UserMediaClient.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/UserMediaController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/UserMediaController.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/UserMediaRequest.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.js ! modules/javafx.web/src/main/native/Source/WebCore/Modules/modern-media-controls/controls/media-document.css ! modules/javafx.web/src/main/native/Source/WebCore/Modules/modern-media-controls/media/media-controller.js ! modules/javafx.web/src/main/native/Source/WebCore/Modules/modern-media-controls/media/media-document-controller.js - modules/javafx.web/src/main/native/Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp - modules/javafx.web/src/main/native/Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtilsClient.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/notifications/Notification.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/notifications/Notification.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/notifications/NotificationController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentHandler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentHandler.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentRequest.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentRequest.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentResponse.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/paymentrequest/PaymentResponse.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm ! modules/javafx.web/src/main/native/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/quota/DOMWindowQuota.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/quota/NavigatorStorageQuota.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/quota/WorkerNavigatorStorageQuota.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/speech/DOMWindowSpeechSynthesis.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/speech/SpeechSynthesis.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/speech/SpeechSynthesis.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/speech/SpeechSynthesisEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/speech/SpeechSynthesisEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js ! modules/javafx.web/src/main/native/Source/WebCore/Modules/streams/ReadableStream.js ! modules/javafx.web/src/main/native/Source/WebCore/Modules/streams/ReadableStreamBYOBReader.js ! modules/javafx.web/src/main/native/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js ! modules/javafx.web/src/main/native/Source/WebCore/Modules/streams/ReadableStreamInternals.js - modules/javafx.web/src/main/native/Source/WebCore/Modules/streams/WebGPUBindGroupLayoutDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/streams/WritableStream.js ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AnalyserNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AnalyserNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AsyncAudioDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AsyncAudioDecoder.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioBuffer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioContext.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioContext.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioDestinationNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioDestinationNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioNode.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioParam.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioParam.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/BiquadFilterNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/BiquadProcessor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/ChannelMergerNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/ChannelMergerNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/ChannelSplitterNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/ChannelSplitterNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/ConvolverNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/ConvolverNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/DelayNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/DelayNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/DelayProcessor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/GainNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/GainNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/OfflineAudioContext.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/OscillatorNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/OscillatorNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/PannerNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/PannerNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/PeriodicWave.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/WaveShaperNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/WaveShaperNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webaudio/WaveShaperProcessor.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/AttestationConveyancePreference.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/AttestationConveyancePreference.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/AuthenticationExtensionsClientInputs.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/AuthenticationExtensionsClientInputs.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/AuthenticatorCoordinatorClient.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/AuthenticatorCoordinatorClient.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/PublicKeyCredential.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/PublicKeyCredential.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/PublicKeyCredentialData.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/PublicKeyCredentialRequestOptions.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/PublicKeyCredentialRequestOptions.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/apdu/ApduCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/apdu/ApduCommand.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/apdu/ApduResponse.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/apdu/ApduResponse.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/fido/FidoConstants.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/fido/FidoHidMessage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/fido/FidoHidMessage.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/fido/FidoHidPacket.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/fido/U2fCommandConstructor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/fido/U2fCommandConstructor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/fido/U2fResponseConverter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webauthn/fido/U2fResponseConverter.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/ChangeVersionData.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/Database.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/Database.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/DatabaseContext.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/DatabaseManager.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/DatabaseThread.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/DatabaseTracker.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/OriginLock.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/SQLError.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/SQLError.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/SQLResultSetRowList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/SQLStatement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/SQLStatement.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/SQLTransaction.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdatabase/SQLTransaction.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webdriver/NavigatorWebDriver.cpp - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/DOMWindowWebGPU.cpp - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/DOMWindowWebGPU.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/DOMWindowWebGPU.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUBindGroupLayoutBinding.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUBindGroupLayoutBinding.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUBindGroupLayoutDescriptor.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUBindGroupLayoutDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUBlendDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUBufferDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUBufferUsage.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUCanvasContext.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUCanvasContext.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUCanvasContext.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUColor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUColorStateDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUColorWriteBits.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUCompareFunction.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUDepthStencilStateDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUErrorFilter.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUExtent3D.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPULoadOp.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUOrigin3D.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUOrigin3D.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUOutOfMemoryError.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPURequestAdapterOptions.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUSamplerDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUShaderStageBit.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUShaderStageBit.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUStoreOp.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUTextureDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUTextureDimension.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUTextureFormat.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUTextureUsage.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUValidationError.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUVertexAttributeDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUVertexBufferDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/GPUVertexInputDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/NavigatorGPU.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/NavigatorGPU.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/NavigatorGPU.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAST.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAddressEscapeMode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAddressSpace.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayType.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAssignmentExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBlock.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBooleanLiteral.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBreak.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLCommaExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLConstantExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLContinue.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLDefaultDelete.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLDereferenceExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLDoWhileLoop.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLDotExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEffectfulExpressionStatement.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEntryPointType.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationDefinition.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFallthrough.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteral.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLForLoop.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionDefinition.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLGlobalVariableReference.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIfStatement.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLLogicalExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLLogicalNotExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLMakeArrayReferenceExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLMakePointerExpression.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNameSpace.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNamedType.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNativeFunctionDeclaration.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNativeTypeDeclaration.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNode.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNullLiteral.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNullLiteralType.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLNumThreadsFunctionAttribute.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLPointerType.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLPropertyAccessExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLQualifier.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResolvableType.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReturn.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStatement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStatement.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStatementList.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStructureDefinition.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLSwitchCase.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLSwitchStatement.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTernaryExpression.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTrap.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLType.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeReference.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedTypeHash.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLValue.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLVariableDeclarationsStatement.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLVariableReference.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLWhileLoop.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLMangledNames.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLNativeTypeWriter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLVertexBufferIndexCalculator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLVertexBufferIndexCalculator.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCodeLocation.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLComputeDimensions.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLComputeDimensions.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLError.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLInferTypes.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLInferTypes.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameContext.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParsingMode.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLProgram.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolvingType.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLScopedSetAdder.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSemanticMatcher.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSemanticMatcher.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibraryFunctionMap.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPU.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPU.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPU.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUAdapter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUAdapter.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUAdapter.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroup.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroup.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroupBinding.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroupBinding.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroupDescriptor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroupDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroupDescriptor.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroupLayout.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroupLayout.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroupLayoutBinding.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroupLayoutBinding.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBindGroupLayoutDescriptor.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBuffer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBuffer.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBufferBinding.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBufferBinding.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBufferDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBufferDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBufferUsage.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUBufferUsage.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUColor.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUColor.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUCommandBuffer.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUCommandEncoder.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUCommandEncoder.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUCommandEncoder.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUComputePassEncoder.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUComputePassEncoder.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUComputePassEncoder.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUComputePipeline.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUComputePipeline.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUComputePipeline.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUComputePipelineDescriptor.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUComputePipelineDescriptor.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUComputePipelineDescriptor.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUDevice.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUDevice.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUDeviceErrorScopes.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUDeviceErrorScopes.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUDeviceErrorScopes.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUIndexFormat.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUIndexFormat.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUInputStateDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUInputStateDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUInputStepMode.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUInputStepMode.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUPipelineDescriptorBase.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUPipelineLayout.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUPipelineLayout.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUPipelineLayout.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUPipelineLayoutDescriptor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUPipelineLayoutDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUPipelineLayoutDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUPipelineStageDescriptor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUPipelineStageDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUPipelineStageDescriptor.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUQueue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUQueue.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUQueue.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPassColorAttachmentDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPassColorAttachmentDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPipeline.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPipeline.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPipeline.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPipelineDescriptor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPipelineDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderPipelineDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderingContext.cpp - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderingContext.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPURenderingContext.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUSampler.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUSampler.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUSampler.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUShaderModule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUShaderModule.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUShaderModule.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUShaderModuleDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUShaderStageBit.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUShaderStageBit.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUSwapChain.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUSwapChain.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUSwapChain.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUSwapChainDescriptor.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUSwapChainDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUTexture.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUTexture.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUTexture.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUTextureView.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUTextureView.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUTextureView.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUVertexAttributeDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUVertexAttributeDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUVertexFormat.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUVertexFormat.idl - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUVertexInputDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WebGPUVertexInputDescriptor.idl + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WorkerNavigatorGPU.cpp + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WorkerNavigatorGPU.h + modules/javafx.web/src/main/native/Source/WebCore/Modules/webgpu/WorkerNavigatorGPU.idl ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/CloseEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocket.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocket.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocketChannel.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocketChannel.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocketChannelClient.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocketDeflateFramer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocketDeflater.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocketExtensionDispatcher.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocketExtensionParser.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocketFrame.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WebSocketHandshake.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webvr/NavigatorWebVR.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webvr/VRDisplay.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webvr/VRDisplay.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webvr/VRDisplayEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webvr/VRDisplayEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webvr/VREyeParameters.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webvr/VRFrameData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/Modules/webvr/VRPose.cpp ! modules/javafx.web/src/main/native/Source/WebCore/PAL/pal/CMakeLists.txt + modules/javafx.web/src/main/native/Source/WebCore/PAL/pal/Gunzip.h ! modules/javafx.web/src/main/native/Source/WebCore/PAL/pal/LogMacros.h ! modules/javafx.web/src/main/native/Source/WebCore/PAL/pal/SessionID.cpp ! modules/javafx.web/src/main/native/Source/WebCore/PAL/pal/SessionID.h ! modules/javafx.web/src/main/native/Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp ! modules/javafx.web/src/main/native/Source/WebCore/PAL/pal/crypto/tasn1/Utilities.cpp ! modules/javafx.web/src/main/native/Source/WebCore/PAL/pal/crypto/tasn1/Utilities.h ! modules/javafx.web/src/main/native/Source/WebCore/PAL/pal/system/ClockGeneric.cpp ! modules/javafx.web/src/main/native/Source/WebCore/PAL/pal/win/LoggingWin.cpp ! modules/javafx.web/src/main/native/Source/WebCore/PlatformJava.cmake ! modules/javafx.web/src/main/native/Source/WebCore/PlatformPlayStation.cmake + modules/javafx.web/src/main/native/Source/WebCore/Resources/AttachmentPlaceholder.png + modules/javafx.web/src/main/native/Source/WebCore/Resources/AttachmentPlaceholder at 2x.png + modules/javafx.web/src/main/native/Source/WebCore/Resources/ContentFilterBlockedPage.html - modules/javafx.web/src/main/native/Source/WebCore/Resources/DictationPhraseWithAlternativesDot.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/DictationPhraseWithAlternativesDot at 2x.png + modules/javafx.web/src/main/native/Source/WebCore/Resources/ListButtonArrow.png + modules/javafx.web/src/main/native/Source/WebCore/Resources/ListButtonArrow at 2x.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/SpellingDot.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/SpellingDot at 2x.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/SpellingDot at 3x.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/decrementArrow.tiff - modules/javafx.web/src/main/native/Source/WebCore/Resources/hScrollControl_left.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/hScrollControl_middle.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/hScrollControl_right.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/incrementArrow.tiff - modules/javafx.web/src/main/native/Source/WebCore/Resources/inputSpeech.tiff - modules/javafx.web/src/main/native/Source/WebCore/Resources/markedLeft.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/markedMiddle.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/markedRight.png ! modules/javafx.web/src/main/native/Source/WebCore/Resources/missingImage.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/missingImage.tiff ! modules/javafx.web/src/main/native/Source/WebCore/Resources/missingImage at 2x.png ! modules/javafx.web/src/main/native/Source/WebCore/Resources/missingImage at 3x.png ! modules/javafx.web/src/main/native/Source/WebCore/Resources/moveCursor.png ! modules/javafx.web/src/main/native/Source/WebCore/Resources/northEastSouthWestResizeCursor.png ! modules/javafx.web/src/main/native/Source/WebCore/Resources/northSouthResizeCursor.png ! modules/javafx.web/src/main/native/Source/WebCore/Resources/northWestSouthEastResizeCursor.png ! modules/javafx.web/src/main/native/Source/WebCore/Resources/nullPlugin.png ! modules/javafx.web/src/main/native/Source/WebCore/Resources/nullPlugin at 2x.png ! modules/javafx.web/src/main/native/Source/WebCore/Resources/panIcon.png ! modules/javafx.web/src/main/native/Source/WebCore/Resources/textAreaResizeCorner.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/textAreaResizeCorner.tiff ! modules/javafx.web/src/main/native/Source/WebCore/Resources/textAreaResizeCorner at 2x.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/urlIcon.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/vScrollControl_bottom.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/vScrollControl_middle.png - modules/javafx.web/src/main/native/Source/WebCore/Resources/vScrollControl_top.png ! modules/javafx.web/src/main/native/Source/WebCore/Scripts/SettingsTemplates/Settings.cpp.erb ! modules/javafx.web/src/main/native/Source/WebCore/Scripts/check-xcfilelists.sh ! modules/javafx.web/src/main/native/Source/WebCore/Sources.txt ! modules/javafx.web/src/main/native/Source/WebCore/SourcesCocoa.txt ! modules/javafx.web/src/main/native/Source/WebCore/SourcesGTK.txt ! modules/javafx.web/src/main/native/Source/WebCore/SourcesPlatformJava.txt ! modules/javafx.web/src/main/native/Source/WebCore/SourcesWPE.txt - modules/javafx.web/src/main/native/Source/WebCore/WebCore.vcxproj/QTMovieWin/QTMovieWinPreLink.cmd ! modules/javafx.web/src/main/native/Source/WebCore/WebCoreMacros.cmake ! modules/javafx.web/src/main/native/Source/WebCore/WebCorePrefix.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AXObjectCache.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AXObjectCache.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityAttachment.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityAttachment.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityImageMapLink.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityImageMapLink.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityMediaControls.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityMediaControls.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityMediaObject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityMenuListOption.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityNodeObject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityNodeObject.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityObject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityObject.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityObjectInterface.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityProgressIndicator.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityRenderObject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityRenderObject.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilitySVGElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilitySVGElement.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityScrollView.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityScrollView.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityScrollbar.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilitySlider.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilitySlider.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityTable.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityTableCell.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityTableColumn.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibilityTableRow.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibleSetValueEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibleSetValueEvent.h - modules/javafx.web/src/main/native/Source/WebCore/accessibility/AccessibleSetValueEvent.idl ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/AriaAttributes.idl ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessible.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessible.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceAction.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceAction.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceComponent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceComponent.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceDocument.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceDocument.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceHypertext.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceImage.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTable.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTable.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceTableCell.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceValue.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h ! modules/javafx.web/src/main/native/Source/WebCore/animation/AnimationPlaybackEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/animation/AnimationPlaybackEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/animation/AnimationTimeline.cpp ! modules/javafx.web/src/main/native/Source/WebCore/animation/AnimationTimeline.h ! modules/javafx.web/src/main/native/Source/WebCore/animation/CSSAnimation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/animation/CSSAnimation.h ! modules/javafx.web/src/main/native/Source/WebCore/animation/CSSTransition.cpp ! modules/javafx.web/src/main/native/Source/WebCore/animation/CSSTransition.h ! modules/javafx.web/src/main/native/Source/WebCore/animation/DeclarativeAnimation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/animation/DeclarativeAnimation.h - modules/javafx.web/src/main/native/Source/WebCore/animation/DocumentAnimationScheduler.cpp - modules/javafx.web/src/main/native/Source/WebCore/animation/DocumentAnimationScheduler.h ! modules/javafx.web/src/main/native/Source/WebCore/animation/DocumentTimeline.cpp ! modules/javafx.web/src/main/native/Source/WebCore/animation/DocumentTimeline.h ! modules/javafx.web/src/main/native/Source/WebCore/animation/KeyframeEffect.cpp ! modules/javafx.web/src/main/native/Source/WebCore/animation/WebAnimation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/animation/WebAnimation.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/IDLTypes.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/CachedScriptFetcher.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/CachedScriptFetcher.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/CallTracer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/CallTracer.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/CallTracerTypes.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/CommonVM.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/CommonVM.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/DOMGCOutputConstraint.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/DOMGCOutputConstraint.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/DOMPromiseProxy.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/GCController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/GCController.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/IDBBindingUtilities.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/IDBBindingUtilities.h + modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSAudioNodeCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSCallbackData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSCustomElementInterface.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSCustomElementInterface.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMBuiltinConstructor.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMConvertNumbers.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMConvertRecord.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMConvertStrings.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMConvertStrings.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMConvertVariadic.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMGlobalObject.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMPromiseDeferred.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMWindowBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMWindowProperties.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDOMWrapper.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDeprecatedCSSOMValueCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSDocumentCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSEventCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSEventListener.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSEventListener.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSEventTargetCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSExecStateInstrumentation.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSHTMLElementCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSHistoryCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSIDBCursorWithValueCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSIDBRequestCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSImageDataCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSLazyEventListener.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSLazyEventListener.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSLocationCustom.cpp + modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSMediaCapabilitiesCustom.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSNavigatorCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSNodeListCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSPerformanceObserverCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSPluginElementFunctions.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSRemoteDOMWindowCustom.cpp + modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSResizeObserverEntryCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSSVGPathSegCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSValueInWrappedObject.h - modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSWebMetalRenderPassAttachmentDescriptorCustom.cpp - modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSWebMetalRenderingContextCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSWindowProxy.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/JSWorkerNavigatorCustom.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/ScriptCachedFrameData.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/ScriptController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/ScriptController.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/ScriptModuleLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/ScriptWrappable.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/SerializedScriptValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/SerializedScriptValue.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/WebCoreBuiltinNames.h ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/WebCoreJSClientData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/WindowProxy.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/js/WorkerScriptController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/CodeGenerator.pm ! modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm ! modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/IDLAttributes.json ! modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/IDLParser.pm ! modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/generate-bindings-all.pl ! modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/generate-bindings.pl ! modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/preprocess-idls.pl - modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.symbols - modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.symbols - modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.symbols - modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestNode.symbols - modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.symbols - modules/javafx.web/src/main/native/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMreadonly.symbols ! modules/javafx.web/src/main/native/Source/WebCore/bridge/NP_jsobject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bridge/c/c_class.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bridge/c/c_instance.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bridge/c/c_utility.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bridge/jni/jsc/JavaInstanceJSC.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bridge/jsc/BridgeJSC.h ! modules/javafx.web/src/main/native/Source/WebCore/bridge/runtime_array.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bridge/runtime_object.cpp ! modules/javafx.web/src/main/native/Source/WebCore/bridge/runtime_object.h ! modules/javafx.web/src/main/native/Source/WebCore/config.h ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/CombinedURLFilters.cpp ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/ContentExtensionActions.h ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/ContentExtensionParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/ContentExtensionRule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/ContentExtensionRule.h ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/ContentExtensionsBackend.cpp ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/ContentExtensionsBackend.h + modules/javafx.web/src/main/native/Source/WebCore/contentextensions/ContentRuleListResults.h ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/DFABytecodeCompiler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/DFACombiner.cpp ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/NFAToDFA.cpp ! modules/javafx.web/src/main/native/Source/WebCore/contentextensions/URLFilterParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/crypto/CommonCryptoUtilities.h ! modules/javafx.web/src/main/native/Source/WebCore/crypto/SubtleCrypto.cpp ! modules/javafx.web/src/main/native/Source/WebCore/crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp ! modules/javafx.web/src/main/native/Source/WebCore/crypto/gcrypt/GCryptUtilities.cpp ! modules/javafx.web/src/main/native/Source/WebCore/crypto/gcrypt/GCryptUtilities.h ! modules/javafx.web/src/main/native/Source/WebCore/crypto/keys/CryptoKeyEC.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSBasicShapes.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSCalculationValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSComputedStyleDeclaration.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSComputedStyleDeclaration.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSCrossfadeValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSCursorImageValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSCustomIdentValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSCustomIdentValue.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSCustomPropertyValue.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSDefaultStyleSheets.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFilterImageValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontFace.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontFace.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontFaceRule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontFaceSet.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontFaceSet.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontFaceSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontFaceSource.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontFaceSrcValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontSelector.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontSelector.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSFontVariationValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSGradientValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSGridAutoRepeatValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSGridAutoRepeatValue.h + modules/javafx.web/src/main/native/Source/WebCore/css/CSSGridIntegerRepeatValue.cpp + modules/javafx.web/src/main/native/Source/WebCore/css/CSSGridIntegerRepeatValue.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSGroupingRule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSImageGeneratorValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSImageValue.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSKeyframeRule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSKeyframesRule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSKeyframesRule.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSMarkup.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSMediaRule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSNamespaceRule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSNamespaceRule.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSPageRule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSPrimitiveValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSPrimitiveValue.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSPrimitiveValueMappings.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSProperties.json ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSPropertySourceData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSPropertySourceData.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSSelector.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSSelector.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSStyleDeclaration.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSStyleDeclaration.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSStyleRule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSStyleSheet.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSStyleSheet.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSTimingFunctionValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSValue.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSValueKeywords.in ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSValuePool.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSValuePool.h ! modules/javafx.web/src/main/native/Source/WebCore/css/CSSVariableData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/DOMCSSPaintWorklet.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/DOMMatrix.h ! modules/javafx.web/src/main/native/Source/WebCore/css/DOMMatrixReadOnly.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/DOMMatrixReadOnly.h - modules/javafx.web/src/main/native/Source/WebCore/css/DashboardRegion.h ! modules/javafx.web/src/main/native/Source/WebCore/css/DocumentRuleSets.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/DocumentRuleSets.h ! modules/javafx.web/src/main/native/Source/WebCore/css/ElementRuleCollector.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/FontFace.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/FontFace.h ! modules/javafx.web/src/main/native/Source/WebCore/css/FontFace.idl ! modules/javafx.web/src/main/native/Source/WebCore/css/FontFaceSet.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/FontFaceSet.h ! modules/javafx.web/src/main/native/Source/WebCore/css/FontVariantBuilder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/LengthFunctions.h ! modules/javafx.web/src/main/native/Source/WebCore/css/MediaFeatureNames.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/MediaFeatureNames.h ! modules/javafx.web/src/main/native/Source/WebCore/css/MediaList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/MediaList.h ! modules/javafx.web/src/main/native/Source/WebCore/css/MediaQueryEvaluator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/MediaQueryExpression.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/MediaQueryExpression.h ! modules/javafx.web/src/main/native/Source/WebCore/css/MediaQueryMatcher.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/MediaQueryMatcher.h ! modules/javafx.web/src/main/native/Source/WebCore/css/PageRuleCollector.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/PropertySetCSSStyleDeclaration.h ! modules/javafx.web/src/main/native/Source/WebCore/css/RuleFeature.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/RuleFeature.h ! modules/javafx.web/src/main/native/Source/WebCore/css/RuleSet.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/RuleSet.h ! modules/javafx.web/src/main/native/Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/SelectorChecker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/SelectorChecker.h ! modules/javafx.web/src/main/native/Source/WebCore/css/SelectorCheckerTestFunctions.h ! modules/javafx.web/src/main/native/Source/WebCore/css/SelectorFilter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in ! modules/javafx.web/src/main/native/Source/WebCore/css/SelectorPseudoTypeMap.h ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleBuilderConverter.h ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleBuilderCustom.h ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleColor.h ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleMedia.idl ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleProperties.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleProperties.h ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleResolver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleResolver.h ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleRule.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleRule.h ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleSheetContents.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleSheetContents.h ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleSheetList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/StyleSheetList.h ! modules/javafx.web/src/main/native/Source/WebCore/css/ViewportStyleResolver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/ViewportStyleResolver.h ! modules/javafx.web/src/main/native/Source/WebCore/css/WebKitCSSMatrix.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/WebKitCSSMatrix.h ! modules/javafx.web/src/main/native/Source/WebCore/css/html.css ! modules/javafx.web/src/main/native/Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py ! modules/javafx.web/src/main/native/Source/WebCore/css/makeSelectorPseudoElementsMap.py ! modules/javafx.web/src/main/native/Source/WebCore/css/makeprop.pl ! modules/javafx.web/src/main/native/Source/WebCore/css/makevalues.pl ! modules/javafx.web/src/main/native/Source/WebCore/css/mathml.css ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSDeferredParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSDeferredParser.h ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParser.h ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParserContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParserContext.h ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParserFastPaths.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParserFastPaths.h ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParserImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParserImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParserSelector.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParserSelector.h ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSParserToken.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSPropertyParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSSelectorParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSSelectorParser.h ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSTokenizer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSTokenizer.h ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSVariableParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSVariableParser.h ! modules/javafx.web/src/main/native/Source/WebCore/css/parser/SizesAttributeParser.h ! modules/javafx.web/src/main/native/Source/WebCore/css/typedom/StylePropertyMap.h + modules/javafx.web/src/main/native/Source/WebCore/css/typedom/TypedOMCSSImageValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/typedom/TypedOMCSSImageValue.h + modules/javafx.web/src/main/native/Source/WebCore/css/typedom/TypedOMCSSNumericValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/typedom/TypedOMCSSNumericValue.h + modules/javafx.web/src/main/native/Source/WebCore/css/typedom/TypedOMCSSStyleValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/typedom/TypedOMCSSStyleValue.h + modules/javafx.web/src/main/native/Source/WebCore/css/typedom/TypedOMCSSUnitValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/typedom/TypedOMCSSUnitValue.h + modules/javafx.web/src/main/native/Source/WebCore/css/typedom/TypedOMCSSUnparsedValue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/css/typedom/TypedOMCSSUnparsedValue.h ! modules/javafx.web/src/main/native/Source/WebCore/cssjit/SelectorCompiler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/cssjit/StackAllocator.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/AbortController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/AbortController.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/AbortSignal.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/AbortSignal.h + modules/javafx.web/src/main/native/Source/WebCore/dom/AllDescendantsCollection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/AllDescendantsCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/AnimationEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/AnimationEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/Attr.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/Attr.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/Attribute.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/BeforeLoadEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ChildNodeList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ChildNodeList.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ClassCollection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ClassCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ClipboardEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ClipboardEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/CompositionEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/CompositionEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ConstantPropertyMap.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ConstantPropertyMap.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ContainerNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ContainerNode.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/CustomElementReactionQueue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/CustomElementReactionQueue.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/CustomElementRegistry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/CustomElementRegistry.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/CustomEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/CustomEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DOMImplementation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DOMImplementation.h + modules/javafx.web/src/main/native/Source/WebCore/dom/DOMPasteAccess.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DOMPoint.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DOMPointReadOnly.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DOMPointReadOnly.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DOMQuad.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DOMQuad.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DOMRect.h + modules/javafx.web/src/main/native/Source/WebCore/dom/DOMRectReadOnly.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DOMRectReadOnly.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DOMRectReadOnly.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/DataTransfer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DataTransfer.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DataTransferItem.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DataTransferItemList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DataTransferItemList.h + modules/javafx.web/src/main/native/Source/WebCore/dom/DataTransferMac.mm ! modules/javafx.web/src/main/native/Source/WebCore/dom/DatasetDOMStringMap.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DatasetDOMStringMap.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceMotionEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceMotionEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceMotionEvent.idl + modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationAndMotionAccessController.cpp + modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationAndMotionAccessController.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationEvent.idl + modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationOrMotionEvent.cpp + modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationOrMotionEvent.h + modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationOrMotionEvent.idl + modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationOrMotionPermissionState.h + modules/javafx.web/src/main/native/Source/WebCore/dom/DeviceOrientationOrMotionPermissionState.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/Document.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/Document.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/Document.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentEventQueue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentFragment.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentFragment.h + modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentFullscreen.h + modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentFullscreen.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentMarker.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentMarkerController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentMarkerController.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentParser.h + modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentStorageAccess.cpp + modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentStorageAccess.h + modules/javafx.web/src/main/native/Source/WebCore/dom/DocumentStorageAccess.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/Element.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/Element.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/Element.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/ElementData.h + modules/javafx.web/src/main/native/Source/WebCore/dom/ElementIdentifier.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ElementRareData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ElementRareData.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ErrorEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ErrorEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/Event.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/Event.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventListener.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventListenerMap.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventListenerMap.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventNames.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventNames.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventNames.in ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventPath.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventSender.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventTarget.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventTarget.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventTarget.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/EventTargetFactory.in ! modules/javafx.web/src/main/native/Source/WebCore/dom/ExtensionStyleSheets.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/FocusEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/FocusEvent.h + modules/javafx.web/src/main/native/Source/WebCore/dom/FullscreenManager.cpp + modules/javafx.web/src/main/native/Source/WebCore/dom/FullscreenManager.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/GenericEventQueue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/GenericEventQueue.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/GlobalEventHandlers.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/HashChangeEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/IdTargetObserver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/IdTargetObserver.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/IdTargetObserverRegistry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/IdTargetObserverRegistry.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/InlineClassicScript.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/InlineStyleSheetOwner.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/InlineStyleSheetOwner.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/InputEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/InputEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/KeyboardEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/KeyboardEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/LiveNodeList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/LiveNodeList.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/LoadableClassicScript.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/LoadableClassicScript.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/LoadableModuleScript.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/LoadableModuleScript.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/LoadableScript.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/MessageChannel.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/MessageEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/MessageEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/MessagePort.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/MessagePort.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/Microtasks.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/Microtasks.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/MouseEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/MouseEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/MouseEvent.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/MouseEventInit.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/MouseEventInit.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/MouseRelatedEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/MouseRelatedEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/MutationEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/MutationEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/MutationObserver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/MutationObserverInterestGroup.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/MutationObserverRegistration.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/MutationObserverRegistration.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/MutationRecord.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/MutationRecord.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/NameNodeList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/NameNodeList.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/NamedNodeMap.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/NamedNodeMap.h + modules/javafx.web/src/main/native/Source/WebCore/dom/NavigatorMaxTouchPoints.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/Node.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/Node.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/NodeIterator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/NodeIterator.h + modules/javafx.web/src/main/native/Source/WebCore/dom/NodeList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/NodeList.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/NodeRareData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/NodeRareData.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/NonElementParentNode.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/OverflowEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/OverflowEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/PageTransitionEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/PageTransitionEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/PointerEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/PointerEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/PointerEvent.idl - modules/javafx.web/src/main/native/Source/WebCore/dom/PointerID.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/PopStateEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/PopStateEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/Position.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ProgressEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ProgressEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/PromiseRejectionEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/PromiseRejectionEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/QualifiedName.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/QualifiedName.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/RadioButtonGroups.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/RadioButtonGroups.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/Range.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/Range.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/RangeBoundaryPoint.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/RequestAnimationFrameCallback.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ScriptDisallowedScope.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ScriptElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ScriptElement.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ScriptElementCachedScriptFetcher.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ScriptExecutionContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ScriptedAnimationController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ScriptedAnimationController.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/SecurityPolicyViolationEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/SelectorQuery.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/SelectorQuery.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ShadowRoot.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ShadowRoot.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/SimulatedClick.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/SlotAssignment.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/SlotAssignment.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/SpaceSplitString.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/SpaceSplitString.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/SpectreGadget.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/SpectreGadget.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/StaticNodeList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/StaticNodeList.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/StaticRange.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/StaticRange.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/StaticRange.idl ! modules/javafx.web/src/main/native/Source/WebCore/dom/StyledElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/StyledElement.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/TagCollection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/TagCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/Text.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/TextDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/TextDecoder.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/TextEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/TextEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/TouchEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/TouchEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/TransitionEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/TransitionEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/TreeScope.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/TreeScope.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/TreeScopeOrderedMap.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/TreeScopeOrderedMap.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/TreeWalker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/TreeWalker.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/UIEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/UIEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/UIEventWithKeyState.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/UserGestureIndicator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/UserGestureIndicator.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/ViewportArguments.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/ViewportArguments.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/VisitedLinkState.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/WebKitAnimationEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/WebKitAnimationEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/WebKitTransitionEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/WebKitTransitionEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/WheelEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/WheelEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/XMLDocument.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/make_names.pl ! modules/javafx.web/src/main/native/Source/WebCore/dom/messageports/MessagePortChannel.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/messageports/MessagePortChannel.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/messageports/MessagePortChannelProvider.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/dom/messageports/MessagePortChannelRegistry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/dom/messageports/MessagePortChannelRegistry.h ! modules/javafx.web/src/main/native/Source/WebCore/domjit/DOMJITHelpers.h ! modules/javafx.web/src/main/native/Source/WebCore/domjit/DOMJITIDLConvert.h ! modules/javafx.web/src/main/native/Source/WebCore/domjit/DOMJITIDLType.h ! modules/javafx.web/src/main/native/Source/WebCore/domjit/DOMJITIDLTypeFilter.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/ApplyBlockElementCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/ApplyBlockElementCommand.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/BreakBlockquoteCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/ChangeListTypeCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/ChangeListTypeCommand.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/CompositeEditCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/CompositeEditCommand.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/DeleteSelectionCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/DeleteSelectionCommand.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/DictionaryPopupInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/EditAction.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/EditAction.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/EditCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/Editing.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/Editing.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/EditingBehavior.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/EditingStyle.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/EditingStyle.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/Editor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/Editor.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/EditorCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/FontAttributes.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/FrameSelection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/FrameSelection.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/InsertEditableImageCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/InsertTextCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/MarkupAccumulator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/MarkupAccumulator.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/ReplaceRangeWithTextCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/ReplaceSelectionCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/ReplaceSelectionCommand.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/SelectionRectGatherer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/SetNodeAttributeCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/SetNodeAttributeCommand.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/SpellingCorrectionCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/SplitElementCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/TextCheckingHelper.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/TextCheckingHelper.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/TextGranularity.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/TextIterator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/TextIterator.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/TypingCommand.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/VisibleSelection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/VisibleUnits.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/VisibleUnits.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/WebContentReader.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/WebCorePasteboardFileReader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/WebCorePasteboardFileReader.h ! modules/javafx.web/src/main/native/Source/WebCore/editing/atk/FrameSelectionAtk.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/markup.cpp ! modules/javafx.web/src/main/native/Source/WebCore/editing/markup.h ! modules/javafx.web/src/main/native/Source/WebCore/features.json ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/AsyncFileStream.cpp ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/Blob.cpp ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/Blob.h ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/Blob.idl ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/File.cpp ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/File.h ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/File.idl + modules/javafx.web/src/main/native/Source/WebCore/fileapi/FileCocoa.mm ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/FileList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/FileList.h ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/FileReader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/FileReader.h ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/FileReaderLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/FileReaderLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/ThreadableBlobRegistry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/fileapi/ThreadableBlobRegistry.h - modules/javafx.web/src/main/native/Source/WebCore/history/BackForwardList.cpp - modules/javafx.web/src/main/native/Source/WebCore/history/BackForwardList.h ! modules/javafx.web/src/main/native/Source/WebCore/history/CachedFrame.cpp ! modules/javafx.web/src/main/native/Source/WebCore/history/CachedPage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/history/PageCache.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/Autocapitalize.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/Autocapitalize.h ! modules/javafx.web/src/main/native/Source/WebCore/html/Autofill.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/Autofill.h ! modules/javafx.web/src/main/native/Source/WebCore/html/BaseCheckableInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/BaseCheckableInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/BaseClickableWithKeyInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/BaseClickableWithKeyInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/BaseTextInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/ButtonInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/ButtonInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/CachedHTMLCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/html/CanvasBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/CheckboxInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/CheckboxInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/ColorInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/ColorInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/DOMFormData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/DOMFormData.h ! modules/javafx.web/src/main/native/Source/WebCore/html/DOMTokenList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/DOMTokenList.h ! modules/javafx.web/src/main/native/Source/WebCore/html/DOMURL.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/DateInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/DateInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/DateTimeInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/DateTimeInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/DateTimeLocalInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/DateTimeLocalInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/EmailInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/EmailInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/FTPDirectoryDocument.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/FTPDirectoryDocument.h + modules/javafx.web/src/main/native/Source/WebCore/html/FeaturePolicy.cpp + modules/javafx.web/src/main/native/Source/WebCore/html/FeaturePolicy.h ! modules/javafx.web/src/main/native/Source/WebCore/html/FileInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/FileInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/FileListCreator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/FileListCreator.h ! modules/javafx.web/src/main/native/Source/WebCore/html/FormAssociatedElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/FormAssociatedElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/FormController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/FormController.h ! modules/javafx.web/src/main/native/Source/WebCore/html/GenericCachedHTMLCollection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/GenericCachedHTMLCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAllCollection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAllCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAnchorElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAnchorElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAppletElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAppletElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAreaElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAreaElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAttachmentElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAttachmentElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAttributeNames.in ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAudioElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAudioElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLAudioElement.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLBRElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLBRElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLBaseElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLBaseElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLBodyElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLBodyElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLButtonElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLButtonElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLCanvasElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLCanvasElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLCanvasElement.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLCollection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLDetailsElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLDetailsElement.h + modules/javafx.web/src/main/native/Source/WebCore/html/HTMLDialogElement.cpp + modules/javafx.web/src/main/native/Source/WebCore/html/HTMLDialogElement.h + modules/javafx.web/src/main/native/Source/WebCore/html/HTMLDialogElement.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLDivElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLDivElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLDocument.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLDocument.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLElement.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLEmbedElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLEmbedElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFieldSetElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFieldSetElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFontElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFontElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFormControlElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFormControlElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFormControlsCollection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFormControlsCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFormElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFormElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFrameElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFrameElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFrameElementBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFrameElementBase.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFrameOwnerElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFrameOwnerElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFrameSetElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLFrameSetElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLHRElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLHRElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLHtmlElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLIFrameElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLIFrameElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLIFrameElement.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLImageElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLImageElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLImageElement.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLImageLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLImageLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLInputElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLInputElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLKeygenElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLKeygenElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLKeygenElement.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLLIElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLLIElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLLabelElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLLabelElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLLinkElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLLinkElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLLinkElement.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMapElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMapElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMarqueeElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMarqueeElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMediaElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMediaElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMenuElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMenuElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMetaElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMetaElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMeterElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLMeterElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLNameCollection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLNameCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLOListElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLOListElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLObjectElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLObjectElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLObjectElement.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLOptGroupElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLOptGroupElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLOptionElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLOptionElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLOptionsCollection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLOptionsCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLOutputElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLOutputElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLParagraphElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLParagraphElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLPictureElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLPlugInElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLPlugInElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLPlugInImageElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLPlugInImageElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLPreElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLPreElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLProgressElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLProgressElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLScriptElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLScriptElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLScriptElement.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLSelectElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLSelectElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLSlotElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLSlotElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLSourceElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLSourceElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLStyleElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLStyleElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLSummaryElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableCaptionElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableCaptionElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableCellElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableCellElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableColElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableColElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTablePartElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTablePartElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableRowElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableRowsCollection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTableRowsCollection.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTagNames.in ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTextAreaElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTextAreaElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTextFormControlElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTextFormControlElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTrackElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLTrackElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLUListElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLUListElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLVideoElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HTMLVideoElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/HiddenInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/HiddenInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/ImageBitmap.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/ImageBitmap.h ! modules/javafx.web/src/main/native/Source/WebCore/html/ImageData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/ImageDocument.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/ImageInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/ImageInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/InputMode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/InputMode.h ! modules/javafx.web/src/main/native/Source/WebCore/html/InputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/InputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/InputTypeNames.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/InputTypeNames.h ! modules/javafx.web/src/main/native/Source/WebCore/html/LabelsNodeList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/LabelsNodeList.h ! modules/javafx.web/src/main/native/Source/WebCore/html/MediaController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/MediaController.h ! modules/javafx.web/src/main/native/Source/WebCore/html/MediaDocument.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/MediaDocument.h ! modules/javafx.web/src/main/native/Source/WebCore/html/MediaElementSession.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/MediaElementSession.h ! modules/javafx.web/src/main/native/Source/WebCore/html/MediaEncryptedEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/MediaEncryptedEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/html/MonthInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/MonthInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/NumberInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/NumberInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/OffscreenCanvas.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/OffscreenCanvas.h ! modules/javafx.web/src/main/native/Source/WebCore/html/PasswordInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/PasswordInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/PluginDocument.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/PluginDocument.h ! modules/javafx.web/src/main/native/Source/WebCore/html/PublicURLManager.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/PublicURLManager.h ! modules/javafx.web/src/main/native/Source/WebCore/html/RadioInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/RadioInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/RadioNodeList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/RadioNodeList.h ! modules/javafx.web/src/main/native/Source/WebCore/html/RangeInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/RangeInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/ResetInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/ResetInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/SearchInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/SearchInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/SubmitInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/SubmitInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/TelephoneInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/TelephoneInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/TextDocument.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/TextDocument.h ! modules/javafx.web/src/main/native/Source/WebCore/html/TextFieldInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/TextFieldInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/TextInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/TextInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/TimeInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/TimeInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/URLInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/URLInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/URLRegistry.h ! modules/javafx.web/src/main/native/Source/WebCore/html/URLUtils.h ! modules/javafx.web/src/main/native/Source/WebCore/html/ValidationMessage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/WeekInputType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/WeekInputType.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/CanvasGradient.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/CanvasGradient.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/CanvasRenderingContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/CanvasRenderingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/CanvasRenderingContext2D.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h + modules/javafx.web/src/main/native/Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/ImageBitmapRenderingContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/ImageBitmapRenderingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/OESVertexArrayObject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/OESVertexArrayObject.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/PaintRenderingContext2D.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/PaintRenderingContext2D.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/Path2D.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/PlaceholderRenderingContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/PlaceholderRenderingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGL2RenderingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGL2RenderingContext.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLActiveInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLCompressedTextureASTC.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLCompressedTextureATC.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLCompressedTexturePVRTC.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLCompressedTextureS3TC.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLContextAttributes.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLContextEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLContextEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLContextGroup.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLContextObject.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLDebugRendererInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLDebugShaders.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLDepthTexture.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLDrawBuffers.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLExtension.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLFramebuffer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLFramebuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLLoseContext.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLObject.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLProgram.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLProgram.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLQuery.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLRenderbuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLRenderingContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLRenderingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLRenderingContextBase.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLSampler.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLShader.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLShaderPrecisionFormat.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLSharedObject.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLSync.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLTexture.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLTransformFeedback.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLUniformLocation.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h ! modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalBuffer.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalBuffer.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalBuffer.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalCommandBuffer.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalCommandBuffer.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalCommandBuffer.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalCommandQueue.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalCommandQueue.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalCommandQueue.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalComputeCommandEncoder.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalComputeCommandEncoder.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalComputeCommandEncoder.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalComputePipelineState.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalComputePipelineState.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalComputePipelineState.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalDepthStencilDescriptor.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalDepthStencilDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalDepthStencilDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalDepthStencilState.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalDepthStencilState.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalDepthStencilState.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalDrawable.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalDrawable.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalDrawable.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalEnums.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalEnums.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalEnums.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalFunction.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalFunction.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalFunction.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalLibrary.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalLibrary.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalLibrary.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderCommandEncoder.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderCommandEncoder.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderCommandEncoder.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassAttachmentDescriptor.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassAttachmentDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassAttachmentDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassColorAttachmentDescriptor.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassColorAttachmentDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassColorAttachmentDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassDepthAttachmentDescriptor.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassDepthAttachmentDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassDepthAttachmentDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassDescriptor.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPassDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPipelineColorAttachmentDescriptor.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPipelineColorAttachmentDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPipelineColorAttachmentDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPipelineDescriptor.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPipelineDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPipelineDescriptor.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPipelineState.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPipelineState.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderPipelineState.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderingContext.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderingContext.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalRenderingContext.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalSize.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalSize.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalTexture.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalTexture.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalTexture.idl - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalTextureDescriptor.cpp - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalTextureDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/html/canvas/WebMetalTextureDescriptor.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/AtomicHTMLToken.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/CSSPreloadScanner.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLConstructionSite.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLConstructionSite.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLDocumentParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLEntityParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLFormattingElementList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLFormattingElementList.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLParserIdioms.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLParserIdioms.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLParserOptions.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLParserOptions.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLPreloadScanner.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLResourcePreloader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLResourcePreloader.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLScriptRunner.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLScriptRunner.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLSrcsetParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLSrcsetParser.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLStackItem.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLToken.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLTokenizer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLTokenizer.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLTreeBuilder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLTreeBuilder.h ! modules/javafx.web/src/main/native/Source/WebCore/html/parser/XSSAuditor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/DataListButtonElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/DetailsMarkerControl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/MediaControlElementTypes.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/MediaControlElementTypes.h ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/MediaControlElements.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/MediaControlElements.h ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/MediaControls.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/ProgressShadowElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/SliderThumbElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/SliderThumbElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/SpinButtonElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/TextControlInnerElements.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/AudioTrack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/AudioTrack.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/AudioTrackList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/AudioTrackList.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/BufferedLineReader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/DataCue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/DataCue.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/InbandDataTextTrack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/InbandDataTextTrack.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/InbandGenericTextTrack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/InbandGenericTextTrack.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/InbandTextTrack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/InbandTextTrack.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/InbandWebVTTTextTrack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/InbandWebVTTTextTrack.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/LoadableTextTrack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/LoadableTextTrack.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TextTrack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TextTrack.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TextTrackCue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TextTrackCue.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TextTrackCueGeneric.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TextTrackCueGeneric.h + modules/javafx.web/src/main/native/Source/WebCore/html/track/TextTrackCueGeneric.idl ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TextTrackList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TextTrackList.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TrackBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TrackBase.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TrackEvent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TrackEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TrackListBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/TrackListBase.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/VTTCue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/VTTCue.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/VTTRegion.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/VTTRegion.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/VideoTrack.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/VideoTrack.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/VideoTrackList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/VideoTrackList.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/WebVTTElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/WebVTTElement.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/WebVTTParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/html/track/WebVTTParser.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/WebVTTToken.h ! modules/javafx.web/src/main/native/Source/WebCore/html/track/WebVTTTokenizer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/CommandLineAPIHost.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/CommandLineAPIHost.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/CommandLineAPIHost.idl ! modules/javafx.web/src/main/native/Source/WebCore/inspector/CommandLineAPIModuleSource.js ! modules/javafx.web/src/main/native/Source/WebCore/inspector/DOMEditor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/DOMPatchSupport.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorAuditDOMObject.cpp + modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorAuditResourcesObject.cpp + modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorAuditResourcesObject.h + modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorAuditResourcesObject.idl ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorCanvas.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorCanvas.h - modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorClient.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorClient.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorController.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorDatabaseResource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorDatabaseResource.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorFrontendClient.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorFrontendClientLocal.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorFrontendHost.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorFrontendHost.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorFrontendHost.idl ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorHistory.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorInstrumentation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorInstrumentation.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorNodeFinder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorNodeFinder.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorOverlay.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorOverlay.h - modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorOverlayPage.css - modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorOverlayPage.html - modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorOverlayPage.js ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InspectorStyleSheet.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InstrumentingAgents.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/InstrumentingAgents.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/NetworkResourcesData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/RecordingSwizzleTypes.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/WebInjectedScriptHost.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/WebInjectedScriptManager.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/WebInjectedScriptManager.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/WorkerInspectorController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorApplicationCacheAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorCPUProfilerAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorCPUProfilerAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorCSSAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorCanvasAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorDOMAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorDOMDebuggerAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorDOMDebuggerAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorDOMStorageAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorDatabaseAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorDatabaseAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorLayerTreeAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorLayerTreeAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorMemoryAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorMemoryAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorNetworkAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorPageAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorPageAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorTimelineAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorWorkerAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/InspectorWorkerAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/WebConsoleAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/WebConsoleAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/WebDebuggerAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/WebDebuggerAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/WebHeapAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/WebHeapAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageAuditAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageAuditAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageConsoleAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageDebuggerAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageDebuggerAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageHeapAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageHeapAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageNetworkAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageNetworkAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/page/PageRuntimeAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/ServiceWorkerAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/ServiceWorkerAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/WorkerAuditAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/WorkerAuditAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/WorkerConsoleAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/WorkerConsoleAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/WorkerDebuggerAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/WorkerDebuggerAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/WorkerNetworkAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/WorkerNetworkAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/WorkerRuntimeAgent.cpp ! modules/javafx.web/src/main/native/Source/WebCore/inspector/agents/worker/WorkerRuntimeAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/FormattingContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/FormattingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/FormattingContextGeometry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/FormattingContextQuirks.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/FormattingState.h + modules/javafx.web/src/main/native/Source/WebCore/layout/LayoutPhase.cpp + modules/javafx.web/src/main/native/Source/WebCore/layout/LayoutPhase.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/LayoutState.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/LayoutState.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/LayoutUnits.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/Verification.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/blockformatting/BlockFormattingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/displaytree/DisplayBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/displaytree/DisplayBox.h + modules/javafx.web/src/main/native/Source/WebCore/layout/displaytree/DisplayRect.h + modules/javafx.web/src/main/native/Source/WebCore/layout/displaytree/DisplayRun.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/floats/FloatAvoider.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/floats/FloatAvoider.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/floats/FloatBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/floats/FloatBox.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/floats/FloatingContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/floats/FloatingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/floats/FloatingState.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/floats/FloatingState.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineFormattingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp + modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineFormattingContextQuirks.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineFormattingState.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineItem.h + modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineLine.cpp + modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineLine.h + modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineLineBox.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineLineBreaker.h - modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineRun.h - modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineRunProvider.cpp - modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineRunProvider.h + modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineTextItem.cpp + modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/InlineTextItem.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/text/TextUtil.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/inlineformatting/text/TextUtil.h - modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutBlockContainer.cpp - modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutBlockContainer.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutBox.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutContainer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutContainer.h - modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutInlineBox.cpp - modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutInlineBox.h - modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutInlineContainer.cpp - modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutInlineContainer.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutIterator.h - modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutLineBreakBox.cpp - modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutLineBreakBox.h ! modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutReplaced.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/layout/layouttree/LayoutTreeBuilder.h + modules/javafx.web/src/main/native/Source/WebCore/layout/tableformatting/TableFormattingContext.cpp + modules/javafx.web/src/main/native/Source/WebCore/layout/tableformatting/TableFormattingContext.h + modules/javafx.web/src/main/native/Source/WebCore/layout/tableformatting/TableFormattingContextGeometry.cpp + modules/javafx.web/src/main/native/Source/WebCore/layout/tableformatting/TableFormattingState.cpp + modules/javafx.web/src/main/native/Source/WebCore/layout/tableformatting/TableFormattingState.h + modules/javafx.web/src/main/native/Source/WebCore/layout/tableformatting/TableGrid.cpp + modules/javafx.web/src/main/native/Source/WebCore/layout/tableformatting/TableGrid.h + modules/javafx.web/src/main/native/Source/WebCore/layout/tableformatting/TableInvalidation.cpp + modules/javafx.web/src/main/native/Source/WebCore/layout/tableformatting/TableInvalidation.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/AdClickAttribution.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/AdClickAttribution.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/ApplicationManifestLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ContentFilter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ContentFilter.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/CookieJar.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/CookieJar.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/CrossOriginAccessControl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/CrossOriginAccessControl.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/CrossOriginPreflightResultCache.h + modules/javafx.web/src/main/native/Source/WebCore/loader/CustomHeaderFields.cpp + modules/javafx.web/src/main/native/Source/WebCore/loader/CustomHeaderFields.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/DocumentLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/DocumentLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/DocumentThreadableLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/DocumentWriter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/DocumentWriter.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/EmptyClients.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/EmptyClients.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/EmptyFrameLoaderClient.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/FetchOptions.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/FormSubmission.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/FrameLoadRequest.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/FrameLoadRequest.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/FrameLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/FrameLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/FrameLoaderClient.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/FrameLoaderStateMachine.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/FrameLoaderTypes.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/HistoryController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ImageLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ImageLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/LinkHeader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/LinkHeader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/LinkLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/LinkLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/LoadTiming.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/LoaderStrategy.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/MediaResourceLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/MediaResourceLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/NavigationAction.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/NavigationAction.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/NavigationDisabler.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/NavigationScheduler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/NavigationScheduler.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/NetscapePlugInStreamLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/NetscapePlugInStreamLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/PingLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/PingLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/PolicyChecker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ProgressTracker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceCryptographicDigest.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceCryptographicDigest.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceLoadInfo.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceLoadInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceLoadNotifier.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceLoadObserver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceLoadObserver.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceLoadStatistics.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceLoadStatistics.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceTimingInformation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ResourceTimingInformation.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/SinkDocument.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/SinkDocument.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/SubframeLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/SubframeLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/SubresourceLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/SubresourceLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/TextResourceDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/TextTrackLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/ThreadableLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/WorkerThreadableLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/appcache/ApplicationCacheGroup.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/appcache/ApplicationCacheHost.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/appcache/ApplicationCacheHost.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/appcache/DOMApplicationCache.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/appcache/DOMApplicationCache.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/appcache/DOMApplicationCache.idl ! modules/javafx.web/src/main/native/Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/archive/mhtml/MHTMLParser.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedFont.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedFont.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedImage.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedRawResource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedResource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedResource.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedResourceLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedResourceLoader.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedResourceRequest.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedResourceRequest.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedResourceRequestInitiators.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedResourceRequestInitiators.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedSVGDocument.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedSVGDocumentReference.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedSVGFont.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedSVGFont.h ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/KeepaliveRequestTracker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/cache/MemoryCache.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/icon/IconLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/loader/soup/ResourceLoaderSoup.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mapfile-macosx ! modules/javafx.web/src/main/native/Source/WebCore/mapfile-vers ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLAnnotationElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLAnnotationElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLFractionElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLFractionElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLMathElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLMathElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLMencloseElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLMencloseElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLOperatorDictionary.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLOperatorDictionary.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLOperatorElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLOperatorElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLPaddedElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLPaddedElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLPresentationElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLPresentationElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLScriptsElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLScriptsElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLSelectElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLSelectElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLSpaceElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLSpaceElement.h ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLTokenElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLUnderOverElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/mathml/MathMLUnderOverElement.h ! modules/javafx.web/src/main/native/Source/WebCore/page/AbstractDOMWindow.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/AbstractDOMWindow.h ! modules/javafx.web/src/main/native/Source/WebCore/page/AutoscrollController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/BarProp.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/BarProp.h ! modules/javafx.web/src/main/native/Source/WebCore/page/BarProp.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/CacheStorageProvider.h ! modules/javafx.web/src/main/native/Source/WebCore/page/CaptionUserPreferences.h ! modules/javafx.web/src/main/native/Source/WebCore/page/Chrome.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Chrome.h ! modules/javafx.web/src/main/native/Source/WebCore/page/ChromeClient.h ! modules/javafx.web/src/main/native/Source/WebCore/page/ClientOrigin.h ! modules/javafx.web/src/main/native/Source/WebCore/page/ContextMenuClient.h ! modules/javafx.web/src/main/native/Source/WebCore/page/ContextMenuController.cpp + modules/javafx.web/src/main/native/Source/WebCore/page/CrossSiteNavigationDataTransfer.h ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMSelection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMSelection.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMTimer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMTimer.h ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.h ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindowExtension.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindowExtension.h ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindowProperty.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindowProperty.h ! modules/javafx.web/src/main/native/Source/WebCore/page/DebugPageOverlays.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/DeviceController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/DeviceController.h ! modules/javafx.web/src/main/native/Source/WebCore/page/DiagnosticLoggingClient.h ! modules/javafx.web/src/main/native/Source/WebCore/page/DragController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/DragController.h ! modules/javafx.web/src/main/native/Source/WebCore/page/EditorClient.h ! modules/javafx.web/src/main/native/Source/WebCore/page/EventHandler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/EventHandler.h ! modules/javafx.web/src/main/native/Source/WebCore/page/EventSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/EventSource.h ! modules/javafx.web/src/main/native/Source/WebCore/page/FocusController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/FocusController.h ! modules/javafx.web/src/main/native/Source/WebCore/page/Frame.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Frame.h + modules/javafx.web/src/main/native/Source/WebCore/page/FrameIdentifier.h ! modules/javafx.web/src/main/native/Source/WebCore/page/FrameSnapshotting.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/FrameSnapshotting.h ! modules/javafx.web/src/main/native/Source/WebCore/page/FrameTree.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/FrameTree.h ! modules/javafx.web/src/main/native/Source/WebCore/page/FrameView.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/FrameView.h ! modules/javafx.web/src/main/native/Source/WebCore/page/FrameViewLayoutContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/FrameViewLayoutContext.h ! modules/javafx.web/src/main/native/Source/WebCore/page/GlobalFrameIdentifier.h ! modules/javafx.web/src/main/native/Source/WebCore/page/History.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/History.h ! modules/javafx.web/src/main/native/Source/WebCore/page/History.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/IntersectionObserver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Location.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Location.h ! modules/javafx.web/src/main/native/Source/WebCore/page/Location.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/MediaProducer.h ! modules/javafx.web/src/main/native/Source/WebCore/page/MemoryRelease.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/MemoryRelease.h ! modules/javafx.web/src/main/native/Source/WebCore/page/Navigator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Navigator.h ! modules/javafx.web/src/main/native/Source/WebCore/page/Navigator.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/NavigatorBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/NavigatorBase.h ! modules/javafx.web/src/main/native/Source/WebCore/page/Page.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Page.h ! modules/javafx.web/src/main/native/Source/WebCore/page/PageConfiguration.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PageConfiguration.h ! modules/javafx.web/src/main/native/Source/WebCore/page/PageConsoleClient.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PageConsoleClient.h ! modules/javafx.web/src/main/native/Source/WebCore/page/PageGroup.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PageGroup.h + modules/javafx.web/src/main/native/Source/WebCore/page/PageIdentifier.h ! modules/javafx.web/src/main/native/Source/WebCore/page/PageOverlayController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PageOverlayController.h ! modules/javafx.web/src/main/native/Source/WebCore/page/Performance.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Performance.h ! modules/javafx.web/src/main/native/Source/WebCore/page/PerformanceEntry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PerformanceEntry.h ! modules/javafx.web/src/main/native/Source/WebCore/page/PerformanceMonitor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PerformanceNavigation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PerformanceNavigation.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/PerformanceResourceTiming.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PerformanceResourceTiming.h ! modules/javafx.web/src/main/native/Source/WebCore/page/PerformanceTiming.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/PerformanceUserTiming.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PointerCaptureController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PointerCaptureController.h ! modules/javafx.web/src/main/native/Source/WebCore/page/PointerLockController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PointerLockController.h ! modules/javafx.web/src/main/native/Source/WebCore/page/PrewarmInformation.h ! modules/javafx.web/src/main/native/Source/WebCore/page/PrintContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/PrintContext.h ! modules/javafx.web/src/main/native/Source/WebCore/page/ProcessWarming.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Quirks.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Quirks.h ! modules/javafx.web/src/main/native/Source/WebCore/page/RemoteDOMWindow.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/RemoteDOMWindow.h + modules/javafx.web/src/main/native/Source/WebCore/page/RenderingUpdateScheduler.cpp + modules/javafx.web/src/main/native/Source/WebCore/page/RenderingUpdateScheduler.h + modules/javafx.web/src/main/native/Source/WebCore/page/ResizeObservation.cpp + modules/javafx.web/src/main/native/Source/WebCore/page/ResizeObservation.h + modules/javafx.web/src/main/native/Source/WebCore/page/ResizeObserver.cpp + modules/javafx.web/src/main/native/Source/WebCore/page/ResizeObserver.h + modules/javafx.web/src/main/native/Source/WebCore/page/ResizeObserver.idl + modules/javafx.web/src/main/native/Source/WebCore/page/ResizeObserverCallback.h + modules/javafx.web/src/main/native/Source/WebCore/page/ResizeObserverCallback.idl + modules/javafx.web/src/main/native/Source/WebCore/page/ResizeObserverEntry.h + modules/javafx.web/src/main/native/Source/WebCore/page/ResizeObserverEntry.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/ResourceUsageData.h ! modules/javafx.web/src/main/native/Source/WebCore/page/ResourceUsageOverlay.h ! modules/javafx.web/src/main/native/Source/WebCore/page/ResourceUsageThread.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/ResourceUsageThread.h ! modules/javafx.web/src/main/native/Source/WebCore/page/RuntimeEnabledFeatures.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/RuntimeEnabledFeatures.h ! modules/javafx.web/src/main/native/Source/WebCore/page/Screen.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Screen.h ! modules/javafx.web/src/main/native/Source/WebCore/page/Screen.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/SecurityOrigin.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/SecurityOrigin.h ! modules/javafx.web/src/main/native/Source/WebCore/page/SecurityPolicy.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/Settings.yaml ! modules/javafx.web/src/main/native/Source/WebCore/page/SettingsBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/SettingsBase.h ! modules/javafx.web/src/main/native/Source/WebCore/page/SettingsDefaultValues.h ! modules/javafx.web/src/main/native/Source/WebCore/page/SocketProvider.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/SocketProvider.h ! modules/javafx.web/src/main/native/Source/WebCore/page/SpatialNavigation.cpp + modules/javafx.web/src/main/native/Source/WebCore/page/SpeechSynthesisClient.h ! modules/javafx.web/src/main/native/Source/WebCore/page/SuspendableTimer.h ! modules/javafx.web/src/main/native/Source/WebCore/page/TextIndicator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/UndoItem.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/UndoItem.h ! modules/javafx.web/src/main/native/Source/WebCore/page/UndoManager.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/UserContentController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/UserContentProvider.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/UserContentProvider.h ! modules/javafx.web/src/main/native/Source/WebCore/page/UserMessageHandlerDescriptor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/UserMessageHandlerDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/page/UserMessageHandlerDescriptorTypes.h ! modules/javafx.web/src/main/native/Source/WebCore/page/UserMessageHandlersNamespace.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/UserMessageHandlersNamespace.h ! modules/javafx.web/src/main/native/Source/WebCore/page/ViewportConfiguration.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/ViewportConfiguration.h ! modules/javafx.web/src/main/native/Source/WebCore/page/VisitedLinkStore.h ! modules/javafx.web/src/main/native/Source/WebCore/page/VisualViewport.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/VisualViewport.h ! modules/javafx.web/src/main/native/Source/WebCore/page/VisualViewport.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/WheelEventDeltaFilter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/WindowEventHandlers.idl ! modules/javafx.web/src/main/native/Source/WebCore/page/WindowFeatures.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/WindowFeatures.h ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/AnimationBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/AnimationBase.h ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/CSSAnimationController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/CSSAnimationController.h ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/CSSAnimationControllerPrivate.h ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/CSSPropertyAnimation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/CompositeAnimation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/CompositeAnimation.h ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/ImplicitAnimation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/ImplicitAnimation.h ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/KeyframeAnimation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/animation/KeyframeAnimation.h ! modules/javafx.web/src/main/native/Source/WebCore/page/csp/ContentSecurityPolicy.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/csp/ContentSecurityPolicy.h ! modules/javafx.web/src/main/native/Source/WebCore/page/csp/ContentSecurityPolicyDirective.h ! modules/javafx.web/src/main/native/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.h ! modules/javafx.web/src/main/native/Source/WebCore/page/linux/ResourceUsageOverlayLinux.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingConstraints.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingConstraints.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingCoordinator.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingMomentumCalculator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingMomentumCalculator.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateFixedNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateNode.h + modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp + modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.h + modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStatePositionedNode.cpp + modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStatePositionedNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateStickyNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateTree.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingStateTree.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTree.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTree.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeFrameHostingNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeFrameHostingNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeNode.h + modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollProxyNode.cpp + modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollProxyNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollingNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollingNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ScrollingTreeScrollingNodeDelegate.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/ThreadedScrollingTree.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFixedNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFixedNode.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNode.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/CPUMonitor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/Cairo.cmake ! modules/javafx.web/src/main/native/Source/WebCore/platform/ColorData.gperf ! modules/javafx.web/src/main/native/Source/WebCore/platform/ContentFilterUnblockHandler.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ContextMenuItem.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/Cookie.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/CountedUserActivity.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/Curl.cmake ! modules/javafx.web/src/main/native/Source/WebCore/platform/DateTimeChooser.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/Decimal.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/DragImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/DragImage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/EventTrackingRegions.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/EventTrackingRegions.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/FileMonitor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/FreeType.cmake ! modules/javafx.web/src/main/native/Source/WebCore/platform/GStreamer.cmake ! modules/javafx.web/src/main/native/Source/WebCore/platform/GenericTaskQueue.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/HolePunch.cmake ! modules/javafx.web/src/main/native/Source/WebCore/platform/HostWindow.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ImageDecoders.cmake ! modules/javafx.web/src/main/native/Source/WebCore/platform/LayoutUnit.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/Length.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/Length.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/LocalizedStrings.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/LocalizedStrings.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/Logging.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/Logging.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/MIMETypeRegistry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/MainThreadSharedTimer.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/MediaCapabilitiesDecodingInfo.h + modules/javafx.web/src/main/native/Source/WebCore/platform/MediaCapabilitiesEncodingInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/MediaDescription.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/MediaSample.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/Pasteboard.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/PasteboardItemInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/PasteboardStrategy.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/PasteboardWriterData.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/PlatformKeyboardEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/PlatformMouseEvent.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/PlatformPasteboard.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/PlatformScreen.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/PlatformSpeechSynthesisUtterance.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/PlatformSpeechSynthesizer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/PlatformWheelEvent.h + modules/javafx.web/src/main/native/Source/WebCore/platform/PointerID.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ReferrerPolicy.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/ReferrerPolicy.h + modules/javafx.web/src/main/native/Source/WebCore/platform/RegistrableDomain.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/RemoteCommandListener.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/RuntimeApplicationChecks.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ScreenProperties.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollAnimation.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollAnimator.cpp - modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollAnimatorNone.cpp - modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollAnimatorSmooth.cpp - modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollAnimatorSmooth.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollTypes.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollView.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollView.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollableArea.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollableArea.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/Scrollbar.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/Scrollbar.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ScrollbarThemeComposite.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/SearchPopupMenu.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/SharedBuffer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/SharedStringHash.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/SharedStringHash.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/SourcesGLib.txt ! modules/javafx.web/src/main/native/Source/WebCore/platform/SourcesSoup.txt ! modules/javafx.web/src/main/native/Source/WebCore/platform/SuddenTermination.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/TextureMapper.cmake ! modules/javafx.web/src/main/native/Source/WebCore/platform/Theme.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/Theme.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/ThreadGlobalData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/Timer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/Timer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/TouchAction.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/UserAgent.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/UserAgentQuirks.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/WebGLStateTracker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/WebGLStateTracker.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/Widget.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/Widget.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/animation/AnimationUtilities.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/animation/TimingFunction.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/AudioBus.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/AudioBus.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/AudioChannel.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/AudioFIFO.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/AudioPullFIFO.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/AudioResampler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/AudioResampler.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/AudioResamplerKernel.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/AudioSession.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/AudioSession.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/Biquad.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/Cone.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/DenormalDisabler.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/DirectConvolver.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/Distance.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/DownSampler.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/DynamicsCompressor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/DynamicsCompressor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/DynamicsCompressorKernel.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/EqualPowerPanner.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/FFTConvolver.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/FFTFrame.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/HRTFDatabase.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/HRTFDatabaseLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/HRTFElevation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/HRTFElevation.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/HRTFKernel.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/HRTFPanner.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/MultiChannelResampler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/MultiChannelResampler.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/Panner.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/PlatformAudioData.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/PlatformMediaSession.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/PlatformMediaSession.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/PlatformMediaSessionManager.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/Reverb.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/Reverb.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/ReverbAccumulationBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/ReverbConvolver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/ReverbConvolver.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/ReverbConvolverStage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/ReverbConvolverStage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/ReverbInputBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/SincResampler.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/SincResampler.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/UpSampler.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/audio/ZeroPole.h + modules/javafx.web/src/main/native/Source/WebCore/platform/cf/KeyedDecoderCF.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/cf/KeyedDecoderCF.h + modules/javafx.web/src/main/native/Source/WebCore/platform/cf/KeyedEncoderCF.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/cf/KeyedEncoderCF.h + modules/javafx.web/src/main/native/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/cf/MediaAccessibilitySoftLink.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/cf/MediaAccessibilitySoftLink.h + modules/javafx.web/src/main/native/Source/WebCore/platform/cf/RunLoopObserver.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/cf/RunLoopObserver.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/encryptedmedia/CDMInstance.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/encryptedmedia/CDMInstanceSession.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/encryptedmedia/CDMPrivate.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/generic/KeyedDecoderGeneric.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/generic/KeyedDecoderGeneric.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/generic/KeyedEncoderGeneric.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/generic/KeyedEncoderGeneric.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/generic/ScrollAnimatorGeneric.cpp - modules/javafx.web/src/main/native/Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.cpp - modules/javafx.web/src/main/native/Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.h - modules/javafx.web/src/main/native/Source/WebCore/platform/geoclue/GeolocationProviderGeoclueClient.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/BitmapImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/BitmapImage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/Color.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/Color.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ColorUtilities.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ColorUtilities.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ComplexTextController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/CustomPaintImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/CustomPaintImage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ExtendedColor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FloatPoint.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FloatPoint3D.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FloatPolygon.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/Font.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/Font.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontCache.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontCache.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontCascade.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontCascade.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontCascadeDescription.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontCascadeDescription.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontCascadeFonts.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontDescription.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontDescription.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontFamilySpecificationNull.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontGenericFamilies.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontGenericFamilies.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontPlatformData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontPlatformData.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontSelector.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FontTaggedSettings.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/FourCC.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GLContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GLContext.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GeneratedImage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GlyphBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GlyphMetricsMap.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GradientImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GradientImage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsContext.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsContext.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsContext3D.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsContext3DAttributes.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsContext3DManager.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsContextImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsContextImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsLayer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsLayer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/GraphicsLayerClient.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/HEVCUtilities.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/Image.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/Image.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageBackingStore.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageBuffer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageFrame.h - modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageFrameCache.cpp - modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageOrientation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageOrientation.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ImagePaintingOptions.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/InbandTextTrackPrivate.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/IntSize.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/IntSize.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/LayoutPoint.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/LayoutRect.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/LayoutSize.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/LegacyCDMSession.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/MediaPlayer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/MediaPlayer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/MediaPlayerEnums.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/MediaPlayerPrivate.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/NamedImageGeneratedImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/NamedImageGeneratedImage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/NativeImage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/OpenGLShims.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/PathUtilities.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/Pattern.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/PlatformDisplay.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/PlatformDisplay.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/Region.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/Region.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/RemoteVideoSample.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/RoundedRect.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/RoundedRect.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ShadowBlur.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/ShadowBlur.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/SourceBufferPrivate.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/SourceBufferPrivateClient.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/TabSize.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/TextRun.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/TextRun.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/TextTrackRepresentation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/TiledBacking.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/TrackPrivateBase.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/VelocityData.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/VelocityData.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/WidthIterator.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/cv/TextureCacheCV.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/cv/TextureCacheCV.mm ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/egl/GLContextEGL.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/egl/GLContextEGLLibWPE.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/filters/FEBlend.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/filters/FEComposite.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/filters/FilterOperation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/filters/SourceAlpha.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/filters/SourceAlpha.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/filters/SourceGraphic.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/filters/SourceGraphic.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBindGroup.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBindGroupAllocator.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBindGroupBinding.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBindGroupDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBindGroupLayout.h - modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBindGroupLayoutBinding.h - modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBindGroupLayoutDescriptor.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBlendDescriptor.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBuffer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBufferBinding.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBufferDescriptor.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUBufferUsage.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUColorStateDescriptor.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUColorWriteBits.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUCommandBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUCompareFunction.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUComputePassEncoder.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUComputePipeline.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUComputePipelineDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUDevice.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUDevice.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUError.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUError.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUErrorFilter.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUErrorScopes.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUErrorScopes.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUExtent3D.h - modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUInputStateDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPULimits.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPULoadOp.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUObjectBase.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUOutOfMemoryError.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUPipelineDescriptorBase.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUPipelineLayout.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUPipelineLayout.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUPipelineLayoutDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUPipelineStageDescriptor.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUQueue.h - modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPURenderPassColorAttachmentDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPURenderPassDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPURenderPassEncoder.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPURenderPipeline.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPURenderPipelineDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPURequestAdapterOptions.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUSampler.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUSamplerDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUShaderModule.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUStoreOp.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUSwapChain.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUSwapChainDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUTexture.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUTextureDescriptor.h - modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUTextureDimension.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUTextureFormat.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUTextureUsage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUUtils.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUValidationError.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUValidationError.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUVertexAttributeDescriptor.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUVertexBufferDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/GPUVertexInputDescriptor.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/gpu/Texture.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOBox.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOSchemeInformationBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOSchemeInformationBox.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOSchemeTypeBox.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/iso/ISOVTTCue.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/BufferImageJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/BufferImageJava.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/FontCacheJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/FontCustomPlatformData.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/FontPlatformDataJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/ImageBufferJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/ImageDecoderJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/NativeImageJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/PathJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/NicosiaAnimation.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/NicosiaAnimation.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingOperation.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.h + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaBackingStoreTextureMapperImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaBackingStoreTextureMapperImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaContentLayerTextureMapperImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaContentLayerTextureMapperImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGC3DLayer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaImageBackingTextureMapperImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaImageBackingTextureMapperImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/opentype/OpenTypeUtilities.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h - modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp - modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperGLHeaders.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/coordinated/Tile.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/transforms/AffineTransform.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/transforms/AffineTransform.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/transforms/TransformOperations.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/transforms/TransformState.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/transforms/TransformState.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/ScalableImageDecoder.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/ScalableImageDecoderFrame.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/bmp/BMPImageDecoder.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/bmp/BMPImageReader.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/gif/GIFImageReader.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/jpeg2000/JPEG2000ImageDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/png/PNGImageDecoder.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/java/DragImageJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/java/LocalizedStringsJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/java/PasteboardJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/java/RenderThemeJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/java/TextBreakIteratorJava.cpp = modules/javafx.web/src/main/native/Source/WebCore/platform/java/WebKitLogging.cpp = modules/javafx.web/src/main/native/Source/WebCore/platform/java/WebKitLogging.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/java/WidgetJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/libwpe/PasteboardLibWPE.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/libwpe/PlatformKeyboardEventLibWPE.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediacapabilities/AudioConfiguration.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediacapabilities/MediaEngineConfigurationFactory.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediacapabilities/MediaEngineConfigurationFactory.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediacapabilities/VideoConfiguration.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/CaptureDeviceManager.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/CaptureDeviceManager.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/MediaConstraints.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/MediaConstraints.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/MediaStreamPrivate.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/MediaStreamRequest.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h + modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RTCDTMFSenderBackend.h - modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RTCDTMFSenderHandler.h - modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RTCDTMFSenderHandlerClient.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeMediaSource.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeMediaSourceFactory.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h + modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/RealtimeVideoSource.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/VideoPreset.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/VideoTrackPrivateMediaStream.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.h + modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDTMFSenderBackend.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDTMFSenderBackend.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderGStreamer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/GeolocationClientMock.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/GeolocationClientMock.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/MediaEngineConfigurationFactoryMock.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/MediaEngineConfigurationFactoryMock.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/MediaPlaybackTargetPickerMock.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/MockRealtimeAudioSource.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/MockRealtimeVideoSource.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/PlatformSpeechSynthesizerMock.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/RTCDataChannelHandlerMock.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/RTCNotifiersMock.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/mediasource/MockBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/mock/mediasource/MockTracks.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/BlobRegistry.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/BlobRegistryImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/BlobRegistryImpl.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/BlobResourceHandle.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/CacheValidation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/CacheValidation.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/CookieRequestHeaderFieldProxy.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/CredentialStorage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/CredentialStorage.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/DNSResolveQueue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/DataURLDecoder.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/DataURLDecoder.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/FormData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/FormData.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/HTTPHeaderMap.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/HTTPHeaderMap.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/HTTPParsers.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/HTTPParsers.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/MIMEHeader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/NetworkStateNotifier.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/NetworkStorageSession.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/NetworkStorageSession.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/ParsedContentType.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/ParsedContentType.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/ResourceErrorBase.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/ResourceHandle.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/ResourceHandle.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/ResourceRequestBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/ResourceRequestBase.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/ResourceResponseBase.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/SocketStreamHandle.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/SocketStreamHandle.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/SocketStreamHandleImpl.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/StoredCredentialsPolicy.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/java/NetworkStorageSessionJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/soup/PublicSuffixSoup.cpp - modules/javafx.web/src/main/native/Source/WebCore/platform/soup/URLSoup.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/sql/SQLiteDatabase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/sql/SQLiteDatabase.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/sql/SQLiteDatabaseTracker.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/sql/SQLiteFileSystem.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/sql/SQLiteFileSystem.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/sql/SQLiteStatement.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/BidiResolver.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/Hyphenation.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/Hyphenation.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/LocaleICU.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/LocaleNone.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/PlatformLocale.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/SegmentedString.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/TextCodecICU.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/TextCodecICU.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/TextCodecLatin1.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/TextCodecReplacement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/TextCodecUTF16.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/TextCodecUTF8.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/TextCodecUserDefined.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/TextEncoding.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/TextEncodingRegistry.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp - modules/javafx.web/src/main/native/Source/WebCore/platform/text/icu/UTextProvider.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/vr/openvr/VRPlatformDisplayOpenVR.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/vr/openvr/VRPlatformManagerOpenVR.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/vr/openvr/VRPlatformManagerOpenVR.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/BString.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/BString.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/BitmapInfo.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/BitmapInfo.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/COMPtr.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/ClipboardUtilitiesWin.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/CursorWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/DefWndProcWindowClass.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/DefWndProcWindowClass.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/DelayLoadedModulesEnumerator.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/DelayLoadedModulesEnumerator.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/DragDataWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/DragImageCGWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/DragImageCairoWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/DragImageDirect2D.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/DragImageWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/EventLoopWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/GDIObjectCounter.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/GDIObjectCounter.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/GDIUtilities.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/GDIUtilities.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/HWndDC.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/ImportedFunctionsEnumerator.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/ImportedFunctionsEnumerator.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/ImportedModulesEnumerator.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/ImportedModulesEnumerator.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/ImportedModulesEnumeratorBase.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/KeyEventWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/LocalizedStringsWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/LoggingWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/MIMETypeRegistryWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/MainThreadSharedTimerWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/PEImage.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/PEImage.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/PasteboardWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/PlatformMouseEventWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/PlatformScreenWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/PopupMenuWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/PopupMenuWin.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/SSLKeyGeneratorWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/ScrollbarThemeWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/ScrollbarThemeWin.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/SearchPopupMenuDB.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/SearchPopupMenuDB.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/SearchPopupMenuWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/SearchPopupMenuWin.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/SharedBufferWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/TemporaryLinkStubs.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/UserAgentWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WCDataObject.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WCDataObject.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WebCoreBundleWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WebCoreBundleWin.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WebCoreInstanceHandle.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WebCoreInstanceHandle.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WebCoreTextRenderer.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WebCoreTextRenderer.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WheelEventWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WidgetWin.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WindowMessageBroadcaster.cpp + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WindowMessageBroadcaster.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WindowMessageListener.h + modules/javafx.web/src/main/native/Source/WebCore/platform/win/WindowsTouch.h ! modules/javafx.web/src/main/native/Source/WebCore/plugins/DOMMimeTypeArray.cpp ! modules/javafx.web/src/main/native/Source/WebCore/plugins/DOMMimeTypeArray.h ! modules/javafx.web/src/main/native/Source/WebCore/plugins/DOMMimeTypeArray.idl ! modules/javafx.web/src/main/native/Source/WebCore/plugins/DOMPlugin.cpp ! modules/javafx.web/src/main/native/Source/WebCore/plugins/DOMPlugin.h ! modules/javafx.web/src/main/native/Source/WebCore/plugins/DOMPluginArray.cpp ! modules/javafx.web/src/main/native/Source/WebCore/plugins/DOMPluginArray.h ! modules/javafx.web/src/main/native/Source/WebCore/plugins/DOMPluginArray.idl ! modules/javafx.web/src/main/native/Source/WebCore/plugins/PluginData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/BorderEdge.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/BreakLines.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/CSSFilter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/ClipRect.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/ClipRect.h + modules/javafx.web/src/main/native/Source/WebCore/rendering/ComplexLineLayout.cpp + modules/javafx.web/src/main/native/Source/WebCore/rendering/ComplexLineLayout.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/CounterNode.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/CounterNode.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/EllipsisBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/EllipsisBox.h + modules/javafx.web/src/main/native/Source/WebCore/rendering/EventRegion.cpp + modules/javafx.web/src/main/native/Source/WebCore/rendering/EventRegion.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/FixedTableLayout.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/FloatingObjects.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/Grid.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/Grid.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/GridBaselineAlignment.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/GridBaselineAlignment.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/GridLayoutFunctions.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/GridLayoutFunctions.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/GridTrackSizingAlgorithm.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/HitTestRequest.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/HitTestResult.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/HitTestResult.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/ImageQualityController.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/ImageQualityController.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/InlineBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/InlineElementBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/InlineFlowBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/InlineFlowBox.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/InlineIterator.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/InlineTextBox.cpp + modules/javafx.web/src/main/native/Source/WebCore/rendering/LayerAncestorClippingStack.cpp + modules/javafx.web/src/main/native/Source/WebCore/rendering/LayerAncestorClippingStack.h + modules/javafx.web/src/main/native/Source/WebCore/rendering/LayerOverlapMap.cpp + modules/javafx.web/src/main/native/Source/WebCore/rendering/LayerOverlapMap.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/PaintFrequencyTracker.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/PaintInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/PaintPhase.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderBlock.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderBlock.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderBlockFlow.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderBlockFlow.h - modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderBlockLineLayout.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderBox.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderBoxModelObject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderBoxModelObject.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderButton.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderButton.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderCounter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderCounter.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderElement.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderElement.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderEmbeddedObject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderEmbeddedObject.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderFlexibleBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderFragmentContainer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderFragmentedFlow.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderFullScreen.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderGeometryMap.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderGrid.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderIFrame.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderImage.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderInline.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderInline.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLayer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLayer.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLayerBacking.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLayerBacking.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLayerCompositor.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLayerCompositor.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLayerFilters.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLayerModelObject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLayerModelObject.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLineBreak.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderListBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderListBox.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderListMarker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderMarquee.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderMenuList.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderMultiColumnFlow.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderMultiColumnFlow.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderMultiColumnSet.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderMultiColumnSet.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderObject.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderObject.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderReplaced.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderRubyBase.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderRubyBase.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderRubyText.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderRubyText.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderScrollbar.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderScrollbar.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderSearchField.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderSearchField.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTable.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTable.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTableCell.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTableSection.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTableSection.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderText.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTextControlMultiLine.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTextControlSingleLine.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTextControlSingleLine.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTheme.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTheme.h + modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeCocoa.mm ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeGtk.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeGtk.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeIOS.h + modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeIOS.mm + modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeMac.mm ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeWin.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderThemeWin.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTreeAsText.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderTreeAsText.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderVTTCue.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderVideo.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderView.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderView.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderWidget.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RootInlineBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/RootInlineBox.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/ScrollAlignment.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/SelectionRangeData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/SelectionRangeData.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/SimpleLineLayout.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/SimpleLineLayoutFunctions.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/SimpleLineLayoutPagination.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/SimpleLineLayoutResolver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/TextAutoSizing.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/TextDecorationPainter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/TextDecorationPainter.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/TextPaintStyle.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/TextPaintStyle.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/TextPainter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/TextPainter.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/line/BreakingContext.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/line/LineBreaker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/line/LineBreaker.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/line/LineInlineHeaders.h + modules/javafx.web/src/main/native/Source/WebCore/rendering/line/LineLayoutInterfaceTextBoxes.cpp + modules/javafx.web/src/main/native/Source/WebCore/rendering/line/LineLayoutInterfaceTextBoxes.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/line/LineWidth.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/MathOperator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/MathOperator.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLBlock.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLFraction.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLMath.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLRow.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLToken.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/shapes/BoxShape.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/shapes/RasterShape.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/shapes/RasterShape.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/shapes/Shape.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/shapes/ShapeOutsideInfo.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/BasicShapes.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/BasicShapes.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/CollapsedBorderValue.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/ContentData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/ContentData.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/CounterContent.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/CounterDirectives.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/FillLayer.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/FillLayer.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/KeyframeList.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/NinePieceImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/NinePieceImage.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/RenderStyle.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/RenderStyle.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/RenderStyleConstants.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/ShadowData.cpp + modules/javafx.web/src/main/native/Source/WebCore/rendering/style/StyleColorScheme.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/StyleCustomPropertyData.h - modules/javafx.web/src/main/native/Source/WebCore/rendering/style/StyleDashboardRegion.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/StyleRareInheritedData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/StyleRareInheritedData.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/StyleRareNonInheritedData.h - modules/javafx.web/src/main/native/Source/WebCore/rendering/style/StyleSupportedColorSchemes.h + modules/javafx.web/src/main/native/Source/WebCore/rendering/style/TextSizeAdjustment.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/TextSizeAdjustment.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/style/WillChangeData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGBlock.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGBlock.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGImage.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGInline.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGRect.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGResourceContainer.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGResourceFilter.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGResourceMasker.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGShape.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGText.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGText.h ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/SVGPathData.cpp ! modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/SVGPathData.h ! modules/javafx.w