[Rev 04] RFR: 8225571: Port DND source to use GTK instead of GDK

Pankaj Bansal github.com+6153953+pankaj-bansal at openjdk.java.net
Thu Jan 2 06:08:25 UTC 2020


On Thu, 2 Jan 2020 06:08:25 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8225571
>> 
>> To run tests (on the root of the source tree):
>> ./gradlew apps
>> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls
>> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor
>> 
>> java -Djdk.gtk.version=2 @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls
>> java -Djdk.gtk.version=2 @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor
> 
> The pull request has been updated with 1 additional commit.

Sorry for late review. I have reviewed the code and have run few tests for DND on Ubuntu 18.04, Ubuntu 19.04 and OL 7.5. All works fine for me. Approved.

-------------

Marked as reviewed by pankaj-bansal at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jfx/pull/4


More information about the openjfx-dev mailing list