[Rev 02] RFR: 8236651: Simplify and update glass gtk backend

Thiago Milczarek Sayao tsayao at openjdk.java.net
Mon Jan 6 02:08:14 UTC 2020


> This proposed change does the following:
> 
> - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward code (less special cases) ;
> - Replaces (pointer and focus) grabbing with a gtk approach;
> - Reworked frame extents (the wm extension to get decoration sizes) to reduce size and complexity;
> - Simplified cursor changing;
> - Reduced the use of gtk/gdk deprecated functions;
> 
> 
> In general it reduces code size and complexity and hands more work to gtk.
> 
> Important notice: As I could not test the code for handling web start and web applets because browsers do not support it anymore and java has removed "javaws", I took the liberty to remove the code. Will restore if necessary.
> 
> Please, mark it as WIP. 
> 
> ![image](https://user-images.githubusercontent.com/30704286/71788555-442ba400-3002-11ea-9d8c-e4265909fe6b.png)

The pull request has been updated with 4 additional commits.

-------------

Added commits:
 - 628d5528: Revert idea files
 - 8b0cadfc: Fix crash
 - 1c3df122: Fix crash
 - 4691800a: Fix crash

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/77/files
  - new: https://git.openjdk.java.net/jfx/pull/77/files/7b48e484..628d5528

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/77/webrev.02
 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.01-02

  Stats: 118 lines in 4 files changed: 25 ins; 47 del; 46 mod
  Patch: https://git.openjdk.java.net/jfx/pull/77.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77

PR: https://git.openjdk.java.net/jfx/pull/77


More information about the openjfx-dev mailing list