[Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

Kevin Rushforth kcr at openjdk.java.net
Thu Jan 16 14:26:36 UTC 2020


On Thu, 16 Jan 2020 14:16:37 GMT, Michael Paus <mpaus at openjdk.org> wrote:

>> Indeed, substituting the floating math for integer math requires an extra test on the remainder to be correct. 
>> Since this code isn't located in a tight loop, I'm not sure this optimization is worth making the code less straight forward. What do you all think?
> 
> I think it is not worth it.

I agree. I do like the suggestion to rename the variables, though.

-------------

PR: https://git.openjdk.java.net/jfx/pull/68


More information about the openjfx-dev mailing list