[Rev 01] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

Frederic Thevenet github.com+7450507+fthevenet at openjdk.java.net
Thu Jan 16 16:19:58 UTC 2020


On Thu, 16 Jan 2020 10:58:12 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1312:
> 
>> 1311:                     int tileWidth = Math.min(maxTextureSize, width - xOffset);
>> 1312:                     int tileHeight = Math.min(maxTextureSize, height - yOffset);
>> 1313:                     WritableImage tile = doSnapshotTile(scene, xMin + xOffset, yMin + yOffset, tileWidth, tileHeight, root, transform, depthBuffer, fill, camera, null);
> 
> `int xOffset = i * maxTextureSize;`
> `int tileWidth = Math.min(maxTextureSize, width - xOffset);`
> 
> These two lines should be moved to the outer loop of horizontal tabs.

done in 501917284e0490d16b1831fcd854e31a779449b9

-------------

PR: https://git.openjdk.java.net/jfx/pull/68


More information about the openjfx-dev mailing list