[Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

Fri Jan 17 23:18:40 UTC 2020

On Fri, 17 Jan 2020 23:18:40 GMT, Robert Lichtenberger <rlichten at openjdk.org> wrote:

>> As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here).
>> 
>> The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works analogously to the check whether the given event type is mapped.
> 
> Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR.

Looks good to me.

@guruhb can you re-review this when you get a chance?

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/85