RFR: 8236839: System menubar removed when other menubars are created or modified

Kevin Rushforth kcr at openjdk.java.net
Mon Jan 20 14:53:02 UTC 2020


On Tue, 14 Jan 2020 20:06:58 GMT, Johan Kaving <github.com+725090+jkaving at openjdk.org> wrote:

>> This pull request fixes the sceneProperty listener in `MenuBarSkin` so that we leave the
>> current system menubar alone when other menubars are changed.
>> 
>> It also adds a test case that reproduces the problem before the fix.
> 
> I just realised that I did not make the commit with the same email address that I used on the OCA (but both addresses are linked to my GitHub account).
> Will this be a problem?
> Should I redo the commit with the correct email address and do a force push to my branch?

No, it's not a problem. The commit email address doesn't matter as long as your OCA can be validated.

-------------

PR: https://git.openjdk.java.net/jfx/pull/86


More information about the openjfx-dev mailing list