RFR: 8237078: Media build code broken on XCode 11

Kevin Rushforth kcr at openjdk.java.net
Tue Jan 21 18:44:42 UTC 2020


On Mon, 20 Jan 2020 11:10:07 GMT, Johan Vos <jvos at openjdk.org> wrote:

> Fix JDK-8237078
> replace the objc_msgSend call with a direct objC call.
> The fix works on XCode 10.1 and XCode 11.3
> 
> Tested using
> java  -Djfxmedia.platforms=OSXPlatform
> with MediaPlayer playing an mp3.

I verified the fix, and confirmed that the new code is executed. This seems safe enough that a single reviewer is sufficient, although @sashamatveev might want to review as well.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/90


More information about the openjfx-dev mailing list