[Rev 02] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag
Ambarish Rapte
arapte at openjdk.java.net
Tue Jan 28 12:39:21 UTC 2020
On Tue, 28 Jan 2020 12:39:20 GMT, Robert Lichtenberger <rlichten at openjdk.org> wrote:
>> Test simulates a single mouse-released event.
>> Fix simply guards against the null case.
>
> The pull request has been updated with 1 additional commit.
Fix looks good, suggested minor changes in test.
modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java line 484:
> 483:
> 484:
> 485: @Test public void setRotateGraphicAndSeeValueIsReflectedInModel() {
Please remove the additional empty line from here.
modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java line 57:
> 56: import javafx.scene.input.KeyEvent;
> 57: import javafx.scene.input.MouseButton;
> 58: import javafx.scene.input.MouseEvent;
This import it not used, please remove.
-------------
Changes requested by arapte (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/89
More information about the openjfx-dev
mailing list