RFR: 8181775: JavaFX WebView does not calculate border-radius properly [v3]

Bhawesh Choudhary bchoudhary at openjdk.java.net
Thu Jul 23 04:43:56 UTC 2020


> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering of rounded corner rectangle if four
> corners have different radii. but same can be achieved via Path. to fix the issue, in GraphicsContextJava.cpp while
> rendering fillRoundedRect, check if all four corners have same radii. if yes, use FILL_ROUNDED_RECT to draw it
> otherwise construct a path from given rounded rect and draw it.

Bhawesh Choudhary has updated the pull request incrementally with 54 additional commits since the last revision:

 - 8181775: JavaFX WebView does not calculate border-radius properly
 - 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175%
   
   Reviewed-by: kcr, psadhukhan
 - 8248381: Create a daemon thread for MonocleTimer
   
   Reviewed-by: kcr, jvos
 - 8248490: [macOS] Undecorated stage does not minimize
   
   Reviewed-by: arapte, aghaisas
 - 8248908: Printer.createPageLayout() returns 0.75" margins instead of hardware margins
   
   Reviewed-by: kcr
 - 8245284: Update to 610.1 version of WebKit
   
   Co-authored-by: Guru Hb <ghb at openjdk.org>
   Co-authored-by: Bhawesh Choudhary <bchoudhary at openjdk.org>
   Reviewed-by: kcr, bchoudhary, sykora
 - 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException
   
   Reviewed-by: aghaisas, kcr
 - 8245422: Better Pisces rasterizing
   
   Reviewed-by: prr, rhalade, arapte, mschoene
 - 8241108: Glib improvements
   
   Reviewed-by: kcr, ahgross, rhalade
 - 8248365: Debug build crashes on Windows when playing media file
   
   Reviewed-by: kcr
 - ... and 44 more: https://git.openjdk.java.net/jfx/compare/e7cb98fe...586af326

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/218/files
  - new: https://git.openjdk.java.net/jfx/pull/218/files/e7cb98fe..586af326

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/218/webrev.02
 - incr: https://webrevs.openjdk.java.net/jfx/218/webrev.01-02

  Stats: 393560 lines in 5665 files changed: 200813 ins; 130033 del; 62714 mod
  Patch: https://git.openjdk.java.net/jfx/pull/218.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/218/head:pull/218

PR: https://git.openjdk.java.net/jfx/pull/218


More information about the openjfx-dev mailing list