[jfx15] RFR: 8246343: Fix mistakes in FX API docs [v3]

Kevin Rushforth kcr at openjdk.java.net
Mon Jul 27 21:33:06 UTC 2020


On Mon, 27 Jul 2020 20:52:57 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/layout/VBox.java line 163:
>> 
>>> 162:      * If no vertical grow priority is set on a child, the vbox will never
>>> 163:      * allocate it additional vertical space, if available.
>>> 164:      * <p>
>> 
>> This isn't a new problem, but the following is awkward:
>> 
>> "If no vertical grow priority is set on a child, the vbox will never allocate it additional vertical space, if
>> available."
>> If this is trying to say that the vbox will never allocate extra space for that child, then it should be reworded
>> slightly. Maybe something like this?
>> "If no vertical grow priority is set on a child, the vbox will never allocate any additional vertical space for that
>> child."
>> I note that HBox has the same awkward sentence.
>
> Your suggestion looks good, I tried not to rewrite too much initially.

Yeah, the only reason I suggested it is that I had to read that sentence three times before I realized what it was
trying to say.

-------------

PR: https://git.openjdk.java.net/jfx/pull/274


More information about the openjfx-dev mailing list