RFR: 8217472: Add attenuation for PointLight [v5]

Nir Lisker nlisker at openjdk.java.net
Tue Jul 28 13:17:29 UTC 2020


On Fri, 24 Jul 2020 21:01:08 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request with a new target base due to a merge or a rebase. The pull request now
>> contains 11 commits:
>>  - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight
>>  - Attenuation and range changed internally to floats from doubles
>>  - Fixed shader compilation errors for 2 and 3 lights in es2
>>  - Addressing review comments
>>  - Fixed whitespaces
>>  - Correction for indexes
>>  - Docs and year update
>>  - Merge remote-tracking branch 'nlisker/8217472_Add_attenuation_for_PointLight' into
>>    8217472_Add_attenuation_for_PointLight
>>  - GL pipeline
>>  - Separate range from attenuation
>>  - ... and 1 more: https://git.openjdk.java.net/jfx/compare/4ec163df...2e1223ed
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/PointLightHelper.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights reserved.
>> 3:  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> 
> Update the "last modified year" for 2020 or else revert (this applies to all copyright year updates).

Can the script not get it?

-------------

PR: https://git.openjdk.java.net/jfx/pull/43


More information about the openjfx-dev mailing list