[Rev 02] RFR: 8193800: TreeTableView selection changes on sorting

Ambarish Rapte arapte at openjdk.java.net
Wed Jun 3 09:40:53 UTC 2020


On Tue, 2 Jun 2020 17:31:52 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   kcr review comment changes
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java line 1808:
> 
>> 1807:     boolean sortingInProgress;
>> 1808:     protected boolean isSortingInProgress() {
>> 1809:         return sortingInProgress;
> 
> This is an implementation detail. By making it `protected` it becomes public API. You will need to make it
> package-scope instead

Updated in next commit

-------------

PR: https://git.openjdk.java.net/jfx/pull/244


More information about the openjfx-dev mailing list