RFR: 8246745: ListCell/Skin: misbehavior on switching skin

Kevin Rushforth kcr at openjdk.java.net
Wed Jun 10 23:35:52 UTC 2020


On Wed, 10 Jun 2020 12:25:04 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> ListCellSkin installs listeners to the ListView/fixedCellSize that introduce a memory leak, NPE on replacing the
> listView and incorrect update of internal state (see bug report for details)
> Fixed by removing the listeners (and the internal state had been copied from listView on change) and access of listView
> state when needed.
> Added tests that failed before and pass after the fix, plus a sanity test to guarantee same (correct) behavior
> before/after.

@arapte can you review?

-------------

PR: https://git.openjdk.java.net/jfx/pull/251


More information about the openjfx-dev mailing list