ListProperty::bind has different behavior than StringProperty::bind when observables are equal

Nir Lisker nlisker at gmail.com
Thu Jun 11 19:19:43 UTC 2020


Set and Map will also need this change then.

On Tue, Jun 9, 2020 at 5:16 PM Jeanette Winzenburg <fastegal at swingempire.de>
wrote:

>
> Zitat von José Pereda <jose.pereda at gluonhq.com>:
>
> > Thanks, that's helpful.
> >
> > If I get it right, the change applied in ListExpressionHelper [1][2]
> > removed equals:
> >
> > -                if ((currentValue == null)? (oldValue != null) :
> > !currentValue.equals(oldValue)) {
> > +                if (currentValue != oldValue) {
> >
> > So that will imply that we should do the same in ListPropertyBase::bind?
> >
>
> exactly :) IMO, at least - otherwise we get all the old problems back:
> the binding (just the same as listing) must be to an exact instance,
> not to something that's equal but another instance.
>
>


More information about the openjfx-dev mailing list