[Rev 03] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

Abhinay Agarwal github.com+3197675+abhinayagarwal at openjdk.java.net
Fri Jun 12 13:41:18 UTC 2020


On Fri, 29 May 2020 16:48:29 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo: dispose should remove event handler
>
> worth discussing the case were a TextInput is the only control.

@mipastgt The issue happens because of the focus listener. With this PR, we introduce `mouseEventListener` to show the
Keyboard on `MOUSE_CLICKED` event. Therefore, the issue brought up by your previous comment should be resolved by
updating the `focusChangeListener` to:

private final ChangeListener<Boolean> focusChangeListener = (observable, wasFocused, isFocused) -> {
    if (wasFocused && !isFocused) {
        hideSoftwareKeyboard();
    }
};

We should most probably also introduce an API for showing the keyboard as available on both iOS and Android platforms :)

Thoughts?

-------------

PR: https://git.openjdk.java.net/jfx/pull/219


More information about the openjfx-dev mailing list