RFR: 8246348: Crash in libpango on Ubuntu 20.04 with some unicode chars

[Johan Vos]

On Thu, 11 Jun 2020 22:59:04 GMT, Phil Race <prr at openjdk.org> wrote:

>> This addresses https://bugs.openjdk.java.net/browse/JDK-8246348
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/freetype/PangoGlyphLayout.java line 140:
> 
>> 139:             runUtf8.put(run, str);
>> 140:             if (check(str, "Failed allocating UTF-8 buffer.", context, desc, attrList)) {
>> 141:                 return;
> 
> Did you really mean to store the run in the map before checking if str is null ?

I'm not sure what should happen if str is null. Do we want to be able to retry later? In that case, we shouldn't store
it in the map. But if it is fatal, and seems to indicate a problem with rtext (e.g. too big?), so in that case it might
not be worth retrying.

-------------

PR: https://git.openjdk.java.net/jfx/pull/249