[Rev 01] RFR: 8246348: Crash in libpango on Ubuntu 20.04 with some unicode chars

[Johan Vos]

On Fri, 12 Jun 2020 13:07:53 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I'm not sure what should happen if str is null. Do we want to be able to retry later? In that case, we shouldn't store
>> it in the map. But if it is fatal, and seems to indicate a problem with rtext (e.g. too big?), so in that case it might
>> not be worth retrying.
>
> If `str` is null, you would end up retrying it anyway, since `Map::get` will return `null` the next time (if there is a
> next time). Also, I think the dispose method might then crash trying to free a null pointer. So I think Phil is right
> and that you should not add the `str` to the `Map` if it is null.

I don't think it will be `null` but it will be `0` in which case it is stored in the `Map`
The only reason the str == null is then that we never tried to convert the Java chars to utf8, unless I'm missing a
case?

-------------

PR: https://git.openjdk.java.net/jfx/pull/249