[Rev 01] RFR: 8240264: iOS: Unnecessary logging on every pulse when GL context changes

Jose Pereda jpereda at openjdk.java.net
Mon Jun 15 19:54:38 UTC 2020


On Mon, 15 Jun 2020 19:38:19 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Call fprintf only if pulse logging was requested
>
> modules/javafx.graphics/src/main/native-prism-es2/ios/IOSWindowSystemInterface.m line 86:
> 
>> 85:     if (pulseLoggingRequested) {
>> 86:         fprintf(stderr, "IOSWindowSystemInterface : deleteContext unimp\n");
>> 87:     }
> 
> this doesn't relate to pulseLogging I believe?

Right, but since it wasn't commented out, should I just leave it as it was?

-------------

PR: https://git.openjdk.java.net/jfx/pull/165


More information about the openjfx-dev mailing list