[Rev 03] RFR: 8193800: TreeTableView selection changes on sorting

[Ambarish Rapte]

On Mon, 15 Jun 2020 23:26:33 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Correcting the selection change events generated post sorting
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java line 1815:
> 
>> 1814:     boolean isSortTreeOfSelectedItems() {
>> 1815:         return sortTreeOfSelectedItems;
>> 1816:     }
> 
> This method / state attribute isn't really needed. The value is never set to anything other than `true`. I recommend
> removing it.

Corrected in the next commit..

> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java line 431:
> 
>> 430:             for (int j = 0; j < FIRST_LEVEL_COUNT - 1; j++) {
>> 431:                 TreeItem<String> tj = new TreeItem<>("" + i + j);
>> 432:                 tj.setExpanded(true);
> 
> The tree item strings will not be unique. This won't affect whether the test passes or fails, since `TreeItem` does not
> override `equals`, but it might be better if the strings were unique (in case there ever was an error it would be
> easier to understand).

Hi Kevin, I verified the the tree item strings again. They seem to be unique. A total of 8800 of tree items get created
each with unique string. Could you please recheck.

-------------

PR: https://git.openjdk.java.net/jfx/pull/244