RFR: 8193800: TreeTableView selection changes on sorting [v5]

Kevin Rushforth kcr at openjdk.java.net
Tue Jun 23 12:34:42 UTC 2020


On Tue, 23 Jun 2020 10:07:37 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove the un-required flag
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java line 1856:
> 
>> 1855:         Callback<TreeTableView<S>, Boolean> sortPolicy = getSortPolicy();
>> 1856:         if (sortPolicy == null) return;
>> 1857:         Boolean success = sortPolicy.call(this);
> 
> Do we need to set sortingInProgress to false before returning from here?

Yes, I think so. Good catch.

-------------

PR: https://git.openjdk.java.net/jfx/pull/244


More information about the openjfx-dev mailing list