RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v5]

Abhinay Agarwal github.com+3197675+abhinayagarwal at openjdk.java.net
Thu Jun 25 17:58:34 UTC 2020


> In Android, TextInputControls (TextField and TextArea) are responsible for showing and hiding software keyboard.
> Currently, a focus listener is attached to these controls and is used to toggle the visibility of keyboard. This
> condition fails in cases where the control already has focus but the keyboard is not visible.  Ideally, the keyboard
> should be shown again when the user taps on the TextInputControl.
> This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows the keyboard  if the TextInput control is
> both editable and focused.

Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision:

  Show keyboard on mouse event. Focus change listener should be responsible for hiding the keyboard only.

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/219/files
  - new: https://git.openjdk.java.net/jfx/pull/219/files/3024ddcb..0aa79029

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/219/webrev.04
 - incr: https://webrevs.openjdk.java.net/jfx/219/webrev.03-04

  Stats: 12 lines in 2 files changed: 0 ins; 8 del; 4 mod
  Patch: https://git.openjdk.java.net/jfx/pull/219.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/219/head:pull/219

PR: https://git.openjdk.java.net/jfx/pull/219


More information about the openjfx-dev mailing list