RFR: 8193800: TreeTableView selection changes on sorting [v6]

Ambarish Rapte arapte at openjdk.java.net
Fri Jun 26 09:22:56 UTC 2020


On Thu, 25 Jun 2020 22:45:17 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment corrections, adding new tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java line 443:
> 
>> 442:     @Test public void testSelectionUpdatesCorrectlyAfterChildRemoveOneAndSetAll() {
>> 443:         TreeTableColumn<String, String> col = setupForPermutationTest();
>> 444:         TreeItem<String> parentTreeItem = ((TreeItem<String>)sm.getSelectedItem()).getParent();
> 
> Minor: `col` is unused.

Corrected in the next commit

-------------

PR: https://git.openjdk.java.net/jfx/pull/244


More information about the openjfx-dev mailing list