RFR: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo

Kevin Rushforth kcr at openjdk.java.net
Fri Jun 26 23:11:41 UTC 2020


On Fri, 26 Jun 2020 23:05:46 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> - Added DirectShow baseclasses to repository.
>> - Dependency on Windows SDK 7.1 DirectShow baseclasses was removed.
>
> Looks good. I was able to do a build and test with the patch applied. I confirm that it now builds without needing
> `C:/Program Files/Microsoft SDKs/Windows/v7.1`.

@arapte can you be the second reviewer on this?

@johanvos @tiainen FYI, in case you want to take a look as well: It's a straight-forward build change with no changes
other than the location of the Microsoft DirectShow samples (Base Classes), which are now in the repo. No more external
dependency on Windows 7.1 SDK.

-------------

PR: https://git.openjdk.java.net/jfx/pull/254


More information about the openjfx-dev mailing list