RFR: 8248381: Create a daemon thread for MonocleTimer

John Neffenger github.com+1413266+jgneff at openjdk.java.net
Sat Jun 27 16:27:42 UTC 2020


The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.

----------------------------------------------------------------------
On Sat, 27 Jun 2020 16:14:36 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> On second thought, this seems more like a workaround than a fix.

This change just restores the thread daemon status to the way it was before in JavaFX 14, where `true` is passed to the
`Timer` constructor for "isDaemon - true if the associated thread should run as a daemon."

        if (timer == null) {
            timer = new java.util.Timer(true);
        }

I tried setting `task.cancel(true)` instead of `false` in the `_stop` method, but that didn't stop the non-daemon
thread.

-------------

PR: https://git.openjdk.java.net/jfx/pull/256


More information about the openjfx-dev mailing list