Integrated: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts

[Rony G.Flatscher]

On Mon, 20 Apr 2020 12:45:30 GMT, Rony G. Flatscher <github.com+60214806+ronyfla at openjdk.org> wrote:

> This PR adds a "compile" process instruction to FXML files with the optional PI data "true" (default) and "false". The
> PI data is turned into a boolean value using "Boolean.parseBoolean(String)".
> This makes it possible to inject the compile PI everywhere in a FXML file and turn on and off compilation of scripts if
> the scripting engine implements the javax.script.Compilable interface. The PR adds the ability for a fallback in case
> compilation of scripts fails, in which case a warning gets issued about this fact and evaluation of the script will be
> done without compilation. Because of the fallback scripts get compiled with this version by default.
> ---------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
> 
> ### Issue
>  * [JDK-8238080](https://bugs.openjdk.java.net/browse/JDK-8238080): FXMLLoader: if script engines implement
>    javax.script.Compilable compile scripts
> 
> 
> ### Download
> `$ git fetch https://git.openjdk.java.net/jfx pull/192/head:pull/192`
> `$ git checkout pull/192`

This pull request has now been integrated.

Changeset: 45c9854c
Author:    Rony G. Flatscher <Rony.Flatscher at wu.ac.at>
Committer: Kevin Rushforth <kcr at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/45c9854c
Stats:     2553 lines in 29 files changed: 2 ins; 2523 del; 28 mod

8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts

Reviewed-by: kcr, aghaisas

-------------

PR: https://git.openjdk.java.net/jfx/pull/192