RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v2]

Oliver Schmidtmer github.com+10960818+Schmidor at openjdk.java.net
Tue Jun 30 18:28:11 UTC 2020


> In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and Math.round produce different results and
> EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one error on the line width and therefore sheared
> rendering.  The changes were already proposed by the submitter in JBS-8220484.
> 
> OCA is signed and send.

Oliver Schmidtmer has updated the pull request incrementally with one additional commit since the last revision:

  Change to Math.ceil and add test

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/246/files
  - new: https://git.openjdk.java.net/jfx/pull/246/files/5eda49bf..994ca03c

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/246/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/246/webrev.00-01

  Stats: 161 lines in 3 files changed: 155 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jfx/pull/246.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/246/head:pull/246

PR: https://git.openjdk.java.net/jfx/pull/246


More information about the openjfx-dev mailing list