[Rev 01] RFR: 8208761: Update constant collections to use the new immutable collections
Ambarish Rapte
arapte at openjdk.java.net
Mon Mar 2 05:56:01 UTC 2020
On Fri, 28 Feb 2020 08:03:45 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> I finished my review and tested this on all platforms. It looks good to me.
>>
>> The only comment I have is the one inline comment I left in `KeyCodeMap.java` about renaming the "put" method to something with "entry" in the name to reflect what it now does.
>
>> The only comment I have is the one inline comment I left in KeyCodeMap.java about renaming the "put" method to something with "entry" in the name to reflect what it now does.
>
> Will fix it after Ambarish reviews.
The fix looks good to me too, Shall approve once PR is updated for Kevin's comment.
-------------
PR: https://git.openjdk.java.net/jfx/pull/104
More information about the openjfx-dev
mailing list