[Rev 01] RFR: 8236259: MemoryLeak in ProgressIndicator

Florian Kirmaier fkirmaier at openjdk.java.net
Mon Mar 2 12:55:36 UTC 2020


On Mon, 2 Mar 2020 10:59:12 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> I've now readded the unit-test. It based on the "InitialNodesMemoryLeakTest".
>> 
>> Command to execute: `./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests test.javafx.scene.control.ProgressIndicatorLeakTest`
>> 
>> It's now part of the systemtests, because the memory-semantics for the tests in controls is changed due to the TestToolkit.
>
>> It's now part of the systemtests, because the memory-semantics for the tests in controls is changed due to the TestToolkit.
> 
> just curious: does that imply that you think the tests in controls ... rather useless?

@kleopatra 
It's not useless, but having a special Toolkit which is only used inside of JavaFX itself is very unreasonable. It would make much more sense, to use the same basis for unit-test as the rest of the JavaFX-Community which is monocle. The systemTests also seem to work quite well.

-------------

PR: https://git.openjdk.java.net/jfx/pull/71


More information about the openjfx-dev mailing list