RFR: 8240287: SelectedItemsReadOnlyObservableList cleanup: remove unused code.

Kevin Rushforth kcr at openjdk.java.net
Mon Mar 2 16:50:07 UTC 2020


On Mon, 2 Mar 2020 16:47:05 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> The below member variables and method of class SelectedItemsReadOnlyObservableList are not required anymore.
>> Variables: itemsList, itemsListChanged, itemsListChange, itemsListListener.
>> Method: setItemsList
>> 
>> These members were added when this class was created for [JDK-8154216](https://bugs.openjdk.java.net/browse/JDK-8154216).
>> But after the fix for [JDK-8152396](https://bugs.openjdk.java.net/browse/JDK-8152396), these class members are not required.
>> This change also fixes the leak issue : [JDK-8237926](https://bugs.openjdk.java.net/browse/JDK-8237926)
>> 
>> Verification:
>> No build and test failures.
>
> As I mentioned in the bug report for [JDK-8240287](https://bugs.openjdk.java.net/browse/JDK-8240287), I recommend using [JDK-8227619](https://bugs.openjdk.java.net/browse/JDK-8227619) as the bug ID for this fix (and closing JDK-8240287 in JBS as a duplicate). I think that you should be able to just change the title of this PR.

Is it possible to create a test for the leak?

-------------

PR: https://git.openjdk.java.net/jfx/pull/132


More information about the openjfx-dev mailing list