RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

Rony G. Flatscher Rony.Flatscher at wu.ac.at
Mon Mar 2 18:08:36 UTC 2020


Hi Kevin,

On 02.03.2020 17:51, Kevin Rushforth wrote:
> On Thu, 27 Feb 2020 14:36:17 GMT, Rony G. Flatscher <github.com+60214806+ronyfla at openjdk.org> wrote:
>
>>> Overall this looks good to me. As I mentioned in PR #123 you should fold that the unit test into this PR.
>> Removed executable bits from gradlew (which I manually have added to become able to run ./gradlew) and pushed it, however the commit has not appeared. Not wanting to add more noise, I stop until advised differently.
> Btw, I recommend to run `sh gradlew ...` so you don't have to change the permission locally.
>
> -------------
>
> PR: https://git.openjdk.java.net/jfx/pull/122

thank you very much for this hint!

As you can probably tell I have never really worked with git (other than pulling open source
projects for inspection, experiments) I learn my lessons step by step (svn would be another story).
Just trying to not bother experts like yourself and others, but then, not everything can be
accounted for by a git-rookie! :) When learning that the executable bit caused a problem on the
push, I felt quite embarrassed to have caused noise and stopped doing a "chmod +x gradlew" (did that
out of pure laziness in the first place to forgo the 'sh' command) and restarted doing the 'sh
gradlew ...' (needless to say now that I have never worked with gradle beforehand, but being  *very*
impressed about it, making the creation of such complex libraries like JavaFX or webkit on Linux a
breeze, wow).

BTW, mistakingly (pressed "Reply" instead of "Reply-to-all") sent my answer to your e-mail address
only, resending it via the list now, because currently there seems to be a problem with
<kcr at openjdk.java.net>:

    The original message was received at Mon, 2 Mar 2020 17:50:57 GMT
    from aserp3030.oracle.com [127.0.0.1]

       ----- The following addresses had permanent fatal errors -----
    <kcr at openjdk.java.net>
        (reason: 550 5.1.1 <kcr at openjdk.java.net>: Recipient address rejected: User unknown in local
    recipient table)

       ----- Transcript of session follows -----
    ... while talking to [137.254.59.6]:
    >>> DATA
    <<< 550 5.1.1 <kcr at openjdk.java.net>: Recipient address rejected: User unknown in local
    recipient table
    550 5.1.1 <kcr at openjdk.java.net>... User unknown
    <<< 554 5.5.1 Error: no valid recipients

Best regards

---rony




More information about the openjfx-dev mailing list