[Rev 01] RFR: 8237926: Potential memory leak of model data in javafx.scene.control.ListView
Kevin Rushforth
kcr at openjdk.java.net
Wed Mar 4 00:23:23 UTC 2020
On Tue, 3 Mar 2020 13:06:52 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> The selection model of ListView stores a strong reference to the most recently changed item in `SelectedItemsReadOnlyObservableList.itemsListChange`, which causes a leak.
>>
>> Fix:
>> The below member variables and method of class SelectedItemsReadOnlyObservableList are not required anymore.
>> Variables: itemsList, itemsListChanged, itemsListChange, itemsListListener.
>> Method: setItemsList
>>
>> These members were added when this class was created for [JDK-8154216](https://bugs.openjdk.java.net/browse/JDK-8154216).
>> But after the fix for [JDK-8152396](https://bugs.openjdk.java.net/browse/JDK-8152396), these class members are not required.
>>
>> Verification:
>> No failure in existing tests and added a new test.
>
> The pull request has been updated with 1 additional commit.
Marked as reviewed by kcr (Lead).
-------------
PR: https://git.openjdk.java.net/jfx/pull/132
More information about the openjfx-dev
mailing list