RFR: 8240211: Stack overflow on Windows 32-bit can lead to crash

Johan Vos jvos at openjdk.java.net
Thu Mar 5 17:48:22 UTC 2020


On Thu, 5 Mar 2020 16:50:55 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> Issue: The stack pointer is checked close to the stack limit during the last iteration of calling frameLoaded() and then, grows beyond the thread's stack range causing a stack overflow and crashes. This occurs as the stack grows by an amount larger than the reserved zone at the end of the stack.
>> 
>> Fix: Reduce the stack range visible to the thread in [StackBounds.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WTF/wtf/StackBounds.cpp) similar to Mac and Linux. This causes the stack pointer check to throw a StackOverflowError during the last iteration.
>
> Looks good to me. 
> I believe you have executed DRT on both 64 & 32 bit build.

This looks correct and very valuable to me. Would be great if there was a test that results in a crash before?

-------------

PR: https://git.openjdk.java.net/jfx/pull/137


More information about the openjfx-dev mailing list