RFR: 8240692: Cleanup of the javafx property objects

[Nir Lisker]

On Fri, 6 Mar 2020 23:12:57 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> A simple readability cleanup for the files that were changed in #113.
>> 
>> Note that the boolean property has an `instanceof` check that doesn't exist in the other properties.
>
> I note that this also changes the wrapper property objects from anonymous subclasses of XxxxxPropertyBase to SimpleXxxxxProperty. This is more than just a readability cleanup. It's probably fine for this case, but that's why I want a second reviewer.

> I note that this also changes the wrapper property objects from anonymous subclasses of XxxxxPropertyBase to SimpleXxxxxProperty. This is more than just a readability cleanup. It's probably fine for this case, but that's why I want a second reviewer.

Isn't SimpleXxxxxProperty exactly made for XxxxxPropertyBase with the built-in overrides for the bean and the name? When is this substitution not fine?

-------------

PR: https://git.openjdk.java.net/jfx/pull/141