RFR: 8240692: Cleanup of the javafx property objects
Tom Schindl
github.com+52631+tomsontom at openjdk.java.net
Sat Mar 7 00:28:44 UTC 2020
On Fri, 6 Mar 2020 23:35:56 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> I note that this also changes the wrapper property objects from anonymous subclasses of XxxxxPropertyBase to SimpleXxxxxProperty. This is more than just a readability cleanup. It's probably fine for this case, but that's why I want a second reviewer.
>
>> I note that this also changes the wrapper property objects from anonymous subclasses of XxxxxPropertyBase to SimpleXxxxxProperty. This is more than just a readability cleanup. It's probably fine for this case, but that's why I want a second reviewer.
>
> Isn't SimpleXxxxxProperty exactly made for XxxxxPropertyBase with the built-in overrides for the bean and the name? When is this substitution not fine?
I can somehow remember asking Richard Bair why JavaFX internally does not use Simple* but creates the anonymous subclasses and he said it's memory reason - Simple* uses more memory because of the additional fields
-------------
PR: https://git.openjdk.java.net/jfx/pull/141
More information about the openjfx-dev
mailing list