RFR: 8240692: Cleanup of the javafx property objects

[Kevin Rushforth]

On Sat, 7 Mar 2020 00:49:28 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> the subclass saves the owner field who is a static null, not?
>
> From what I see, they save the same data.

The anonymous subclasses don't have an instance field for the `bean` or the `name`, so the tradeoff is one of static footprint (an extra anonymous inner class) for dynamic footprint (slightly larger instances).

Note, however, that this savings is reduced by the fact that the inner classes have a `this$0` pointer to the enclosing class. I think this means that we are really only saving one reference variable per instance of the anonymous inner class versus an instance of SimpleXxxxProperty. That's why I think that in the specific case of this proposed fix, it should be fine. I just want to take a closer look.

-------------

PR: https://git.openjdk.java.net/jfx/pull/141