[Rev 03] RFR: 8217472: Add attenuation for PointLight

Kevin Rushforth kcr at openjdk.java.net
Tue Mar 10 22:43:43 UTC 2020


On Tue, 10 Mar 2020 18:52:23 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Looks like the `jcheck` bot removed the `rfr` label because the CSR isn't complete. An incomplete CSR should be treated
>> the same way as an insufficient number of reviewers. I filed
>> [SKARA-262](https://bugs.openjdk.java.net/browse/SKARA-262) to track this.
>
> @kevinrushforth Can you have a look at the test app? I would like to get this moving so we would have time to get the
> rest of the lighting enhancements into 15.

I'll take a look. My quick thought is that we need some sort of test with a reasonable number of large boxes (so that
it is fill-limited). If there isn't such a case, and the 3D rendering is always node-limited, then the shader
performance doesn't really matter all that much. I suspect we should be able to find a case where it does, but we'll
see.

-------------

PR: https://git.openjdk.java.net/jfx/pull/43


More information about the openjfx-dev mailing list