[Rev 05] RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation
    Ajit Ghaisas 
    aghaisas at openjdk.java.net
       
    Fri Mar 13 17:48:31 UTC 2020
    
    
  
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
> 
> Fix : Added the missed out RTL checks to the key mappings in TableViewBehaviorBase class.
> 
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as a parameter. The Left/Right key press
> tests have been modified to address LTR and RTL orientations.
> Note : If this test modification is acceptable, I would like to address other similar tests separately. (I will create
> a test JBS issue and address later)
Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
  Fixed review comments
-------------
Changes:
  - all: https://git.openjdk.java.net/jfx/pull/114/files
  - new: https://git.openjdk.java.net/jfx/pull/114/files/b987fcc8..c17d6fdc
Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/114/webrev.05
 - incr: https://webrevs.openjdk.java.net/jfx/114/webrev.04-05
  Stats: 915 lines in 3 files changed: 194 ins; 470 del; 251 mod
  Patch: https://git.openjdk.java.net/jfx/pull/114.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/114/head:pull/114
PR: https://git.openjdk.java.net/jfx/pull/114
    
    
More information about the openjfx-dev
mailing list