[Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

Kevin Rushforth kcr at openjdk.java.net
Fri Mar 20 12:17:13 UTC 2020


On Fri, 20 Mar 2020 11:28:46 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Rony G. Flatscher has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   corrected wrong test string
>
> tests/system/src/testscriptapp1/java/mymod/myapp1/Util.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved.
>> 3:  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> 
> Please remove "2017, "

Since this file was copied verbatim from one of the other test apps, the initial `2017,` is correct.

> tests/system/src/testscriptapp1/java/mymod/myapp1/Constants.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved.
>> 3:  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> 
> Please remove "2017, "

Same as above. The `2017,` is correct.

-------------

PR: https://git.openjdk.java.net/jfx/pull/122


More information about the openjfx-dev mailing list