RFR: 8089828: RTL Orientation, the flag of a mnemonic is not placed under the mnemonic letter.

Kevin Rushforth kcr at openjdk.java.net
Tue Mar 24 13:30:46 UTC 2020


On Mon, 23 Mar 2020 22:42:54 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> **Bug :**
>> https://bugs.openjdk.java.net/browse/JDK-8089828
>> 
>> **Root Cause :**
>> RIGHT_TO_LEFT NodeOrientation was not considered during mnemonic position calculation.
>> 
>> **Fix :**
>> Corrected code to consider RIGHT_TO_LEFT NodeOrientation while calculating mnemonic position.
>> 
>> **Testing :**
>> Existing manual test is modified to test RTL buttons as well.
>
> The fix looks good to me, although I'd like a second reviewer.
> 
> I did note one issue with the format of the copyright year.

@arapte can you also review this?

-------------

PR: https://git.openjdk.java.net/jfx/pull/146


More information about the openjfx-dev mailing list