[Rev 01] RFR: 8241455: Memory leak on replacing selection/focusModel

Jeanette Winzenburg fastegal at openjdk.java.net
Fri Mar 27 11:46:30 UTC 2020


> ChoiceBox leaves a memory leak when replacing the selectionModel. Culprit is ChoiceBoxSelectionModel which registers
> listener with strong references. Fix is to change these to weak references.
> Added test that fails before and passes after the test.
> 
> for convenience, the bug reference https://bugs.openjdk.java.net/browse/JDK-8241455

Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:

  widened issue/fix/test for all controls with selection/focus models

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/148/files
  - new: https://git.openjdk.java.net/jfx/pull/148/files/56d16954..d2918fb5

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/148/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/148/webrev.00-01

  Stats: 358 lines in 5 files changed: 312 ins; 34 del; 12 mod
  Patch: https://git.openjdk.java.net/jfx/pull/148.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/148/head:pull/148

PR: https://git.openjdk.java.net/jfx/pull/148


More information about the openjfx-dev mailing list